November 2024 - flashrom-gerrit

[XS] Change in flashrom[main]: doc: Double-clarify that mailing list is public
by Anastasia Klimchuk (Code Review) 23 Nov '24

23 Nov '24

Attention is currently required from: Anastasia Klimchuk, Stefan Reinauer. Hello Stefan Reinauer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/85277?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+2 by Stefan Reinauer, Verified+1 by build bot (Jenkins) Change subject: doc: Double-clarify that mailing list is public ...................................................................... doc: Double-clarify that mailing list is public Change-Id: Id8e0daf75e25e6153a80fb9444547bdf91d1d343 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M doc/contact.rst 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/77/85277/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/85277?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Id8e0daf75e25e6153a80fb9444547bdf91d1d343 Gerrit-Change-Number: 85277 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[XS] Change in flashrom[main]: doc: Double-clarify that mailing list is public
by Stefan Reinauer (Code Review) 23 Nov '24

23 Nov '24

Attention is currently required from: Anastasia Klimchuk. Stefan Reinauer has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/85277?usp=email ) Change subject: doc: Double-clarify that mailing list is public ...................................................................... Patch Set 1: Code-Review+2 (2 comments) File doc/contact.rst: https://review.coreboot.org/c/flashrom/+/85277/comment/d9368a5d_559b63a2?us… : PS1, Line 20: . So please be careful when sending potentially personal information to the mailing list" ? https://review.coreboot.org/c/flashrom/+/85277/comment/bff3898b_03b0ae25?us… : PS1, Line 20: . .. "that are not operated by the flashrom team". -- To view, visit https://review.coreboot.org/c/flashrom/+/85277?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Id8e0daf75e25e6153a80fb9444547bdf91d1d343 Gerrit-Change-Number: 85277 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sat, 23 Nov 2024 09:42:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in flashrom[main]: doc: Double-clarify that mailing list is public
by Anastasia Klimchuk (Code Review) 23 Nov '24

23 Nov '24

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/85277?usp=email ) Change subject: doc: Double-clarify that mailing list is public ...................................................................... doc: Double-clarify that mailing list is public Change-Id: Id8e0daf75e25e6153a80fb9444547bdf91d1d343 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M doc/contact.rst 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/77/85277/1 diff --git a/doc/contact.rst b/doc/contact.rst index 38888fb..552c61a 100644 --- a/doc/contact.rst +++ b/doc/contact.rst @@ -16,6 +16,9 @@ Please note that the list is moderated for non-subscribers and we recommend to subscribe first. +Our mailing list is public and archived, see below for the links to our archives. There are also a bunch of independent +public archives services. Archives are also public, everyone on the internet can read them. + Subscription """""""""""" https://mail.coreboot.org/postorius/lists/flashrom.flashrom.org/ -- To view, visit https://review.coreboot.org/c/flashrom/+/85277?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Id8e0daf75e25e6153a80fb9444547bdf91d1d343 Gerrit-Change-Number: 85277 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[M] Change in flashrom[main]: cli_classic.c: Make -r/-w/-v argument optional when using -i
by Anastasia Klimchuk (Code Review) 23 Nov '24

23 Nov '24

Attention is currently required from: Matt DeVillier. Anastasia Klimchuk has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/flashrom/+/85159?usp=email ) Change subject: cli_classic.c: Make -r/-w/-v argument optional when using -i ...................................................................... Patch Set 4: (2 comments) Patchset: PS4: I have one last comment and that should be it. Thank you for your work, you took years old patch and finished it! Much appreciated. File cli_classic.c: https://review.coreboot.org/c/flashrom/+/85159/comment/d6e112c8_b94eb07b?us… : PS4, Line 1341: * Common rules for -r/-w/-v syntax parsing: I really like this comment, and I would copy it into the manpage. Same text (just need to remove the asterisks). The users won't read the source code, but they might read the manpage and learn command line syntax. Specifically, I would copy this text just before line 209 which says "Examples". So just before Examples, maybe call it "Summary" and then full text of this comment. And also I would leave it here too. Thank you! -- To view, visit https://review.coreboot.org/c/flashrom/+/85159?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I6eba095d478f1a7bdbc3854627a656f93dd9e452 Gerrit-Change-Number: 85159 Gerrit-PatchSet: 4 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Sat, 23 Nov 2024 07:42:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in flashrom[main]: cli_classic.c: Make -r/-w/-v argument optional when using -i
by Matt DeVillier (Code Review) 22 Nov '24

22 Nov '24

Attention is currently required from: Anastasia Klimchuk. Matt DeVillier has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/flashrom/+/85159?usp=email ) Change subject: cli_classic.c: Make -r/-w/-v argument optional when using -i ...................................................................... Patch Set 4: (5 comments) File doc/classic_cli_manpage.rst: https://review.coreboot.org/c/flashrom/+/85159/comment/087e8020_432d88a4?us… : PS2, Line 57: file > Let's do the same formatting as in the first sentence, […] Done https://review.coreboot.org/c/flashrom/+/85159/comment/319468c5_fc568170?us… : PS2, Line 70: file > Let's do the same formatting as in the first sentence, […] Done https://review.coreboot.org/c/flashrom/+/85159/comment/1e731092_e7909a36?us… : PS2, Line 100: file > Let's do the same formatting as in the first sentence, […] Done https://review.coreboot.org/c/flashrom/+/85159/comment/7ef74958_650ca145?us… : PS2, Line 206: <file> > same here, same formatting […] Done File layout.c: https://review.coreboot.org/c/flashrom/+/85159/comment/8a044050_204e472b?us… : PS2, Line 296: Error: No region file specified > Maybe we can give more details, so that there no confusion for the users where the error comes from: […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/85159?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I6eba095d478f1a7bdbc3854627a656f93dd9e452 Gerrit-Change-Number: 85159 Gerrit-PatchSet: 4 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Fri, 22 Nov 2024 14:27:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[XL] Change in flashrom[main]: flashchips: Splitting flashchips into separate files by vendor
by Anastasia Klimchuk (Code Review) 22 Nov '24

22 Nov '24

Attention is currently required from: Angel Pons. Anastasia Klimchuk has posted comments on this change by Angel Pons. ( https://review.coreboot.org/c/flashrom/+/83307?usp=email ) Change subject: flashchips: Splitting flashchips into separate files by vendor ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: At current state, the output of `flashrom -L` is identical before / after the patch. But the binary has diffs (and I hacked to have version "none" for both before and after binaries). Need to figure out why binaries different. -- To view, visit https://review.coreboot.org/c/flashrom/+/83307?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I3a9ebb0575e2700c5871d16875495d9c8943b30b Gerrit-Change-Number: 83307 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 22 Nov 2024 13:32:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XL] Change in flashrom[main]: flashchips: Splitting flashchips into separate files by vendor
by Anastasia Klimchuk (Code Review) 22 Nov '24

22 Nov '24

Attention is currently required from: Angel Pons. Anastasia Klimchuk has posted comments on this change by Angel Pons. ( https://review.coreboot.org/c/flashrom/+/83307?usp=email ) Change subject: flashchips: Splitting flashchips into separate files by vendor ...................................................................... Patch Set 2: (2 comments) This change is ready for review. Patchset: PS1: > I like this so much <3 […] Done PS1: > One more things I just realised, this will need an update to the doc "How to add new chip", the doc […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/83307?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I3a9ebb0575e2700c5871d16875495d9c8943b30b Gerrit-Change-Number: 83307 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 22 Nov 2024 13:30:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[M] Change in flashrom[main]: cli_classic.c: Make -r/-w/-v argument optional when using -i
by Anastasia Klimchuk (Code Review) 21 Nov '24

21 Nov '24

Attention is currently required from: Matt DeVillier. Anastasia Klimchuk has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/flashrom/+/85159?usp=email ) Change subject: cli_classic.c: Make -r/-w/-v argument optional when using -i ...................................................................... Patch Set 4: (3 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/85159/comment/a2f9b937_20c1c230?us… : PS2, Line 21: TEST=verify read/write/verify operations successful when specifying : the filename only after the region. > As a note, you can just copy-paste the list of commands that you ran to test, might be easier than w […] Done File cli_classic.c: https://review.coreboot.org/c/flashrom/+/85159/comment/c83f9af9_e77d9932?us… : PS3, Line 1344: > There are few trailing spaces (shown in gerrit in bright pink) in this comment Done https://review.coreboot.org/c/flashrom/+/85159/comment/ef366126_ccdb04af?us… : PS3, Line 1366: * - If file is specified for -w/-v and no files are specified with -i : * args, then the file is to be used for writing/verifying the entire : * ROM. > Maybe this one can be promoted to common rules? It does apply to all of them -r/-w/-v ? Done -- To view, visit https://review.coreboot.org/c/flashrom/+/85159?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I6eba095d478f1a7bdbc3854627a656f93dd9e452 Gerrit-Change-Number: 85159 Gerrit-PatchSet: 4 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Thu, 21 Nov 2024 21:57:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[M] Change in flashrom[main]: cli_classic.c: Make -r/-w/-v argument optional when using -i
by Matt DeVillier (Code Review) 21 Nov '24

21 Nov '24

Attention is currently required from: Matt DeVillier. Hello Anastasia Klimchuk, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/85159?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: cli_classic.c: Make -r/-w/-v argument optional when using -i ...................................................................... cli_classic.c: Make -r/-w/-v argument optional when using -i Make the filename parameter directly following -r/-w/-v optional, since the -i parameter allows the image to be written to be sourced from multiple files, regions to be read from flash and written to separate image files, and regions to be verified using an image file only containing that region. Since the filename parameter following -w/-v was ignored when a filename was specified following `-i <region>:<filename>`, this patch essentially removes the requirement to provide an unused parameter. Based on https://review.coreboot.org/c/flashrom/+/52362. TEST=run the following commands on a supported board: flashrom -p internal -r /tmp/coreboot.rom flashrom -p internal -r --ifd -i bios:/tmp/coreboot.rom flashrom -p internal -r /tmp/coreboot.rom --ifd -i bios:/tmp/bios.bin flashrom -p internal -w /tmp/coreboot.rom flashrom -p internal -w --ifd -i bios:/tmp/coreboot.rom flashrom -p internal -w /tmp/coreboot.rom --ifd -i bios:/tmp/bios.bin flashrom -p internal -v /tmp/coreboot.rom flashrom -p internal -v --ifd -i bios:/tmp/coreboot.rom flashrom -p internal -v /tmp/coreboot.rom --ifd -i bios:/tmp/bios.bin Change-Id: I6eba095d478f1a7bdbc3854627a656f93dd9e452 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M cli_classic.c M doc/classic_cli_manpage.rst M include/layout.h M layout.c 4 files changed, 123 insertions(+), 23 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/59/85159/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/85159?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I6eba095d478f1a7bdbc3854627a656f93dd9e452 Gerrit-Change-Number: 85159 Gerrit-PatchSet: 4 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>

1 0

[S] Change in flashrom[main]: Extract cli_output declarations to a separate header.
by Antonio Vázquez Blanco (Code Review) 21 Nov '24

21 Nov '24

Attention is currently required from: Anastasia Klimchuk. Antonio Vázquez Blanco has posted comments on this change by Antonio Vázquez Blanco. ( https://review.coreboot.org/c/flashrom/+/85134?usp=email ) Change subject: Extract cli_output declarations to a separate header. ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: Confirmation please! :) File include/cli_output.h: https://review.coreboot.org/c/flashrom/+/85134/comment/88635bd4_60a91ae7?us… : PS1, Line 4: * SPDX-FileCopyrightText: 2024 Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> : * SPDX-License-Identifier: GPL-2.0-or-later > I would ask you the same thing as in previous patch: if you can keep our usual license header for th […] Just for clarification, this is a newly added file. This header is not a change with respect with a previously existing copyright text and thus I believe this is not a modification of an original copyright text. That being said, I can copy the copyright text from any other file onto this one. Would you rather I copy the full license text from other file? Thanks! -- To view, visit https://review.coreboot.org/c/flashrom/+/85134?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I4209d5ed205ca14c39e83aa923e103b7282a7059 Gerrit-Change-Number: 85134 Gerrit-PatchSet: 1 Gerrit-Owner: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Thu, 21 Nov 2024 17:43:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit November 2024