November 2024 - flashrom-gerrit

[XS] Change in flashrom[main]: VERSION: Update version to v1.5.0-rc2
by Anastasia Klimchuk (Code Review) 28 Nov '24

28 Nov '24

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/85369?usp=email ) Change subject: VERSION: Update version to v1.5.0-rc2 ...................................................................... VERSION: Update version to v1.5.0-rc2 Change-Id: I03454539e69314f8532dd22a9b375ce5b7c9412b Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/85369 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Peter Marheine <pmarheine(a)chromium.org> --- M VERSION 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Peter Marheine: Looks good to me, approved diff --git a/VERSION b/VERSION index fcd141d..3468457 100644 --- a/VERSION +++ b/VERSION @@ -1 +1 @@ -v1.5.0-rc1 +v1.5.0-rc2 -- To view, visit https://review.coreboot.org/c/flashrom/+/85369?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I03454539e69314f8532dd22a9b375ce5b7c9412b Gerrit-Change-Number: 85369 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in flashrom[main]: VERSION: Update version to v1.5.0-rc2
by Peter Marheine (Code Review) 28 Nov '24

28 Nov '24

Attention is currently required from: Anastasia Klimchuk. Peter Marheine has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/85369?usp=email ) Change subject: VERSION: Update version to v1.5.0-rc2 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/85369?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I03454539e69314f8532dd22a9b375ce5b7c9412b Gerrit-Change-Number: 85369 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Thu, 28 Nov 2024 22:44:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in flashrom[main]: VERSION: Update version to v1.5.0-rc2
by Anastasia Klimchuk (Code Review) 28 Nov '24

28 Nov '24

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/85369?usp=email ) Change subject: VERSION: Update version to v1.5.0-rc2 ...................................................................... VERSION: Update version to v1.5.0-rc2 Change-Id: I03454539e69314f8532dd22a9b375ce5b7c9412b Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M VERSION 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/69/85369/1 diff --git a/VERSION b/VERSION index fcd141d..3468457 100644 --- a/VERSION +++ b/VERSION @@ -1 +1 @@ -v1.5.0-rc1 +v1.5.0-rc2 -- To view, visit https://review.coreboot.org/c/flashrom/+/85369?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I03454539e69314f8532dd22a9b375ce5b7c9412b Gerrit-Change-Number: 85369 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[S] Change in flashrom[main]: libflashrom: Fix comparison of layout romentry regions
by Anastasia Klimchuk (Code Review) 28 Nov '24

28 Nov '24

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/85292?usp=email ) Change subject: libflashrom: Fix comparison of layout romentry regions ...................................................................... libflashrom: Fix comparison of layout romentry regions Comparing structs (romentries in this case) with memcmp won't work if the struct includes pointers. Also in this case romentry region is compared to the one loaded from dump, and from dump only start, end and name are filled in. https://ticket.coreboot.org/issues/570 Prior effort: https://review.coreboot.org/c/flashrom/+/72433 Change-Id: I715969036c8e516aac8d90b46830f1f92ae6a160 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/85292 Reviewed-by: Peter Marheine <pmarheine(a)chromium.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M libflashrom.c 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Peter Marheine: Looks good to me, approved diff --git a/libflashrom.c b/libflashrom.c index dfc86e6..78e5c9b 100644 --- a/libflashrom.c +++ b/libflashrom.c @@ -306,6 +306,15 @@ } } +static int compare_region_with_dump(const struct romentry *const a, const struct romentry *const b) +{ + if (a->region.start != b->region.end + || a->region.end != b->region.end + || strcmp(a->region.name, b->region.name)) + return 1; + return 0; +} + int flashrom_layout_read_from_ifd(struct flashrom_layout **const layout, struct flashctx *const flashctx, const void *const dump, const size_t len) { @@ -343,7 +352,7 @@ const struct romentry *chip_entry = layout_next(chip_layout, NULL); const struct romentry *dump_entry = layout_next(dump_layout, NULL); - while (chip_entry && dump_entry && !memcmp(chip_entry, dump_entry, sizeof(*chip_entry))) { + while (chip_entry && dump_entry && !compare_region_with_dump(chip_entry, dump_entry)) { chip_entry = layout_next(chip_layout, chip_entry); dump_entry = layout_next(dump_layout, dump_entry); } -- To view, visit https://review.coreboot.org/c/flashrom/+/85292?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I715969036c8e516aac8d90b46830f1f92ae6a160 Gerrit-Change-Number: 85292 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in flashrom[main]: flashchips.c: Add reg_bits for W25Q256JW
by Anastasia Klimchuk (Code Review) 28 Nov '24

28 Nov '24

Attention is currently required from: Hsuan Ting Chen, Kapil Porwal. Anastasia Klimchuk has posted comments on this change by Kapil Porwal. ( https://review.coreboot.org/c/flashrom/+/85323?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: flashchips.c: Add reg_bits for W25Q256JW ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: Thanks everyone, for contribution and reviews! I have two pieces of information: 1) I leave this unresolved comment as a note this patch will be submitted after v1.5.0 tag is done. ETA 6th December. Perhaps you already know, but just in case, we are now preparing a release and only merging bugfixes. See the thread for details: https://mail.coreboot.org/hyperkitty/list/flashrom@flashrom.org/thread/WM4C… So this is a special time now. At normal time, merging would be in 3 days, process documented here: https://flashrom.org/dev_guide/development_guide.html#merging-patches 2) We are splitting flashchips.c (this was also explained in the same announcement thread). That work will go as https://review.coreboot.org/c/flashrom/+/83307 , but similarly, only after v1.5.0 tag is done. You will need to move your code from `flashchips.c` into `winbond.c`, all the same lines, just copy-paste from one file to the other. You will be able to do all that on 6th December, and then your patch can go ahead. In general, I recommend subscribing to our public mailing list if you would like to be on the top of what is happening and all the big plans. Thank you! https://flashrom.org/contact.html#mailing-list-1 -- To view, visit https://review.coreboot.org/c/flashrom/+/85323?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I050754b28a90911a50f891869297524ce9a6720e Gerrit-Change-Number: 85323 Gerrit-PatchSet: 2 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Reviewer: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Thu, 28 Nov 2024 01:54:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in flashrom[main]: flashchips.c: Add reg_bits for W25Q256JW
by Hsuan-ting Chen (Code Review) 27 Nov '24

27 Nov '24

Attention is currently required from: Hsuan Ting Chen, Kapil Porwal. Hsuan-ting Chen has posted comments on this change by Kapil Porwal. ( https://review.coreboot.org/c/flashrom/+/85323?usp=email ) Change subject: flashchips.c: Add reg_bits for W25Q256JW ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: Thanks for the commit update. LGTM -- To view, visit https://review.coreboot.org/c/flashrom/+/85323?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I050754b28a90911a50f891869297524ce9a6720e Gerrit-Change-Number: 85323 Gerrit-PatchSet: 2 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Reviewer: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Wed, 27 Nov 2024 09:27:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in flashrom[main]: flashchips.c: Add reg_bits for W25Q256JW
by Kapil Porwal (Code Review) 27 Nov '24

27 Nov '24

Attention is currently required from: Hsuan Ting Chen. Kapil Porwal has posted comments on this change by Kapil Porwal. ( https://review.coreboot.org/c/flashrom/+/85323?usp=email ) Change subject: flashchips.c: Add reg_bits for W25Q256JW ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/85323/comment/39e482e8_c88e69b0?us… : PS1, Line 11: > Please add the link-to datasheet, e.g. https://www.winbond.com/hq/support/documentation/levelOne. […] Acknowledged File flashchips.c: https://review.coreboot.org/c/flashrom/+/85323/comment/79136ab9_333ae7e8?us… : PS1, Line 20341: TEST_OK_PREWB > I see this is marked as tested. […] Acknowledged. Updated the commit message with test details. -- To view, visit https://review.coreboot.org/c/flashrom/+/85323?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I050754b28a90911a50f891869297524ce9a6720e Gerrit-Change-Number: 85323 Gerrit-PatchSet: 2 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Reviewer: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Comment-Date: Wed, 27 Nov 2024 09:13:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hsuan-ting Chen <roccochen(a)google.com>

1 0

[S] Change in flashrom[main]: flashchips.c: Add reg_bits for W25Q256JW
by Kapil Porwal (Code Review) 27 Nov '24

27 Nov '24

Attention is currently required from: Hsuan Ting Chen, Kapil Porwal. Hello Anastasia Klimchuk, Hsuan Ting Chen, Hsuan-ting Chen, Nikolai Artemiev, Stefan Reinauer, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/85323?usp=email to look at the new patch set (#2). Change subject: flashchips.c: Add reg_bits for W25Q256JW ...................................................................... flashchips.c: Add reg_bits for W25Q256JW Add reg_bits for W25Q256JW as per the datasheet. The register definitions are same as W25Q256JW_DTR. Datasheet: https://www.winbond.com/hq/support/documentation/levelOne.jsp?__locale=en&D… BUG=b:376929528 TEST=Program and verify WP ranges ``` flashrom -p internal --wp-status flashrom -p internal --wp-range 0x0,0x2000000 flashrom -p internal --wp-enable flashrom -p internal --wp-status ``` Change-Id: I050754b28a90911a50f891869297524ce9a6720e Signed-off-by: Kapil Porwal <kapilporwal(a)google.com> --- M flashchips.c 1 file changed, 13 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/23/85323/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/85323?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I050754b28a90911a50f891869297524ce9a6720e Gerrit-Change-Number: 85323 Gerrit-PatchSet: 2 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Reviewer: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>

1 0

[S] Change in flashrom[main]: flashchips.c: Add reg_bits for W25Q256JW
by Hsuan-ting Chen (Code Review) 27 Nov '24

27 Nov '24

Attention is currently required from: Hsuan Ting Chen, Kapil Porwal. Hsuan-ting Chen has posted comments on this change by Kapil Porwal. ( https://review.coreboot.org/c/flashrom/+/85323?usp=email ) Change subject: flashchips.c: Add reg_bits for W25Q256JW ...................................................................... Patch Set 1: (1 comment) File flashchips.c: https://review.coreboot.org/c/flashrom/+/85323/comment/51ffd053_4628bdb2?us… : PS1, Line 20341: TEST_OK_PREWB I see this is marked as tested. Could you please share some details about the testing process you followed? -- To view, visit https://review.coreboot.org/c/flashrom/+/85323?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I050754b28a90911a50f891869297524ce9a6720e Gerrit-Change-Number: 85323 Gerrit-PatchSet: 1 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Reviewer: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Wed, 27 Nov 2024 06:43:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in flashrom[main]: flashchips.c: Add reg_bits for W25Q256JW
by Hsuan-ting Chen (Code Review) 27 Nov '24

27 Nov '24

Attention is currently required from: Hsuan Ting Chen, Kapil Porwal. Hsuan-ting Chen has posted comments on this change by Kapil Porwal. ( https://review.coreboot.org/c/flashrom/+/85323?usp=email ) Change subject: flashchips.c: Add reg_bits for W25Q256JW ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/85323/comment/418a0007_f87a2ca6?us… : PS1, Line 11: Please add the link-to datasheet, e.g. https://www.winbond.com/hq/support/documentation/levelOne.jsp?__locale=en&D… -- To view, visit https://review.coreboot.org/c/flashrom/+/85323?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I050754b28a90911a50f891869297524ce9a6720e Gerrit-Change-Number: 85323 Gerrit-PatchSet: 1 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Reviewer: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Wed, 27 Nov 2024 06:40:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit November 2024