October 2024 - flashrom-gerrit

[L] Change in flashrom[main]: cli_classic: Add rpmc command support
by Matti Finder (Code Review) Oct. 25, 2024

Oct. 25, 2024

Attention is currently required from: Anastasia Klimchuk, Peter Marheine. Matti Finder has posted comments on this change by Matti Finder. ( https://review.coreboot.org/c/flashrom/+/84840?usp=email ) Change subject: cli_classic: Add rpmc command support ...................................................................... Patch Set 3: (1 comment) File cli_classic.c: https://review.coreboot.org/c/flashrom/+/84840/comment/8709319f_bb0f0e83?us… : PS2, Line 159: printf(".\n\nYou can specify one of -h, -R, -L, " > Should this list be extended, since any RPMC command is also allowed? Do you think the way I extended it is ok. Otherwise I think the message would get too long. The wp-range options are also not specified here. -- To view, visit https://review.coreboot.org/c/flashrom/+/84840?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I36c823bbee65f256eb6edabe6f058321c9a0cfa1 Gerrit-Change-Number: 84840 Gerrit-PatchSet: 3 Gerrit-Owner: Matti Finder <matti.finder(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Fri, 25 Oct 2024 14:41:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org>

1 0

[L] Change in flashrom[main]: cli_classic: Add rpmc command support
by Matti Finder (Code Review) Oct. 25, 2024

Oct. 25, 2024

Attention is currently required from: Anastasia Klimchuk, Peter Marheine. Matti Finder has posted comments on this change by Matti Finder. ( https://review.coreboot.org/c/flashrom/+/84840?usp=email ) Change subject: cli_classic: Add rpmc command support ...................................................................... Patch Set 3: (3 comments) Patchset: PS3: I didn't have my editor set up correctly for this coding style. Now with 8-wide tabs, I have restored the things i retabbed back to their original state. Also I adjusted my patch to better match the coding style. Please let me know if there are more things that need adjustment to match the coding style. File cli_classic.c: https://review.coreboot.org/c/flashrom/+/84840/comment/d479cedd_bfd3983e?us… : PS2, Line 113: > I don't think we should re-tab all this text, since at default 8-char tabs some of them now exceed 8 […] Done https://review.coreboot.org/c/flashrom/+/84840/comment/00d2d6d8_8a91fa90?us… : PS2, Line 147: #if CONFIG_RPMC_ENABLED == 1 > These options are all related to RPMC, so adding a heading might be useful. […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/84840?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I36c823bbee65f256eb6edabe6f058321c9a0cfa1 Gerrit-Change-Number: 84840 Gerrit-PatchSet: 3 Gerrit-Owner: Matti Finder <matti.finder(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Fri, 25 Oct 2024 14:34:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org>

1 0

[L] Change in flashrom[main]: cli_classic: Add rpmc command support
by Matti Finder (Code Review) Oct. 25, 2024

Oct. 25, 2024

Attention is currently required from: Anastasia Klimchuk, Matti Finder. Hello Anastasia Klimchuk, Peter Marheine, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/84840?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: cli_classic: Add rpmc command support ...................................................................... cli_classic: Add rpmc command support Added optional support for all the commands specified in JESD260. Added a new optional dependency to openssls libcrypto. Added parsing for the rpmc parameter sfdp table. Added necessary rpmc parameter information to flashchips struct and the flash hardening feature to enable rpmc commands. Tested on the Winbond W25R128JV as a 'SFDP-capable chip'. This patch was done to add rpmc command support to flashrom. This enables users to write root keys to their flash chips while they flash data on the chip. This might become usefull in the future as rpmc support is extended in coreboot. Also adds usefull debug tools to flashrom, which might be usefull in implementing coreboots rpmc support. Change-Id: I36c823bbee65f256eb6edabe6f058321c9a0cfa1 Signed-off-by: Matti Finder <matti.finder(a)gmail.com> --- M cli_classic.c M include/flash.h A include/rpmc.h M meson.build M meson_options.txt A rpmc.c M sfdp.c 7 files changed, 799 insertions(+), 18 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/40/84840/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/84840?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I36c823bbee65f256eb6edabe6f058321c9a0cfa1 Gerrit-Change-Number: 84840 Gerrit-PatchSet: 3 Gerrit-Owner: Matti Finder <matti.finder(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Matti Finder <matti.finder(a)gmail.com>

1 0

[S] Change in flashrom[main]: doc: Add chip models support into recent development
by Anastasia Klimchuk (Code Review) Oct. 25, 2024

Oct. 25, 2024

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/84870?usp=email ) Change subject: doc: Add chip models support into recent development ...................................................................... doc: Add chip models support into recent development Change-Id: I9b96902a02b83d35f0a0f221bd1678b7edf99dad Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M doc/release_notes/devel.rst 1 file changed, 45 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/70/84870/1 diff --git a/doc/release_notes/devel.rst b/doc/release_notes/devel.rst index 919d364..8021899 100644 --- a/doc/release_notes/devel.rst +++ b/doc/release_notes/devel.rst @@ -26,6 +26,7 @@ New Feature =========== + Libpci 3.13.0 and onwards support ECAM to access pci registers. Flashrom will be moved to ECAM from IO port 0xcf8/0xcfc if the libpci version is >= 3.13.0. The ECAM has been supported for a very long time, most platforms should support @@ -34,4 +35,48 @@ Chipset support =============== + Added Raptor Point PCH support. + +Chip model support added +======================== + +* FM25Q04 +* FM25Q64 +* FM25Q128 + +* GD25B128E +* GD25B256E +* GD25B512MF +* GD25F64F +* GD25F256F +* GD25R128E +* GD25R256E +* GD25R512MF +* GD25LB256F +* GD25LB512ME +* GD25LB512MF +* GD25LR256F +* GD25LR512MF +* GD25LF256F +* GD25LF512MF + +* MX25U25645G +* MX77U51250F + +* W25Q32JV_M + +* XM25LU64C +* XM25QH32C +* XM25QH32D +* XM25QH64D +* XM25QH128D +* XM25QH256D +* XM25QH512C +* XM25QH512D +* XM25QU16C +* XM25QU32C +* XM25QU128D +* XM25QU256D +* XM25QU512C +* XM25QU512D -- To view, visit https://review.coreboot.org/c/flashrom/+/84870?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I9b96902a02b83d35f0a0f221bd1678b7edf99dad Gerrit-Change-Number: 84870 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[XS] Change in flashrom[main]: [WIP] Erase blocks are selected smaller than expected
by Anastasia Klimchuk (Code Review) Oct. 25, 2024

Oct. 25, 2024

Attention is currently required from: Aarya, Peter Marheine. Anastasia Klimchuk has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/82723?usp=email ) Change subject: [WIP] Erase blocks are selected smaller than expected ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Running this on head, erase blocks are more granular than expected, specifically: […] I know why sometimes smaller adjacent blocks are not merged into a larger block. Because they belong to the different blocks of size+1. That's the second case here specifically 1031 Eraser called with blockaddr=0x2, blocklen=0x2 1033 Eraser called with blockaddr=0x4, blocklen=0x2 size+1 is blocklen==4 and blockaddr 0x2 vs 0x4 belong to the different blocks of size 4 To merge them, we would need to do a second pass after all blocks are selected, and potentially merge -- To view, visit https://review.coreboot.org/c/flashrom/+/82723?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I47851d2b6106075111babf8c3535e5394cbbe0f9 Gerrit-Change-Number: 82723 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Fri, 25 Oct 2024 10:32:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[M] Change in flashrom[main]: erasure_layout: Add an option to sacrifice unchanged blocks for speed
by Anastasia Klimchuk (Code Review) Oct. 25, 2024

Oct. 25, 2024

Attention is currently required from: Aarya, Bill XIE. Anastasia Klimchuk has posted comments on this change by Bill XIE. ( https://review.coreboot.org/c/flashrom/+/84721?usp=email ) Change subject: erasure_layout: Add an option to sacrifice unchanged blocks for speed ...................................................................... Patch Set 5: (3 comments) Patchset: PS3: > Okay. Done File cli_classic.c: https://review.coreboot.org/c/flashrom/+/84721/comment/a1514ad8_3b4bbe3c?us… : PS5, Line 126: max 100 What do you think about restricting max to 50? I don't think values more than 50 make sense. https://review.coreboot.org/c/flashrom/+/84721/comment/dd660fbd_5cc0dcec?us… : PS5, Line 1141: Invalid input of sacrifice ratio, use default 0 Invalid input of sacrifice ratio, valid range is 0-50. Fallback to default value 0. (that's if you agree with previous comment) -- To view, visit https://review.coreboot.org/c/flashrom/+/84721?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I154e8a713f626c37dbbe118db700055b96d24803 Gerrit-Change-Number: 84721 Gerrit-PatchSet: 5 Gerrit-Owner: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Reviewer: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Comment-Date: Fri, 25 Oct 2024 10:22:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Bill XIE <persmule(a)hardenedlinux.org> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[M] Change in flashrom[main]: erasure_layout: Add an option to sacrifice unchanged blocks for speed
by Anastasia Klimchuk (Code Review) Oct. 25, 2024

Oct. 25, 2024

Attention is currently required from: Aarya, Anastasia Klimchuk. Anastasia Klimchuk has uploaded a new patch set (#5) to the change originally created by Bill XIE. ( https://review.coreboot.org/c/flashrom/+/84721?usp=email ) The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: erasure_layout: Add an option to sacrifice unchanged blocks for speed ...................................................................... erasure_layout: Add an option to sacrifice unchanged blocks for speed Someone may prefer to sacrifice sub-blocks needless to change within a larger erase block for programming speed. These people who are okay to fry their chip sooner can set this option. If the percentage of sub-blocks needless to change within a larger erase block is lower than the given value, the whole larger erase block will be erased. Change-Id: I154e8a713f626c37dbbe118db700055b96d24803 Co-developed-by: persmule <persmule(a)hardenedlinux.org Co-developed-by: Anastasia Klimchuk <aklm(a)flashrom.org> Signed-off-by: persmule <persmule(a)hardenedlinux.org> Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M cli_classic.c M erasure_layout.c M include/flash.h M tests/erase_func_algo.c 4 files changed, 112 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/21/84721/5 -- To view, visit https://review.coreboot.org/c/flashrom/+/84721?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I154e8a713f626c37dbbe118db700055b96d24803 Gerrit-Change-Number: 84721 Gerrit-PatchSet: 5 Gerrit-Owner: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Reviewer: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[S] Change in flashrom[main]: flashchips: add GD25F128F
by Anastasia Klimchuk (Code Review) Oct. 25, 2024

Oct. 25, 2024

Attention is currently required from: Nikolai Artemiev, Stefan Reinauer, Victor Lim. Anastasia Klimchuk has posted comments on this change by Victor Lim. ( https://review.coreboot.org/c/flashrom/+/84827?usp=email ) Change subject: flashchips: add GD25F128F ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/84827/comment/50c4e772_4158e4a3?us… : PS1, Line 12: Will send datasheet via email > Is it possible that you will also include Nikolai in the email when you send the datasheet? Thank yo […] We got email, all good, you can remove this from commit message. File flashchips.c: https://review.coreboot.org/c/flashrom/+/84827/comment/81d6aac8_b28d1f4f?us… : PS1, Line 8199: OTP: 1024B total, 256B reserved I have a question, why it is 1024B total, and what does it mean "reserved"? Datasheet says `3x2048-Byte Security Registers With OTP Locks` and 3x2K bytes is 6K, not 1024B. So I wanted to understand where 1024B total coming from. Also I could not find where 256B reserved is mentioned. If you could maybe explain to me? Thank you so much! -- To view, visit https://review.coreboot.org/c/flashrom/+/84827?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I14c0905f50e92492287d50f8377790b997c4acfe Gerrit-Change-Number: 84827 Gerrit-PatchSet: 1 Gerrit-Owner: Victor Lim <vlim(a)gigadevice.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Victor Lim <vlim(a)gigadevice.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Fri, 25 Oct 2024 07:34:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[S] Change in flashrom[main]: VERSION: Change name pattern to match tag name from now on
by Anastasia Klimchuk (Code Review) Oct. 25, 2024

Oct. 25, 2024

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/84811?usp=email ) Change subject: VERSION: Change name pattern to match tag name from now on ...................................................................... VERSION: Change name pattern to match tag name from now on This patch updated the VERSION file itself, and the document on release process. Change-Id: I2bd2e57e42c29ea5a9d8bc334b86c6fa5c4b46a4 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/84811 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Peter Marheine <pmarheine(a)chromium.org> --- M VERSION M doc/dev_guide/release_process.rst 2 files changed, 18 insertions(+), 12 deletions(-) Approvals: build bot (Jenkins): Verified Peter Marheine: Looks good to me, approved diff --git a/VERSION b/VERSION index 4a06232..bd033f4 100644 --- a/VERSION +++ b/VERSION @@ -1 +1 @@ -1.5.0-devel +v1.5.0-devel diff --git a/doc/dev_guide/release_process.rst b/doc/dev_guide/release_process.rst index 749779e..15eaf6c 100644 --- a/doc/dev_guide/release_process.rst +++ b/doc/dev_guide/release_process.rst @@ -24,14 +24,13 @@ * Double-check and merge all the patches that are fully ready (see also :ref:`merge-checklist`) -* Update VERSION file to first release candidate. Check the git history of VERSION file for a version name pattern. +* Update VERSION file to first release candidate. The name pattern is: ``v{version_number}-rc{rc_number}``. - * As an example at the time of writing, the version name of the first release candidate was ``1.4.0-rc1``. + * As an example, the version name of the first release candidate can be ``v1.4.0-rc1``. * To update the VERSION file, push a patch to Gerrit, and another maintainer should review and approve. -* After submitting the change to the VERSION file, tag this commit. - You can check `flashrom tags in Gerrit <https://review.coreboot.org/admin/repos/flashrom,tags,25>`_ - for tag name pattern. As an example at the time of writing, the tag name was ``v1.4.0-rc1``. +* After submitting the change to the VERSION file, tag this commit. Tag name should be the same as + version name, for example above ``v1.4.0-rc1``. * Write an announcement on the mailing list. Be very clear about: @@ -74,13 +73,19 @@ * Submit the release notes, and in the same patch restart :doc:`/release_notes/devel` document. This way everyone who is syncing the repository by the release tag will have release notes in the tree. -* Update VERSION file to release version (for example, at the time of writing ``1.4.0``), and submit this +* Update VERSION file to release version, name pattern is: ``v{version_name}`` + (for example, it can be ``v1.4.0``), and submit this. -* Tag the commit which updates the VERSION file. You can check - `flashrom tags in Gerrit <https://review.coreboot.org/admin/repos/flashrom,tags,25>`_ for tag name pattern. - As an example at the time of writing, the tag name was ``v1.4.0``. +* Tag the commit which updates the VERSION file. Tag name should be the same as version name, + for example above ``v1.4.0``. -* Create the tarball, sign it, and upload to the server together with the signature. +* Create the tarball: + + * At the moment of writing, the command we use ``meson dist --include-subprojects``, + more details are in `meson docs <https://mesonbuild.com/Creating-releases.html#creating-releases>`_. + * Check that tarball name follows the pattern ``flashrom-v{version_name}.tar.xz``, for example ``flashrom-v1.4.0.tar.xz``. + +* Sign the tarball, and upload to the server together with the signature. * Update release notes with the link to download tarball, signature, and fingerprint. Submit this and check that final release notes are published on the website. @@ -93,7 +98,8 @@ Start the next cycle of development =================================== -* Update the VERSION file to the development version. For example, at the time of writing ``1.5.0-devel``, and submit this. +* Update the VERSION file to the development version. For example, the name pattern is: ``v{version_name}-devel``, + for example ``v1.5.0-devel``, and submit this. * Submit all the patches that have been ready and waiting. -- To view, visit https://review.coreboot.org/c/flashrom/+/84811?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I2bd2e57e42c29ea5a9d8bc334b86c6fa5c4b46a4 Gerrit-Change-Number: 84811 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[L] Change in flashrom[main]: cli_classic: Add rpmc command support
by Peter Marheine (Code Review) Oct. 24, 2024

Oct. 24, 2024

Attention is currently required from: Anastasia Klimchuk, Matti Finder. Peter Marheine has posted comments on this change by Matti Finder. ( https://review.coreboot.org/c/flashrom/+/84840?usp=email ) Change subject: cli_classic: Add rpmc command support ...................................................................... Patch Set 2: (3 comments) File cli_classic.c: https://review.coreboot.org/c/flashrom/+/84840/comment/d47812b6_72108ce3?us… : PS2, Line 113: I don't think we should re-tab all this text, since at default 8-char tabs some of them now exceed 80 characters in width. I think for the new options that are longer, it might be better to wrap the help to start on the next line. https://review.coreboot.org/c/flashrom/+/84840/comment/eabcda37_24261973?us… : PS2, Line 147: #if CONFIG_RPMC_ENABLED == 1 These options are all related to RPMC, so adding a heading might be useful. Something like: ``` RPMC COMMANDS --get-rpmc-status ... RPMC OPTIONS --rpmc-root-key ... PROGRAMMER SELECTION OPTIONS -p | --programmer ... ``` It would be nice to organize all the options like that, but this change could set the tone. https://review.coreboot.org/c/flashrom/+/84840/comment/529c9327_b7e1c544?us… : PS2, Line 159: printf(".\n\nYou can specify one of -h, -R, -L, " Should this list be extended, since any RPMC command is also allowed? -- To view, visit https://review.coreboot.org/c/flashrom/+/84840?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I36c823bbee65f256eb6edabe6f058321c9a0cfa1 Gerrit-Change-Number: 84840 Gerrit-PatchSet: 2 Gerrit-Owner: Matti Finder <matti.finder(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Matti Finder <matti.finder(a)gmail.com> Gerrit-Comment-Date: Thu, 24 Oct 2024 22:54:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0