November 2023 - flashrom-gerrit

[M] Change in flashrom[main]: ati: add all rx6xx ids
by Chen (Code Review) 30 Nov '23

30 Nov '23

Attention is currently required from: Angel Pons, Chen, Luc Verhaegen. Chen has uploaded a new patch set (#6) to the change originally created by Luc Verhaegen. ( https://review.coreboot.org/c/flashrom/+/29091?usp=email ) Change subject: ati: add all rx6xx ids ...................................................................... ati: add all rx6xx ids Change-Id: Ia1db93efcc4e10e6f651564ca194a146c668d68b Signed-off-by: Luc Verhaegen <libv(a)skynet.be> Signed-off-by: Jiajie Chen <c(a)jia.je> --- M ati_spi.c 1 file changed, 117 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/91/29091/6 -- To view, visit https://review.coreboot.org/c/flashrom/+/29091?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ia1db93efcc4e10e6f651564ca194a146c668d68b Gerrit-Change-Number: 29091 Gerrit-PatchSet: 6 Gerrit-Owner: Luc Verhaegen <libv(a)skynet.be> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Chen <c(a)jia.je> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Chen <c(a)jia.je> Gerrit-Attention: Luc Verhaegen <libv(a)skynet.be> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in flashrom[main]: ati: add r600_spi_command and r600_spi_master
by Chen (Code Review) 30 Nov '23

30 Nov '23

Attention is currently required from: Angel Pons, Chen, Luc Verhaegen. Chen has uploaded a new patch set (#6) to the change originally created by Luc Verhaegen. ( https://review.coreboot.org/c/flashrom/+/29090?usp=email ) Change subject: ati: add r600_spi_command and r600_spi_master ...................................................................... ati: add r600_spi_command and r600_spi_master Change-Id: I3d0bc682898f8eadadfe1f6db0d1383eb7639054 Signed-off-by: Luc Verhaegen <libv(a)skynet.be> Signed-off-by: Jiajie Chen <c(a)jia.je> --- M ati_spi.c 1 file changed, 108 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/90/29090/6 -- To view, visit https://review.coreboot.org/c/flashrom/+/29090?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I3d0bc682898f8eadadfe1f6db0d1383eb7639054 Gerrit-Change-Number: 29090 Gerrit-PatchSet: 6 Gerrit-Owner: Luc Verhaegen <libv(a)skynet.be> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Chen <c(a)jia.je> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Chen <c(a)jia.je> Gerrit-Attention: Luc Verhaegen <libv(a)skynet.be> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[main]: ati: add further spi initialization
by Chen (Code Review) 30 Nov '23

30 Nov '23

Attention is currently required from: Angel Pons, Chen, Luc Verhaegen. Chen has uploaded a new patch set (#6) to the change originally created by Luc Verhaegen. ( https://review.coreboot.org/c/flashrom/+/29089?usp=email ) Change subject: ati: add further spi initialization ...................................................................... ati: add further spi initialization Change-Id: I14fb218d001c1e12888225675bd8fdd46e7d8fae Signed-off-by: Luc Verhaegen <libv(a)skynet.be> Signed-off-by: Jiajie Chen <c(a)jia.je> --- M ati_spi.c 1 file changed, 35 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/89/29089/6 -- To view, visit https://review.coreboot.org/c/flashrom/+/29089?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I14fb218d001c1e12888225675bd8fdd46e7d8fae Gerrit-Change-Number: 29089 Gerrit-PatchSet: 6 Gerrit-Owner: Luc Verhaegen <libv(a)skynet.be> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Chen <c(a)jia.je> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Chen <c(a)jia.je> Gerrit-Attention: Luc Verhaegen <libv(a)skynet.be> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[main]: ati: add spi access enable
by Chen (Code Review) 30 Nov '23

30 Nov '23

Attention is currently required from: Angel Pons, Chen, Luc Verhaegen. Chen has uploaded a new patch set (#6) to the change originally created by Luc Verhaegen. ( https://review.coreboot.org/c/flashrom/+/29088?usp=email ) Change subject: ati: add spi access enable ...................................................................... ati: add spi access enable Change-Id: Ibd68fb11237a39857ba6a4bb69e89589afd8c198 Signed-off-by: Luc Verhaegen <libv(a)skynet.be> Signed-off-by: Jiajie Chen <c(a)jia.je> --- M ati_spi.c 1 file changed, 41 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/88/29088/6 -- To view, visit https://review.coreboot.org/c/flashrom/+/29088?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ibd68fb11237a39857ba6a4bb69e89589afd8c198 Gerrit-Change-Number: 29088 Gerrit-PatchSet: 6 Gerrit-Owner: Luc Verhaegen <libv(a)skynet.be> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Chen <c(a)jia.je> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Chen <c(a)jia.je> Gerrit-Attention: Luc Verhaegen <libv(a)skynet.be> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in flashrom[main]: ati: add save/restore
by Chen (Code Review) 30 Nov '23

30 Nov '23

Attention is currently required from: Angel Pons, Chen, Luc Verhaegen. Chen has uploaded a new patch set (#6) to the change originally created by Luc Verhaegen. ( https://review.coreboot.org/c/flashrom/+/29087?usp=email ) Change subject: ati: add save/restore ...................................................................... ati: add save/restore Change-Id: I392c3ecc07facdeb2454ec1702bd277f7ebbf50d Signed-off-by: Luc Verhaegen <libv(a)skynet.be> Signed-off-by: Jiajie Chen <c(a)jia.je> --- M ati_spi.c 1 file changed, 146 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/87/29087/6 -- To view, visit https://review.coreboot.org/c/flashrom/+/29087?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I392c3ecc07facdeb2454ec1702bd277f7ebbf50d Gerrit-Change-Number: 29087 Gerrit-PatchSet: 6 Gerrit-Owner: Luc Verhaegen <libv(a)skynet.be> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Chen <c(a)jia.je> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Chen <c(a)jia.je> Gerrit-Attention: Luc Verhaegen <libv(a)skynet.be> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[main]: ati: map mmio
by Chen (Code Review) 30 Nov '23

30 Nov '23

Attention is currently required from: Angel Pons, Chen, Luc Verhaegen. Chen has uploaded a new patch set (#6) to the change originally created by Luc Verhaegen. ( https://review.coreboot.org/c/flashrom/+/29086?usp=email ) Change subject: ati: map mmio ...................................................................... ati: map mmio Change-Id: Ifaf964aa7ff12e2397aaec3c9aaae07a7ac9309a Signed-off-by: Luc Verhaegen <libv(a)skynet.be> Signed-off-by: Jiajie Chen <c(a)jia.je> --- M ati_spi.c 1 file changed, 19 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/86/29086/6 -- To view, visit https://review.coreboot.org/c/flashrom/+/29086?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ifaf964aa7ff12e2397aaec3c9aaae07a7ac9309a Gerrit-Change-Number: 29086 Gerrit-PatchSet: 6 Gerrit-Owner: Luc Verhaegen <libv(a)skynet.be> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Chen <c(a)jia.je> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Chen <c(a)jia.je> Gerrit-Attention: Luc Verhaegen <libv(a)skynet.be> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in flashrom[main]: ati: initial commit
by Chen (Code Review) 30 Nov '23

30 Nov '23

Attention is currently required from: Angel Pons, Chen, Luc Verhaegen. Chen has uploaded a new patch set (#6) to the change originally created by Luc Verhaegen. ( https://review.coreboot.org/c/flashrom/+/29085?usp=email ) Change subject: ati: initial commit ...................................................................... ati: initial commit Change-Id: Ia5f755ae7a0723372933216516625bc156b1f4bc Signed-off-by: Luc Verhaegen <libv(a)skynet.be> Signed-off-by: Jiajie Chen <c(a)jia.je> --- M Makefile A ati_spi.c M include/programmer.h M meson.build M programmer_table.c 5 files changed, 106 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/85/29085/6 -- To view, visit https://review.coreboot.org/c/flashrom/+/29085?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ia5f755ae7a0723372933216516625bc156b1f4bc Gerrit-Change-Number: 29085 Gerrit-PatchSet: 6 Gerrit-Owner: Luc Verhaegen <libv(a)skynet.be> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Chen <c(a)jia.je> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Chen <c(a)jia.je> Gerrit-Attention: Luc Verhaegen <libv(a)skynet.be> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in flashrom[main]: MAINTAINERS: Add roccochen as supporter for flashrom_tester
by Hsuan-ting Chen (Code Review) 30 Nov '23

30 Nov '23

Attention is currently required from: Anastasia Klimchuk. Hsuan-ting Chen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/79319?usp=email ) Change subject: MAINTAINERS: Add roccochen as supporter for flashrom_tester ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I could take the supporter role for newer flashrom_tester related patches. -- To view, visit https://review.coreboot.org/c/flashrom/+/79319?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I71139401b5f2c7c1b4e76ba67ff774e030a343aa Gerrit-Change-Number: 79319 Gerrit-PatchSet: 1 Gerrit-Owner: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Evan Benn <evanbenn(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Thu, 30 Nov 2023 08:42:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[main]: MAINTAINERS: Add roccochen as supporter for flashrom_tester
by Hsuan-ting Chen (Code Review) 30 Nov '23

30 Nov '23

Hsuan-ting Chen has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/79319?usp=email ) Change subject: MAINTAINERS: Add roccochen as supporter for flashrom_tester ...................................................................... MAINTAINERS: Add roccochen as supporter for flashrom_tester BUG=none BRANCH=none TEST=~/coreboot/util/scripts/get_maintainer.pl -f util/flashrom_tester/build.rs Change-Id: I71139401b5f2c7c1b4e76ba67ff774e030a343aa Signed-off-by: Hsuan Ting Chen <roccochen(a)google.com> --- M MAINTAINERS 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/19/79319/1 diff --git a/MAINTAINERS b/MAINTAINERS index 40aa3ed..0b5f09a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -196,6 +196,7 @@ FLASHROM TESTER R: Evan Benn <evanbenn(a)gmail.com> +M: Hsuan-ting Chen <roccochen(a)google.com> S: Supported F: util/flashrom_tester/ -- To view, visit https://review.coreboot.org/c/flashrom/+/79319?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I71139401b5f2c7c1b4e76ba67ff774e030a343aa Gerrit-Change-Number: 79319 Gerrit-PatchSet: 1 Gerrit-Owner: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-MessageType: newchange

1 0

[S] Change in flashrom[main]: buspirate_spi: Add support for hiz output with pullups=off
by David Reguera Garcia (Code Review) 30 Nov '23

30 Nov '23

Attention is currently required from: Anastasia Klimchuk, Thomas Heijligen. Hello Anastasia Klimchuk, Thomas Heijligen, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/79299?usp=email to look at the new patch set (#6). Change subject: buspirate_spi: Add support for hiz output with pullups=off ...................................................................... buspirate_spi: Add support for hiz output with pullups=off When working with low-voltage chips, the internal 10k pull-ups of the Bus Pirate might be too high. In such cases, it's necessary to create an external pull-up using lower-value resistors. For this, you can use the 'hiz' parameter. This way, the Bus Pirate will operate as an open drain with 'pullups=off' So, why not just use the 'pullups=on' option for this scenario? I'm trying to prevent a very typical human error in the training sessions I conduct. For example, in the previous session, a user might have left the VPU (vextern) connected to 5V, and now they need to access a 1.8V chip. If 'pullups=on' is used, the following will happen: 5V (VPU) --> CD4060 --> 2K (internal Bus Pirate) --> MOSI target chip. By having the option to set a 'hiz=on', this can be avoided. Since the pull-ups will remain deactivated while the Bus Pirate will function in an open-drain mode Change-Id: I6d9909b23782ef3fcb1428fd127dae0d6b211855 Signed-off-by: David Reguera Garcia <dreg(a)rootkit.es> --- M buspirate_spi.c M doc/classic_cli_manpage.rst 2 files changed, 22 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/99/79299/6 -- To view, visit https://review.coreboot.org/c/flashrom/+/79299?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I6d9909b23782ef3fcb1428fd127dae0d6b211855 Gerrit-Change-Number: 79299 Gerrit-PatchSet: 6 Gerrit-Owner: David Reguera Garcia <dreg(a)rootkit.es> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: David Reguera Garcia <dreg(a)rootkit.es> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit November 2023