Attention is currently required from: Nico Huber, Nikolai Artemiev, Sergii Dmytruk.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68221 )
Change subject: writeprotect.c: differentiate lack of WP from lack of implementation
......................................................................
Patch Set 7:
(2 comments)
File writeprotect.c:
https://review.coreboot.org/c/flashrom/+/68221/comment/b05c8681_2b73ded6
PS7, Line 425: verify_chip_support
`chip_supported()` makes more sense imho.
https://review.coreboot.org/c/flashrom/+/68221/comment/88885bfc_8b8d2929
PS7, Line 427: flash->chip == NULL
`!ptr` is canonical.
--
To view, visit https://review.coreboot.org/c/flashrom/+/68221
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I6e75b124c21ccab51a9b5e1cd344b5310d384187
Gerrit-Change-Number: 68221
Gerrit-PatchSet: 7
Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Comment-Date: Sun, 15 Jan 2023 01:30:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/70603 )
Change subject: flashrom.c: Reduce the prog global state machine
......................................................................
Patch Set 2:
(1 comment)
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/70603/comment/834d955a_16b10c6b
PS1, Line 41: g_programmer_type
> Since this is a bool, I would name this `g_is_internal_programmer`. […]
Well this is ephemeral, I wouldn't wrangle over the perfect name, the `_type` suffix is meant to give disambiguation from the `g_programmer`.
--
To view, visit https://review.coreboot.org/c/flashrom/+/70603
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I93dfe09fe877acd32c4f22665921544ccd9323f6
Gerrit-Change-Number: 70603
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Sun, 15 Jan 2023 01:24:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net>
Gerrit-MessageType: comment
Attention is currently required from: Alexander Goncharov.
eshankelkar(a)galorithm.com has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/71791 )
Change subject: sfdp.c : Initializing hbuf to avoid warnings generated by scan-build
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
> Oops, I wanted to point out CB:62747.
Thank you for directing me there.
--
To view, visit https://review.coreboot.org/c/flashrom/+/71791
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I6815e246b4fd225d1837cae6e7d2aa0236b48b1b
Gerrit-Change-Number: 71791
Gerrit-PatchSet: 5
Gerrit-Owner: eshankelkar(a)galorithm.com
Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-Comment-Date: Sat, 14 Jan 2023 15:15:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Thomas Heijligen, Alexander Goncharov.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68247 )
Change subject: util: add bash completion script
......................................................................
Patch Set 12: Code-Review+1
(3 comments)
File Makefile:
https://review.coreboot.org/c/flashrom/+/68247/comment/1928b585_4e31f096
PS9, Line 1032: $(PROGRAM).8 $(PROGRAM).8.html $(PROGRAM).bash $(BUILD_DETAILS_FILE)
> What do you mean? I just added `$(PROGRAM). […]
It's a continuation of the previous line, hence further indented.
File meson.build:
https://review.coreboot.org/c/flashrom/+/68247/comment/1fc5422a_c0e60fc1
PS9, Line 646: .bash
> No way. […]
Only option I could find is to provide a custom install_script.
File util/flashrom.bash-completion.tmpl:
https://review.coreboot.org/c/flashrom/+/68247/comment/b21f1b96_fc9842b5
PS9, Line 43: OPTS="--help
> It makes no difference for this task. […]
I agree, it shouldn't be necessary. If `compgen` can handle the tabs, it should
also be able to handle other whitespace.
--
To view, visit https://review.coreboot.org/c/flashrom/+/68247
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie68bc91c3cea4de2ffdbeffd07e48edd8d5590e1
Gerrit-Change-Number: 68247
Gerrit-PatchSet: 12
Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-Comment-Date: Sat, 14 Jan 2023 15:14:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net>
Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de>
Comment-In-Reply-To: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-MessageType: comment
Attention is currently required from: eshankelkar(a)galorithm.com.
Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/71791 )
Change subject: sfdp.c : Initializing hbuf to avoid warnings generated by scan-build
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
> Hello! Thank you for the patch. […]
Oops, I wanted to point out CB:62747.
--
To view, visit https://review.coreboot.org/c/flashrom/+/71791
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I6815e246b4fd225d1837cae6e7d2aa0236b48b1b
Gerrit-Change-Number: 71791
Gerrit-PatchSet: 5
Gerrit-Owner: eshankelkar(a)galorithm.com
Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: eshankelkar(a)galorithm.com
Gerrit-Comment-Date: Sat, 14 Jan 2023 15:00:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-MessageType: comment
Attention is currently required from: eshankelkar(a)galorithm.com.
Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/71791 )
Change subject: sfdp.c : Initializing hbuf to avoid warnings generated by scan-build
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
Hello! Thank you for the patch. There's already the one that covers the same topic and a bit more - CB:55269. I don't know why that patch has no progress, but please go through comments on the patch page.
--
To view, visit https://review.coreboot.org/c/flashrom/+/71791
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I6815e246b4fd225d1837cae6e7d2aa0236b48b1b
Gerrit-Change-Number: 71791
Gerrit-PatchSet: 5
Gerrit-Owner: eshankelkar(a)galorithm.com
Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: eshankelkar(a)galorithm.com
Gerrit-Comment-Date: Sat, 14 Jan 2023 14:57:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment