February 2022 - flashrom-gerrit

Change in flashrom[master]: Makefile: Rework the EXEC_SUFFIX determination
by Nico Huber (Code Review) 21 Feb '22

21 Feb '22

Attention is currently required from: Felix Singer, Thomas Heijligen. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62195 ) Change subject: Makefile: Rework the EXEC_SUFFIX determination ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/62195 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iee66dbc609bd5c6eb9d04b457f4508911b2e6560 Gerrit-Change-Number: 62195 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Mon, 21 Feb 2022 14:17:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Makefile: enable internal programmer for x86 and all linux platforms
by Nico Huber (Code Review) 21 Feb '22

21 Feb '22

Nico Huber has submitted this change. ( https://review.coreboot.org/c/flashrom/+/61300 ) Change subject: Makefile: enable internal programmer for x86 and all linux platforms ...................................................................... Makefile: enable internal programmer for x86 and all linux platforms The internal programmer has platform independent code for x86 and linux based code for mipsel. Furthermore the internal programmer can call the linux mtd programmer when available. Enable the internal programmer on x86 or linux. Change-Id: Ia607ea60c3d7d15fe231fa412595992dadc535ad Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/61300 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Nico Huber <nico.h(a)gmx.de> --- M Makefile 1 file changed, 20 insertions(+), 12 deletions(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved diff --git a/Makefile b/Makefile index 7628142..3c5ba43 100644 --- a/Makefile +++ b/Makefile @@ -99,7 +99,7 @@ CONFIG_SERPROG \ DEPENDS_ON_BITBANG_SPI := \ - CONFIG_INTERNAL \ + CONFIG_INTERNAL_X86 \ CONFIG_NICINTEL_SPI \ CONFIG_OGP_SPI \ CONFIG_PONY_SPI \ @@ -109,7 +109,7 @@ CONFIG_ATAPROMISE \ CONFIG_DRKAISER \ CONFIG_GFXNVIDIA \ - CONFIG_INTERNAL \ + CONFIG_INTERNAL_X86 \ CONFIG_IT8212 \ CONFIG_NICINTEL \ CONFIG_NICINTEL_EEPROM \ @@ -119,12 +119,12 @@ CONFIG_SATASII \ DEPENDS_ON_X86_MSR := \ - CONFIG_INTERNAL \ + CONFIG_INTERNAL_X86 \ DEPENDS_ON_X86_PORT_IO := \ CONFIG_ATAHPT \ CONFIG_ATAPROMISE \ - CONFIG_INTERNAL \ + CONFIG_INTERNAL_X86 \ CONFIG_NIC3COM \ CONFIG_NICNATSEMI \ CONFIG_NICREALTEK \ @@ -311,8 +311,8 @@ $(call mark_unsupported,$(DEPENDS_ON_X86_PORT_IO)) endif -# Disable the internal programmer on unsupported architectures (everything but x86 and mipsel) -ifneq ($(ARCH)-little, $(filter $(ARCH), x86 mips)-$(ENDIAN)) +# Disable the internal programmer on unsupported architectures or systems +ifeq ($(or $(filter $(ARCH), x86), $(filter $(TARGET_OS), Linux)), ) $(call mark_unsupported,CONFIG_INTERNAL) endif @@ -417,6 +417,7 @@ # Always enable internal/onboard support for now. CONFIG_INTERNAL ?= yes +CONFIG_INTERNAL_X86 ?= yes # Always enable serprog for now. CONFIG_SERPROG ?= yes @@ -585,18 +586,25 @@ FEATURE_FLAGS += -D'CONFIG_DEFAULT_PROGRAMMER_ARGS="$(CONFIG_DEFAULT_PROGRAMMER_ARGS)"' +################################################################################ + +ifeq ($(ARCH), x86) +ifeq ($(CONFIG_INTERNAL) $(CONFIG_INTERNAL_X86), yes yes) +FEATURE_FLAGS += -D'CONFIG_INTERNAL=1' +PROGRAMMER_OBJS += processor_enable.o chipset_enable.o board_enable.o cbtable.o \ + internal.o it87spi.o it85spi.o sb600spi.o amd_imc.o wbsio_spi.o mcp6x_spi.o \ + ichspi.o dmi.o +endif +else ifeq ($(CONFIG_INTERNAL), yes) FEATURE_FLAGS += -D'CONFIG_INTERNAL=1' PROGRAMMER_OBJS += processor_enable.o chipset_enable.o board_enable.o cbtable.o internal.o -ifeq ($(ARCH), x86) -PROGRAMMER_OBJS += it87spi.o it85spi.o sb600spi.o amd_imc.o wbsio_spi.o mcp6x_spi.o -PROGRAMMER_OBJS += ichspi.o dmi.o +endif +endif + ifeq ($(CONFIG_INTERNAL_DMI), yes) FEATURE_FLAGS += -D'CONFIG_INTERNAL_DMI=1' endif -else -endif -endif ifeq ($(CONFIG_SERPROG), yes) FEATURE_FLAGS += -D'CONFIG_SERPROG=1' -- To view, visit https://review.coreboot.org/c/flashrom/+/61300 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia607ea60c3d7d15fe231fa412595992dadc535ad Gerrit-Change-Number: 61300 Gerrit-PatchSet: 9 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Peter Marheine <pmarheine(a)chromium.org> Gerrit-MessageType: merged

1 0

Change in flashrom[master]: Makefile: enable internal programmer for x86 and all linux platforms
by Nico Huber (Code Review) 21 Feb '22

21 Feb '22

Attention is currently required from: Felix Singer, Thomas Heijligen. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61300 ) Change subject: Makefile: enable internal programmer for x86 and all linux platforms ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/61300 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia607ea60c3d7d15fe231fa412595992dadc535ad Gerrit-Change-Number: 61300 Gerrit-PatchSet: 8 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Mon, 21 Feb 2022 14:15:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Makefile: use HAS_ USE_ pattern for serial support
by Thomas Heijligen (Code Review) 21 Feb '22

21 Feb '22

Attention is currently required from: Felix Singer, Nico Huber. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62196 ) Change subject: Makefile: use HAS_ USE_ pattern for serial support ...................................................................... Patch Set 2: (1 comment) File Makefile: https://review.coreboot.org/c/flashrom/+/62196/comment/98217293_66528bad PS1, Line 795: ,$(DEPENDS_ON_SERIAL)),yes,no) > the `filter_deps` function can't handle spaces yet. All existing calls are like this. Additionally the result of $(if ..., yes, no) need to get stripped. Otherwise the result is " yes" / " no" and not "yes" / "no". The best way would be another function. Something for later. -- To view, visit https://review.coreboot.org/c/flashrom/+/62196 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ica951e76d6362b01f09d23a729a2a6049e7f0b66 Gerrit-Change-Number: 62196 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Mon, 21 Feb 2022 13:27:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Makefile: print version info as part of the config target
by Thomas Heijligen (Code Review) 21 Feb '22

21 Feb '22

Attention is currently required from: Felix Singer, Nico Huber. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62199 ) Change subject: Makefile: print version info as part of the config target ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/62199/comment/c5956d70_2b3fc0e0 PS1, Line 7: versioninfo > add a space there Done -- To view, visit https://review.coreboot.org/c/flashrom/+/62199 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I1a846acfd8d2e0a9fc8b02c078b6ac0342438490 Gerrit-Change-Number: 62199 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Mon, 21 Feb 2022 13:20:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Makefile: use the HAS_ USE_ scheme for linux i2c dependend programmer
by Thomas Heijligen (Code Review) 21 Feb '22

21 Feb '22

Attention is currently required from: Felix Singer, Nico Huber. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62197 ) Change subject: Makefile: use the HAS_ USE_ scheme for linux i2c dependend programmer ...................................................................... Patch Set 2: (1 comment) File Makefile: https://review.coreboot.org/c/flashrom/+/62197/comment/24122beb_6362e0e2 PS1, Line 795: ,$(DEPENDS_ON_LINUX_I2C)),yes,no) > add missing spaces The `filter_deps` function can't handle spaces yet. All existing calls are like this. -- To view, visit https://review.coreboot.org/c/flashrom/+/62197 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I47acdf89a369441b9fc664352c27c43b461545b1 Gerrit-Change-Number: 62197 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Mon, 21 Feb 2022 13:20:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Makefile: use HAS_ USE_ pattern for serial support
by Thomas Heijligen (Code Review) 21 Feb '22

21 Feb '22

Attention is currently required from: Felix Singer, Nico Huber. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62196 ) Change subject: Makefile: use HAS_ USE_ pattern for serial support ...................................................................... Patch Set 2: (1 comment) File Makefile: https://review.coreboot.org/c/flashrom/+/62196/comment/b916e4de_e67b85ac PS1, Line 795: ,$(DEPENDS_ON_SERIAL)),yes,no) > add missing spaces the `filter_deps` function can't handle spaces yet. All existing calls are like this. -- To view, visit https://review.coreboot.org/c/flashrom/+/62196 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ica951e76d6362b01f09d23a729a2a6049e7f0b66 Gerrit-Change-Number: 62196 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Mon, 21 Feb 2022 13:19:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Makefile: Rework the EXEC_SUFFIX determination
by Thomas Heijligen (Code Review) 21 Feb '22

21 Feb '22

Attention is currently required from: Felix Singer, Nico Huber. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62195 ) Change subject: Makefile: Rework the EXEC_SUFFIX determination ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/62195/comment/f5b44fb3_12f55fdb PS1, Line 10: multible > multi_p_le Done -- To view, visit https://review.coreboot.org/c/flashrom/+/62195 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iee66dbc609bd5c6eb9d04b457f4508911b2e6560 Gerrit-Change-Number: 62195 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Mon, 21 Feb 2022 13:17:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Makefile: print version info as part of the config target
by Thomas Heijligen (Code Review) 21 Feb '22

21 Feb '22

Attention is currently required from: Nico Huber, Thomas Heijligen. Hello Felix Singer, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/62199 to look at the new patch set (#2). Change subject: Makefile: print version info as part of the config target ...................................................................... Makefile: print version info as part of the config target Change-Id: I1a846acfd8d2e0a9fc8b02c078b6ac0342438490 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M Makefile 1 file changed, 1 insertion(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/99/62199/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/62199 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I1a846acfd8d2e0a9fc8b02c078b6ac0342438490 Gerrit-Change-Number: 62199 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: Makefile: use the HAS_ USE_ scheme for linux i2c dependend programmer
by Thomas Heijligen (Code Review) 21 Feb '22

21 Feb '22

Attention is currently required from: Nico Huber, Thomas Heijligen. Hello Felix Singer, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/62197 to look at the new patch set (#2). Change subject: Makefile: use the HAS_ USE_ scheme for linux i2c dependend programmer ...................................................................... Makefile: use the HAS_ USE_ scheme for linux i2c dependend programmer Change-Id: I47acdf89a369441b9fc664352c27c43b461545b1 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M Makefile 1 file changed, 7 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/97/62197/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/62197 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I47acdf89a369441b9fc664352c27c43b461545b1 Gerrit-Change-Number: 62197 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newpatchset

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit February 2022