December 2022 - flashrom-gerrit

[S] Change in flashrom[master]: meson: Determine custom_baud source file only once
by Peter Stuge (Code Review) 22 Dec '22

22 Dec '22

Attention is currently required from: Thomas Heijligen. Hello build bot (Jenkins), Thomas Heijligen, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/70568 to look at the new patch set (#4). Change subject: meson: Determine custom_baud source file only once ...................................................................... meson: Determine custom_baud source file only once Change-Id: I13221bdca7d14a483f416e81e3830a495659a85e Signed-off-by: Peter Stuge <peter(a)stuge.se> --- M meson.build 1 file changed, 19 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/68/70568/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/70568 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I13221bdca7d14a483f416e81e3830a495659a85e Gerrit-Change-Number: 70568 Gerrit-PatchSet: 4 Gerrit-Owner: Peter Stuge <peter(a)stuge.se> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: meson: Determine custom_baud source file only once
by Peter Stuge (Code Review) 22 Dec '22

22 Dec '22

Attention is currently required from: Thomas Heijligen. Peter Stuge has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/70568 ) Change subject: meson: Determine custom_baud source file only once ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: Can the first two changes in this series be submitted? -- To view, visit https://review.coreboot.org/c/flashrom/+/70568 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I13221bdca7d14a483f416e81e3830a495659a85e Gerrit-Change-Number: 70568 Gerrit-PatchSet: 3 Gerrit-Owner: Peter Stuge <peter(a)stuge.se> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Thu, 22 Dec 2022 01:18:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in flashrom[master]: ch347_spi.c: Add initial support for the WCH CH347
by Angel Pons (Code Review) 21 Dec '22

21 Dec '22

Attention is currently required from: Thomas Heijligen, qianfan, Anastasia Klimchuk, Nicholas Chin. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/70573 ) Change subject: ch347_spi.c: Add initial support for the WCH CH347 ...................................................................... Patch Set 3: (1 comment) File ch347_spi.c: https://review.coreboot.org/c/flashrom/+/70573/comment/a8fa4cec_54bb3397 PS3, Line 106: uint8_t *buffer = malloc(packet_len); > This isn't freed later. Maybe just use a statically allocated buffer with a fixed size. +1 -- To view, visit https://review.coreboot.org/c/flashrom/+/70573 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I31b86c41076cc45d4a416a73fa1131350fb745ba Gerrit-Change-Number: 70573 Gerrit-PatchSet: 3 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alexander Goncharov <chat(a)joursoir.net> Gerrit-CC: qianfan <qianfanguijin(a)163.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: qianfan <qianfanguijin(a)163.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Wed, 21 Dec 2022 19:57:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-MessageType: comment

1 0

[L] Change in flashrom[master]: ch347_spi.c: Add initial support for the WCH CH347
by Nicholas Chin (Code Review) 21 Dec '22

21 Dec '22

Attention is currently required from: Thomas Heijligen, Angel Pons, qianfan, Anastasia Klimchuk. Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/70573 ) Change subject: ch347_spi.c: Add initial support for the WCH CH347 ...................................................................... Patch Set 3: -Code-Review (2 comments) File ch347_spi.c: https://review.coreboot.org/c/flashrom/+/70573/comment/38767a47_b3a8114d PS3, Line 106: uint8_t *buffer = malloc(packet_len); This isn't freed later. Maybe just use a statically allocated buffer with a fixed size. https://review.coreboot.org/c/flashrom/+/70573/comment/9608c6df_78860b23 PS3, Line 145: malloc(CH347_MAX_DATA_LEN + 3); Same as above -- To view, visit https://review.coreboot.org/c/flashrom/+/70573 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I31b86c41076cc45d4a416a73fa1131350fb745ba Gerrit-Change-Number: 70573 Gerrit-PatchSet: 3 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alexander Goncharov <chat(a)joursoir.net> Gerrit-CC: qianfan <qianfanguijin(a)163.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: qianfan <qianfanguijin(a)163.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Wed, 21 Dec 2022 19:54:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in flashrom[master]: ch347_spi.c: Add initial support for the WCH CH347
by Nicholas Chin (Code Review) 21 Dec '22

21 Dec '22

Attention is currently required from: Thomas Heijligen, Angel Pons, qianfan, Anastasia Klimchuk. Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/70573 ) Change subject: ch347_spi.c: Add initial support for the WCH CH347 ...................................................................... Patch Set 3: (2 comments) File ch347_spi.c: https://review.coreboot.org/c/flashrom/+/70573/comment/fc1405ae_3ad1f03b PS3, Line 69: free(data); > Do you have to free this? `ch341a_spi` does not, but `ft2232_spi` does. Both my code and `ft2232_spi` allocate memory for the data passed around in flashctx, so I would think that memory should be freed later. `ch341a_spi` doesn't free anything because it doesn't pass around data in flashctx and thus there isn't anything to free in the first place. https://review.coreboot.org/c/flashrom/+/70573/comment/ec846349_ebf3cf86 PS3, Line 261: 64 * 1024 > Where does this come from? With the CH347, you can basically read an unlimited amount of bytes with one command. The read command accepts a 32 bit unsigned value representing the number of bytes that requested, and then you just continually issue USB_BULK_IN transfers until it has returned that number of bytes. I just chose some decently large number (it's the same as what the ft2232 chooses), and chose the same value for writes (for writes, you just continually issue write commands with a little over 500 bytes of payload data each until you've sent out all the bits you need) 64k is probably a bit overkill though for writes, as for SPI flash I think the most number of bytes would be a page program, which generally seem to be 256 bytes/page) -- To view, visit https://review.coreboot.org/c/flashrom/+/70573 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I31b86c41076cc45d4a416a73fa1131350fb745ba Gerrit-Change-Number: 70573 Gerrit-PatchSet: 3 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alexander Goncharov <chat(a)joursoir.net> Gerrit-CC: qianfan <qianfanguijin(a)163.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: qianfan <qianfanguijin(a)163.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Wed, 21 Dec 2022 19:08:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[L] Change in flashrom[master]: Add initial CH347T SPI programmer
by Nicholas Chin (Code Review) 21 Dec '22

21 Dec '22

Attention is currently required from: Angel Pons, qianfan. Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/70529 ) Change subject: Add initial CH347T SPI programmer ...................................................................... Patch Set 6: (8 comments) File ch347t_spi.c: https://review.coreboot.org/c/flashrom/+/70529/comment/45ae4f2a_9ec4cb13 PS2, Line 34: CH347_CMD_SPI_CONTROL, > Yes Done File ch347t_spi.c: https://review.coreboot.org/c/flashrom/+/70529/comment/c7f4f0f0_e7738933 PS3, Line 119: SPI_NSS_HARD > OK, I will change it to SPI_NSS_SOFT, as same as the vendor drivers. Done https://review.coreboot.org/c/flashrom/+/70529/comment/df2da099_1b222b41 PS3, Line 330: ch347t_spi_spi_send_command > The two "spi"s are redundant Done https://review.coreboot.org/c/flashrom/+/70529/comment/fa4b5ed6_a962d4f0 PS3, Line 367: libusb_release_interface(handle, 0); : libusb_attach_kernel_driver(handle, 0); > Interface 2, see comment in `ch347t_spi_init` Done https://review.coreboot.org/c/flashrom/+/70529/comment/4fa9ebae_bd022a84 PS3, Line 420: 0 > Got it. I will make a change. Done https://review.coreboot.org/c/flashrom/+/70529/comment/2c08c511_e814bc65 PS3, Line 425: 0 > Interface 2 Done https://review.coreboot.org/c/flashrom/+/70529/comment/8c035452_b111ba34 PS3, Line 442: release_interface: : libusb_release_interface(handle, 0); : close_handle: : libusb_attach_kernel_driver(handle, 0); > Interface 2 Done File ch347t_spi.c: https://review.coreboot.org/c/flashrom/+/70529/comment/1410baf4_05f1659b PS5, Line 169: if (n > CH347_MAX_DATA_WRITE) : n = CH347_MAX_DATA_WRITE; > Oh wait, this is chunking the transfers, right? It's a bit confusing because the chunk size goes thr […] Yes, I believe this code is for splitting up transfers into smaller transfers. I did basically the same thing in my code. Looks like there is a `min()` function in `helpers.c`, which is declared in the `flash.h` header file (which is already included) -- To view, visit https://review.coreboot.org/c/flashrom/+/70529 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6da5e308af76693e60308c8165349128e517e09a Gerrit-Change-Number: 70529 Gerrit-PatchSet: 6 Gerrit-Owner: qianfan <qianfanguijin(a)163.com> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: qianfan <qianfanguijin(a)163.com> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-Comment-Date: Wed, 21 Dec 2022 18:37:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: qianfan <qianfanguijin(a)163.com> Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashrom.c: Plumb 'all_skipped' global state into func param
by Aarya (Code Review) 21 Dec '22

21 Dec '22

Aarya has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/67473 ) Change subject: flashrom.c: Plumb 'all_skipped' global state into func param ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/flashrom/+/67473 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic7990b0afebd49d2a27e89b03638b64e36c329df Gerrit-Change-Number: 67473 Gerrit-PatchSet: 6 Gerrit-Owner: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: abandon

1 0

[M] Change in flashrom[master]: flashrom.c: Add wrapper function to use the erase algorithm
by Aarya (Code Review) 21 Dec '22

21 Dec '22

Attention is currently required from: Simon Buhrow, Nico Huber, Edward O'Callaghan, Aarya, Anastasia Klimchuk. Hello build bot (Jenkins), Simon Buhrow, Thomas Heijligen, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/66104 to look at the new patch set (#90). Change subject: flashrom.c: Add wrapper function to use the erase algorithm ...................................................................... flashrom.c: Add wrapper function to use the erase algorithm Add a function to call the erase algorithm. Change-Id: I29e3f2bd796759794184b125741a5abaac6f3ce8 Signed-off-by: Aarya Chaumal <aarya.chaumal(a)gmail.com> --- M erasure_layout.c M erasure_layout.h 2 files changed, 100 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/04/66104/90 -- To view, visit https://review.coreboot.org/c/flashrom/+/66104 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I29e3f2bd796759794184b125741a5abaac6f3ce8 Gerrit-Change-Number: 66104 Gerrit-PatchSet: 90 Gerrit-Owner: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Simon Buhrow Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Simon Buhrow Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: flashrom.c:Add a function to get list of sectors that need erasing
by Aarya (Code Review) 21 Dec '22

21 Dec '22

Attention is currently required from: Simon Buhrow, Edward O'Callaghan, Aarya. Hello build bot (Jenkins), Simon Buhrow, Thomas Heijligen, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/65844 to look at the new patch set (#72). Change subject: flashrom.c:Add a function to get list of sectors that need erasing ...................................................................... flashrom.c:Add a function to get list of sectors that need erasing Add a function that returns a list of sectors (as seen by the first erase function) that need erasing. Change-Id: Ic57ca1cca3d1646543f6b5939ba9c35db8d08256 Signed-off-by: Aarya Chaumal <aarya.chaumal(a)gmail.com> --- M erasure_layout.c 1 file changed, 48 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/44/65844/72 -- To view, visit https://review.coreboot.org/c/flashrom/+/65844 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic57ca1cca3d1646543f6b5939ba9c35db8d08256 Gerrit-Change-Number: 65844 Gerrit-PatchSet: 72 Gerrit-Owner: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Simon Buhrow Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Simon Buhrow Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: flashrom.c:Add function to align region to sector boundaries
by Aarya (Code Review) 21 Dec '22

21 Dec '22

Attention is currently required from: Edward O'Callaghan, Aarya. Hello build bot (Jenkins), Simon Buhrow, Thomas Heijligen, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/65642 to look at the new patch set (#73). Change subject: flashrom.c:Add function to align region to sector boundaries ...................................................................... flashrom.c:Add function to align region to sector boundaries Add a function to align start and end address of the region (in struct walk_info) to some erase sector boundaries and modify the region start and end addresses to match nearest erase sector boundaries. This function will be used in the new algorithm for erase function selection. Change-Id: I215ea4986aa23360fc65ff761f4e49c6069160ac Signed-off-by: Aarya Chaumal <aarya.chaumal(a)gmail.com> --- M erasure_layout.c 1 file changed, 40 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/42/65642/73 -- To view, visit https://review.coreboot.org/c/flashrom/+/65642 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I215ea4986aa23360fc65ff761f4e49c6069160ac Gerrit-Change-Number: 65642 Gerrit-PatchSet: 73 Gerrit-Owner: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Simon Buhrow Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit December 2022