October 2022 - flashrom-gerrit

[M] Change in flashrom[master]: spi25_statusreg: support reading/writing "configuration registers"
by Edward O'Callaghan (Code Review) 06 Oct '22

06 Oct '22

Attention is currently required from: Angel Pons, Anastasia Klimchuk, Sergii Dmytruk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66211 ) Change subject: spi25_statusreg: support reading/writing "configuration registers" ...................................................................... Patch Set 5: (1 comment) File include/flash.h: https://review.coreboot.org/c/flashrom/+/66211/comment/80af1695_d5217c3a PS5, Line 189: /* For chips that call SR2 "Configuration Register 1" */ : #define CONFIG1 STATUS2 : /* For chips that call SR3 "Configuration Register 2" */ : #define CONFIG2 STATUS3 Is it instead a good idea to add these as new values to the `flash_reg` enum and separately switch on those values if there is semantic difference between `STATUSx` and `CONFIGx`? Seems more robust than short-circuiting though the `STATUSx` pattern match and jamming in another branch there. This keeps the pattern match mapping between register space and opcode as 1:1. -- To view, visit https://review.coreboot.org/c/flashrom/+/66211 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I45f9afcc31f1928ef6263a749596380082963de4 Gerrit-Change-Number: 66211 Gerrit-PatchSet: 5 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Thu, 06 Oct 2022 01:29:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: spi25_statusreg: support reading/writing security register
by Edward O'Callaghan (Code Review) 06 Oct '22

06 Oct '22

Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk, Sergii Dmytruk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59709 ) Change subject: spi25_statusreg: support reading/writing security register ...................................................................... Patch Set 28: Code-Review+2 (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/59709/comment/05c2bf6b_adb77e4b PS28, Line 9: Not to be confused with "secure registers" of OTP. include this remark in the comment above the `FEATURE_SCUR` define? File spi25_statusreg.c: https://review.coreboot.org/c/flashrom/+/59709/comment/fb20025c_84ab83f0 PS28, Line 104: use special commands for modifying it `specialised command used to modifying it` ? -- To view, visit https://review.coreboot.org/c/flashrom/+/59709 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iae1753ca4cb051127a5bcbeba7f064053adb8dae Gerrit-Change-Number: 59709 Gerrit-PatchSet: 28 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Thu, 06 Oct 2022 01:22:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: writeprotect: skip unnecessary writes
by Edward O'Callaghan (Code Review) 06 Oct '22

06 Oct '22

Attention is currently required from: Nico Huber, Sergii Dmytruk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66754 ) Change subject: writeprotect: skip unnecessary writes ...................................................................... Patch Set 1: Code-Review+1 (4 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/66754/comment/f939e2dd_fd9f7ada PS1, Line 7: writeprotect nit: `writeprotect.c:` File writeprotect.c: https://review.coreboot.org/c/flashrom/+/66754/comment/e70cebcb_ac082f6a PS1, Line 158: old `actual` https://review.coreboot.org/c/flashrom/+/66754/comment/bd0e1cd2_131c2db4 PS1, Line 159: new `expected` https://review.coreboot.org/c/flashrom/+/66754/comment/0ad0dc3c_cc9d8fe2 PS1, Line 160: old == new You may reuse the result from line159 one line163, ``` if (actual == expected) continue; value = (value & ~write_masks[reg]) | expected; if (wp_write_register(flash, reg, value)) return FLASHROM_WP_ERR_WRITE_FAILED; } ``` -- To view, visit https://review.coreboot.org/c/flashrom/+/66754 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I81d2d3fc0a103ee00ced78838d77fe33a9d3056a Gerrit-Change-Number: 66754 Gerrit-PatchSet: 1 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Thu, 06 Oct 2022 01:16:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: writeprotect: refuse to work with chip if OTP WPS == 1
by Edward O'Callaghan (Code Review) 06 Oct '22

06 Oct '22

Attention is currently required from: Nico Huber, Sergii Dmytruk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66836 ) Change subject: writeprotect: refuse to work with chip if OTP WPS == 1 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/66836 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I143186066a1d3af89809b7135886cb8b0d038085 Gerrit-Change-Number: 66836 Gerrit-PatchSet: 1 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Thu, 06 Oct 2022 01:16:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: tree/: Convert flashchip decode range func ptr to enum
by Felix Singer (Code Review) 06 Oct '22

06 Oct '22

Attention is currently required from: Nikolai Artemiev. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67195 ) Change subject: tree/: Convert flashchip decode range func ptr to enum ...................................................................... Patch Set 8: Code-Review+1 (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/67195/comment/4bc7d866_3f3962ca PS8, Line 10: to Duplicate "to" https://review.coreboot.org/c/flashrom/+/67195/comment/9d28d916_c9f15816 PS8, Line 12: This follows from on from previous patches that This sounds confusing -- To view, visit https://review.coreboot.org/c/flashrom/+/67195 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If6d08d414d3d1ddadc95ca1d407fc87c23ab543d Gerrit-Change-Number: 67195 Gerrit-PatchSet: 8 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Thu, 06 Oct 2022 01:13:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[1.2.x]: Makefile: Fix dependencies for developerbox_spi
by Felix Singer (Code Review) 06 Oct '22

06 Oct '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/flashrom/+/68064 ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: Makefile: Fix dependencies for developerbox_spi ...................................................................... Makefile: Fix dependencies for developerbox_spi Note: This patch was backported from the master branch and it was modified so that it can be applied on the 1.2.x branch. The developerbox_spi programmer depends on bitbang SPI support. Thus, fix that. Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: Ic0fe589ffdccede0fbf6360c2bebe58a36654f10 Reviewed-on: https://review.coreboot.org/c/flashrom/+/66096 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Thomas Heijligen <src(a)posteo.de> Reviewed-on: https://review.coreboot.org/c/flashrom/+/68064 --- M Makefile 1 file changed, 25 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved diff --git a/Makefile b/Makefile index 52a2f95..0cea6b7 100644 --- a/Makefile +++ b/Makefile @@ -763,12 +763,16 @@ ifeq ($(CONFIG_OGP_SPI), yes) override CONFIG_BITBANG_SPI = yes else +ifeq ($(CONFIG_DEVELOPERBOX_SPI), yes) +override CONFIG_BITBANG_SPI = yes +else CONFIG_BITBANG_SPI ?= no endif endif endif endif endif +endif ############################################################################### # Handle CONFIG_* variables that depend on others set (and verified) above. -- To view, visit https://review.coreboot.org/c/flashrom/+/68064 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.2.x Gerrit-Change-Id: Ic0fe589ffdccede0fbf6360c2bebe58a36654f10 Gerrit-Change-Number: 68064 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in flashrom[1.1.x]: Makefile: Fix dependencies for developerbox_spi
by Felix Singer (Code Review) 06 Oct '22

06 Oct '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/flashrom/+/68011 ) Change subject: Makefile: Fix dependencies for developerbox_spi ...................................................................... Makefile: Fix dependencies for developerbox_spi Note: This patch was backported from the master branch and it was modified so that it can be applied on the 1.1.x branch. The developerbox_spi programmer depends on bitbang SPI support. Thus, fix that. Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: Ic0fe589ffdccede0fbf6360c2bebe58a36654f10 Reviewed-on: https://review.coreboot.org/c/flashrom/+/66096 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Thomas Heijligen <src(a)posteo.de> Reviewed-on: https://review.coreboot.org/c/flashrom/+/68011 --- M Makefile M programmer.h 2 files changed, 26 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved diff --git a/Makefile b/Makefile index e08a3f6..38fc1fc 100644 --- a/Makefile +++ b/Makefile @@ -735,12 +735,16 @@ ifeq ($(CONFIG_OGP_SPI), yes) override CONFIG_BITBANG_SPI = yes else +ifeq ($(CONFIG_DEVELOPERBOX_SPI), yes) +override CONFIG_BITBANG_SPI = yes +else CONFIG_BITBANG_SPI ?= no endif endif endif endif endif +endif ############################################################################### # Handle CONFIG_* variables that depend on others set (and verified) above. diff --git a/programmer.h b/programmer.h index d22bc6b..ef5175d 100644 --- a/programmer.h +++ b/programmer.h @@ -622,7 +622,7 @@ #if CONFIG_DEDIPROG == 1 SPI_CONTROLLER_DEDIPROG, #endif -#if CONFIG_OGP_SPI == 1 || CONFIG_NICINTEL_SPI == 1 || CONFIG_RAYER_SPI == 1 || CONFIG_PONY_SPI == 1 || (CONFIG_INTERNAL == 1 && (defined(__i386__) || defined(__x86_64__))) +#if CONFIG_OGP_SPI == 1 || CONFIG_NICINTEL_SPI == 1 || CONFIG_RAYER_SPI == 1 || CONFIG_PONY_SPI == 1 || CONFIG_DEVELOPERBOX_SPI == 1 || (CONFIG_INTERNAL == 1 && (defined(__i386__) || defined(__x86_64__))) SPI_CONTROLLER_BITBANG, #endif #if CONFIG_LINUX_MTD == 1 -- To view, visit https://review.coreboot.org/c/flashrom/+/68011 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.1.x Gerrit-Change-Id: Ic0fe589ffdccede0fbf6360c2bebe58a36654f10 Gerrit-Change-Number: 68011 Gerrit-PatchSet: 5 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[M] Change in flashrom[1.2.x]: Replace freenode references
by Felix Singer (Code Review) 06 Oct '22

06 Oct '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/flashrom/+/68063 ) Change subject: Replace freenode references ...................................................................... Replace freenode references The flashrom project no longer uses freenode. To avoid having outdated man pages in the future, the contact methods are now listed in the wiki. Change-Id: I75e8f43c50dc4c3feede0250334a877cdaac8103 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/56031 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Nico Huber <nico.h(a)gmx.de> Reviewed-by: Edward O'Callaghan <quasisec(a)chromium.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/68063 --- M README M flashrom.8.tmpl M flashrom.c 3 files changed, 33 insertions(+), 30 deletions(-) Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved diff --git a/README b/README index 4e7bd4f..71e8735 100644 --- a/README +++ b/README @@ -183,10 +183,6 @@ http://www.flashrom.org/ -The IRC channel is +Available contact methods are - #flashrom at irc.freenode.net - -The mailing list address is - - flashrom(a)flashrom.org + https://www.flashrom.org/Contact diff --git a/flashrom.8.tmpl b/flashrom.8.tmpl index 959e5fd..e67cdea 100644 --- a/flashrom.8.tmpl +++ b/flashrom.8.tmpl @@ -1378,24 +1378,13 @@ .B "/etc/rc.securelevel" and rebooting, or rebooting into single user mode. .SH BUGS -Please report any bugs to the -.MTOB "flashrom(a)flashrom.org" "flashrom mailing list" . +You can report bugs, ask us questions or send success reports +via our communication channels listed here: +.URLB "https://www.flashrom.org/Contact" "" . .sp -We recommend to subscribe first at -.URLB "https://flashrom.org/mailman/listinfo/flashrom" "" . -.sp -Many of the developers communicate via the -.B "#flashrom" -IRC channel on -.BR chat.freenode.net . -If you don't have an IRC client, you can use the -.URLB http://webchat.freenode.net/?channels=flashrom "freenode webchat" . -You are welcome to join and ask questions, send us bug and success reports there -too. Please provide a way to contact you later (e.g.\& a mail address) and be -patient if there is no immediate reaction. Also, we provide a +Also, we provide a .URLB https://paste.flashrom.org "pastebin service" -that is very useful when you want to share logs etc.\& without spamming the -channel. +that is very useful to share logs without spamming the communication channels. .SS .B Laptops .sp diff --git a/flashrom.c b/flashrom.c index e540027..61e9530 100644 --- a/flashrom.c +++ b/flashrom.c @@ -1864,16 +1864,16 @@ #if CONFIG_INTERNAL == 1 if (programmer == PROGRAMMER_INTERNAL) msg_gerr("This means we have to add special support for your board, programmer or flash\n" - "chip. Please report this on IRC at chat.freenode.net (channel #flashrom) or\n" - "mail flashrom(a)flashrom.org, thanks!\n" + "chip. Please report this to the mailing list at flashrom(a)flashrom.org or on\n" + "IRC (see https://www.flashrom.org/Contact for details), thanks!\n" "-------------------------------------------------------------------------------\n" "You may now reboot or simply leave the machine running.\n"); else #endif msg_gerr("Please check the connections (especially those to write protection pins) between\n" "the programmer and the flash chip. If you think the error is caused by flashrom\n" - "please report this on IRC at chat.freenode.net (channel #flashrom) or\n" - "mail flashrom(a)flashrom.org, thanks!\n"); + "please report this to the mailing list at flashrom(a)flashrom.org or on IRC (see\n" + "https://www.flashrom.org/Contact for details), thanks!\n"); } static void emergency_help_message(void) @@ -1881,14 +1881,14 @@ msg_gerr("Your flash chip is in an unknown state.\n"); #if CONFIG_INTERNAL == 1 if (programmer == PROGRAMMER_INTERNAL) - msg_gerr("Get help on IRC at chat.freenode.net (channel #flashrom) or\n" - "mail flashrom(a)flashrom.org with the subject \"FAILED: <your board name>\"!\n" + msg_gerr("Get help on IRC (see https://www.flashrom.org/Contact) or mail\n" + "flashrom(a)flashrom.org with the subject \"FAILED: <your board name>\"!" "-------------------------------------------------------------------------------\n" "DO NOT REBOOT OR POWEROFF!\n"); else #endif - msg_gerr("Please report this on IRC at chat.freenode.net (channel #flashrom) or\n" - "mail flashrom(a)flashrom.org, thanks!\n"); + msg_gerr("Please report this to the mailing list at flashrom(a)flashrom.org or\n" + "on IRC (see https://www.flashrom.org/Contact for details), thanks!\n"); } void list_programmers_linebreak(int startcol, int cols, int paren) -- To view, visit https://review.coreboot.org/c/flashrom/+/68063 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.2.x Gerrit-Change-Id: I75e8f43c50dc4c3feede0250334a877cdaac8103 Gerrit-Change-Number: 68063 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in flashrom[1.2.x]: print_wiki.c: Update mailing list reference
by Felix Singer (Code Review) 06 Oct '22

06 Oct '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/flashrom/+/68062 ) Change subject: print_wiki.c: Update mailing list reference ...................................................................... print_wiki.c: Update mailing list reference Change-Id: I5c67b5b3be2f306132d8565539bbf10477222026 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/56030 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Nico Huber <nico.h(a)gmx.de> Reviewed-by: Edward O'Callaghan <quasisec(a)chromium.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/68062 --- M print_wiki.c 1 file changed, 16 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved diff --git a/print_wiki.c b/print_wiki.c index b2ac65c..aecefcc 100644 --- a/print_wiki.c +++ b/print_wiki.c @@ -80,7 +80,7 @@ or may not be added later.\n\n\ Mainboards (or individual revisions) which don't appear in the list may or may \ not work (we don't know, someone has to give it a try). Please report any \ -further verified mainboards on the [[Mailinglist|mailing list]].\n"; +further verified mainboards on the [[Contact#Mailing_List|mailing list]].\n"; #endif static const char chip_th[] = "\ -- To view, visit https://review.coreboot.org/c/flashrom/+/68062 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.2.x Gerrit-Change-Id: I5c67b5b3be2f306132d8565539bbf10477222026 Gerrit-Change-Number: 68062 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[M] Change in flashrom[1.1.x]: Replace freenode references
by Felix Singer (Code Review) 06 Oct '22

06 Oct '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/flashrom/+/68061 ) Change subject: Replace freenode references ...................................................................... Replace freenode references The flashrom project no longer uses freenode. To avoid having outdated man pages in the future, the contact methods are now listed in the wiki. Change-Id: I75e8f43c50dc4c3feede0250334a877cdaac8103 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/56031 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Nico Huber <nico.h(a)gmx.de> Reviewed-by: Edward O'Callaghan <quasisec(a)chromium.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/68061 --- M README M flashrom.8.tmpl M flashrom.c 3 files changed, 33 insertions(+), 30 deletions(-) Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved diff --git a/README b/README index 4e7bd4f..71e8735 100644 --- a/README +++ b/README @@ -183,10 +183,6 @@ http://www.flashrom.org/ -The IRC channel is +Available contact methods are - #flashrom at irc.freenode.net - -The mailing list address is - - flashrom(a)flashrom.org + https://www.flashrom.org/Contact diff --git a/flashrom.8.tmpl b/flashrom.8.tmpl index 5192d0b..df9c79b 100644 --- a/flashrom.8.tmpl +++ b/flashrom.8.tmpl @@ -1277,24 +1277,13 @@ .B "/etc/rc.securelevel" and rebooting, or rebooting into single user mode. .SH BUGS -Please report any bugs to the -.MTOB "flashrom(a)flashrom.org" "flashrom mailing list" . +You can report bugs, ask us questions or send success reports +via our communication channels listed here: +.URLB "https://www.flashrom.org/Contact" "" . .sp -We recommend to subscribe first at -.URLB "https://flashrom.org/mailman/listinfo/flashrom" "" . -.sp -Many of the developers communicate via the -.B "#flashrom" -IRC channel on -.BR chat.freenode.net . -If you don't have an IRC client, you can use the -.URLB http://webchat.freenode.net/?channels=flashrom "freenode webchat" . -You are welcome to join and ask questions, send us bug and success reports there -too. Please provide a way to contact you later (e.g.\& a mail address) and be -patient if there is no immediate reaction. Also, we provide a +Also, we provide a .URLB https://paste.flashrom.org "pastebin service" -that is very useful when you want to share logs etc.\& without spamming the -channel. +that is very useful to share logs without spamming the communication channels. .SS .B Laptops .sp diff --git a/flashrom.c b/flashrom.c index d6c4d24..b7d77c7 100644 --- a/flashrom.c +++ b/flashrom.c @@ -1982,16 +1982,16 @@ #if CONFIG_INTERNAL == 1 if (programmer == PROGRAMMER_INTERNAL) msg_gerr("This means we have to add special support for your board, programmer or flash\n" - "chip. Please report this on IRC at chat.freenode.net (channel #flashrom) or\n" - "mail flashrom(a)flashrom.org, thanks!\n" + "chip. Please report this to the mailing list at flashrom(a)flashrom.org or on\n" + "IRC (see https://www.flashrom.org/Contact for details), thanks!\n" "-------------------------------------------------------------------------------\n" "You may now reboot or simply leave the machine running.\n"); else #endif msg_gerr("Please check the connections (especially those to write protection pins) between\n" "the programmer and the flash chip. If you think the error is caused by flashrom\n" - "please report this on IRC at chat.freenode.net (channel #flashrom) or\n" - "mail flashrom(a)flashrom.org, thanks!\n"); + "please report this to the mailing list at flashrom(a)flashrom.org or on IRC (see\n" + "https://www.flashrom.org/Contact for details), thanks!\n"); } static void emergency_help_message(void) @@ -1999,14 +1999,14 @@ msg_gerr("Your flash chip is in an unknown state.\n"); #if CONFIG_INTERNAL == 1 if (programmer == PROGRAMMER_INTERNAL) - msg_gerr("Get help on IRC at chat.freenode.net (channel #flashrom) or\n" - "mail flashrom(a)flashrom.org with the subject \"FAILED: <your board name>\"!\n" + msg_gerr("Get help on IRC (see https://www.flashrom.org/Contact) or mail\n" + "flashrom(a)flashrom.org with the subject \"FAILED: <your board name>\"!" "-------------------------------------------------------------------------------\n" "DO NOT REBOOT OR POWEROFF!\n"); else #endif - msg_gerr("Please report this on IRC at chat.freenode.net (channel #flashrom) or\n" - "mail flashrom(a)flashrom.org, thanks!\n"); + msg_gerr("Please report this to the mailing list at flashrom(a)flashrom.org or\n" + "on IRC (see https://www.flashrom.org/Contact for details), thanks!\n"); } /* The way to go if you want a delimited list of programmers */ -- To view, visit https://review.coreboot.org/c/flashrom/+/68061 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.1.x Gerrit-Change-Id: I75e8f43c50dc4c3feede0250334a877cdaac8103 Gerrit-Change-Number: 68061 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit October 2022