September 2021 - flashrom-gerrit

Change in flashrom[master]: dediprog.c: Split up compound conditional and swap two operations
by Anastasia Klimchuk (Code Review) 30 Sep '21

30 Sep '21

Attention is currently required from: Nico Huber, Edward O'Callaghan, Anastasia Klimchuk. Anastasia Klimchuk has uploaded a new patch set (#2) to the change originally created by Angel Pons. ( https://review.coreboot.org/c/flashrom/+/51706 ) Change subject: dediprog.c: Split up compound conditional and swap two operations ...................................................................... dediprog.c: Split up compound conditional and swap two operations register_spi_master now becomes the last operation in init function, which is consistent with other spi masters. In addition, the patch fixes propagation of register_spi_master return values, which is also consistent with other spi masters. TEST=ninja test Change-Id: Ib7e0179da39279e32a8497466b044b69ec836da8 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M dediprog.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/06/51706/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/51706 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib7e0179da39279e32a8497466b044b69ec836da8 Gerrit-Change-Number: 51706 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: Add Tiger Lake U Premium support
by Tim Crawford (Code Review) 29 Sep '21

29 Sep '21

Attention is currently required from: Michał Żygowski, Paul Menzel. Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55578 ) Change subject: Add Tiger Lake U Premium support ...................................................................... Patch Set 12: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/55578 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I28f3b6fe9f8ce9e976a6808683f46b6f4ec72bdd Gerrit-Change-Number: 55578 Gerrit-PatchSet: 12 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Wed, 29 Sep 2021 17:52:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips.c: mark EN25F10 as TEST_OK_PREW
by Angel Pons (Code Review) 29 Sep '21

29 Sep '21

Attention is currently required from: Simon Buhrow. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58031 ) Change subject: flashchips.c: mark EN25F10 as TEST_OK_PREW ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/58031 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0c19f84780e7fa3699fd706f8e105fc5937ba8bf Gerrit-Change-Number: 58031 Gerrit-PatchSet: 1 Gerrit-Owner: Simon Buhrow Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Simon Buhrow Gerrit-Comment-Date: Wed, 29 Sep 2021 13:50:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ch341a: use better english in the debug message
by Paul Menzel (Code Review) 29 Sep '21

29 Sep '21

Attention is currently required from: Nico Huber, Thomas Heijligen. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58037 ) Change subject: ch341a: use better english in the debug message ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/58037 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib7f15aa36fedc6af990c3ca45e81547cbfde24a1 Gerrit-Change-Number: 58037 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Wed, 29 Sep 2021 13:38:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: util: Add Nix shell file
by Felix Singer (Code Review) 29 Sep '21

29 Sep '21

Attention is currently required from: Thomas Heijligen, Michael Niewöhner. Hello build bot (Jenkins), Thomas Heijligen, Michael Niewöhner, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/58012 to look at the new patch set (#3). Change subject: util: Add Nix shell file ...................................................................... util: Add Nix shell file Add a Nix shell file which is able to compile flashrom. Change-Id: I9757b952f4b034e98c2b4b70fbede52d8efb9d50 Signed-off-by: Felix Singer <felix.singer(a)secunet.com> --- A util/shell.nix 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/12/58012/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/58012 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9757b952f4b034e98c2b4b70fbede52d8efb9d50 Gerrit-Change-Number: 58012 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: flashchips: Add support for GigaDevice GD25LR256E
by Angel Pons (Code Review) 29 Sep '21

29 Sep '21

Attention is currently required from: Ravishankar Sarawadi, Sukumar Ghorai. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58025 ) Change subject: flashchips: Add support for GigaDevice GD25LR256E ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/58025/comment/4b110c69_080a2a51 PS1, Line 15: Change-Id: I2fe6bc1219cd1ee19b93caabab69de938cfc44b0 Missing a Signed-off-by line File flashchips.c: https://review.coreboot.org/c/flashrom/+/58025/comment/017ec669_dc36e99d PS1, Line 6349: : { : .vendor = "GigaDevice", : .name = "GD25LR256E", : .bustype = BUS_SPI, : .manufacture_id = GIGADEVICE_ID, : .model_id = GIGADEVICE_GD25LR256E, : .total_size = 32768, : .page_size = 256, : .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_4BA_WREN, : .tested = TEST_OK_PREW, : .probe = probe_spi_rdid, : .probe_timing = TIMING_ZERO, : .block_erasers = : { : { : .eraseblocks = { {4 * 1024, 8192} }, : .block_erase = spi_block_erase_21, : }, { : .eraseblocks = { {4 * 1024, 8192} }, : .block_erase = spi_block_erase_20, : }, { : .eraseblocks = { {32 * 1024, 1024} }, : .block_erase = spi_block_erase_5c, : }, { : .eraseblocks = { {32 * 1024, 1024} }, : .block_erase = spi_block_erase_52, : }, { : .eraseblocks = { {64 * 1024, 512} }, : .block_erase = spi_block_erase_dc, : }, { : .eraseblocks = { {64 * 1024, 512} }, : .block_erase = spi_block_erase_d8, : }, { : .eraseblocks = { {32 * 1024 * 1024, 1} }, : .block_erase = spi_block_erase_60, : }, { : .eraseblocks = { {32 * 1024 * 1024, 1} }, : .block_erase = spi_block_erase_c7, : } : }, : .printlock = spi_prettyprint_status_register_bp3_srwd, : .unlock = spi_disable_blockprotect, : .write = spi_chip_write_256, : .read = spi_chip_read, : .voltage = {1600, 2000}, : }, Please indent with tabs -- To view, visit https://review.coreboot.org/c/flashrom/+/58025 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2fe6bc1219cd1ee19b93caabab69de938cfc44b0 Gerrit-Change-Number: 58025 Gerrit-PatchSet: 1 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.corp-partner.google.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Attention: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Comment-Date: Wed, 29 Sep 2021 12:43:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ch341a: use better english in the debug message
by Angel Pons (Code Review) 29 Sep '21

29 Sep '21

Attention is currently required from: Thomas Heijligen. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58037 ) Change subject: ch341a: use better english in the debug message ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: Thanks! -- To view, visit https://review.coreboot.org/c/flashrom/+/58037 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib7f15aa36fedc6af990c3ca45e81547cbfde24a1 Gerrit-Change-Number: 58037 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Wed, 29 Sep 2021 12:39:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ch341a_spi: replace active kernel driver detaching by automatic one
by Thomas Heijligen (Code Review) 29 Sep '21

29 Sep '21

Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57889 ) Change subject: ch341a_spi: replace active kernel driver detaching by automatic one ...................................................................... Patch Set 6: (1 comment) File ch341a_spi.c: https://review.coreboot.org/c/flashrom/+/57889/comment/bf5cbf16_eddec770 PS6, Line 453: of > nit: I'd say omitting `of` sounds more natural You're right, https://review.coreboot.org/c/flashrom/+/58037 -- To view, visit https://review.coreboot.org/c/flashrom/+/57889 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If6f19744503055ab8e22c863b31e696808e0407d Gerrit-Change-Number: 57889 Gerrit-PatchSet: 6 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 29 Sep 2021 12:27:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ch341a: use better english in the debug message
by Thomas Heijligen (Code Review) 29 Sep '21

29 Sep '21

Thomas Heijligen has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/58037 ) Change subject: ch341a: use better english in the debug message ...................................................................... ch341a: use better english in the debug message Change-Id: Ib7f15aa36fedc6af990c3ca45e81547cbfde24a1 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.de> --- M ch341a_spi.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/37/58037/1 diff --git a/ch341a_spi.c b/ch341a_spi.c index 48642f3..bc4112b 100644 --- a/ch341a_spi.c +++ b/ch341a_spi.c @@ -450,7 +450,7 @@ ret = libusb_set_auto_detach_kernel_driver(handle, 1); if (ret != 0) { msg_pwarn("Platform does not support detaching of USB kernel drivers.\n" - "If an unsupported driver is active, claiming of the interface may fail.\n"); + "If an unsupported driver is active, claiming the interface may fail.\n"); } ret = libusb_claim_interface(handle, 0); -- To view, visit https://review.coreboot.org/c/flashrom/+/58037 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib7f15aa36fedc6af990c3ca45e81547cbfde24a1 Gerrit-Change-Number: 58037 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: ch341a_spi: replace active kernel driver detaching by automatic one
by Angel Pons (Code Review) 29 Sep '21

29 Sep '21

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57889 ) Change subject: ch341a_spi: replace active kernel driver detaching by automatic one ...................................................................... Patch Set 6: (1 comment) File ch341a_spi.c: https://review.coreboot.org/c/flashrom/+/57889/comment/3d4ab017_762e45d7 PS6, Line 453: of nit: I'd say omitting `of` sounds more natural -- To view, visit https://review.coreboot.org/c/flashrom/+/57889 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If6f19744503055ab8e22c863b31e696808e0407d Gerrit-Change-Number: 57889 Gerrit-PatchSet: 6 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 29 Sep 2021 12:06:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit September 2021