August 2021 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: internal: Return early from map_flash for >16MiB on x86
by Tim Wawrzynczak (Code Review) 03 Aug '21

03 Aug '21

Attention is currently required from: Nico Huber, Furquan Shaikh, Edward O'Callaghan. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56721 ) Change subject: internal: Return early from map_flash for >16MiB on x86 ...................................................................... Patch Set 1: (1 comment) File flashrom.c: https://review.coreboot.org/c/flashrom/+/56721/comment/d68c1c37_4686a850 PS1, Line 712: programmer_map_flash_region > Thank you for the patch! […] Gotcha, thanks for the pointer 😊 -- To view, visit https://review.coreboot.org/c/flashrom/+/56721 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I60244b6970118dbdfdbb5b8424fc0a8acd9def2e Gerrit-Change-Number: 56721 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Tue, 03 Aug 2021 17:10:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: internal: Return early from map_flash for >16MiB on x86
by Tim Wawrzynczak (Code Review) 03 Aug '21

03 Aug '21

Attention is currently required from: Nico Huber, Furquan Shaikh, Tim Wawrzynczak. Hello build bot (Jenkins), Furquan Shaikh, Edward O'Callaghan, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/56721 to look at the new patch set (#2). Change subject: internal: Return early from map_flash for >16MiB on x86 ...................................................................... internal: Return early from map_flash for >16MiB on x86 In the case of a flash chip bigger than 16 MiB, x86 chipsets are only able to map the topmost 16 MiB of the chip into memory. To access the rest, flashrom can use hardware sequencing, therefore return early from `physmap_common()` in this situation; this avoids messages like the following in Linux kernel logs: [ 57.715654] x86/PAT: flashrom:2805 conflicting memory types fe0000... [ 57.726270] x86/PAT: memtype_reserve failed [mem 0xfe000000-0xffff... BUG=b:185021901 TEST=On a system with a W25Q256.V (32MB), flashrom logs show: $ flashrom -p host -r bios.bin ... Found Winbond flash chip "W25Q256.V" (32768 kB, Programmer-specific) ... Chipset unable to map >16 MiB of flash Reading flash... done. SUCCESS Signed-off-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Change-Id: I60244b6970118dbdfdbb5b8424fc0a8acd9def2e --- M physmap.c 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/21/56721/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/56721 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I60244b6970118dbdfdbb5b8424fc0a8acd9def2e Gerrit-Change-Number: 56721 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: flashrom: Return early from map_flash for >16MiB on x86
by Edward O'Callaghan (Code Review) 03 Aug '21

03 Aug '21

Attention is currently required from: Nico Huber, Furquan Shaikh, Tim Wawrzynczak. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56721 ) Change subject: flashrom: Return early from map_flash for >16MiB on x86 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Don't call map_flash for X86 you mean? or get rid of the call to map_flash here https://review. […] just noticed this comment. I think in the case of sb600spi a mapping is actually needed? -- To view, visit https://review.coreboot.org/c/flashrom/+/56721 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I60244b6970118dbdfdbb5b8424fc0a8acd9def2e Gerrit-Change-Number: 56721 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Tue, 03 Aug 2021 08:44:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashrom: Return early from map_flash for >16MiB on x86
by Edward O'Callaghan (Code Review) 03 Aug '21

03 Aug '21

Attention is currently required from: Nico Huber, Furquan Shaikh, Tim Wawrzynczak. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56721 ) Change subject: flashrom: Return early from map_flash for >16MiB on x86 ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File flashrom.c: https://review.coreboot.org/c/flashrom/+/56721/comment/5faa4126_15d98c56 PS1, Line 712: programmer_map_flash_region Thank you for the patch! Here programmer_map_flash_region() is called and that is hooked here https://github.com/flashrom/flashrom/blob/2376ccf00a805f4744eb830aabdfb7fe8… the general physmap() implementation is implemented here https://github.com/flashrom/flashrom/blob/f41d24823c1703e328fc27588bbcf3c96… . Sine this is platform specific code it probably should be encapsulated within internal.c itself. The flashrom.c implementation is generic dispatch and handling code and so should not really have platform specifics here. In the chromium tree `-p host` simply just aliases `-p internal` https://chromium.googlesource.com/chromiumos/third_party/flashrom/+/refs/he… -- To view, visit https://review.coreboot.org/c/flashrom/+/56721 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I60244b6970118dbdfdbb5b8424fc0a8acd9def2e Gerrit-Change-Number: 56721 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Tue, 03 Aug 2021 08:37:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashrom: Return early from map_flash for >16MiB on x86
by Tim Wawrzynczak (Code Review) 02 Aug '21

02 Aug '21

Attention is currently required from: Nico Huber, Furquan Shaikh, Edward O'Callaghan. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56721 ) Change subject: flashrom: Return early from map_flash for >16MiB on x86 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > IIRC, the call to map_flash() is spurious for most chips (all SPI maybe?), […] Don't call map_flash for X86 you mean? or get rid of the call to map_flash here https://review.coreboot.org/plugins/gitiles/flashrom/+/refs/heads/master/fl… ? -- To view, visit https://review.coreboot.org/c/flashrom/+/56721 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I60244b6970118dbdfdbb5b8424fc0a8acd9def2e Gerrit-Change-Number: 56721 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Mon, 02 Aug 2021 22:21:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ni845x_spi: handle PROGRAMFILES(X86) env var properly
by Angel Pons (Code Review) 02 Aug '21

02 Aug '21

Attention is currently required from: Nico Huber, Miklós Márton. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56636 ) Change subject: ni845x_spi: handle PROGRAMFILES(X86) env var properly ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/56636 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I397619a5038567d649a417ce6b9d8ac9e1c8c67b Gerrit-Change-Number: 56636 Gerrit-PatchSet: 1 Gerrit-Owner: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Comment-Date: Mon, 02 Aug 2021 16:45:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: tests: Add tests to erase a chip
by Anastasia Klimchuk (Code Review) 02 Aug '21

02 Aug '21

Attention is currently required from: Nico Huber, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56501 ) Change subject: tests: Add tests to erase a chip ...................................................................... Patch Set 7: (1 comment) Patchset: PS7: I split initial patch into two, and now you can see that new tests to erase a chip do not add any new mocks! :) -- To view, visit https://review.coreboot.org/c/flashrom/+/56501 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6f74bfe4e02244d24d6c837cc3d551251e7b4898 Gerrit-Change-Number: 56501 Gerrit-PatchSet: 7 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 02 Aug 2021 04:15:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: tests: Split flashrom tests into two executables
by Anastasia Klimchuk (Code Review) 02 Aug '21

02 Aug '21

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/56753 ) Change subject: tests: Split flashrom tests into two executables ...................................................................... tests: Split flashrom tests into two executables The reason for splitting: some tests need to wrap spi_send_command, some other tests (specifically the tests in the next patch in this chain) need a real spi_send_command. Cmocka offers a capability to call __real_spi_send_command to call a real function and bypass the wrap. However, the function in question, spi_send_command, is not called in tests explicitly. There is no clear way to say "for this one test use the wrap, for other tests use real". There is one test file spi25.c which needs spi_send_command to be wrapped, and this test file is extracted into a separate executable in this patch. The rest of existing tests don't care about spi_send_command. However in the next patch new tests are added, and they need spi_send_command real. The approach used here is: use real function unless it is required to mock, so all tests that don't care go into the executable with the real spi_send_command. BUG=b:181803212 TEST=builds and ninja test Change-Id: I22945cce3d0f36adaa8032167a3ef4e54eccb611 Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M tests/meson.build M tests/tests.c M tests/tests.h A tests/wrap_send_tests.c A tests/wrap_send_tests.h 5 files changed, 128 insertions(+), 34 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/53/56753/1 diff --git a/tests/meson.build b/tests/meson.build index 5776862..fb1f438 100644 --- a/tests/meson.build +++ b/tests/meson.build @@ -17,16 +17,30 @@ 'tests.c', 'helpers.c', 'flashrom.c', - 'spi25.c', 'init_shutdown.c', 'layout.c', ] +srcs_wrap_send = [ + 'wrap_send_tests.c', + 'spi25.c', +] + +# These mocks are needed for all executables +shared_mocks = [ + '-Wl,--wrap=test_outb', + '-Wl,--wrap=test_inb', + '-Wl,--wrap=test_outw', + '-Wl,--wrap=test_inw', + '-Wl,--wrap=test_outl', + '-Wl,--wrap=test_inl', +] + mocks = [ + shared_mocks, '-Wl,--wrap=strdup', '-Wl,--wrap=physunmap', '-Wl,--wrap=physmap', - '-Wl,--wrap=spi_send_command', '-Wl,--wrap=sio_write', '-Wl,--wrap=sio_read', '-Wl,--wrap=open', @@ -35,12 +49,6 @@ '-Wl,--wrap=fopen', '-Wl,--wrap=fopen64', '-Wl,--wrap=rget_io_perms', - '-Wl,--wrap=test_outb', - '-Wl,--wrap=test_inb', - '-Wl,--wrap=test_outw', - '-Wl,--wrap=test_inw', - '-Wl,--wrap=test_outl', - '-Wl,--wrap=test_inl', '-Wl,--wrap=usb_dev_get_by_vid_pid_number', '-Wl,--wrap=libusb_set_configuration', '-Wl,--wrap=libusb_claim_interface', @@ -51,6 +59,11 @@ '-Wl,--gc-sections', ] +mocks_wrap_send = [ + shared_mocks, + '-Wl,--wrap=spi_send_command', +] + flashrom_tests = executable('flashrom_unit_tests', srcs, include_directories : root_includes, @@ -65,3 +78,18 @@ dependencies : [cmocka_dep, flashrom_test_dep], ) test('cmocka test flashrom', flashrom_tests) + +flashrom_wrap_send_tests = executable('flashrom_wrap_send_unit_tests', + srcs_wrap_send, + include_directories : root_includes, + c_args : [ + cargs, + '-ffunction-sections', + '-fdata-sections', + # '-DSTANDALONE', + ], + export_dynamic : true, + link_args : mocks_wrap_send, + dependencies : [cmocka_dep, flashrom_test_dep], +) +test('cmocka wrap send test flashrom', flashrom_wrap_send_tests) diff --git a/tests/tests.c b/tests/tests.c index 00c987c..3c40faa 100644 --- a/tests/tests.c +++ b/tests/tests.c @@ -213,20 +213,6 @@ }; ret |= cmocka_run_group_tests_name("flashrom.c tests", flashrom_tests, NULL, NULL); - const struct CMUnitTest spi25_tests[] = { - cmocka_unit_test(spi_write_enable_test_success), - cmocka_unit_test(spi_write_disable_test_success), - cmocka_unit_test(probe_spi_rdid_test_success), - cmocka_unit_test(probe_spi_rdid4_test_success), - cmocka_unit_test(probe_spi_rems_test_success), - cmocka_unit_test(probe_spi_res1_test_success), - cmocka_unit_test(probe_spi_res2_test_success), - cmocka_unit_test(probe_spi_res3_test_success), - cmocka_unit_test(probe_spi_at25f_test_success), - cmocka_unit_test(probe_spi_st95_test_success), /* spi95.c */ - }; - ret |= cmocka_run_group_tests_name("spi25.c tests", spi25_tests, NULL, NULL); - const struct CMUnitTest init_shutdown_tests[] = { cmocka_unit_test(dummy_init_and_shutdown_test_success), cmocka_unit_test(mec1308_init_and_shutdown_test_success), diff --git a/tests/tests.h b/tests/tests.h index 14cfee0..65d3769 100644 --- a/tests/tests.h +++ b/tests/tests.h @@ -28,18 +28,6 @@ /* flashrom.c */ void flashbuses_to_text_test_success(void **state); -/* spi25.c */ -void spi_write_enable_test_success(void **state); -void spi_write_disable_test_success(void **state); -void probe_spi_rdid_test_success(void **state); -void probe_spi_rdid4_test_success(void **state); -void probe_spi_rems_test_success(void **state); -void probe_spi_res1_test_success(void **state); -void probe_spi_res2_test_success(void **state); -void probe_spi_res3_test_success(void **state); -void probe_spi_at25f_test_success(void **state); -void probe_spi_st95_test_success(void **state); /* spi95.c */ - /* init_shutdown.c */ void dummy_init_and_shutdown_test_success(void **state); void mec1308_init_and_shutdown_test_success(void **state); diff --git a/tests/wrap_send_tests.c b/tests/wrap_send_tests.c new file mode 100644 index 0000000..33da308 --- /dev/null +++ b/tests/wrap_send_tests.c @@ -0,0 +1,61 @@ +/* + * This file is part of the flashrom project. + * + * Copyright 2020 Google LLC + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <include/test.h> +#include "wrap_send_tests.h" + +void __wrap_test_outb(unsigned char value, unsigned short port) {} + +unsigned char __wrap_test_inb(unsigned short port) +{ + return 0; +} + +void __wrap_test_outw(unsigned short value, unsigned short port) {} + +unsigned short __wrap_test_inw(unsigned short port) +{ + return 0; +} + +void __wrap_test_outl(unsigned int value, unsigned short port) {} + +unsigned int __wrap_test_inl(unsigned short port) +{ + return 0; +} + +int main(void) +{ + int ret = 0; + + cmocka_set_message_output(CM_OUTPUT_STDOUT); + + const struct CMUnitTest spi25_tests[] = { + cmocka_unit_test(spi_write_enable_test_success), + cmocka_unit_test(spi_write_disable_test_success), + cmocka_unit_test(probe_spi_rdid_test_success), + cmocka_unit_test(probe_spi_rdid4_test_success), + cmocka_unit_test(probe_spi_rems_test_success), + cmocka_unit_test(probe_spi_res1_test_success), + cmocka_unit_test(probe_spi_res2_test_success), + cmocka_unit_test(probe_spi_res3_test_success), + cmocka_unit_test(probe_spi_at25f_test_success), + cmocka_unit_test(probe_spi_st95_test_success), /* spi95.c */ + }; + ret |= cmocka_run_group_tests_name("spi25.c tests", spi25_tests, NULL, NULL); + + return ret; +} diff --git a/tests/wrap_send_tests.h b/tests/wrap_send_tests.h new file mode 100644 index 0000000..69cdeae --- /dev/null +++ b/tests/wrap_send_tests.h @@ -0,0 +1,31 @@ +/* + * This file is part of the flashrom project. + * + * Copyright 2020 Google LLC + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#ifndef WRAP_SEND_TESTS_H +#define WRAP_SEND_TESTS_H + +/* spi25.c */ +void spi_write_enable_test_success(void **state); +void spi_write_disable_test_success(void **state); +void probe_spi_rdid_test_success(void **state); +void probe_spi_rdid4_test_success(void **state); +void probe_spi_rems_test_success(void **state); +void probe_spi_res1_test_success(void **state); +void probe_spi_res2_test_success(void **state); +void probe_spi_res3_test_success(void **state); +void probe_spi_at25f_test_success(void **state); +void probe_spi_st95_test_success(void **state); /* spi95.c */ + +#endif /* WRAP_SEND_TESTS_H */ -- To view, visit https://review.coreboot.org/c/flashrom/+/56753 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I22945cce3d0f36adaa8032167a3ef4e54eccb611 Gerrit-Change-Number: 56753 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: tests: Add tests to erase a chip
by Anastasia Klimchuk (Code Review) 02 Aug '21

02 Aug '21

Attention is currently required from: Nico Huber, Angel Pons. Hello build bot (Jenkins), Nico Huber, Edward O'Callaghan, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/56501 to look at the new patch set (#7). Change subject: tests: Add tests to erase a chip ...................................................................... tests: Add tests to erase a chip Two tests cover the code which performs do_erase operation. First one works with fake chip and dummy programmer. Fake chip has all operations defined, and a buffer to emulate chip memory. Second one uses the chip which is closer to the real one, because read/write/unlock/erase operations are real. The tests takes the advantage of dummyflasher's capability of emulating a W25Q128.V chip. BUG=b:181803212 TEST=builds and ninja test Change-Id: I6f74bfe4e02244d24d6c837cc3d551251e7b4898 Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> --- A tests/chip.c M tests/meson.build M tests/tests.c M tests/tests.h 4 files changed, 237 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/01/56501/7 -- To view, visit https://review.coreboot.org/c/flashrom/+/56501 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6f74bfe4e02244d24d6c837cc3d551251e7b4898 Gerrit-Change-Number: 56501 Gerrit-PatchSet: 7 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: spi_master: Use new API to register shutdown function
by Anastasia Klimchuk (Code Review) 02 Aug '21

02 Aug '21

Attention is currently required from: Nico Huber, Thomas Heijligen, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56103 ) Change subject: spi_master: Use new API to register shutdown function ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: I rebased this, please let me know if there are any other comments that I should do (I am happy to work more on this if needed). I would keep going and do the same with par masters and opaque masters (actually I started already and wrote some tests CB:56470 and CB:56413). Technically pars and opaques are not blocked, but please tell me if there is something I am missing here. Thank you! -- To view, visit https://review.coreboot.org/c/flashrom/+/56103 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib60300f9ddb295a255d5ef3f8da0e07064207140 Gerrit-Change-Number: 56103 Gerrit-PatchSet: 5 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 02 Aug 2021 02:52:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit August 2021