July 2021 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: flashrom.c: Reorder read_by_layout() to avoid forward decl
by Anastasia Klimchuk (Code Review) 15 Jul '21

15 Jul '21

Attention is currently required from: Edward O'Callaghan, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56297 ) Change subject: flashrom.c: Reorder read_by_layout() to avoid forward decl ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/56297 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ifd6c152e3a1d84b59a876997e543127387f24d40 Gerrit-Change-Number: 56297 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 15 Jul 2021 02:18:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashrom.c: Reorder check_block_eraser() to avoid forward decl
by Anastasia Klimchuk (Code Review) 15 Jul '21

15 Jul '21

Attention is currently required from: Edward O'Callaghan, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56296 ) Change subject: flashrom.c: Reorder check_block_eraser() to avoid forward decl ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/56296 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0906a6e581ce5135b58f6acc6339908dfa770a59 Gerrit-Change-Number: 56296 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 15 Jul 2021 02:17:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashrom.c: Reorder read_by_layout() to avoid forward decl
by Edward O'Callaghan (Code Review) 15 Jul '21

15 Jul '21

Attention is currently required from: Angel Pons, Anastasia Klimchuk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56297 ) Change subject: flashrom.c: Reorder read_by_layout() to avoid forward decl ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Is this one similar to previous, can it be tested by comparing binaries before and after? they are the same. -- To view, visit https://review.coreboot.org/c/flashrom/+/56297 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ifd6c152e3a1d84b59a876997e543127387f24d40 Gerrit-Change-Number: 56297 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Thu, 15 Jul 2021 00:32:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashrom.c: Reorder check_block_eraser() to avoid forward decl
by Edward O'Callaghan (Code Review) 15 Jul '21

15 Jul '21

Attention is currently required from: Angel Pons, Anastasia Klimchuk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56296 ) Change subject: flashrom.c: Reorder check_block_eraser() to avoid forward decl ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > Is this the kind of change that can be tested by comparing binaries before and after? they are the same. buildbot is just tripping up on something unrelated. -- To view, visit https://review.coreboot.org/c/flashrom/+/56296 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0906a6e581ce5135b58f6acc6339908dfa770a59 Gerrit-Change-Number: 56296 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Thu, 15 Jul 2021 00:31:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: tests: Wrap strdup to help cmocka recognise memory allocation
by Edward O'Callaghan (Code Review) 15 Jul '21

15 Jul '21

Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56323 ) Change subject: tests: Wrap strdup to help cmocka recognise memory allocation ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/56323 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I56aef6b342752d80995c36ab075b12198fc101d9 Gerrit-Change-Number: 56323 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Thu, 15 Jul 2021 00:30:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: tests: Add layout tests for overlapping regions
by Edward O'Callaghan (Code Review) 15 Jul '21

15 Jul '21

Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56324 ) Change subject: tests: Add layout tests for overlapping regions ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File tests/layout.c: https://review.coreboot.org/c/flashrom/+/56324/comment/009327ee_ce662587 PS1, Line 21: int flashrom_layout_new(struct flashrom_layout **); : int flashrom_layout_add_region(struct flashrom_layout *, size_t start, size_t end, const char *name); : int flashrom_layout_include_region(struct flashrom_layout *, const char *name); : void flashrom_layout_release(struct flashrom_layout *); > This looks a bit awkward, but... The functions are not static in layout.c. […] what about including `libflashrom.h` will that not work? -- To view, visit https://review.coreboot.org/c/flashrom/+/56324 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7aa8dc0c9bc5a22fe5deea757eea1a151b969cea Gerrit-Change-Number: 56324 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-CC: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Thu, 15 Jul 2021 00:29:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: tests: Add layout tests for overlapping regions
by Anastasia Klimchuk (Code Review) 15 Jul '21

15 Jul '21

Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56324 ) Change subject: tests: Add layout tests for overlapping regions ...................................................................... Patch Set 1: (1 comment) File tests/layout.c: https://review.coreboot.org/c/flashrom/+/56324/comment/b8247253_a83cc86d PS1, Line 21: int flashrom_layout_new(struct flashrom_layout **); : int flashrom_layout_add_region(struct flashrom_layout *, size_t start, size_t end, const char *name); : int flashrom_layout_include_region(struct flashrom_layout *, const char *name); : void flashrom_layout_release(struct flashrom_layout *); This looks a bit awkward, but... The functions are not static in layout.c. They are used in flashrom.c and libflashrom.c so I thought, why test can't use them too. -- To view, visit https://review.coreboot.org/c/flashrom/+/56324 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7aa8dc0c9bc5a22fe5deea757eea1a151b969cea Gerrit-Change-Number: 56324 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-CC: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 15 Jul 2021 00:25:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: tests: Add layout tests for overlapping regions
by Anastasia Klimchuk (Code Review) 15 Jul '21

15 Jul '21

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/56324 ) Change subject: tests: Add layout tests for overlapping regions ...................................................................... tests: Add layout tests for overlapping regions There are no tests for layout, it would be great to add some. Also partially inspired by commit 06a89d713951a2e08ef8fb698a7688357baa83d1 and commit c9039fc27916c03e21ba91365d01e6bc49503053 BUG=b:193584590 TEST=ninja test Change-Id: I7aa8dc0c9bc5a22fe5deea757eea1a151b969cea Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> --- A tests/layout.c M tests/meson.build M tests/tests.c M tests/tests.h 4 files changed, 120 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/24/56324/1 diff --git a/tests/layout.c b/tests/layout.c new file mode 100644 index 0000000..96adfd3 --- /dev/null +++ b/tests/layout.c @@ -0,0 +1,107 @@ +/* + * This file is part of the flashrom project. + * + * Copyright 2021 Google LLC + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <include/test.h> +#include <stdio.h> + +#include "layout.h" + +int flashrom_layout_new(struct flashrom_layout **); +int flashrom_layout_add_region(struct flashrom_layout *, size_t start, size_t end, const char *name); +int flashrom_layout_include_region(struct flashrom_layout *, const char *name); +void flashrom_layout_release(struct flashrom_layout *); + +void included_regions_dont_overlap_test_success(void **state) +{ + (void) state; /* unused */ + + printf("Creating layout...\n"); + struct flashrom_layout *layout; + assert_int_equal(0, flashrom_layout_new(&layout)); + printf("done\n"); + + printf("Adding and including first region...\n"); + assert_int_equal(0, flashrom_layout_add_region(layout, 0x00021000, 0x00031000, "first region")); + assert_int_equal(0, flashrom_layout_include_region(layout, "first region")); + printf("done\n"); + + printf("Adding and including second (non-overlapping) region...\n"); + assert_int_equal(0, flashrom_layout_add_region(layout, 0x00031001, 0x0023efc0, "second region")); + assert_int_equal(0, flashrom_layout_include_region(layout, "second region")); + printf("done\n"); + + printf("Asserting included regions do not overlap...\n"); + assert_int_equal(0, included_regions_overlap(layout)); + printf("done\n"); + + printf("Releasing layout...\n"); + flashrom_layout_release(layout); + printf("done\n"); +} + +void included_regions_overlap_test_success(void **state) +{ + (void) state; /* unused */ + + printf("Creating layout...\n"); + struct flashrom_layout *layout; + assert_int_equal(0, flashrom_layout_new(&layout)); + printf("done\n"); + + printf("Adding and including first region...\n"); + assert_int_equal(0, flashrom_layout_add_region(layout, 0x00021000, 0x00031000, "first region")); + assert_int_equal(0, flashrom_layout_include_region(layout, "first region")); + printf("done\n"); + + printf("Adding and including second (overlapping) region...\n"); + assert_int_equal(0, flashrom_layout_add_region(layout, 0x00027100, 0x0023efc0, "second region")); + assert_int_equal(0, flashrom_layout_include_region(layout, "second region")); + printf("done\n"); + + printf("Asserting included regions overlap...\n"); + assert_int_equal(1, included_regions_overlap(layout)); + printf("done\n"); + + printf("Releasing layout...\n"); + flashrom_layout_release(layout); + printf("done\n"); +} + +void region_not_included_overlap_test_success(void **state) +{ + (void) state; /* unused */ + + printf("Creating layout...\n"); + struct flashrom_layout *layout; + assert_int_equal(0, flashrom_layout_new(&layout)); + printf("done\n"); + + printf("Adding and including first region...\n"); + assert_int_equal(0, flashrom_layout_add_region(layout, 0x00021000, 0x00031000, "first region")); + assert_int_equal(0, flashrom_layout_include_region(layout, "first region")); + printf("done\n"); + + printf("Adding second (overlapping) region, not included...\n"); + assert_int_equal(0, flashrom_layout_add_region(layout, 0x00027100, 0x0023efc0, "second region")); + printf("done\n"); + + printf("Asserting included regions do not overlap...\n"); + assert_int_equal(0, included_regions_overlap(layout)); + printf("done\n"); + + printf("Releasing layout...\n"); + flashrom_layout_release(layout); + printf("done\n"); +} diff --git a/tests/meson.build b/tests/meson.build index 1c480f6..b5b3f16 100644 --- a/tests/meson.build +++ b/tests/meson.build @@ -19,6 +19,7 @@ 'flashrom.c', 'spi25.c', 'init_shutdown.c', + 'layout.c', ] mocks = [ diff --git a/tests/tests.c b/tests/tests.c index ad30a7b..5862d71 100644 --- a/tests/tests.c +++ b/tests/tests.c @@ -188,5 +188,12 @@ }; ret |= cmocka_run_group_tests_name("init_shutdown.c tests", init_shutdown_tests, NULL, NULL); + const struct CMUnitTest layout_tests[] = { + cmocka_unit_test(included_regions_dont_overlap_test_success), + cmocka_unit_test(included_regions_overlap_test_success), + cmocka_unit_test(region_not_included_overlap_test_success), + }; + ret |= cmocka_run_group_tests_name("layout.c tests", layout_tests, NULL, NULL); + return ret; } diff --git a/tests/tests.h b/tests/tests.h index da4f4a9..84202e8 100644 --- a/tests/tests.h +++ b/tests/tests.h @@ -46,4 +46,9 @@ void ene_lpc_init_and_shutdown_test_success(void **state); void linux_spi_init_and_shutdown_test_success(void **state); +/* layout.c */ +void included_regions_dont_overlap_test_success(void **state); +void included_regions_overlap_test_success(void **state); +void region_not_included_overlap_test_success(void **state); + #endif /* TESTS_H */ -- To view, visit https://review.coreboot.org/c/flashrom/+/56324 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7aa8dc0c9bc5a22fe5deea757eea1a151b969cea Gerrit-Change-Number: 56324 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: tests: Wrap strdup to help cmocka recognise memory allocation
by Anastasia Klimchuk (Code Review) 15 Jul '21

15 Jul '21

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/56323 ) Change subject: tests: Wrap strdup to help cmocka recognise memory allocation ...................................................................... tests: Wrap strdup to help cmocka recognise memory allocation This is a known issue in cmocka (see https://github.com/clibs/cmocka/issues/17) where cmocka does not recognise memory allocation happening inside strdup, and then later throws an error when the memory is freed. If the issue is fixed at some point, this workaround can be removed. Given that cmocka already overrides malloc, calloc, realloc, free, adding strdup there seems fine. Existing tests now can (and have to) free the memory they allocated by strdup, and this is in the same patch. BUG=b:193584590 TEST=ninja test Change-Id: I56aef6b342752d80995c36ab075b12198fc101d9 Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M tests/init_shutdown.c M tests/meson.build M tests/tests.c 3 files changed, 17 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/23/56323/1 diff --git a/tests/init_shutdown.c b/tests/init_shutdown.c index 48448f8..c1492d2 100644 --- a/tests/init_shutdown.c +++ b/tests/init_shutdown.c @@ -23,13 +23,17 @@ { (void) state; /* unused */ + char *param_dup = strdup(param); + printf("Testing programmer_init for programmer=%s ...\n", prog->name); - assert_int_equal(0, programmer_init(prog, strdup(param))); + assert_int_equal(0, programmer_init(prog, param_dup)); printf("... programmer_init for programmer=%s successful\n", prog->name); printf("Testing programmer_shutdown for programmer=%s ...\n", prog->name); assert_int_equal(0, programmer_shutdown()); printf("... programmer_shutdown for programmer=%s successful\n", prog->name); + + free(param_dup); } void dummy_init_and_shutdown_test_success(void **state) diff --git a/tests/meson.build b/tests/meson.build index 852fd4c..1c480f6 100644 --- a/tests/meson.build +++ b/tests/meson.build @@ -22,6 +22,7 @@ ] mocks = [ + '-Wl,--wrap=strdup', '-Wl,--wrap=physunmap', '-Wl,--wrap=physmap', '-Wl,--wrap=spi_send_command', diff --git a/tests/tests.c b/tests/tests.c index dcbd5af..ad30a7b 100644 --- a/tests/tests.c +++ b/tests/tests.c @@ -18,6 +18,7 @@ #include "tests.h" #include <stdio.h> +#include <string.h> #include <stdint.h> /* redefinitions/wrapping */ @@ -30,6 +31,16 @@ current_io = io; } +char *__wrap_strdup(const char *s) +{ + LOG_ME; + size_t len = strlen(s) + 1; + void *new = malloc(len); + if (new == NULL) + return NULL; + return (char *)memcpy(new, s, len); +} + void __wrap_physunmap(void *virt_addr, size_t len) { LOG_ME; -- To view, visit https://review.coreboot.org/c/flashrom/+/56323 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I56aef6b342752d80995c36ab075b12198fc101d9 Gerrit-Change-Number: 56323 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: flashrom.c: Reorder read_by_layout() to avoid forward decl
by Anastasia Klimchuk (Code Review) 14 Jul '21

14 Jul '21

Attention is currently required from: Edward O'Callaghan, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56297 ) Change subject: flashrom.c: Reorder read_by_layout() to avoid forward decl ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: Is this one similar to previous, can it be tested by comparing binaries before and after? -- To view, visit https://review.coreboot.org/c/flashrom/+/56297 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ifd6c152e3a1d84b59a876997e543127387f24d40 Gerrit-Change-Number: 56297 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 14 Jul 2021 22:49:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit July 2021