May 2021 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: sb600spi.c: Move sb600_spibar into spi data instead of being global
by Edward O'Callaghan (Code Review) 20 May '21

20 May '21

Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54712 ) Change subject: sb600spi.c: Move sb600_spibar into spi data instead of being global ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File sb600spi.c: https://review.coreboot.org/c/flashrom/+/54712/comment/dcbee9ee_d0a9dbcb PS1, Line 610: free(data); > I am not quite sure whether I need to free sb600_data->sb600_spibar here. […] not free'ed as its physical memory but technically it should be unmapped yes although I think everyone leaks it across the tree and its there is about five'ish cases of spibar being a global. -- To view, visit https://review.coreboot.org/c/flashrom/+/54712 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ifaad0f0a2c0e956029d2df18ddcfd092515ca3c0 Gerrit-Change-Number: 54712 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Thu, 20 May 2021 02:21:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: sb600spi.c: Make use of new register_spi_master() API
by Edward O'Callaghan (Code Review) 20 May '21

20 May '21

Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54713 ) Change subject: sb600spi.c: Make use of new register_spi_master() API ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/54713/comment/92f256b6_bce6a140 PS1, Line 13: TEST=builds we have DUT's to test with so probably a good idea to spot check a AMD board. -- To view, visit https://review.coreboot.org/c/flashrom/+/54713 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id555dc5e125309883a816e00afb26d7141fd870d Gerrit-Change-Number: 54713 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Thu, 20 May 2021 02:14:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: sb600spi.c: Move sb600_spibar into spi data instead of being global
by Anastasia Klimchuk (Code Review) 20 May '21

20 May '21

Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54712 ) Change subject: sb600spi.c: Move sb600_spibar into spi data instead of being global ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: I have a message to reviewers, below. Thank you! File sb600spi.c: https://review.coreboot.org/c/flashrom/+/54712/comment/1a8e13df_4f8b9de9 PS1, Line 610: free(data); I am not quite sure whether I need to free sb600_data->sb600_spibar here. I wasn't freed before, and also it is mapped by rphysmap (not allocated). But if it needs to be freed, I would better do this in this patch. -- To view, visit https://review.coreboot.org/c/flashrom/+/54712 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ifaad0f0a2c0e956029d2df18ddcfd092515ca3c0 Gerrit-Change-Number: 54712 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 20 May 2021 02:04:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: sb600spi.c: Drop sb600_ prefix for spi data struct member
by Anastasia Klimchuk (Code Review) 20 May '21

20 May '21

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/54714 ) Change subject: sb600spi.c: Drop sb600_ prefix for spi data struct member ...................................................................... sb600spi.c: Drop sb600_ prefix for spi data struct member The name of the struct already contains sb600spi_ prefix, so prefix doesn't need to be repeated in members name. BUG=b:185191942 TEST=builds Change-Id: I001ae2044453d1bc205fa253ffb773ed993f57f8 Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M sb600spi.c 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/14/54714/1 diff --git a/sb600spi.c b/sb600spi.c index 32071b9..c057947 100644 --- a/sb600spi.c +++ b/sb600spi.c @@ -56,7 +56,7 @@ struct sb600spi_data { struct flashctx *flash; - uint8_t *sb600_spibar; + uint8_t *spibar; }; static int find_smbus_dev_rev(uint16_t vendor, uint16_t device) @@ -207,7 +207,7 @@ unsigned char *readarr) { struct sb600spi_data *sb600_data = flash->mst->spi.data; - uint8_t *sb600_spibar = sb600_data->sb600_spibar; + uint8_t *sb600_spibar = sb600_data->spibar; /* First byte is cmd which can not be sent through the FIFO. */ unsigned char cmd = *writearr++; writecnt--; @@ -295,7 +295,7 @@ unsigned char *readarr) { struct sb600spi_data *sb600_data = flash->mst->spi.data; - uint8_t *sb600_spibar = sb600_data->sb600_spibar; + uint8_t *sb600_spibar = sb600_data->spibar; /* First byte is cmd which can not be sent through the buffer. */ unsigned char cmd = *writearr++; writecnt--; @@ -784,7 +784,7 @@ } data->flash = NULL; - data->sb600_spibar = sb600_spibar; + data->spibar = sb600_spibar; register_shutdown(sb600spi_shutdown, data); -- To view, visit https://review.coreboot.org/c/flashrom/+/54714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I001ae2044453d1bc205fa253ffb773ed993f57f8 Gerrit-Change-Number: 54714 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: sb600spi.c: Make use of new register_spi_master() API
by Anastasia Klimchuk (Code Review) 20 May '21

20 May '21

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/54713 ) Change subject: sb600spi.c: Make use of new register_spi_master() API ...................................................................... sb600spi.c: Make use of new register_spi_master() API Pass pointers to dynamically allocated data to register_spi_master(). This way we can avoid mutable globals. BUG=b:185191942 TEST=builds Change-Id: Id555dc5e125309883a816e00afb26d7141fd870d Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M sb600spi.c 1 file changed, 6 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/13/54713/1 diff --git a/sb600spi.c b/sb600spi.c index 80ff0eb..32071b9 100644 --- a/sb600spi.c +++ b/sb600spi.c @@ -570,7 +570,7 @@ return 0; } -static struct spi_master spi_master_sb600 = { +static const struct spi_master spi_master_sb600 = { .max_data_read = FIFO_SIZE_OLD, .max_data_write = FIFO_SIZE_OLD - 3, .command = sb600_spi_send_command, @@ -580,7 +580,7 @@ .write_aai = default_spi_write_aai, }; -static struct spi_master spi_master_yangtze = { +static const struct spi_master spi_master_yangtze = { .max_data_read = FIFO_SIZE_YANGTZE - 3, /* Apparently the big SPI 100 buffer is not a ring buffer. */ .max_data_write = FIFO_SIZE_YANGTZE - 3, .command = spi100_spi_send_command, @@ -590,7 +590,7 @@ .write_aai = default_spi_write_aai, }; -static struct spi_master spi_master_promontory = { +static const struct spi_master spi_master_promontory = { .max_data_read = MAX_DATA_READ_UNLIMITED, .max_data_write = FIFO_SIZE_YANGTZE - 3, .command = spi100_spi_send_command, @@ -787,18 +787,14 @@ data->sb600_spibar = sb600_spibar; register_shutdown(sb600spi_shutdown, data); - spi_master_sb600.data = data; - spi_master_yangtze.data = data; - spi_master_promontory.data = data; - /* Starting with Yangtze the SPI controller got a different interface with a much bigger buffer. */ if (amd_gen < CHIPSET_YANGTZE) - register_spi_master(&spi_master_sb600, NULL); + register_spi_master(&spi_master_sb600, data); else if (amd_gen == CHIPSET_YANGTZE) - register_spi_master(&spi_master_yangtze, NULL); + register_spi_master(&spi_master_yangtze, data); else - register_spi_master(&spi_master_promontory, NULL); + register_spi_master(&spi_master_promontory, data); return 0; } -- To view, visit https://review.coreboot.org/c/flashrom/+/54713 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id555dc5e125309883a816e00afb26d7141fd870d Gerrit-Change-Number: 54713 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: sb600spi.c: Move sb600_spibar into spi data instead of being global
by Anastasia Klimchuk (Code Review) 20 May '21

20 May '21

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/54712 ) Change subject: sb600spi.c: Move sb600_spibar into spi data instead of being global ...................................................................... sb600spi.c: Move sb600_spibar into spi data instead of being global This driver already has sb600spi_data struct, and sb600_spibar can be its member instead of being a global variable. BUG=b:185191942 TEST=builds Change-Id: Ifaad0f0a2c0e956029d2df18ddcfd092515ca3c0 Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M sb600spi.c 1 file changed, 28 insertions(+), 20 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/12/54712/1 diff --git a/sb600spi.c b/sb600spi.c index 43bf407..80ff0eb 100644 --- a/sb600spi.c +++ b/sb600spi.c @@ -40,7 +40,6 @@ *}; */ -static uint8_t *sb600_spibar = NULL; enum amd_chipset { CHIPSET_AMD_UNKNOWN, CHIPSET_SB6XX, @@ -57,6 +56,7 @@ struct sb600spi_data { struct flashctx *flash; + uint8_t *sb600_spibar; }; static int find_smbus_dev_rev(uint16_t vendor, uint16_t device) @@ -149,7 +149,7 @@ return CHIPSET_AMD_UNKNOWN; } -static void reset_internal_fifo_pointer(void) +static void reset_internal_fifo_pointer(uint8_t *sb600_spibar) { mmio_writeb(mmio_readb(sb600_spibar + 2) | 0x10, sb600_spibar + 2); @@ -158,7 +158,7 @@ msg_pspew("reset\n"); } -static int compare_internal_fifo_pointer(uint8_t want) +static int compare_internal_fifo_pointer(uint8_t want, uint8_t *sb600_spibar) { uint8_t have = mmio_readb(sb600_spibar + 0xd) & 0x07; want %= FIFO_SIZE_OLD; @@ -192,7 +192,7 @@ return 0; } -static void execute_command(void) +static void execute_command(uint8_t *sb600_spibar) { msg_pspew("Executing... "); mmio_writeb(mmio_readb(sb600_spibar + 2) | 1, sb600_spibar + 2); @@ -206,6 +206,8 @@ const unsigned char *writearr, unsigned char *readarr) { + struct sb600spi_data *sb600_data = flash->mst->spi.data; + uint8_t *sb600_spibar = sb600_data->sb600_spibar; /* First byte is cmd which can not be sent through the FIFO. */ unsigned char cmd = *writearr++; writecnt--; @@ -226,7 +228,7 @@ uint8_t readwrite = (readcnt + readoffby1) << 4 | (writecnt); mmio_writeb(readwrite, sb600_spibar + 1); - reset_internal_fifo_pointer(); + reset_internal_fifo_pointer(sb600_spibar); msg_pspew("Filling FIFO: "); unsigned int count; for (count = 0; count < writecnt; count++) { @@ -234,16 +236,16 @@ mmio_writeb(writearr[count], sb600_spibar + 0xC); } msg_pspew("\n"); - if (compare_internal_fifo_pointer(writecnt)) + if (compare_internal_fifo_pointer(writecnt, sb600_spibar)) return SPI_PROGRAMMER_ERROR; /* * We should send the data in sequence, which means we need to reset * the FIFO pointer to the first byte we want to send. */ - reset_internal_fifo_pointer(); - execute_command(); - if (compare_internal_fifo_pointer(writecnt + readcnt)) + reset_internal_fifo_pointer(sb600_spibar); + execute_command(sb600_spibar); + if (compare_internal_fifo_pointer(writecnt + readcnt, sb600_spibar)) return SPI_PROGRAMMER_ERROR; /* @@ -257,7 +259,7 @@ * the opcode, the FIFO already stores the response from the chip. * Usually, the chip will respond with 0x00 or 0xff. */ - reset_internal_fifo_pointer(); + reset_internal_fifo_pointer(sb600_spibar); /* Skip the bytes we sent. */ msg_pspew("Skipping: "); @@ -265,7 +267,7 @@ msg_pspew("[%02x]", mmio_readb(sb600_spibar + 0xC)); } msg_pspew("\n"); - if (compare_internal_fifo_pointer(writecnt)) + if (compare_internal_fifo_pointer(writecnt, sb600_spibar)) return SPI_PROGRAMMER_ERROR; msg_pspew("Reading FIFO: "); @@ -274,7 +276,7 @@ msg_pspew("[%02x]", readarr[count]); } msg_pspew("\n"); - if (compare_internal_fifo_pointer(writecnt+readcnt)) + if (compare_internal_fifo_pointer(writecnt+readcnt, sb600_spibar)) return SPI_PROGRAMMER_ERROR; if (mmio_readb(sb600_spibar + 1) != readwrite) { @@ -292,6 +294,8 @@ const unsigned char *writearr, unsigned char *readarr) { + struct sb600spi_data *sb600_data = flash->mst->spi.data; + uint8_t *sb600_spibar = sb600_data->sb600_spibar; /* First byte is cmd which can not be sent through the buffer. */ unsigned char cmd = *writearr++; writecnt--; @@ -314,7 +318,7 @@ } msg_pspew("\n"); - execute_command(); + execute_command(sb600_spibar); msg_pspew("Reading buffer: "); for (count = 0; count < readcnt; count++) { @@ -353,7 +357,7 @@ "Fast Read", }; -static int set_speed(struct pci_dev *dev, enum amd_chipset amd_gen, uint8_t speed) +static int set_speed(struct pci_dev *dev, enum amd_chipset amd_gen, uint8_t speed, uint8_t *sb600_spibar) { bool success = false; @@ -376,7 +380,7 @@ return 0; } -static int set_mode(struct pci_dev *dev, uint8_t mode) +static int set_mode(struct pci_dev *dev, uint8_t mode, uint8_t *sb600_spibar) { msg_pdbg("Setting SPI read mode to %s (%i)... ", spireadmodes[mode], mode); uint32_t tmp = mmio_readl(sb600_spibar + 0x00); @@ -391,7 +395,7 @@ return 0; } -static int handle_speed(struct pci_dev *dev, enum amd_chipset amd_gen) +static int handle_speed(struct pci_dev *dev, enum amd_chipset amd_gen, uint8_t *sb600_spibar) { uint32_t tmp; int16_t spispeed_idx = -1; @@ -459,7 +463,7 @@ msg_perr("Warning: spireadmode not set, " "leaving spireadmode unchanged."); } - else if (set_mode(dev, spireadmode_idx) != 0) { + else if (set_mode(dev, spireadmode_idx, sb600_spibar) != 0) { return 1; } @@ -502,7 +506,7 @@ msg_perr("Warning: spispeed not set, leaving spispeed unchanged."); return 0; } - return set_speed(dev, amd_gen, spispeed_idx); + return set_speed(dev, amd_gen, spispeed_idx, sb600_spibar); } static int handle_imc(struct pci_dev *dev, enum amd_chipset amd_gen) @@ -598,9 +602,11 @@ static int sb600spi_shutdown(void *data) { - struct flashctx *flash = ((struct sb600spi_data *)data)->flash; + struct sb600spi_data *sb600_data = data; + struct flashctx *flash = sb600_data->flash; if (flash) finalize_flash_access(flash); + free(data); return 0; } @@ -610,6 +616,7 @@ struct pci_dev *smbus_dev; uint32_t tmp; uint8_t reg; + uint8_t *sb600_spibar = NULL; /* Read SPI_BaseAddr */ tmp = pci_read_long(dev, 0xa0); @@ -764,7 +771,7 @@ return 0; } - if (handle_speed(dev, amd_gen) != 0) + if (handle_speed(dev, amd_gen, sb600_spibar) != 0) return ERROR_FATAL; if (handle_imc(dev, amd_gen) != 0) @@ -777,6 +784,7 @@ } data->flash = NULL; + data->sb600_spibar = sb600_spibar; register_shutdown(sb600spi_shutdown, data); spi_master_sb600.data = data; -- To view, visit https://review.coreboot.org/c/flashrom/+/54712 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ifaad0f0a2c0e956029d2df18ddcfd092515ca3c0 Gerrit-Change-Number: 54712 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: dummyflasher.c: Use BUS_NONSPI where appropriate
by Edward O'Callaghan (Code Review) 19 May '21

19 May '21

Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/flashrom/+/54356 ) Change subject: dummyflasher.c: Use BUS_NONSPI where appropriate ...................................................................... dummyflasher.c: Use BUS_NONSPI where appropriate The BUS_NONSPI is short-hand and is intended to be the collection, therefore use it. BUG=none BRANCH=none TEST=builds Change-Id: I368e8865c446d9b9ffd580c90eac034850dd53d8 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/54356 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> Reviewed-by: Sam McNally <sammc(a)google.com> --- M dummyflasher.c 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: build bot (Jenkins): Verified Sam McNally: Looks good to me, approved Anastasia Klimchuk: Looks good to me, but someone else must approve diff --git a/dummyflasher.c b/dummyflasher.c index d434eec..e19e46c 100644 --- a/dummyflasher.c +++ b/dummyflasher.c @@ -175,7 +175,7 @@ static struct emu_data* get_data_from_context(const struct flashctx *flash) { - if (dummy_buses_supported & (BUS_PARALLEL | BUS_LPC | BUS_FWH)) + if (dummy_buses_supported & BUS_NONSPI) return (struct emu_data *)flash->mst->par.data; else if (dummy_buses_supported & BUS_SPI) return (struct emu_data *)flash->mst->spi.data; @@ -1025,9 +1025,9 @@ free(data); return 1; } - if (dummy_buses_supported & (BUS_PARALLEL | BUS_LPC | BUS_FWH)) + if (dummy_buses_supported & BUS_NONSPI) register_par_master(&par_master_dummy, - dummy_buses_supported & (BUS_PARALLEL | BUS_LPC | BUS_FWH)); + dummy_buses_supported & BUS_NONSPI); if (dummy_buses_supported & BUS_SPI) register_spi_master(&spi_master_dummyflasher, data); -- To view, visit https://review.coreboot.org/c/flashrom/+/54356 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I368e8865c446d9b9ffd580c90eac034850dd53d8 Gerrit-Change-Number: 54356 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Sam McNally <sammc(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in flashrom[master]: stlinkv3_spi.c: Drop stlinkv3_ prefix for spi data struct member
by Miklós Márton (Code Review) 19 May '21

19 May '21

Attention is currently required from: Nico Huber, Anastasia Klimchuk. Miklós Márton has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54043 ) Change subject: stlinkv3_spi.c: Drop stlinkv3_ prefix for spi data struct member ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: LGTM -- To view, visit https://review.coreboot.org/c/flashrom/+/54043 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ibddac9371ab8f08276d499642a9bdd6dbecea0ca Gerrit-Change-Number: 54043 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Wed, 19 May 2021 14:11:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: stlinkv3_spi.c: Refactor singleton states into reentrant pattern
by Miklós Márton (Code Review) 19 May '21

19 May '21

Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk. Miklós Márton has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54042 ) Change subject: stlinkv3_spi.c: Refactor singleton states into reentrant pattern ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: LGTM -- To view, visit https://review.coreboot.org/c/flashrom/+/54042 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id044661b864b506028720ea809bc524f0640469f Gerrit-Change-Number: 54042 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Wed, 19 May 2021 14:11:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: stlinkv3_spi.c: Drop stlinkv3_ prefix for spi data struct member
by Edward O'Callaghan (Code Review) 19 May '21

19 May '21

Attention is currently required from: Nico Huber, Anastasia Klimchuk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54043 ) Change subject: stlinkv3_spi.c: Drop stlinkv3_ prefix for spi data struct member ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/54043 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ibddac9371ab8f08276d499642a9bdd6dbecea0ca Gerrit-Change-Number: 54043 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Wed, 19 May 2021 05:10:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit May 2021