March 2021 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: test_build.sh: use sh from env
by Angel Pons (Code Review) 31 Mar '21

31 Mar '21

Attention is currently required from: Nico Huber, Paul Menzel, Thomas Heijligen. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51978 ) Change subject: test_build.sh: use sh from env ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I think there are pros and cons for this pattern. Which ones? I'm curious. If I were an English teacher, I'd ask you to write a for-and-against essay. 😜 But since I'm not, a brief explanation is more than enough 😊 -- To view, visit https://review.coreboot.org/c/flashrom/+/51978 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3897b8d980425ecbb89b238d4a766f628cf9d3e6 Gerrit-Change-Number: 51978 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Wed, 31 Mar 2021 12:44:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: test_build.sh: use sh from env
by Paul Menzel (Code Review) 31 Mar '21

31 Mar '21

Attention is currently required from: Nico Huber, Thomas Heijligen. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51978 ) Change subject: test_build.sh: use sh from env ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I think there are pros and cons for this pattern. -- To view, visit https://review.coreboot.org/c/flashrom/+/51978 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3897b8d980425ecbb89b238d4a766f628cf9d3e6 Gerrit-Change-Number: 51978 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Wed, 31 Mar 2021 12:35:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: test_build.sh: use sh from env
by Paul Menzel (Code Review) 31 Mar '21

31 Mar '21

Attention is currently required from: Nico Huber, Thomas Heijligen. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51978 ) Change subject: test_build.sh: use sh from env ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/51978 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3897b8d980425ecbb89b238d4a766f628cf9d3e6 Gerrit-Change-Number: 51978 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Wed, 31 Mar 2021 12:35:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: test_build.sh: use -C option of ninja
by Paul Menzel (Code Review) 31 Mar '21

31 Mar '21

Attention is currently required from: Nico Huber, Thomas Heijligen, Angel Pons. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51979 ) Change subject: test_build.sh: use -C option of ninja ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/51979/comment/3fe3b02a_559e49a9 PS2, Line 7: test_build.sh: use -C option of ninja … to specify the build directory -- To view, visit https://review.coreboot.org/c/flashrom/+/51979 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I04a0fdf9b5126b9f4006e8229c3926ceb1013456 Gerrit-Change-Number: 51979 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 31 Mar 2021 12:35:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: test_build.sh: use -C option of ninja
by Thomas Heijligen (Code Review) 31 Mar '21

31 Mar '21

Attention is currently required from: Nico Huber, Angel Pons. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51979 ) Change subject: test_build.sh: use -C option of ninja ...................................................................... Patch Set 2: (1 comment) File test_build.sh: https://review.coreboot.org/c/flashrom/+/51979/comment/15906a39_9f4c7e0f PS1, Line 4: #make CONFIG_EVERYTHING=yes WARNERROR=yes > Did you mean to comment this line out? No, that was a mistake. I've not all dependencies for the make build available and commend it out for testing the meson part -- To view, visit https://review.coreboot.org/c/flashrom/+/51979 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I04a0fdf9b5126b9f4006e8229c3926ceb1013456 Gerrit-Change-Number: 51979 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 31 Mar 2021 11:45:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: test_build.sh: use -C option of ninja
by Thomas Heijligen (Code Review) 31 Mar '21

31 Mar '21

Attention is currently required from: Nico Huber, Thomas Heijligen. Hello build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/51979 to look at the new patch set (#2). Change subject: test_build.sh: use -C option of ninja ...................................................................... test_build.sh: use -C option of ninja Change-Id: I04a0fdf9b5126b9f4006e8229c3926ceb1013456 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.de> --- M test_build.sh 1 file changed, 5 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/79/51979/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/51979 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I04a0fdf9b5126b9f4006e8229c3926ceb1013456 Gerrit-Change-Number: 51979 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: test_build.sh: use -C option of ninja
by Angel Pons (Code Review) 31 Mar '21

31 Mar '21

Attention is currently required from: Nico Huber, Thomas Heijligen. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51979 ) Change subject: test_build.sh: use -C option of ninja ...................................................................... Patch Set 1: (1 comment) File test_build.sh: https://review.coreboot.org/c/flashrom/+/51979/comment/d65d63ed_dfe9ff0a PS1, Line 4: #make CONFIG_EVERYTHING=yes WARNERROR=yes Did you mean to comment this line out? -- To view, visit https://review.coreboot.org/c/flashrom/+/51979 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I04a0fdf9b5126b9f4006e8229c3926ceb1013456 Gerrit-Change-Number: 51979 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Wed, 31 Mar 2021 11:39:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: test_build.sh: use sh from env
by Angel Pons (Code Review) 31 Mar '21

31 Mar '21

Attention is currently required from: Nico Huber, Thomas Heijligen. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51978 ) Change subject: test_build.sh: use sh from env ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/51978 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3897b8d980425ecbb89b238d4a766f628cf9d3e6 Gerrit-Change-Number: 51978 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Wed, 31 Mar 2021 11:38:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: test_build.sh: use -C option of ninja
by Thomas Heijligen (Code Review) 31 Mar '21

31 Mar '21

Thomas Heijligen has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/51979 ) Change subject: test_build.sh: use -C option of ninja ...................................................................... test_build.sh: use -C option of ninja Change-Id: I04a0fdf9b5126b9f4006e8229c3926ceb1013456 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.de> --- M test_build.sh 1 file changed, 6 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/79/51979/1 diff --git a/test_build.sh b/test_build.sh index 8f11ccd..604b12d 100755 --- a/test_build.sh +++ b/test_build.sh @@ -1,8 +1,10 @@ #!/usr/bin/env sh set -e -make CONFIG_EVERYTHING=yes WARNERROR=yes +#make CONFIG_EVERYTHING=yes WARNERROR=yes -meson out -(cd out && ninja) -(cd out && ninja test) + +builddir=out +meson $builddir +ninja -C $builddir +ninja -C $builddir test -- To view, visit https://review.coreboot.org/c/flashrom/+/51979 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I04a0fdf9b5126b9f4006e8229c3926ceb1013456 Gerrit-Change-Number: 51979 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: test_build.sh: use sh from env
by Thomas Heijligen (Code Review) 31 Mar '21

31 Mar '21

Thomas Heijligen has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/51978 ) Change subject: test_build.sh: use sh from env ...................................................................... test_build.sh: use sh from env Change-Id: I3897b8d980425ecbb89b238d4a766f628cf9d3e6 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.de> --- M test_build.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/78/51978/1 diff --git a/test_build.sh b/test_build.sh index 0e43cd3..8f11ccd 100755 --- a/test_build.sh +++ b/test_build.sh @@ -1,4 +1,4 @@ -#!/bin/sh +#!/usr/bin/env sh set -e make CONFIG_EVERYTHING=yes WARNERROR=yes -- To view, visit https://review.coreboot.org/c/flashrom/+/51978 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3897b8d980425ecbb89b238d4a766f628cf9d3e6 Gerrit-Change-Number: 51978 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newchange

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit March 2021