March 2021 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: flashchips: Add AT25DF011
by Hanno Heinrichs (Code Review) March 18, 2021

March 18, 2021

Attention is currently required from: Hanno Heinrichs. Hello build bot (Jenkins), Nikolai Artemiev, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/51048 to look at the new patch set (#3). Change subject: flashchips: Add AT25DF011 ...................................................................... flashchips: Add AT25DF011 Tested read/write/erase/probe operations with a ch341a_spi programmer. Signed-off-by: Hanno Heinrichs <hanno.heinrichs(a)rwth-aachen.de> Change-Id: I5a2141f1380e864c843d6a3008fdb02dc1b75131 --- M flashchips.c M flashchips.h 2 files changed, 40 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/48/51048/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/51048 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5a2141f1380e864c843d6a3008fdb02dc1b75131 Gerrit-Change-Number: 51048 Gerrit-PatchSet: 3 Gerrit-Owner: Hanno Heinrichs <hanno.heinrichs(a)rwth-aachen.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Hanno Heinrichs <hanno.heinrichs(a)rwth-aachen.de> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: flashrom.c: automatic generated programmer_enum.h
by Xiang Wang (Code Review) March 18, 2021

March 18, 2021

Attention is currently required from: Sam McNally, Nico Huber, Stefan Reinauer. Hello Sam McNally, build bot (Jenkins), Nico Huber, Stefan Reinauer, Edward O'Callaghan, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/49599 to look at the new patch set (#6). Change subject: flashrom.c: automatic generated programmer_enum.h ...................................................................... flashrom.c: automatic generated programmer_enum.h programmer_table and enum programmer need to keep the same order, which is error-prone. This patch is used to automatically generate enum programmer. Change-Id: I3f4370ccae2b64da3c4178243b192700d3d205d2 Signed-off-by: Xiang Wang <merle(a)hardenedliux.org> --- M .gitignore M Makefile M flashrom.c M meson.build M programmer.h A programmer_table.h A util/generator_programmer_enum.sh 7 files changed, 550 insertions(+), 598 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/99/49599/6 -- To view, visit https://review.coreboot.org/c/flashrom/+/49599 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3f4370ccae2b64da3c4178243b192700d3d205d2 Gerrit-Change-Number: 49599 Gerrit-PatchSet: 6 Gerrit-Owner: Xiang Wang <merle(a)hardenedlinux.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Sam McNally <sammc(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Idwer Vollering <vidwer(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-CC: Shawn C <citypw(a)hardenedlinux.org> Gerrit-Attention: Sam McNally <sammc(a)google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: flashrom.c: automatic generated programmer_enum.h
by Xiang Wang (Code Review) March 18, 2021

March 18, 2021

Attention is currently required from: Sam McNally, Nico Huber, Stefan Reinauer. Xiang Wang has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49599 ) Change subject: flashrom.c: automatic generated programmer_enum.h ...................................................................... Patch Set 5: (3 comments) Patchset: PS4: > Thanks for starting the effort. Many people stumbled over the […] The current enumeration may be used to select the default programmer when building, like this: > make CONFIG_DEFAULT_PROGRAMMER=PROGRAMMER_SERPROG CONFIG_DEFAULT_PROGRAMMER_ARGS="dev=/dev/ttyUSB0:1500000" If this enumeration can be deleted, I think it is best. File Makefile: https://review.coreboot.org/c/flashrom/+/49599/comment/cbd5a40a_64363fdd PS4, Line 681: $(shell bash ./util/generator_programmer_enum.sh) > This should be run as a recipe for the file. Currently it would be […] This is a good suggestion. But I have no better solution yet. File flashrom.c: https://review.coreboot.org/c/flashrom/+/49599/comment/3004eaa0_7233e5a1 PS4, Line 43: #include "programmer_table.c" > .c includes are generally discouraged. Yes, this may cause some problems. This file has been renamed -- To view, visit https://review.coreboot.org/c/flashrom/+/49599 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3f4370ccae2b64da3c4178243b192700d3d205d2 Gerrit-Change-Number: 49599 Gerrit-PatchSet: 5 Gerrit-Owner: Xiang Wang <merle(a)hardenedlinux.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Sam McNally <sammc(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Idwer Vollering <vidwer(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-CC: Shawn C <citypw(a)hardenedlinux.org> Gerrit-Attention: Sam McNally <sammc(a)google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Thu, 18 Mar 2021 08:03:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashrom.c: automatic generated programmer_enum.h
by Xiang Wang (Code Review) March 18, 2021

March 18, 2021

Attention is currently required from: Sam McNally, Xiang Wang, Stefan Reinauer. Hello Sam McNally, build bot (Jenkins), Nico Huber, Stefan Reinauer, Edward O'Callaghan, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/49599 to look at the new patch set (#5). Change subject: flashrom.c: automatic generated programmer_enum.h ...................................................................... flashrom.c: automatic generated programmer_enum.h programmer_table and enum programmer need to keep the same order, which is error-prone. This patch is used to automatically generate enum programmer. Change-Id: I3f4370ccae2b64da3c4178243b192700d3d205d2 Signed-off-by: Xiang Wang <merle(a)hardenedliux.org> --- M .gitignore M Makefile M flashrom.c M meson.build M programmer.h A programmer_table.h A util/generator_programmer_enum.sh 7 files changed, 550 insertions(+), 598 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/99/49599/5 -- To view, visit https://review.coreboot.org/c/flashrom/+/49599 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3f4370ccae2b64da3c4178243b192700d3d205d2 Gerrit-Change-Number: 49599 Gerrit-PatchSet: 5 Gerrit-Owner: Xiang Wang <merle(a)hardenedlinux.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Sam McNally <sammc(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Idwer Vollering <vidwer(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-CC: Shawn C <citypw(a)hardenedlinux.org> Gerrit-Attention: Sam McNally <sammc(a)google.com> Gerrit-Attention: Xiang Wang <merle(a)hardenedlinux.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: rayer_spi.c: Remove forward-declarations
by Edward O'Callaghan (Code Review) March 18, 2021

March 18, 2021

Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/flashrom/+/51555 ) Change subject: rayer_spi.c: Remove forward-declarations ...................................................................... rayer_spi.c: Remove forward-declarations Reorder functions to avoid forward-declarations. This was aimed to be done for all spi masters in the earlier patch however this file was missed. BUG=b:140394053 TEST=builds Change-Id: I0e3c82967a169d6a2512ffa17d1e0c78eafb2797 Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/51555 Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Edward O'Callaghan <quasisec(a)chromium.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M rayer_spi.c 1 file changed, 45 insertions(+), 54 deletions(-) Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Edward O'Callaghan: Looks good to me, approved diff --git a/rayer_spi.c b/rayer_spi.c index 8e869e6..cde008f 100644 --- a/rayer_spi.c +++ b/rayer_spi.c @@ -31,6 +31,11 @@ #include "programmer.h" #include "hwaccess.h" +static uint16_t lpt_iobase; + +/* Cached value of last byte sent. */ +static uint8_t lpt_outbyte; + /* We have two sets of pins, out and in. The numbers for both sets are * independent and are bitshift values, not real pin numbers. * Default settings are for the RayeR hardware. @@ -59,8 +64,20 @@ .miso_bit = 6, }; -static void dlc5_preinit(const void *); -static int dlc5_shutdown(void *); +static void dlc5_preinit(const void *data) { + msg_pdbg("dlc5_preinit\n"); + /* Assert pin 6 to receive MISO. */ + lpt_outbyte |= (1<<4); + OUTB(lpt_outbyte, lpt_iobase); +} + +static int dlc5_shutdown(void *data) { + msg_pdbg("dlc5_shutdown\n"); + /* De-assert pin 6 to force MISO low. */ + lpt_outbyte &= ~(1<<4); + OUTB(lpt_outbyte, lpt_iobase); + return 0; +} static const struct rayer_pinout xilinx_dlc5 = { .cs_bit = 2, @@ -71,8 +88,18 @@ .shutdown = dlc5_shutdown, }; -static void byteblaster_preinit(const void *); -static int byteblaster_shutdown(void *); +static void byteblaster_preinit(const void *data){ + msg_pdbg("byteblaster_preinit\n"); + /* Assert #EN signal. */ + OUTB(2, lpt_iobase + 2 ); +} + +static int byteblaster_shutdown(void *data){ + msg_pdbg("byteblaster_shutdown\n"); + /* De-Assert #EN signal. */ + OUTB(0, lpt_iobase + 2 ); + return 0; +} static const struct rayer_pinout altera_byteblastermv = { .cs_bit = 1, @@ -83,8 +110,20 @@ .shutdown = byteblaster_shutdown, }; -static void stk200_preinit(const void *); -static int stk200_shutdown(void *); +static void stk200_preinit(const void *data) { + msg_pdbg("stk200_init\n"); + /* Assert #EN signals, set LED signal. */ + lpt_outbyte = (1 << 6) ; + OUTB(lpt_outbyte, lpt_iobase); +} + +static int stk200_shutdown(void *data) { + msg_pdbg("stk200_shutdown\n"); + /* Assert #EN signals, clear LED signal. */ + lpt_outbyte = (1 << 2) | (1 << 3); + OUTB(lpt_outbyte, lpt_iobase); + return 0; +} static const struct rayer_pinout atmel_stk200 = { .cs_bit = 7, @@ -121,11 +160,6 @@ static const struct rayer_pinout *pinout = NULL; -static uint16_t lpt_iobase; - -/* Cached value of last byte sent. */ -static uint8_t lpt_outbyte; - static void rayer_bitbang_set_cs(int val) { lpt_outbyte &= ~(1 << pinout->cs_bit); @@ -237,49 +271,6 @@ return 0; } -static void byteblaster_preinit(const void *data){ - msg_pdbg("byteblaster_preinit\n"); - /* Assert #EN signal. */ - OUTB(2, lpt_iobase + 2 ); -} - -static int byteblaster_shutdown(void *data){ - msg_pdbg("byteblaster_shutdown\n"); - /* De-Assert #EN signal. */ - OUTB(0, lpt_iobase + 2 ); - return 0; -} - -static void stk200_preinit(const void *data) { - msg_pdbg("stk200_init\n"); - /* Assert #EN signals, set LED signal. */ - lpt_outbyte = (1 << 6) ; - OUTB(lpt_outbyte, lpt_iobase); -} - -static int stk200_shutdown(void *data) { - msg_pdbg("stk200_shutdown\n"); - /* Assert #EN signals, clear LED signal. */ - lpt_outbyte = (1 << 2) | (1 << 3); - OUTB(lpt_outbyte, lpt_iobase); - return 0; -} - -static void dlc5_preinit(const void *data) { - msg_pdbg("dlc5_preinit\n"); - /* Assert pin 6 to receive MISO. */ - lpt_outbyte |= (1<<4); - OUTB(lpt_outbyte, lpt_iobase); -} - -static int dlc5_shutdown(void *data) { - msg_pdbg("dlc5_shutdown\n"); - /* De-assert pin 6 to force MISO low. */ - lpt_outbyte &= ~(1<<4); - OUTB(lpt_outbyte, lpt_iobase); - return 0; -} - #else #error PCI port I/O access is not supported on this architecture yet. #endif -- To view, visit https://review.coreboot.org/c/flashrom/+/51555 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0e3c82967a169d6a2512ffa17d1e0c78eafb2797 Gerrit-Change-Number: 51555 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in flashrom[master]: meson: Add print_wiki option
by Edward O'Callaghan (Code Review) March 18, 2021

March 18, 2021

Attention is currently required from: Martin Roth, David Hendricks, Mario Limonciello, Daniel Campello. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51552 ) Change subject: meson: Add print_wiki option ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/51552 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I97d2fd687aa21533b86f9af446038bfe3da1f7d3 Gerrit-Change-Number: 51552 Gerrit-PatchSet: 3 Gerrit-Owner: Daniel Campello <campello(a)chromium.org> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Mario Limonciello <superm1(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Richard Hughes <hughsient(a)gmail.com> Gerrit-Reviewer: Richard Hughes <richard(a)hughsie.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Mario Limonciello <superm1(a)gmail.com> Gerrit-Attention: Daniel Campello <campello(a)chromium.org> Gerrit-Comment-Date: Thu, 18 Mar 2021 00:15:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: meson: Generalise libflashrom product to link as static or dyn
by Edward O'Callaghan (Code Review) March 18, 2021

March 18, 2021

Attention is currently required from: Daniel Campello, Angel Pons. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51616 ) Change subject: meson: Generalise libflashrom product to link as static or dyn ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/51616 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I77e5c298163979a0222270b3ac5d03542e5618f7 Gerrit-Change-Number: 51616 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Campello <campello(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Daniel Campello <campello(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 18 Mar 2021 00:15:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: meson: Generalise libflashrom product to link as static or dyn
by Daniel Campello (Code Review) March 18, 2021

March 18, 2021

Attention is currently required from: Angel Pons. Daniel Campello has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51616 ) Change subject: meson: Generalise libflashrom product to link as static or dyn ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/51616/comment/18d967c1_9d2ad7d6 PS1, Line 7: libFlashrom > `flashrom` is always written in lowercase, and so should `libflashrom` be sounds good! fixed. thanks! -- To view, visit https://review.coreboot.org/c/flashrom/+/51616 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I77e5c298163979a0222270b3ac5d03542e5618f7 Gerrit-Change-Number: 51616 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Campello <campello(a)chromium.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 18 Mar 2021 00:07:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: meson: Generalise libflashrom product to link as static or dyn
by Daniel Campello (Code Review) March 18, 2021

March 18, 2021

Attention is currently required from: Daniel Campello. Daniel Campello has uploaded a new patch set (#2). ( https://review.coreboot.org/c/flashrom/+/51616 ) Change subject: meson: Generalise libflashrom product to link as static or dyn ...................................................................... meson: Generalise libflashrom product to link as static or dyn Allow the user to specify if they would like a static archive or a DSO produced for libflashrom by way of the flag e.g. `-Ddefault_library=static`. Signed-off-by: Daniel Campello <campello(a)chromium.org> Change-Id: I77e5c298163979a0222270b3ac5d03542e5618f7 --- M meson.build 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/16/51616/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/51616 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I77e5c298163979a0222270b3ac5d03542e5618f7 Gerrit-Change-Number: 51616 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Campello <campello(a)chromium.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Daniel Campello <campello(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: meson: Generalise libFlashrom product to link as static or dyn
by Angel Pons (Code Review) March 18, 2021

March 18, 2021

Attention is currently required from: Daniel Campello. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51616 ) Change subject: meson: Generalise libFlashrom product to link as static or dyn ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/51616/comment/38acd957_489cd634 PS1, Line 7: libFlashrom `flashrom` is always written in lowercase, and so should `libflashrom` be -- To view, visit https://review.coreboot.org/c/flashrom/+/51616 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I77e5c298163979a0222270b3ac5d03542e5618f7 Gerrit-Change-Number: 51616 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Campello <campello(a)chromium.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Daniel Campello <campello(a)chromium.org> Gerrit-Comment-Date: Thu, 18 Mar 2021 00:06:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0