Attention is currently required from: Sam McNally, Nico Huber, Stefan Reinauer.
Hello Sam McNally, build bot (Jenkins), Nico Huber, Stefan Reinauer, Edward O'Callaghan,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/49599
to look at the new patch set (#6).
Change subject: flashrom.c: automatic generated programmer_enum.h
......................................................................
flashrom.c: automatic generated programmer_enum.h
programmer_table and enum programmer need to keep the same order, which
is error-prone. This patch is used to automatically generate enum
programmer.
Change-Id: I3f4370ccae2b64da3c4178243b192700d3d205d2
Signed-off-by: Xiang Wang <merle(a)hardenedliux.org>
---
M .gitignore
M Makefile
M flashrom.c
M meson.build
M programmer.h
A programmer_table.h
A util/generator_programmer_enum.sh
7 files changed, 550 insertions(+), 598 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/99/49599/6
--
To view, visit https://review.coreboot.org/c/flashrom/+/49599
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3f4370ccae2b64da3c4178243b192700d3d205d2
Gerrit-Change-Number: 49599
Gerrit-PatchSet: 6
Gerrit-Owner: Xiang Wang <merle(a)hardenedlinux.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Sam McNally <sammc(a)google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-CC: Idwer Vollering <vidwer(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-CC: Shawn C <citypw(a)hardenedlinux.org>
Gerrit-Attention: Sam McNally <sammc(a)google.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Sam McNally, Nico Huber, Stefan Reinauer.
Xiang Wang has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49599 )
Change subject: flashrom.c: automatic generated programmer_enum.h
......................................................................
Patch Set 5:
(3 comments)
Patchset:
PS4:
> Thanks for starting the effort. Many people stumbled over the […]
The current enumeration may be used to select the default programmer when building, like this:
> make CONFIG_DEFAULT_PROGRAMMER=PROGRAMMER_SERPROG CONFIG_DEFAULT_PROGRAMMER_ARGS="dev=/dev/ttyUSB0:1500000"
If this enumeration can be deleted, I think it is best.
File Makefile:
https://review.coreboot.org/c/flashrom/+/49599/comment/cbd5a40a_64363fdd
PS4, Line 681: $(shell bash ./util/generator_programmer_enum.sh)
> This should be run as a recipe for the file. Currently it would be […]
This is a good suggestion. But I have no better solution yet.
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/49599/comment/3004eaa0_7233e5a1
PS4, Line 43: #include "programmer_table.c"
> .c includes are generally discouraged.
Yes, this may cause some problems. This file has been renamed
--
To view, visit https://review.coreboot.org/c/flashrom/+/49599
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3f4370ccae2b64da3c4178243b192700d3d205d2
Gerrit-Change-Number: 49599
Gerrit-PatchSet: 5
Gerrit-Owner: Xiang Wang <merle(a)hardenedlinux.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Sam McNally <sammc(a)google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-CC: Idwer Vollering <vidwer(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-CC: Shawn C <citypw(a)hardenedlinux.org>
Gerrit-Attention: Sam McNally <sammc(a)google.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Comment-Date: Thu, 18 Mar 2021 08:03:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Gerrit-MessageType: comment
Attention is currently required from: Sam McNally, Xiang Wang, Stefan Reinauer.
Hello Sam McNally, build bot (Jenkins), Nico Huber, Stefan Reinauer, Edward O'Callaghan,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/49599
to look at the new patch set (#5).
Change subject: flashrom.c: automatic generated programmer_enum.h
......................................................................
flashrom.c: automatic generated programmer_enum.h
programmer_table and enum programmer need to keep the same order, which
is error-prone. This patch is used to automatically generate enum
programmer.
Change-Id: I3f4370ccae2b64da3c4178243b192700d3d205d2
Signed-off-by: Xiang Wang <merle(a)hardenedliux.org>
---
M .gitignore
M Makefile
M flashrom.c
M meson.build
M programmer.h
A programmer_table.h
A util/generator_programmer_enum.sh
7 files changed, 550 insertions(+), 598 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/99/49599/5
--
To view, visit https://review.coreboot.org/c/flashrom/+/49599
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3f4370ccae2b64da3c4178243b192700d3d205d2
Gerrit-Change-Number: 49599
Gerrit-PatchSet: 5
Gerrit-Owner: Xiang Wang <merle(a)hardenedlinux.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Sam McNally <sammc(a)google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-CC: Idwer Vollering <vidwer(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-CC: Shawn C <citypw(a)hardenedlinux.org>
Gerrit-Attention: Sam McNally <sammc(a)google.com>
Gerrit-Attention: Xiang Wang <merle(a)hardenedlinux.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Martin Roth, David Hendricks, Mario Limonciello, Daniel Campello.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51552 )
Change subject: meson: Add print_wiki option
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/flashrom/+/51552
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I97d2fd687aa21533b86f9af446038bfe3da1f7d3
Gerrit-Change-Number: 51552
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Campello <campello(a)chromium.org>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Mario Limonciello <superm1(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Richard Hughes <hughsient(a)gmail.com>
Gerrit-Reviewer: Richard Hughes <richard(a)hughsie.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Attention: Mario Limonciello <superm1(a)gmail.com>
Gerrit-Attention: Daniel Campello <campello(a)chromium.org>
Gerrit-Comment-Date: Thu, 18 Mar 2021 00:15:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Daniel Campello, Angel Pons.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51616 )
Change subject: meson: Generalise libflashrom product to link as static or dyn
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/flashrom/+/51616
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I77e5c298163979a0222270b3ac5d03542e5618f7
Gerrit-Change-Number: 51616
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Campello <campello(a)chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Daniel Campello <campello(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Thu, 18 Mar 2021 00:15:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Angel Pons.
Daniel Campello has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51616 )
Change subject: meson: Generalise libflashrom product to link as static or dyn
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/51616/comment/18d967c1_9d2ad7d6
PS1, Line 7: libFlashrom
> `flashrom` is always written in lowercase, and so should `libflashrom` be
sounds good! fixed. thanks!
--
To view, visit https://review.coreboot.org/c/flashrom/+/51616
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I77e5c298163979a0222270b3ac5d03542e5618f7
Gerrit-Change-Number: 51616
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Campello <campello(a)chromium.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Thu, 18 Mar 2021 00:07:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Daniel Campello.
Daniel Campello has uploaded a new patch set (#2). ( https://review.coreboot.org/c/flashrom/+/51616 )
Change subject: meson: Generalise libflashrom product to link as static or dyn
......................................................................
meson: Generalise libflashrom product to link as static or dyn
Allow the user to specify if they would like a static archive or a DSO
produced for libflashrom by way of the flag e.g. `-Ddefault_library=static`.
Signed-off-by: Daniel Campello <campello(a)chromium.org>
Change-Id: I77e5c298163979a0222270b3ac5d03542e5618f7
---
M meson.build
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/16/51616/2
--
To view, visit https://review.coreboot.org/c/flashrom/+/51616
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I77e5c298163979a0222270b3ac5d03542e5618f7
Gerrit-Change-Number: 51616
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Campello <campello(a)chromium.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Daniel Campello <campello(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Daniel Campello.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51616 )
Change subject: meson: Generalise libFlashrom product to link as static or dyn
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/51616/comment/38acd957_489cd634
PS1, Line 7: libFlashrom
`flashrom` is always written in lowercase, and so should `libflashrom` be
--
To view, visit https://review.coreboot.org/c/flashrom/+/51616
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I77e5c298163979a0222270b3ac5d03542e5618f7
Gerrit-Change-Number: 51616
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Campello <campello(a)chromium.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Daniel Campello <campello(a)chromium.org>
Gerrit-Comment-Date: Thu, 18 Mar 2021 00:06:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth, David Hendricks, Edward O'Callaghan, Mario Limonciello.
Daniel Campello has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51552 )
Change subject: meson: Add print_wiki option
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/51552/comment/29e9cda9_5011f34b
PS2, Line 7: meson: add missing meson options from ebuild
:
: This change adds missing meson options from chromiumos-overlay flashrom
: ebuild in order to migrate to meson.
> This commit message is more describing the motivations for it than specifically the change at hand. […]
Done
--
To view, visit https://review.coreboot.org/c/flashrom/+/51552
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I97d2fd687aa21533b86f9af446038bfe3da1f7d3
Gerrit-Change-Number: 51552
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Campello <campello(a)chromium.org>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Mario Limonciello <superm1(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Richard Hughes <hughsient(a)gmail.com>
Gerrit-Reviewer: Richard Hughes <richard(a)hughsie.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Mario Limonciello <superm1(a)gmail.com>
Gerrit-Comment-Date: Thu, 18 Mar 2021 00:04:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-MessageType: comment