June 2019 - flashrom-gerrit - mail.coreboot.org

Change in ...flashrom[master]: layout: Move generic layout functions into `layout.c`
by Nico Huber (Code Review) 16 Jun '19

16 Jun '19

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33514 ) Change subject: layout: Move generic layout functions into `layout.c` ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://review.coreboot.org/c/flashrom/+/33514 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If1edde70fc51e88e6e1c560d79a0d51941b9627c Gerrit-Change-Number: 33514 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Sun, 16 Jun 2019 01:55:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...flashrom[master]: layout: Never use global `layout` directly.
by Nico Huber (Code Review) 16 Jun '19

16 Jun '19

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33513 ) Change subject: layout: Never use global `layout` directly. ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://review.coreboot.org/c/flashrom/+/33513 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia2d7d1f4f649cd239b559ba6a40ee0977004e774 Gerrit-Change-Number: 33513 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Sun, 16 Jun 2019 01:54:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...flashrom[master]: libflashrom: Add CPP guard to fix big-endian builds
by Nico Huber (Code Review) 14 Jun '19

14 Jun '19

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/flashrom/+/33306 ) Change subject: libflashrom: Add CPP guard to fix big-endian builds ...................................................................... libflashrom: Add CPP guard to fix big-endian builds Calm a compiler warning on big-endian builds about the unused static flashrom_layout_parse_fmap(). The guard is ugly but gets the job done. We should forbid endian-specific code in the future, I guess. Change-Id: Id3f4a57e027f88cc469ed50312adddcc8af71a63 Signed-off-by: Nico Huber <nico.h(a)gmx.de> Reviewed-on: https://review.coreboot.org/c/flashrom/+/33306 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M libflashrom.c 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved diff --git a/libflashrom.c b/libflashrom.c index c5e56ae..fee60ff 100644 --- a/libflashrom.c +++ b/libflashrom.c @@ -386,6 +386,7 @@ #endif } +#ifdef __FLASHROM_LITTLE_ENDIAN__ static int flashrom_layout_parse_fmap(struct flashrom_layout **layout, struct flashctx *const flashctx, const struct fmap *const fmap) { @@ -417,6 +418,7 @@ *layout = l; return 0; } +#endif /* __FLASHROM_LITTLE_ENDIAN__ */ /** * @brief Read a layout by searching the flash chip for fmap. -- To view, visit https://review.coreboot.org/c/flashrom/+/33306 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id3f4a57e027f88cc469ed50312adddcc8af71a63 Gerrit-Change-Number: 33306 Gerrit-PatchSet: 4 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in ...flashrom[master]: cli: Add error on missing IFD
by Patrick Rudolph (Code Review) 14 Jun '19

14 Jun '19

Hello Patrick Rudolph, I'd like you to do a code review. Please visit https://review.coreboot.org/c/flashrom/+/33245 to review the following change. Change subject: cli: Add error on missing IFD ...................................................................... cli: Add error on missing IFD When no IFD is present, but the option --ifd is specified, flashrom would just exit without printing a helpful error message. Add error message that IFD could not be read or parsed. Tested on Intel platform without IFD present. Change-Id: Ie1edd7f36f647c52b17799878185d1e69e10d3b0 Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M cli_classic.c 1 file changed, 10 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/45/33245/1 diff --git a/cli_classic.c b/cli_classic.c index ced08c6..f6bd59b 100644 --- a/cli_classic.c +++ b/cli_classic.c @@ -607,10 +607,16 @@ if (layoutfile) { layout = get_global_layout(); - } else if (ifd && (flashrom_layout_read_from_ifd(&layout, fill_flash, NULL, 0) || - process_include_args(layout))) { - ret = 1; - goto out_shutdown; + } else if (ifd) { + ret = flashrom_layout_read_from_ifd(&layout, fill_flash, NULL, 0); + if (ret) { + msg_gerr("Failed to read or parse the IFD\n"); + ret = 1; + goto out_shutdown; + } else if (process_include_args(layout)) { + ret = 1; + goto out_shutdown; + } } else if (fmap && fmapfile) { struct stat s; if (stat(fmapfile, &s) != 0) { -- To view, visit https://review.coreboot.org/c/flashrom/+/33245 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie1edd7f36f647c52b17799878185d1e69e10d3b0 Gerrit-Change-Number: 33245 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-MessageType: newchange

2 9

Change in ...flashrom[master]: [WIP] Add data source/sink abstraction `flashrom_data`
by Nico Huber (Code Review) 10 Jun '19

10 Jun '19

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/33372 Change subject: [WIP] Add data source/sink abstraction `flashrom_data` ...................................................................... [WIP] Add data source/sink abstraction `flashrom_data` A first sketch. API will change when I see how it works out. Change-Id: Ie550914eca2cffb4c14cfdd76289334a2f0636b9 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M Makefile M flash.h A flashrom_data.c A flashrom_data_file.c M libflashrom.h A libflashrom_file.h 6 files changed, 373 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/72/33372/1 diff --git a/Makefile b/Makefile index e08a3f6..744344a 100644 --- a/Makefile +++ b/Makefile @@ -547,7 +547,10 @@ ############################################################################### # Library code. -LIB_OBJS = libflashrom.o layout.o flashrom.o udelay.o programmer.o helpers.o ich_descriptors.o fmap.o +LIB_OBJS = libflashrom.o flashrom_data.o layout.o flashrom.o udelay.o programmer.o helpers.o ich_descriptors.o fmap.o +ifneq ($(TARGET_OS), libpayload) +LIB_OBJS += flashrom_data_file.o +endif ############################################################################### # Frontend related stuff. diff --git a/flash.h b/flash.h index 911214c..af01479 100644 --- a/flash.h +++ b/flash.h @@ -55,6 +55,8 @@ #define ARRAY_SIZE(a) (sizeof(a) / sizeof((a)[0])) +#define container_of(ptr, type, member) ((type *)((char *)ptr - offsetof(type, member))) + enum chipbustype { BUS_NONE = 0, BUS_PARALLEL = 1 << 0, @@ -267,6 +269,10 @@ bool in_4ba_mode; }; +static inline size_t total_size(const struct flashrom_flashctx *flash) { + return flash ? flash->chip ? flash->chip->total_size * 1024 : 0 : 0; +}; + /* Timing used in probe routines. ZERO is -2 to differentiate between an unset * field and zero delay. * diff --git a/flashrom_data.c b/flashrom_data.c new file mode 100644 index 0000000..5e541a9 --- /dev/null +++ b/flashrom_data.c @@ -0,0 +1,220 @@ +/* + * This file is part of the flashrom project. + * + * Copyright (C) 2019 Nico Huber <nico.h(a)gmx.de> + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <stdio.h> +#include <stdlib.h> +#include <string.h> + +#include "flash.h" +#include "libflashrom.h" + +/** + * @defgroup flashrom-data Data sources/sinks + * @{ + */ + +struct flash_data { + struct flashrom_data data; + struct flashrom_flashctx *flash; +}; +#define FLASH_DATA(d) container_of(d, struct flash_data, data) + +static ssize_t flash_readat( + void *const buf, const struct flashrom_data *const data, + const off_t offset, const size_t count) +{ + const struct flash_data *const fdata = FLASH_DATA(data); + + if (!data || !fdata->flash || !fdata->flash->chip || !fdata->flash->chip->read) + return -1; + + return fdata->flash->chip->read(fdata->flash, buf, offset, count); +} + +static void flash_release(struct flashrom_data *const data) +{ + free(FLASH_DATA(data)); +} + +int flashrom_data_from_flash( + struct flashrom_data **const data, struct flashrom_flashctx *const flash) +{ + struct flash_data *const fdata = malloc(sizeof(*fdata)); + + if (!fdata) + return -1; + + memset(fdata, 0x00, sizeof(*fdata)); + fdata->flash = flash; + fdata->data.size = total_size(flash); + fdata->data.readat = flash_readat; + fdata->data.release = flash_release; + + *data = &fdata->data; + return 0; +} + +struct buffer_data { + struct flashrom_data data; + void *buf; +}; +#define BUFFER_DATA(d) container_of(d, struct buffer_data, data) + +static ssize_t buffer_readat( + void *const buf, const struct flashrom_data *const data, + const off_t offset, const size_t count) +{ + const struct buffer_data *const bdata = BUFFER_DATA(data); + + if (!data || !bdata->buf || offset + count > data->size) + return -1; + + memcpy(buf, (char *)bdata->buf + offset, count); + return count; +} + +static ssize_t buffer_writeat( + const struct flashrom_data *const data, const off_t offset, + const void *const buf, const size_t count) +{ + const struct buffer_data *const bdata = BUFFER_DATA(data); + + if (!data || !bdata->buf || offset + count > data->size) + return -1; + + memcpy((char *)bdata->buf + offset, buf, count); + return count; +} + +static void buffer_release(struct flashrom_data *const data) +{ + free(BUFFER_DATA(data)); +} + +int flashrom_data_from_buf( + struct flashrom_data **const data, void *const buf, const size_t size) +{ + struct buffer_data *const bdata = malloc(sizeof(*bdata)); + + if (!bdata) + return -1; + + memset(bdata, 0x00, sizeof(*bdata)); + bdata->buf = buf; + bdata->data.size = size; + bdata->data.readat = buffer_readat; + bdata->data.writeat = buffer_writeat; + bdata->data.release = buffer_release; + + *data = &bdata->data; + return 0; +} + +struct sub_data { + struct flashrom_data data; + const struct flashrom_data *parent; + off_t offset; +}; +#define SUB_DATA(d) container_of(d, struct sub_data, data) + +static ssize_t sub_readat( + void *const buf, const struct flashrom_data *const data, + const off_t offset, const size_t count) +{ + const struct sub_data *const sdata = SUB_DATA(data); + + if (!data || !sdata->parent || !sdata->parent->readat || + offset + count > data->size) + return -1; + + return sdata->parent->readat(buf, sdata->parent, sdata->offset + offset, count); +} + +static ssize_t sub_writeat( + const struct flashrom_data *const data, const off_t offset, + const void *const buf, const size_t count) +{ + const struct sub_data *const sdata = SUB_DATA(data); + + if (!data || !sdata->parent || !sdata->parent->writeat || + offset + count > data->size) + return -1; + + return sdata->parent->writeat(sdata->parent, sdata->offset + offset, buf, count); +} + +static void sub_release(struct flashrom_data *const data) +{ + free(SUB_DATA(data)); +} + +int flashrom_data_subregion( + struct flashrom_data **const data, + const struct flashrom_data *const parent, + const off_t offset, const size_t size) +{ + if (!parent || offset + size > parent.size) + return -1; + + struct sub_data *const sdata = malloc(sizeof(*sdata)); + + if (!sdata) + return -1; + + memset(sdata, 0x00, sizeof(*sdata)); + sdata->parent = parent; + sdata->offset = offset; + sdata->data.size = size; + sdata->data.readat = parent->readat ? sub_readat : NULL; + sdata->data.writeat = parent->writeat ? sub_writeat : NULL; + sdata->data.release = sub_release; + + *data = &sdata->data; + return 0; +} + +ssize_t flashrom_data_copy( + const struct flashrom_data *const dst, + const struct flashrom_data *const src) +{ + ssize_t ret = -1; + + if (!dst || !dst->writeat || !src || !src->readat) + return ret; + if (dst->size != src->size) + return ret; + + void *const buf = malloc(dst->size); + if (!buf) + return ret; + + if (src->readat(buf, src, 0, dst->size) != dst->size) + goto _free_ret; + + ret = dst->writeat(dst, 0, buf, dst->size); + +_free_ret: + free(buf); + return ret; +} + +void flashrom_data_release(struct flashrom_data *const data) +{ + if (data->release) + data->release(data); +} + +/** @} */ /* end flashrom-data */ diff --git a/flashrom_data_file.c b/flashrom_data_file.c new file mode 100644 index 0000000..d7e1c66 --- /dev/null +++ b/flashrom_data_file.c @@ -0,0 +1,95 @@ +/* + * This file is part of the flashrom project. + * + * Copyright (C) 2019 Nico Huber <nico.h(a)gmx.de> + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <stdio.h> +#include <stdlib.h> +#include <string.h> + +#include "flash.h" +#include "libflashrom.h" +#include "libflashrom_file.h" + +/** @ingroup flashrom-data */ + +struct file_data { + struct flashrom_data data; + FILE *file; +}; +#define FILE_DATA(d) container_of(d, struct file_data, data) + +static ssize_t file_readat( + void *const buf, const struct flashrom_data *const data, + const off_t offset, const size_t count) +{ + const struct file_data *const fdata = FILE_DATA(data); + + if (!data || !fdata->file) + return -1; + + if (fseek(fdata->file, offset, SEEK_SET) != 0) + return -1; + if (fread(buf, count, 1, fdata->file) != 1) + return -1; + + return count; +} + +static ssize_t file_writeat( + const struct flashrom_data *const data, const off_t offset, + const void *const buf, const size_t count) +{ + const struct file_data *const fdata = FILE_DATA(data); + + if (!data || !fdata->file) + return -1; + + if (fseek(fdata->file, offset, SEEK_SET) != 0) + return -1; + if (fwrite(buf, count, 1, fdata->file) != 1) + return -1; + + return count; +} + +static void file_release(struct flashrom_data *const data) +{ + free(FILE_DATA(data)); +} + +int flashrom_data_from_file(struct flashrom_data **const data, FILE *const file) +{ + struct file_data *const fdata = malloc(sizeof(*fdata)); + + if (!fdata || !file) + return -1; + + if (fseek(file, 0, SEEK_END) != 0) + return -1; + + const long pos = ftell(file); + if (pos < 0 || pos > SIZE_MAX) + return -1; + + memset(fdata, 0x00, sizeof(*fdata)); + fdata->file = file; + fdata->data.size = (size_t)pos; + fdata->data.readat = file_readat; + fdata->data.writeat = file_writeat; + fdata->data.release = file_release; + + *data = &fdata->data; + return 0; +} diff --git a/libflashrom.h b/libflashrom.h index 38c95d2..01ecd3f 100644 --- a/libflashrom.h +++ b/libflashrom.h @@ -3,6 +3,7 @@ * * Copyright (C) 2012 secunet Security Networks AG * (Written by Nico Huber <nico.huber(a)secunet.com> for secunet) + * Copyright (C) 2019 Nico Huber <nico.h(a)gmx.de> * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -47,6 +48,26 @@ int flashrom_flash_erase(struct flashrom_flashctx *); void flashrom_flash_release(struct flashrom_flashctx *); +/** @ingroup flashrom-data */ +/** Representation of a data source/sink (can be flash, a file, memory buffer, ...) */ +struct flashrom_data { + size_t size; + + /* Offsets are relative to the `flashrom_data` instance, not the `buf`. */ + ssize_t (*readat)(void *buf, const struct flashrom_data *, off_t offset, size_t count); + ssize_t (*writeat)(const struct flashrom_data *, off_t offset, const void *buf, size_t count); + + void (*release)(struct flashrom_data *); +}; + +int flashrom_data_from_flash(struct flashrom_data **, struct flashrom_flashctx *); +int flashrom_data_from_buf(struct flashrom_data **, void *, size_t); +int flashrom_data_subregion(struct flashrom_data **, const struct flashrom_data *parent, off_t, size_t); + +ssize_t flashrom_data_copy(const struct flashrom_data *dst, const struct flashrom_data *src); + +void flashrom_data_release(struct flashrom_data *); + /** @ingroup flashrom-flash */ enum flashrom_flag { FLASHROM_FLAG_FORCE, diff --git a/libflashrom_file.h b/libflashrom_file.h new file mode 100644 index 0000000..54de515 --- /dev/null +++ b/libflashrom_file.h @@ -0,0 +1,27 @@ +/* + * This file is part of the flashrom project. + * + * Copyright (C) 2019 Nico Huber <nico.h(a)gmx.de> + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#ifndef __LIBFLASHROM_FILE_H__ +#define __LIBFLASHROM_FILE_H__ 1 + +#include <stdio.h> + +#include "libflashrom.h" + +/** @ingroup flashrom-data */ +int flashrom_data_from_file(struct flashrom_data **, FILE *); + +#endif /* !__LIBFLASHROM_FILE_H__ */ -- To view, visit https://review.coreboot.org/c/flashrom/+/33372 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie550914eca2cffb4c14cfdd76289334a2f0636b9 Gerrit-Change-Number: 33372 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: newchange

1 0

Change in ...flashrom[master]: atavia.c: Remove unneeded 'else'
by HAOUAS Elyes (Code Review) 10 Jun '19

10 Jun '19

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/33343 Change subject: atavia.c: Remove unneeded 'else' ...................................................................... atavia.c: Remove unneeded 'else' 'else' is not needed after a 'break' or 'return'. Change-Id: Ib43a8c186c34c85f964df648564fa7f5aef10412 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M atavia.c 1 file changed, 2 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/43/33343/1 diff --git a/atavia.c b/atavia.c index 80bba58..3b4a5bd 100644 --- a/atavia.c +++ b/atavia.c @@ -102,10 +102,9 @@ if (((access & BROM_TRIGGER) == 0) && (status & BROM_ERROR_STATUS) == 0) { ready = true; break; - } else { - programmer_delay(1); - continue; } + programmer_delay(1); + continue; } msg_pdbg2("\n%s: %s after %d tries (access=0x%02x, status=0x%02x)\n", -- To view, visit https://review.coreboot.org/c/flashrom/+/33343 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib43a8c186c34c85f964df648564fa7f5aef10412 Gerrit-Change-Number: 33343 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

3 8

Change in ...flashrom[master]: manibuilder: Add DJGPP target
by Nico Huber (Code Review) 09 Jun '19

09 Jun '19

Nico Huber has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/23042 ) Change subject: manibuilder: Add DJGPP target ...................................................................... Abandoned squashed into parent commit -- To view, visit https://review.coreboot.org/c/flashrom/+/23042 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id3b85685f39fb5fdd6e21fca7ffa3f5d4a4ba51d Gerrit-Change-Number: 23042 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in ...flashrom[master]: Add Manibuilder
by Nico Huber (Code Review) 09 Jun '19

09 Jun '19

Hello Angel Pons, Arthur Heymans, David Hendricks, Paul Menzel, build bot (Jenkins), Martin Roth, Patrick Georgi, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/23005 to look at the new patch set (#3). Change subject: Add Manibuilder ...................................................................... Add Manibuilder Add a set of Dockerfiles for build testing. If you have an x86 machine and ~20GiB free disk space, run `make register` and `make -jxx` in util/manibuilder and go eat some pizza. The former runs a privileged docker container to set binfmt_misc up for qemu (read the code, don't trust it). Change-Id: I60863a5c7d70dde71486fccb66cb59b30ba4d982 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- A util/manibuilder/Dockerfile.alpine A util/manibuilder/Dockerfile.anita A util/manibuilder/Dockerfile.centos A util/manibuilder/Dockerfile.debian-debootstrap A util/manibuilder/Dockerfile.djgpp A util/manibuilder/Dockerfile.fedora A util/manibuilder/Dockerfile.qemu-user-static A util/manibuilder/Dockerfile.ubuntu-debootstrap A util/manibuilder/Makefile A util/manibuilder/Makefile.targets A util/manibuilder/README.md A util/manibuilder/anita-wrapper.sh A util/manibuilder/mani-wrapper.sh 13 files changed, 470 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/05/23005/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/23005 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I60863a5c7d70dde71486fccb66cb59b30ba4d982 Gerrit-Change-Number: 23005 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in ...flashrom[1.1.x]: libflashrom: Add CPP guard to fix big-endian builds
by Nico Huber (Code Review) 09 Jun '19

09 Jun '19

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/33297 Change subject: libflashrom: Add CPP guard to fix big-endian builds ...................................................................... libflashrom: Add CPP guard to fix big-endian builds It's ugly but gets the job done. We should forbid endian-specific code in the future, I guess. Change-Id: Id3f4a57e027f88cc469ed50312adddcc8af71a63 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M libflashrom.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/97/33297/1 diff --git a/libflashrom.c b/libflashrom.c index f90a22c..c327c62 100644 --- a/libflashrom.c +++ b/libflashrom.c @@ -383,6 +383,7 @@ #endif } +#ifdef __FLASHROM_LITTLE_ENDIAN__ static int flashrom_layout_parse_fmap(struct flashrom_layout **layout, struct flashctx *const flashctx, const struct fmap *const fmap) { @@ -414,6 +415,7 @@ *layout = l; return 0; } +#endif /* __FLASHROM_LITTLE_ENDIAN__ */ /** * @brief Read a layout by searching the flash chip for fmap. -- To view, visit https://review.coreboot.org/c/flashrom/+/33297 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.1.x Gerrit-Change-Id: Id3f4a57e027f88cc469ed50312adddcc8af71a63 Gerrit-Change-Number: 33297 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: newchange

2 4

Change in ...flashrom[master]: libflashrom: Add CPP guard to fix big-endian builds
by Angel Pons (Code Review) 09 Jun '19

09 Jun '19

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33306 ) Change subject: libflashrom: Add CPP guard to fix big-endian builds ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/33306 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id3f4a57e027f88cc469ed50312adddcc8af71a63 Gerrit-Change-Number: 33306 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 09 Jun 2019 11:35:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit June 2019