February 2018 - flashrom-gerrit

Change in flashrom[master]: ENE EDI - add dummy read to ensure proper detection of ENE chips
by Nico Huber (Code Review) 03 Feb '18

03 Feb '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/23260 ) Change subject: ENE EDI - add dummy read to ensure proper detection of ENE chips ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/23260 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I69ee71674649cd8ba4fc635f889cb39a1cd204b9 Gerrit-Change-Number: 23260 Gerrit-PatchSet: 2 Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 03 Feb 2018 12:50:28 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: Add support for selecting the erased bit value with a flag
by Mike Banon (Code Review) 03 Feb '18

03 Feb '18

Mike Banon has posted comments on this change. ( https://review.coreboot.org/23258 ) Change subject: Add support for selecting the erased bit value with a flag ...................................................................... Patch Set 3: > (3 comments) > > >> Code looks good, how well was the rebase tested? > > > > After I've tested the code and submitted these ported patches, > the > > only rebase was because of a small typo fix at one of the commit > > messages, so the results are still positive - fully tested on the > > real hardware > > I meant the original rebase of Paul's work. What is "the real hard- > ware"? It should be primarily tested on previously supported pro- > grammers and flash chips to make sure nothing regresses. > (3 comments) > > >> Code looks good, how well was the rebase tested? > > > > After I've tested the code and submitted these ported patches, > the > > only rebase was because of a small typo fix at one of the commit > > messages, so the results are still positive - fully tested on the > > real hardware > > I meant the original rebase of Paul's work. What is "the real hard- > ware"? It should be primarily tested on previously supported pro- > grammers and flash chips to make sure nothing regresses. Since the original submission of KB9012 patches by Paul , flashrom source code has been significantly changed (most importantly "Kill doit()") - thats why the additional modifications (included to the commits above) were required to make them work, can't be tested without modifications. "Real hardware" is G505S laptop with KB9012 chip installed onboard, my flashing setup is fully described at this manual - http://dangerousprototypes.com/docs/Flashing_KB9012_with_Bus_Pirate After the changes, what I've tried: *) using CH341A SPI USB programmer - 1) Probed/read/erased/flashed/verified KB9012 a few times, looks like its working perfectly :) 2) Tried all these operations with a few chips from SPI 25 series - EN25QH16, EN25QH32, and S25FL032A/P to make sure that nothing broke down for them after KB9012 patches *) using Bus Pirate v4 programmer - did only "2)" (didn't retest KB9012 because the Bus Pirate is much slower with KB9012 than other programmers) -- To view, visit https://review.coreboot.org/23258 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia7b0de8568e31f9bf263ba0ad6b051e837477b6b Gerrit-Change-Number: 23258 Gerrit-PatchSet: 3 Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Kocialkowski <contact(a)paulk.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 03 Feb 2018 12:48:16 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in flashrom[master]: Add support for selecting the erased bit value with a flag
by Nico Huber (Code Review) 03 Feb '18

03 Feb '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/23258 ) Change subject: Add support for selecting the erased bit value with a flag ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/#/c/23258/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/23258/1//COMMIT_MSG@2 PS1, Line 2: Author: Mike Banon <mikebdp2(a)gmail.com> > Good idea. […] During an interactive rebase, this should work: git commit --amend --author=... --date=... You can find the original commits here, btw. http://git.code.paulk.fr/gitweb/?p=flashrom.git;a=shortlog;h=refs/heads/next -- To view, visit https://review.coreboot.org/23258 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia7b0de8568e31f9bf263ba0ad6b051e837477b6b Gerrit-Change-Number: 23258 Gerrit-PatchSet: 3 Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Kocialkowski <contact(a)paulk.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 03 Feb 2018 12:32:18 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: Add support for selecting the erased bit value with a flag
by Paul Kocialkowski (Code Review) 03 Feb '18

03 Feb '18

Paul Kocialkowski has posted comments on this change. ( https://review.coreboot.org/23258 ) Change subject: Add support for selecting the erased bit value with a flag ...................................................................... Patch Set 3: > Thanks for the great work on this series! I had planned on > submitting follow-up patches to this (I have not given up) so as > Nico mentioned, it would be nice that I am still listed as author > and have a signed-off-by line in the commits that get landed. I > would be more than happy to add your signed-off line as well to > show that you were also involved with this effort! I think the easiest way to do things would be that I submit my rebased commit with your signed-off-by line so we can have the right author. -- To view, visit https://review.coreboot.org/23258 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia7b0de8568e31f9bf263ba0ad6b051e837477b6b Gerrit-Change-Number: 23258 Gerrit-PatchSet: 3 Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Kocialkowski <contact(a)paulk.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 03 Feb 2018 12:31:04 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in flashrom[master]: Add support for selecting the erased bit value with a flag
by Paul Kocialkowski (Code Review) 03 Feb '18

03 Feb '18

Paul Kocialkowski has posted comments on this change. ( https://review.coreboot.org/23258 ) Change subject: Add support for selecting the erased bit value with a flag ...................................................................... Patch Set 3: Thanks for the great work on this series! I had planned on submitting follow-up patches to this (I have not given up) so as Nico mentioned, it would be nice that I am still listed as author and have a signed-off-by line in the commits that get landed. I would be more than happy to add your signed-off line as well to show that you were also involved with this effort! -- To view, visit https://review.coreboot.org/23258 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia7b0de8568e31f9bf263ba0ad6b051e837477b6b Gerrit-Change-Number: 23258 Gerrit-PatchSet: 3 Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Kocialkowski <contact(a)paulk.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 03 Feb 2018 12:29:12 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in flashrom[master]: Add the hidden-from-probing chips category and make KB9012 hidden
by build bot (Jenkins) (Code Review) 03 Feb '18

03 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23262 ) Change subject: Add the hidden-from-probing chips category and make KB9012 hidden ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1088/ : SUCCESS -- To view, visit https://review.coreboot.org/23262 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89a53ccaef2791a2ac32904d7ab813da7478a6f0 Gerrit-Change-Number: 23262 Gerrit-PatchSet: 2 Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Kocialkowski <contact(a)paulk.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 03 Feb 2018 12:27:55 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: Add the hidden-from-probing chips category and make KB9012 hidden
by Mike Banon (Code Review) 03 Feb '18

03 Feb '18

Hello Paul Kocialkowski, Paul Menzel, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/23262 to look at the new patch set (#2). Change subject: Add the hidden-from-probing chips category and make KB9012 hidden ...................................................................... Add the hidden-from-probing chips category and make KB9012 hidden There are some chips like ENE KB9012, probing for which could cause the other chips to misbehave. Therefore, such chips should be "hidden" - not probed for unless the user wants This commit introduces a new field to the "flashchip" structure: int hidden; Now it is possible to "hide" any chip by adding this line .hidden = 1, to the "struct flashchip flashchips[]" structure of a chip, like .write = edi_chip_write, .read = edi_chip_read, .voltage = {2700, 3600}, .hidden = 1, }, ^^^ KB9012 has been "hidden" this way, and it will never be probed for unless explicitly specified by its' chip name: --chip "KB9012 (EDI)" Now, flashrom will probe for a chip only if one of these conditions is true: 1) no chip has been specified AND this chip is not "hidden" 2) this chip has been specified by -c | --chip <chipname> Change-Id: I89a53ccaef2791a2ac32904d7ab813da7478a6f0 Signed-off-by: Mike Banon <mikebdp2(a)gmail.com> --- M flash.h M flashchips.c M flashrom.c 3 files changed, 17 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/62/23262/2 -- To view, visit https://review.coreboot.org/23262 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I89a53ccaef2791a2ac32904d7ab813da7478a6f0 Gerrit-Change-Number: 23262 Gerrit-PatchSet: 2 Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Kocialkowski <contact(a)paulk.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: [v4, 5/6] Add the hidden-from-probing chips category and make KB9012 h...
by Mike Banon (Code Review) 03 Feb '18

03 Feb '18

Mike Banon has posted comments on this change. ( https://review.coreboot.org/23262 ) Change subject: [v4,5/6] Add the hidden-from-probing chips category and make KB9012 hidden ...................................................................... Patch Set 1: > IMHO, taking shortcuts is one of the problems that made flashrom > less > maintainable and makes merging of new patches much harder. Usually, > the time you spend to do something right from the beginning pays > off > later. If you want, I can take this one commit over and you'd only > have to rebase the others on it. > IMHO, taking shortcuts is one of the problems that made flashrom > less > maintainable and makes merging of new patches much harder. Usually, > the time you spend to do something right from the beginning pays > off > later. If you want, I can take this one commit over and you'd only > have to rebase the others on it. Thank you very much, that would be very helpful (and hopefully benefit the future chips as well). Meanwhile I will try to bring other KB9012 commits into a good condition -- To view, visit https://review.coreboot.org/23262 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89a53ccaef2791a2ac32904d7ab813da7478a6f0 Gerrit-Change-Number: 23262 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Kocialkowski <contact(a)paulk.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 03 Feb 2018 12:27:11 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in flashrom[master]: ENE EDI - print debug info like others while probing for ENE chips
by Mike Banon (Code Review) 03 Feb '18

03 Feb '18

Mike Banon has posted comments on this change. ( https://review.coreboot.org/23261 ) Change subject: ENE EDI - print debug info like others while probing for ENE chips ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/#/c/23261/2//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/23261/2//COMMIT_MSG@13 PS2, Line 13: > You can leave a long line in a commit message if it's a quote. […] changed into long line (95 chars), and now its printing rc1/rc2 as integers so "rc1 0x0, rc2 0x0" looks like "rc1 0, rc2 0"; also removing a tag... -- To view, visit https://review.coreboot.org/23261 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8e62bc9f6785b4bf0be0aaf0f74c8120d77c0d4 Gerrit-Change-Number: 23261 Gerrit-PatchSet: 3 Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 03 Feb 2018 12:24:53 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: ENE EDI - print debug info like others while probing for ENE chips
by build bot (Jenkins) (Code Review) 03 Feb '18

03 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23261 ) Change subject: ENE EDI - print debug info like others while probing for ENE chips ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1087/ : SUCCESS -- To view, visit https://review.coreboot.org/23261 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8e62bc9f6785b4bf0be0aaf0f74c8120d77c0d4 Gerrit-Change-Number: 23261 Gerrit-PatchSet: 3 Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 03 Feb 2018 12:24:15 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit February 2018