January 2018 - flashrom-gerrit

Change in flashrom[master]: layout: Add a helper to get number of '-i' args with files
by build bot (Jenkins) (Code Review) Jan. 20, 2018

Jan. 20, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23343 ) Change subject: layout: Add a helper to get number of '-i' args with files ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1049/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/895/ : SUCCESS -- To view, visit https://review.coreboot.org/23343 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2629167d371bc7f3766006600d2d256bed9ec145 Gerrit-Change-Number: 23343 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 21 Jan 2018 02:14:54 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: make args for -r/-w/-v non-positional and optional
by build bot (Jenkins) (Code Review) Jan. 20, 2018

Jan. 20, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23022 ) Change subject: make args for -r/-w/-v non-positional and optional ...................................................................... Patch Set 9: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1046/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/893/ : SUCCESS -- To view, visit https://review.coreboot.org/23022 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iefbcb7dc4fefe26f5afd1292dfd5c1687fa62803 Gerrit-Change-Number: 23022 Gerrit-PatchSet: 9 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Louis Yung-Chieh Lo <yjlou(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 21 Jan 2018 02:14:48 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: Hack up test_v2.sh to work better with upstream
by build bot (Jenkins) (Code Review) Jan. 20, 2018

Jan. 20, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23025 ) Change subject: Hack up test_v2.sh to work better with upstream ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1048/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/894/ : SUCCESS -- To view, visit https://review.coreboot.org/23025 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9ace99fdb8d779804fe1887fe49f6409f8aff02e Gerrit-Change-Number: 23025 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 21 Jan 2018 02:14:48 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: test_v2.sh: Copy layout to local tempdir in local-layout mode
by build bot (Jenkins) (Code Review) Jan. 20, 2018

Jan. 20, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23024 ) Change subject: test_v2.sh: Copy layout to local tempdir in local-layout mode ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1047/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/892/ : SUCCESS -- To view, visit https://review.coreboot.org/23024 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia2328d367ee3df5ac1c481c16e4502a81d69fd98 Gerrit-Change-Number: 23024 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 21 Jan 2018 02:14:45 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: Copy test_v2 directory from chromiumos branch
by build bot (Jenkins) (Code Review) Jan. 20, 2018

Jan. 20, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23023 ) Change subject: Copy test_v2 directory from chromiumos branch ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1045/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/891/ : SUCCESS -- To view, visit https://review.coreboot.org/23023 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I41bef98d32df61af400ecac46ea9571e722b2ac6 Gerrit-Change-Number: 23023 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 21 Jan 2018 02:14:38 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: layout: Add -i <region>[:<file>] support.
by build bot (Jenkins) (Code Review) Jan. 20, 2018

Jan. 20, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23021 ) Change subject: layout: Add -i <region>[:<file>] support. ...................................................................... Patch Set 9: Verified-1 Build Failed https://qa.coreboot.org/job/flashrom_gerrit/890/ : FAILURE https://qa.coreboot.org/job/flashrom-customrules/1044/ : SUCCESS -- To view, visit https://review.coreboot.org/23021 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5465659605d8431d931053967b40290195cfd99 Gerrit-Change-Number: 23021 Gerrit-PatchSet: 9 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 21 Jan 2018 02:14:32 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: layout: Add a helper to get number of '-i' args with files
by David Hendricks (Code Review) Jan. 20, 2018

Jan. 20, 2018

David Hendricks has uploaded this change for review. ( https://review.coreboot.org/23343 Change subject: layout: Add a helper to get number of '-i' args with files ...................................................................... layout: Add a helper to get number of '-i' args with files Change-Id: I2629167d371bc7f3766006600d2d256bed9ec145 Signed-off-by: David Hendricks <dhendricks(a)fb.com> --- M layout.c M layout.h 2 files changed, 14 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/43/23343/1 diff --git a/layout.c b/layout.c index a990adc..ebbb0a1 100644 --- a/layout.c +++ b/layout.c @@ -260,6 +260,19 @@ return overlap_detected; } +/* return number of '-i' args with both region and filename specified */ +int get_num_include_args_with_files(const struct flashrom_layout *const l) +{ + int i, ret = 0; + + for (i = 0; i < l->num_entries; i++) { + if (l->entries[i].included && l->entries[i].file) + ret++; + } + + return ret; +} + void layout_cleanup(void) { int i; diff --git a/layout.h b/layout.h index f401ef2..9131b06 100644 --- a/layout.h +++ b/layout.h @@ -64,5 +64,6 @@ int process_include_args(struct flashrom_layout *); int included_regions_overlap(const struct flashrom_layout *const flashrom_layout); +int get_num_include_args_with_files(const struct flashrom_layout *const layout); #endif /* !__LAYOUT_H__ */ -- To view, visit https://review.coreboot.org/23343 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I2629167d371bc7f3766006600d2d256bed9ec145 Gerrit-Change-Number: 23343 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>

1 0

Change in flashrom[master]: layout: Add -i <region>[:<file>] support.
by David Hendricks (Code Review) Jan. 20, 2018

Jan. 20, 2018

Hello Carl-Daniel Hailfinger, Arthur Heymans, Nicola Corna, Paul Menzel, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/23021 to look at the new patch set (#9). Change subject: layout: Add -i <region>[:<file>] support. ...................................................................... layout: Add -i <region>[:<file>] support. Add an optional sub-parameter to the -i parameter to allow building the image to be written from multiple files. This will also allow regions to be read from flash and written to separate image files. This is a rebase of a patch that was ported from chromiumos. A lot of things have changed, but the idea is the same. Original patch by Louis Yung-Chieh Lo <yjlou(a)chromium.org>: Summary: Support -i partition:file feature for both read and write. Commit: 9c7525f Review URL: http://codereview.chromium.org/6611015 Ported version by Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> and Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net>: Summary: [PATCH 2/6] layout: Add -i <region>[:<file>] support. Review URL: https://mail.coreboot.org/pipermail/flashrom/2013-October/011729.html Change-Id: Ic5465659605d8431d931053967b40290195cfd99 Signed-off-by: David Hendricks <dhendrix(a)chromium.org> Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M cli_classic.c M dummyflasher.c M flash.h M flashrom.8.tmpl M flashrom.c M layout.c M layout.h 7 files changed, 269 insertions(+), 41 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/21/23021/9 -- To view, visit https://review.coreboot.org/23021 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic5465659605d8431d931053967b40290195cfd99 Gerrit-Change-Number: 23021 Gerrit-PatchSet: 9 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: flashchips: reset a M25P10-A before a probe
by build bot (Jenkins) (Code Review) Jan. 20, 2018

Jan. 20, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23337 ) Change subject: flashchips: reset a M25P10-A before a probe ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1043/ : SUCCESS -- To view, visit https://review.coreboot.org/23337 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I19a5332756d15b3cb74609c44a8d3fed2f4a2d68 Gerrit-Change-Number: 23337 Gerrit-PatchSet: 2 Gerrit-Owner: Lubomir Rintel <lkundrak(a)v3.sk> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 20 Jan 2018 18:18:34 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: digilent_spi: add a driver for the iCEblink40 development board
by build bot (Jenkins) (Code Review) Jan. 20, 2018

Jan. 20, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23338 ) Change subject: digilent_spi: add a driver for the iCEblink40 development board ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1042/ : SUCCESS -- To view, visit https://review.coreboot.org/23338 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ffcd9a2db4395816f0e8b6ce6c3b0d8e930c9e6 Gerrit-Change-Number: 23338 Gerrit-PatchSet: 2 Gerrit-Owner: Lubomir Rintel <lkundrak(a)v3.sk> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 20 Jan 2018 18:18:30 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0