September 2017 - flashrom-gerrit

Change in flashrom[staging]: layout: Add -i <region>[:<file>] support.
by David Hendricks (Code Review) 04 Sep '17

04 Sep '17

Hello Carl-Daniel Hailfinger, Philippe Mathieu-Daudé, Paul Menzel, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/19342 to look at the new patch set (#7). Change subject: layout: Add -i <region>[:<file>] support. ...................................................................... layout: Add -i <region>[:<file>] support. Add an optional sub-parameter to the -i parameter to allow building the image to be written from multiple files. This will also allow regions to be read from flash and written to separate image files. This is a rebase of a patch that was ported from chromiumos. A lot of things have changed, but the idea is the same. Original patch by Louis Yung-Chieh Lo <yjlou(a)chromium.org>: Summary: Support -i partition:file feature for both read and write. Commit: 9c7525f Review URL: http://codereview.chromium.org/6611015 Ported version by Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> and Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net>: Summary: [PATCH 2/6] layout: Add -i <region>[:<file>] support. Review URL: https://mail.coreboot.org/pipermail/flashrom/2013-October/011729.html Change-Id: Ic5465659605d8431d931053967b40290195cfd99 Signed-off-by: David Hendricks <dhendrix(a)chromium.org> Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> --- M cli_classic.c M dummyflasher.c M flash.h M flashrom.8.tmpl M flashrom.c M layout.c M layout.h 7 files changed, 142 insertions(+), 34 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/42/19342/7 -- To view, visit https://review.coreboot.org/19342 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic5465659605d8431d931053967b40290195cfd99 Gerrit-Change-Number: 19342 Gerrit-PatchSet: 7 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[staging]: Move get_layout() from flashrom.c to layout.c
by build bot (Jenkins) (Code Review) 04 Sep '17

04 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21367 ) Change subject: Move get_layout() from flashrom.c to layout.c ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/540/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/490/ : SUCCESS -- To view, visit https://review.coreboot.org/21367 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Ic67cf53abddc0aa905674acbcde717d9aed2f66e Gerrit-Change-Number: 21367 Gerrit-PatchSet: 3 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 04 Sep 2017 01:30:15 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Move get_layout() from flashrom.c to layout.c
by David Hendricks (Code Review) 04 Sep '17

04 Sep '17

Hello build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/21367 to look at the new patch set (#3). Change subject: Move get_layout() from flashrom.c to layout.c ...................................................................... Move get_layout() from flashrom.c to layout.c Change-Id: Ic67cf53abddc0aa905674acbcde717d9aed2f66e Signed-off-by: David Hendricks <david.hendricks(a)gmail.com> --- M flashrom.c M layout.c M layout.h 3 files changed, 10 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/67/21367/3 -- To view, visit https://review.coreboot.org/21367 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic67cf53abddc0aa905674acbcde717d9aed2f66e Gerrit-Change-Number: 21367 Gerrit-PatchSet: 3 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[staging]: Move get_layout() from flashrom.c to layout.c
by build bot (Jenkins) (Code Review) 04 Sep '17

04 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21367 ) Change subject: Move get_layout() from flashrom.c to layout.c ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/539/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/489/ : SUCCESS -- To view, visit https://review.coreboot.org/21367 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Ic67cf53abddc0aa905674acbcde717d9aed2f66e Gerrit-Change-Number: 21367 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 04 Sep 2017 01:24:03 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Move get_layout() from flashrom.c to layout.c
by David Hendricks (Code Review) 04 Sep '17

04 Sep '17

Hello build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/21367 to look at the new patch set (#2). Change subject: Move get_layout() from flashrom.c to layout.c ...................................................................... Move get_layout() from flashrom.c to layout.c Change-Id: Ic67cf53abddc0aa905674acbcde717d9aed2f66e Signed-off-by: David Hendricks <david.hendricks(a)gmail.com> --- M flash.h M flashrom.c M layout.c M layout.h 4 files changed, 12 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/67/21367/2 -- To view, visit https://review.coreboot.org/21367 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic67cf53abddc0aa905674acbcde717d9aed2f66e Gerrit-Change-Number: 21367 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[staging]: Move get_layout() from flashrom.c to layout.c
by build bot (Jenkins) (Code Review) 04 Sep '17

04 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21367 ) Change subject: Move get_layout() from flashrom.c to layout.c ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/538/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/488/ : SUCCESS -- To view, visit https://review.coreboot.org/21367 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Ic67cf53abddc0aa905674acbcde717d9aed2f66e Gerrit-Change-Number: 21367 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 04 Sep 2017 01:11:37 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Move get_layout() from flashrom.c to layout.c
by David Hendricks (Code Review) 04 Sep '17

04 Sep '17

David Hendricks has uploaded this change for review. ( https://review.coreboot.org/21367 Change subject: Move get_layout() from flashrom.c to layout.c ...................................................................... Move get_layout() from flashrom.c to layout.c Change-Id: Ic67cf53abddc0aa905674acbcde717d9aed2f66e Signed-off-by: David Hendricks <david.hendricks(a)gmail.com> --- M flashrom.c M layout.c M layout.h 3 files changed, 12 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/67/21367/1 diff --git a/flashrom.c b/flashrom.c index c600efc..7a3d9bf 100644 --- a/flashrom.c +++ b/flashrom.c @@ -1529,14 +1529,6 @@ return 0; } -static const struct flashrom_layout *get_layout(const struct flashctx *const flashctx) -{ - if (flashctx->layout && flashctx->layout->num_entries) - return flashctx->layout; - else - return &flashctx->fallback_layout.base; -} - /** * @brief Reads the included layout regions into a buffer. * diff --git a/layout.c b/layout.c index 9bf0b03..c416ec8 100644 --- a/layout.c +++ b/layout.c @@ -40,6 +40,14 @@ return &layout; } +const struct flashrom_layout *get_layout(const struct flashctx *const flashctx) +{ + if (flashctx->layout && flashctx->layout->num_entries) + return flashctx->layout; + else + return &flashctx->fallback_layout.base; +} + #ifndef __LIBPAYLOAD__ int read_romlayout(const char *name) { diff --git a/layout.h b/layout.h index f32dc82..3f78ced 100644 --- a/layout.h +++ b/layout.h @@ -28,6 +28,9 @@ #include <stddef.h> #include <stdint.h> +struct flashrom_flashctx; +#define flashctx flashrom_flashctx /* TODO: Agree on a name and convert all occurences. */ + /* Types and macros regarding the maximum flash space size supported by generic code. */ typedef uint32_t chipoff_t; /* Able to store any addressable offset within a supported flash memory. */ typedef uint32_t chipsize_t; /* Able to store the number of bytes of any supported flash memory. */ @@ -58,6 +61,7 @@ }; struct flashrom_layout *get_global_layout(void); +const struct flashrom_layout *get_layout(const struct flashctx *const flashctx); int process_include_args(struct flashrom_layout *); -- To view, visit https://review.coreboot.org/21367 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: newchange Gerrit-Change-Id: Ic67cf53abddc0aa905674acbcde717d9aed2f66e Gerrit-Change-Number: 21367 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>

1 0

Change in flashrom[staging]: layout: Add -i <region>[:<file>] support.
by build bot (Jenkins) (Code Review) 03 Sep '17

03 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19342 ) Change subject: layout: Add -i <region>[:<file>] support. ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/536/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/486/ : SUCCESS -- To view, visit https://review.coreboot.org/19342 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Ic5465659605d8431d931053967b40290195cfd99 Gerrit-Change-Number: 19342 Gerrit-PatchSet: 6 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 03 Sep 2017 23:20:40 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Hack up test_v2.sh to work better with upstream
by build bot (Jenkins) (Code Review) 03 Sep '17

03 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19341 ) Change subject: Hack up test_v2.sh to work better with upstream ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/535/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/485/ : SUCCESS -- To view, visit https://review.coreboot.org/19341 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I9ace99fdb8d779804fe1887fe49f6409f8aff02e Gerrit-Change-Number: 19341 Gerrit-PatchSet: 6 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 03 Sep 2017 23:20:39 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: make args for -r/-w/-v non-positional and optional
by build bot (Jenkins) (Code Review) 03 Sep '17

03 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19387 ) Change subject: make args for -r/-w/-v non-positional and optional ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/537/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/487/ : SUCCESS -- To view, visit https://review.coreboot.org/19387 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Iefbcb7dc4fefe26f5afd1292dfd5c1687fa62803 Gerrit-Change-Number: 19387 Gerrit-PatchSet: 4 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Louis Yung-Chieh Lo <yjlou(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 03 Sep 2017 23:20:14 +0000 Gerrit-HasComments: No

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit September 2017