September 2017 - flashrom-gerrit

Change in flashrom[staging]: 4BA: Winbond W25Q256.V chip (32MB) declaration, 4-bytes addr mode
by Lijian Zhao (Code Review) 27 Sep '17

27 Sep '17

Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/20506 ) Change subject: 4BA: Winbond W25Q256.V chip (32MB) declaration, 4-bytes addr mode ...................................................................... Patch Set 3: Code-Review+1 Tested okay with both internal flash and ftdi_spi google-servo-v2. Flash with flashrom and then read back from dediprog, the content is identical. -- To view, visit https://review.coreboot.org/20506 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I90226f453f8147ae5ac7dbbef7549ee3bfacc3d6 Gerrit-Change-Number: 20506 Gerrit-PatchSet: 3 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 27 Sep 2017 01:27:32 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: nicintel_eeprom: Move variable declarations out of loops
by Stefan Tauner (Code Review) 26 Sep '17

26 Sep '17

Stefan Tauner has posted comments on this change. ( https://review.coreboot.org/21702 ) Change subject: nicintel_eeprom: Move variable declarations out of loops ...................................................................... Patch Set 1: > > We do not (want to) support non-C99 compilers and I seriously > doubt > > that this is really the issue and thus the best fix. Can you > please > > show us the compiler's diagnostics and build_details.txt? > > Well, we kept the code compatible until now and as long as we don't > specify the standard, should keep it that way. No, we didn't at all. Why do you think so? Not *forcing* a version in the makefile does not mean we support *every* compiler out there. We use lots of C99 features all around the code base... including variable declarations in for heads. The report (and patch) are lacking details... -- To view, visit https://review.coreboot.org/21702 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Ib7ad5a69244e462f84eae93df9e841716e089b31 Gerrit-Change-Number: 21702 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Sep 2017 18:01:12 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: nicintel_eeprom: Move variable declarations out of loops
by Nico Huber (Code Review) 26 Sep '17

26 Sep '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/21702 ) Change subject: nicintel_eeprom: Move variable declarations out of loops ...................................................................... Patch Set 1: Code-Review+2 > We do not (want to) support non-C99 compilers and I seriously doubt > that this is really the issue and thus the best fix. Can you please > show us the compiler's diagnostics and build_details.txt? Well, we kept the code compatible until now and as long as we don't specify the standard, should keep it that way. -- To view, visit https://review.coreboot.org/21702 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Ib7ad5a69244e462f84eae93df9e841716e089b31 Gerrit-Change-Number: 21702 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Sep 2017 17:48:44 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: nicintel_eeprom: Move variable declarations out of loops
by Stefan Tauner (Code Review) 26 Sep '17

26 Sep '17

Stefan Tauner has posted comments on this change. ( https://review.coreboot.org/21702 ) Change subject: nicintel_eeprom: Move variable declarations out of loops ...................................................................... Patch Set 1: Code-Review-1 We do not (want to) support non-C99 compilers and I seriously doubt that this is really the issue and thus the best fix. Can you please show us the compiler's diagnostics and build_details.txt? -- To view, visit https://review.coreboot.org/21702 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Ib7ad5a69244e462f84eae93df9e841716e089b31 Gerrit-Change-Number: 21702 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Sep 2017 17:36:45 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: nicintel_eeprom: Move variable declarations out of loops
by build bot (Jenkins) (Code Review) 26 Sep '17

26 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21702 ) Change subject: nicintel_eeprom: Move variable declarations out of loops ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/flashrom-customrules/569/ : FAILURE https://qa.coreboot.org/job/flashrom_gerrit/515/ : SUCCESS -- To view, visit https://review.coreboot.org/21702 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Ib7ad5a69244e462f84eae93df9e841716e089b31 Gerrit-Change-Number: 21702 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Sep 2017 16:57:27 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: nicintel_eeprom: Move variable declarations out of loops
by David Hendricks (Code Review) 26 Sep '17

26 Sep '17

David Hendricks has uploaded this change for review. ( https://review.coreboot.org/21702 Change subject: nicintel_eeprom: Move variable declarations out of loops ...................................................................... nicintel_eeprom: Move variable declarations out of loops A couple of C99-style variable declarations within loops are causing compilation failures on some systems (gcc 4.9.2-10 on Raspbian). This moves them to make gcc happy. Change-Id: Ib7ad5a69244e462f84eae93df9e841716e089b31 Signed-off-by: David Hendricks <david.hendricks(a)gmail.com> --- M nicintel_eeprom.c 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/02/21702/1 diff --git a/nicintel_eeprom.c b/nicintel_eeprom.c index e2fb584..e4a91ef 100644 --- a/nicintel_eeprom.c +++ b/nicintel_eeprom.c @@ -211,7 +211,8 @@ pci_mmio_writel(eewr, nicintel_eebar + EEWR); programmer_delay(5); - for (int i = 0; i < MAX_ATTEMPTS; i++) + int i; + for (i = 0; i < MAX_ATTEMPTS; i++) if (pci_mmio_readl(nicintel_eebar + EEWR) & BIT(EEWR_DONE)) return 0; return -1; @@ -419,7 +420,8 @@ flup |= BIT(EE_FLUPD); pci_mmio_writel(flup, nicintel_eebar + EEC); - for (int i = 0; i < MAX_ATTEMPTS; i++) + int i; + for (i = 0; i < MAX_ATTEMPTS; i++) if (pci_mmio_readl(nicintel_eebar + EEC) & BIT(EE_FLUDONE)) return 0; -- To view, visit https://review.coreboot.org/21702 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: newchange Gerrit-Change-Id: Ib7ad5a69244e462f84eae93df9e841716e089b31 Gerrit-Change-Number: 21702 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>

1 0

Change in flashrom[staging]: Guard x86-specific IFD stuff
by David Hendricks (Code Review) 17 Sep '17

17 Sep '17

David Hendricks has abandoned this change. ( https://review.coreboot.org/19339 ) Change subject: Guard x86-specific IFD stuff ...................................................................... Abandoned no longer needed -- To view, visit https://review.coreboot.org/19339 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: abandon Gerrit-Change-Id: If5abe84e47112fef0e3576045510b34ce94e6a4d Gerrit-Change-Number: 19339 Gerrit-PatchSet: 3 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[staging]: nicintel_spi: Define BIT() macro
by David Hendricks (Code Review) 17 Sep '17

17 Sep '17

David Hendricks has submitted this change and it was merged. ( https://review.coreboot.org/21432 ) Change subject: nicintel_spi: Define BIT() macro ...................................................................... nicintel_spi: Define BIT() macro Replace bit shits with BIT() macro. This improves the readability of the code. Change-Id: I30315891f18d4d5bfbc247bb9012560479afab90 Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda(a)gmail.com> Reviewed-on: https://review.coreboot.org/21432 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: David Hendricks <david.hendricks(a)gmail.com> --- M nicintel_spi.c 1 file changed, 12 insertions(+), 10 deletions(-) Approvals: build bot (Jenkins): Verified David Hendricks: Looks good to me, approved diff --git a/nicintel_spi.c b/nicintel_spi.c index bbe0afb..3c43e8b 100644 --- a/nicintel_spi.c +++ b/nicintel_spi.c @@ -77,6 +77,8 @@ // #define FL_BUSY 30 // #define FL_ER 31 +#define BIT(x) (1<<(x)) + uint8_t *nicintel_spibar; const struct dev_entry nics_intel_spi[] = { @@ -114,11 +116,11 @@ uint32_t tmp; tmp = pci_mmio_readl(nicintel_spibar + FLA); - tmp |= 1 << FL_REQ; + tmp |= BIT(FL_REQ); pci_mmio_writel(tmp, nicintel_spibar + FLA); /* Wait until we are allowed to use the SPI bus. */ - while (!(pci_mmio_readl(nicintel_spibar + FLA) & (1 << FL_GNT))) ; + while (!(pci_mmio_readl(nicintel_spibar + FLA) & BIT(FL_GNT))) ; } static void nicintel_release_spibus(void) @@ -126,7 +128,7 @@ uint32_t tmp; tmp = pci_mmio_readl(nicintel_spibar + FLA); - tmp &= ~(1 << FL_REQ); + tmp &= ~BIT(FL_REQ); pci_mmio_writel(tmp, nicintel_spibar + FLA); } @@ -135,7 +137,7 @@ uint32_t tmp; tmp = pci_mmio_readl(nicintel_spibar + FLA); - tmp &= ~(1 << FL_CS); + tmp &= ~BIT(FL_CS); tmp |= (val << FL_CS); pci_mmio_writel(tmp, nicintel_spibar + FLA); } @@ -145,7 +147,7 @@ uint32_t tmp; tmp = pci_mmio_readl(nicintel_spibar + FLA); - tmp &= ~(1 << FL_SCK); + tmp &= ~BIT(FL_SCK); tmp |= (val << FL_SCK); pci_mmio_writel(tmp, nicintel_spibar + FLA); } @@ -155,7 +157,7 @@ uint32_t tmp; tmp = pci_mmio_readl(nicintel_spibar + FLA); - tmp &= ~(1 << FL_SI); + tmp &= ~BIT(FL_SI); tmp |= (val << FL_SI); pci_mmio_writel(tmp, nicintel_spibar + FLA); } @@ -225,18 +227,18 @@ uint32_t tmp; tmp = pci_mmio_readl(nicintel_spibar + FLA); - if (tmp & (1 << FL_LOCKED)) { + if (tmp & BIT(FL_LOCKED)) { msg_perr("Flash is in Secure Mode. Abort.\n"); return 1; } - if (!(tmp & (1 << FL_ABORT))) + if (!(tmp & BIT(FL_ABORT))) return 0; - tmp |= (1 << FL_CLR_ERR); + tmp |= BIT(FL_CLR_ERR); pci_mmio_writel(tmp, nicintel_spibar + FLA); tmp = pci_mmio_readl(nicintel_spibar + FLA); - if (!(tmp & (1 << FL_ABORT))) { + if (!(tmp & BIT(FL_ABORT))) { msg_perr("Unable to clear Flash Access Error. Abort\n"); return 1; } -- To view, visit https://review.coreboot.org/21432 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: merged Gerrit-Change-Id: I30315891f18d4d5bfbc247bb9012560479afab90 Gerrit-Change-Number: 21432 Gerrit-PatchSet: 3 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[staging]: nicintel_spi: Define BIT() macro
by David Hendricks (Code Review) 17 Sep '17

17 Sep '17

David Hendricks has posted comments on this change. ( https://review.coreboot.org/21432 ) Change subject: nicintel_spi: Define BIT() macro ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/21432 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I30315891f18d4d5bfbc247bb9012560479afab90 Gerrit-Change-Number: 21432 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 17 Sep 2017 18:14:25 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: nicintel_spi: Define BIT() macro
by build bot (Jenkins) (Code Review) 17 Sep '17

17 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21432 ) Change subject: nicintel_spi: Define BIT() macro ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/567/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/514/ : SUCCESS -- To view, visit https://review.coreboot.org/21432 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I30315891f18d4d5bfbc247bb9012560479afab90 Gerrit-Change-Number: 21432 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 17 Sep 2017 18:14:00 +0000 Gerrit-HasComments: No

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit September 2017