August 2017 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[refs/meta/config]: Modify access rules
by build bot (Jenkins) (Code Review) Aug. 18, 2017

Aug. 18, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21056 ) Change subject: Modify access rules ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/flashrom-customrules/512/ : SUCCESS -- To view, visit https://review.coreboot.org/21056 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-MessageType: comment Gerrit-Change-Id: I5976f78f53328c7406133e811a1da87fa037ec0e Gerrit-Change-Number: 21056 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 18 Aug 2017 11:07:46 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[refs/meta/config]: Modify access rules
by Patrick Georgi (Code Review) Aug. 18, 2017

Aug. 18, 2017

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/21056 ) Change subject: Modify access rules ...................................................................... Modify access rules Change-Id: I5976f78f53328c7406133e811a1da87fa037ec0e Reviewed-on: https://review.coreboot.org/21056 Tested-by: Patrick Georgi <pgeorgi(a)google.com> Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> --- M groups M project.config 2 files changed, 5 insertions(+), 0 deletions(-) Approvals: Patrick Georgi: Verified; Looks good to me, approved diff --git a/groups b/groups index aa8425b..3caeb32 100644 --- a/groups +++ b/groups @@ -2,3 +2,4 @@ # db95ce11b379445ac8c5806ea0b61195555b338d flashrom developers user:dhendrix user/David Hendricks (dhendrix) +user:stefanct user/Stefan Tauner (stefanct) diff --git a/project.config b/project.config index f8a6395..88bd0b0 100644 --- a/project.config +++ b/project.config @@ -9,6 +9,7 @@ submit = group flashrom developers [access "refs/heads/staging"] submit = group flashrom developers + exclusiveGroupPermissions = submit [access "refs/tags/*"] push = +force group flashrom developers @@ -31,4 +32,7 @@ filter = -is:draft [access "refs/heads/master"] create = group user/David Hendricks (dhendrix) + create = group user/Stefan Tauner (stefanct) delete = group user/David Hendricks (dhendrix) + delete = group user/Stefan Tauner (stefanct) + exclusiveGroupPermissions = create delete -- To view, visit https://review.coreboot.org/21056 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-MessageType: merged Gerrit-Change-Id: I5976f78f53328c7406133e811a1da87fa037ec0e Gerrit-Change-Number: 21056 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[refs/meta/config]: Modify access rules
by Patrick Georgi (Code Review) Aug. 18, 2017

Aug. 18, 2017

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/21056 ) Change subject: Modify access rules ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/21056 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-MessageType: comment Gerrit-Change-Id: I5976f78f53328c7406133e811a1da87fa037ec0e Gerrit-Change-Number: 21056 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 18 Aug 2017 11:07:30 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[refs/meta/config]: Modify access rules
by Patrick Georgi (Code Review) Aug. 18, 2017

Aug. 18, 2017

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/21056 ) Change subject: Modify access rules ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://review.coreboot.org/21056 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-MessageType: comment Gerrit-Change-Id: I5976f78f53328c7406133e811a1da87fa037ec0e Gerrit-Change-Number: 21056 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 18 Aug 2017 10:58:08 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[refs/meta/config]: Modify access rules
by build bot (Jenkins) (Code Review) Aug. 16, 2017

Aug. 16, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21056 ) Change subject: Modify access rules ...................................................................... Patch Set 1: Build Failed https://qa.coreboot.org/job/flashrom_gerrit/470/ : FAILURE https://qa.coreboot.org/job/flashrom-customrules/511/ : SUCCESS -- To view, visit https://review.coreboot.org/21056 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-MessageType: comment Gerrit-Change-Id: I5976f78f53328c7406133e811a1da87fa037ec0e Gerrit-Change-Number: 21056 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 16 Aug 2017 19:55:35 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[refs/meta/config]: Modify access rules
by Stefan Tauner (Code Review) Aug. 16, 2017

Aug. 16, 2017

Stefan Tauner has uploaded this change for review. ( https://review.coreboot.org/21056 Change subject: Modify access rules ...................................................................... Modify access rules Change-Id: I5976f78f53328c7406133e811a1da87fa037ec0e --- M groups M project.config 2 files changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/56/21056/1 diff --git a/groups b/groups index aa8425b..3caeb32 100644 --- a/groups +++ b/groups @@ -2,3 +2,4 @@ # db95ce11b379445ac8c5806ea0b61195555b338d flashrom developers user:dhendrix user/David Hendricks (dhendrix) +user:stefanct user/Stefan Tauner (stefanct) diff --git a/project.config b/project.config index f8a6395..88bd0b0 100644 --- a/project.config +++ b/project.config @@ -9,6 +9,7 @@ submit = group flashrom developers [access "refs/heads/staging"] submit = group flashrom developers + exclusiveGroupPermissions = submit [access "refs/tags/*"] push = +force group flashrom developers @@ -31,4 +32,7 @@ filter = -is:draft [access "refs/heads/master"] create = group user/David Hendricks (dhendrix) + create = group user/Stefan Tauner (stefanct) delete = group user/David Hendricks (dhendrix) + delete = group user/Stefan Tauner (stefanct) + exclusiveGroupPermissions = create delete -- To view, visit https://review.coreboot.org/21056 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-MessageType: newchange Gerrit-Change-Id: I5976f78f53328c7406133e811a1da87fa037ec0e Gerrit-Change-Number: 21056 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Tauner <stefan.tauner(a)gmx.at>

1 0

Change in flashrom[staging]: Include <sys/types.h> wherever ssize_t is used
by Nico Huber (Code Review) Aug. 16, 2017

Aug. 16, 2017

Nico Huber has posted comments on this change. ( https://review.coreboot.org/21015 ) Change subject: Include <sys/types.h> wherever ssize_t is used ...................................................................... Patch Set 3: > +2 but all i can do here is +1 :P Should be fixed :) -- To view, visit https://review.coreboot.org/21015 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I5f6f114523f541b3a8d845c6faee2c0b9f753bae Gerrit-Change-Number: 21015 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Urja Rannikko <urjaman(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 16 Aug 2017 17:02:37 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Include <sys/types.h> wherever ssize_t is used
by Nico Huber (Code Review) Aug. 16, 2017

Aug. 16, 2017

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/21015 ) Change subject: Include <sys/types.h> wherever ssize_t is used ...................................................................... Include <sys/types.h> wherever ssize_t is used `ssize_t` is a POSIX type (cf. IEEE Std 1003.1). Change-Id: I5f6f114523f541b3a8d845c6faee2c0b9f753bae Signed-off-by: Nico Huber <nico.h(a)gmx.de> Reported-by: Urja Rannikko <urjaman(a)gmail.com> Reviewed-on: https://review.coreboot.org/21015 Reviewed-by: David Hendricks <david.hendricks(a)gmail.com> Reviewed-by: Urja Rannikko <urjaman(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M dediprog.c M ich_descriptors.c M ich_descriptors.h 3 files changed, 3 insertions(+), 0 deletions(-) Approvals: David Hendricks: Looks good to me, approved Urja Rannikko: Looks good to me, but someone else must approve build bot (Jenkins): Verified diff --git a/dediprog.c b/dediprog.c index 6f82772..2f5b441 100644 --- a/dediprog.c +++ b/dediprog.c @@ -21,6 +21,7 @@ #include "platform.h" +#include <sys/types.h> #include <stdlib.h> #include <stdio.h> #include <string.h> diff --git a/ich_descriptors.c b/ich_descriptors.c index a2f8edf..7916152 100644 --- a/ich_descriptors.c +++ b/ich_descriptors.c @@ -34,6 +34,7 @@ #define UPPER_MAP_OFFSET (4096 - 256 - 4) #define getVTBA(flumap) (((flumap)->FLUMAP1 << 4) & 0x00000ff0) +#include <sys/types.h> #include <string.h> #include "flash.h" /* for msg_* */ #include "programmer.h" diff --git a/ich_descriptors.h b/ich_descriptors.h index 574bc5f..4ddc710 100644 --- a/ich_descriptors.h +++ b/ich_descriptors.h @@ -22,6 +22,7 @@ #ifndef __ICH_DESCRIPTORS_H__ #define __ICH_DESCRIPTORS_H__ 1 +#include <sys/types.h> #include <stdint.h> #include "programmer.h" /* for enum ich_chipset */ -- To view, visit https://review.coreboot.org/21015 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: merged Gerrit-Change-Id: I5f6f114523f541b3a8d845c6faee2c0b9f753bae Gerrit-Change-Number: 21015 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Urja Rannikko <urjaman(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[staging]: Include <sys/types.h> wherever ssize_t is used
by build bot (Jenkins) (Code Review) Aug. 16, 2017

Aug. 16, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21015 ) Change subject: Include <sys/types.h> wherever ssize_t is used ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/509/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/469/ : SUCCESS -- To view, visit https://review.coreboot.org/21015 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I5f6f114523f541b3a8d845c6faee2c0b9f753bae Gerrit-Change-Number: 21015 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Urja Rannikko <urjaman(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 16 Aug 2017 12:32:14 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Include <sys/types.h> wherever ssize_t is used
by Urja Rannikko (Code Review) Aug. 16, 2017

Aug. 16, 2017

Urja Rannikko has posted comments on this change. ( https://review.coreboot.org/21015 ) Change subject: Include <sys/types.h> wherever ssize_t is used ...................................................................... Patch Set 1: Code-Review+1 +2 but all i can do here is +1 :P -- To view, visit https://review.coreboot.org/21015 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I5f6f114523f541b3a8d845c6faee2c0b9f753bae Gerrit-Change-Number: 21015 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Urja Rannikko <urjaman(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 16 Aug 2017 05:34:18 +0000 Gerrit-HasComments: No

1 0