June 2017 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[staging]: Enable writes with active ME
by Nico Huber (Code Review) 09 Jun '17

09 Jun '17

Hello Paul Menzel, David Hendricks, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/18740 to look at the new patch set (#15). Change subject: Enable writes with active ME ...................................................................... Enable writes with active ME At least with the -N,--noverify-all switch, this warning isn't true any more. Maybe we want to force -N in that case? Change-Id: I94a5e7074b845c227e43d76d04dd1a71082a1cef Signed-off-by: Nico Huber <nico.huber(a)secunet.com> --- M flashrom.8.tmpl M ichspi.c 2 files changed, 1 insertion(+), 37 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/40/18740/15 -- To view, visit https://review.coreboot.org/18740 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: newpatchset Gerrit-Change-Id: I94a5e7074b845c227e43d76d04dd1a71082a1cef Gerrit-Change-Number: 18740 Gerrit-PatchSet: 15 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[staging]: Free board_vendor and board_model vars before returning
by Stefan Reinauer (Code Review) 07 Jun '17

07 Jun '17

Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/18207 ) Change subject: Free board_vendor and board_model vars before returning ...................................................................... Patch Set 3: -Code-Review Sorry, +2ed by accident. I don't think free()ing here is a good idea. (Not that it actually really matters ) -- To view, visit https://review.coreboot.org/18207 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I825f53702803292277b44dcb03fdc49b5dd410a8 Gerrit-Change-Number: 18207 Gerrit-PatchSet: 3 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 07 Jun 2017 21:29:25 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Free board_vendor and board_model vars before returning
by Nico Huber (Code Review) 07 Jun '17

07 Jun '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/18207 ) Change subject: Free board_vendor and board_model vars before returning ...................................................................... Patch Set 3: Code-Review-2 See previous comment. The variable `ret` is undeclared on big-endian. -- To view, visit https://review.coreboot.org/18207 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I825f53702803292277b44dcb03fdc49b5dd410a8 Gerrit-Change-Number: 18207 Gerrit-PatchSet: 3 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 07 Jun 2017 21:18:37 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Free board_vendor and board_model vars before returning
by Stefan Reinauer (Code Review) 07 Jun '17

07 Jun '17

Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/18207 ) Change subject: Free board_vendor and board_model vars before returning ...................................................................... Patch Set 3: Code-Review+2 (2 comments) https://review.coreboot.org/#/c/18207/3/internal.c File internal.c: https://review.coreboot.org/#/c/18207/3/internal.c@170 PS3, Line 170: #if IS_X86 || IS_ARM We should assume coreboot is available on all architectures https://review.coreboot.org/#/c/18207/3/internal.c@222 PS3, Line 222: oard_parse_parameter(arg, &board_vendor, &board_model Would it make more sense to rewrite this function to avoid the layering issue that this patch is trying to fix? Or maybe alloca() the space with a reasonable size and have board_parse_parameter copy the data instead of overwriting the pointer. -- To view, visit https://review.coreboot.org/18207 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I825f53702803292277b44dcb03fdc49b5dd410a8 Gerrit-Change-Number: 18207 Gerrit-PatchSet: 3 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 07 Jun 2017 21:01:35 +0000 Gerrit-HasComments: Yes

1 0

Change in flashrom[staging]: spi25: Fix layering violation in probe_spi_rdid4()
by Nico Huber (Code Review) 07 Jun '17

07 Jun '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/19420 ) Change subject: spi25: Fix layering violation in probe_spi_rdid4() ...................................................................... Patch Set 2: Code-Review-2 (1 comment) Will update this (sometime). https://review.coreboot.org/#/c/19420/2/wbsio_spi.c File wbsio_spi.c: https://review.coreboot.org/#/c/19420/2/wbsio_spi.c@73 PS2, Line 73: .max_data_read = 3, > The table above wbsio_spi_send_command() implies that this is 4. It seems y Letting wbsio_spi_send_command() handle it sounds way better than what I did, thanks! I first thought the code in spi25.c was there to make sure we return 0 on this error, but that seems to be handled deeper down already. -- To view, visit https://review.coreboot.org/19420 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Idd21d20465cb214f3ff5bf3267b9014f8beee3f3 Gerrit-Change-Number: 19420 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 07 Jun 2017 20:17:20 +0000 Gerrit-HasComments: Yes

1 0

Change in flashrom[staging]: spi25: Fix layering violation in probe_spi_rdid4()
by David Hendricks (Code Review) 07 Jun '17

07 Jun '17

David Hendricks has posted comments on this change. ( https://review.coreboot.org/19420 ) Change subject: spi25: Fix layering violation in probe_spi_rdid4() ...................................................................... Patch Set 2: Code-Review-1 (1 comment) I'm not sure how this will affect wbsio_spi.c. Can you please explain the impact of setting max_data_read to 3 a bit more? I have no experience with that hardware, so there might be something you know that I don't. https://review.coreboot.org/#/c/19420/2/wbsio_spi.c File wbsio_spi.c: https://review.coreboot.org/#/c/19420/2/wbsio_spi.c@73 PS2, Line 73: .max_data_read = 3, The table above wbsio_spi_send_command() implies that this is 4. It seems you set it to 3 here since there isn't a mode that supports 4-byte RDID (1 command byte + 4 data read). I'm wondering if it's cleaner to leave this as MAX_DATA_UNSPECIFIED and let it fail in wbsio_spi_send_command(). -- To view, visit https://review.coreboot.org/19420 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Idd21d20465cb214f3ff5bf3267b9014f8beee3f3 Gerrit-Change-Number: 19420 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 07 Jun 2017 19:55:17 +0000 Gerrit-HasComments: Yes

1 0

Change in flashrom[staging]: bitbang_spi: Drop bitbang_spi_master_type
by David Hendricks (Code Review) 07 Jun '17

07 Jun '17

David Hendricks has posted comments on this change. ( https://review.coreboot.org/19417 ) Change subject: bitbang_spi: Drop bitbang_spi_master_type ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/19417 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I7a3b5d9ff1e99d2d4f873c6f19fb318f93762037 Gerrit-Change-Number: 19417 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 07 Jun 2017 19:20:44 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Adapt CLI to use new libflashrom interface' print callback
by Philippe Mathieu-Daudé (Code Review) 06 Jun '17

06 Jun '17

Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/17948 ) Change subject: Adapt CLI to use new libflashrom interface' print callback ...................................................................... Patch Set 14: Code-Review+1 -- To view, visit https://review.coreboot.org/17948 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Idf19978eb8e340d258199193d2978f37409e9983 Gerrit-Change-Number: 17948 Gerrit-PatchSet: 14 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 06 Jun 2017 21:17:42 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: spi: Add valid_addr_offset() to spi_master
by build bot (Jenkins) (Code Review) 06 Jun '17

06 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19418 ) Change subject: spi: Add valid_addr_offset() to spi_master ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/353/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/355/ : SUCCESS -- To view, visit https://review.coreboot.org/19418 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Icbac513c5339e8aff624870252133284ef85ab73 Gerrit-Change-Number: 19418 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 06 Jun 2017 17:51:02 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: bitbang_spi: Drop bitbang_spi_master_type
by build bot (Jenkins) (Code Review) 06 Jun '17

06 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19417 ) Change subject: bitbang_spi: Drop bitbang_spi_master_type ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/352/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/354/ : SUCCESS -- To view, visit https://review.coreboot.org/19417 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I7a3b5d9ff1e99d2d4f873c6f19fb318f93762037 Gerrit-Change-Number: 19417 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 06 Jun 2017 17:50:48 +0000 Gerrit-HasComments: No

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit June 2017