April 2017 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[staging]: Make read_ich_descriptors_from_dump() available in flashrom
by build bot (Jenkins) (Code Review) 12 Apr '17

12 Apr '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/17952 ) Change subject: Make read_ich_descriptors_from_dump() available in flashrom ...................................................................... Patch Set 4: Verified-1 Build Failed https://qa.coreboot.org/job/flashrom_gerrit/124/ : FAILURE https://qa.coreboot.org/job/flashrom-customrules/107/ : SUCCESS -- To view, visit https://review.coreboot.org/17952 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib3d38a622a581afee87b49777e775942cc901fc8 Gerrit-PatchSet: 4 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in flashrom[staging]: cli_classic: Remove layout-for-write-only check
by build bot (Jenkins) (Code Review) 12 Apr '17

12 Apr '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/17951 ) Change subject: cli_classic: Remove layout-for-write-only check ...................................................................... Patch Set 4: Verified-1 Build Failed https://qa.coreboot.org/job/flashrom_gerrit/123/ : FAILURE https://qa.coreboot.org/job/flashrom-customrules/106/ : SUCCESS -- To view, visit https://review.coreboot.org/17951 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f5e9623ca75bc4503aeb45ae346d7573c0fef2c Gerrit-PatchSet: 4 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Add option to read ROM layout from IFD
by build bot (Jenkins) (Code Review) 12 Apr '17

12 Apr '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/17953 ) Change subject: Add option to read ROM layout from IFD ...................................................................... Patch Set 4: Verified-1 Build Failed https://qa.coreboot.org/job/flashrom_gerrit/125/ : FAILURE https://qa.coreboot.org/job/flashrom-customrules/108/ : SUCCESS -- To view, visit https://review.coreboot.org/17953 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifafff2bf6d5c5e62283416b3269723f81fdc0fa3 Gerrit-PatchSet: 4 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Add option (-A, --noverify-all) to not verify the whole chip...
by build bot (Jenkins) (Code Review) 12 Apr '17

12 Apr '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/17950 ) Change subject: Add option (-A, --noverify-all) to not verify the whole chip after write ...................................................................... Patch Set 4: Verified-1 Build Failed https://qa.coreboot.org/job/flashrom_gerrit/122/ : FAILURE https://qa.coreboot.org/job/flashrom-customrules/105/ : SUCCESS -- To view, visit https://review.coreboot.org/17950 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I40b5983f56d62821d17b827b88b73d1d41a30bd7 Gerrit-PatchSet: 4 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Kill doit()
by build bot (Jenkins) (Code Review) 12 Apr '17

12 Apr '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/17949 ) Change subject: Kill doit() ...................................................................... Patch Set 4: Verified-1 Build Failed https://qa.coreboot.org/job/flashrom_gerrit/121/ : FAILURE https://qa.coreboot.org/job/flashrom-customrules/104/ : SUCCESS -- To view, visit https://review.coreboot.org/17949 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id81177c50b4410e68dcf8ebab48386a94cd9b714 Gerrit-PatchSet: 4 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Adapt CLI to use new libflashrom interface' print callback
by build bot (Jenkins) (Code Review) 12 Apr '17

12 Apr '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/17948 ) Change subject: Adapt CLI to use new libflashrom interface' print callback ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/103/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/119/ : SUCCESS -- To view, visit https://review.coreboot.org/17948 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf19978eb8e340d258199193d2978f37409e9983 Gerrit-PatchSet: 4 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Add Doxyfile for libflashrom documentation
by build bot (Jenkins) (Code Review) 12 Apr '17

12 Apr '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/17947 ) Change subject: Add Doxyfile for libflashrom documentation ...................................................................... Patch Set 4: Verified-1 Build Failed https://qa.coreboot.org/job/flashrom_gerrit/120/ : FAILURE https://qa.coreboot.org/job/flashrom-customrules/102/ : SUCCESS -- To view, visit https://review.coreboot.org/17947 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I583bf9aa8c43049723aff498625d490c37832f13 Gerrit-PatchSet: 4 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Add a convenient libflashrom interface
by build bot (Jenkins) (Code Review) 12 Apr '17

12 Apr '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/17946 ) Change subject: Add a convenient libflashrom interface ...................................................................... Patch Set 4: Verified-1 Build Failed https://qa.coreboot.org/job/flashrom_gerrit/117/ : FAILURE https://qa.coreboot.org/job/flashrom-customrules/101/ : SUCCESS -- To view, visit https://review.coreboot.org/17946 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00f169990830aa17b7dfae5eb74010d40c476181 Gerrit-PatchSet: 4 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Add functions to read/erase/write/verify by layout
by build bot (Jenkins) (Code Review) 12 Apr '17

12 Apr '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/17945 ) Change subject: Add functions to read/erase/write/verify by layout ...................................................................... Patch Set 4: Verified-1 Build Failed https://qa.coreboot.org/job/flashrom_gerrit/118/ : FAILURE https://qa.coreboot.org/job/flashrom-customrules/100/ : SUCCESS -- To view, visit https://review.coreboot.org/17945 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic6194cea4c4c430e0cf9d586052508a865b09c86 Gerrit-PatchSet: 4 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Add functions to read/erase/write/verify by layout
by Nico Huber (Code Review) 12 Apr '17

12 Apr '17

Hello David Hendricks, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/17945 to look at the new patch set (#4). Change subject: Add functions to read/erase/write/verify by layout ...................................................................... Add functions to read/erase/write/verify by layout Inspired by Lynxis' related work, this implements a foundation for layout based flash access. All operations iterate over the given layout regions. Erase and write then walk, per region, over all erase blocks in an inner loop (which might not be what we want, see note on optimization below). Special care has been taken that flash content is merged properly, in case an erase block is only partially covered by a layout region or even affects mul- tiple regions. A note on performance: In the case an erase block affects multiple regions, it will probably be read, erased and written for each region. Another approach would be to walk all erase blocks once and check for each erase block which regions it touches (i.e. for each erase block, merge data pontentially from the flash and all layout regions, then flash the combined data). That might result in cleaner code. I haven't tried it yet, though. Change-Id: Ic6194cea4c4c430e0cf9d586052508a865b09c86 Signed-off-by: Nico Huber <nico.huber(a)secunet.com> --- M flash.h M flashrom.c 2 files changed, 352 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/45/17945/4 -- To view, visit https://review.coreboot.org/17945 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic6194cea4c4c430e0cf9d586052508a865b09c86 Gerrit-PatchSet: 4 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins)

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit April 2017