April 2017 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[staging]: Kill doit()
by build bot (Jenkins) (Code Review) 22 Apr '17

22 Apr '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/17949 ) Change subject: Kill doit() ...................................................................... Patch Set 10: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/212/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/224/ : SUCCESS -- To view, visit https://review.coreboot.org/17949 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType:… [View More]

1 0

Change in flashrom[staging]: cli_classic: Add option (-A, --noverify-all)
by build bot (Jenkins) (Code Review) 22 Apr '17

22 Apr '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/17950 ) Change subject: cli_classic: Add option (-A, --noverify-all) ...................................................................... Patch Set 10: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/213/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/225/ : SUCCESS -- To view, visit https://review.coreboot.org/17950 To unsubscribe, visit https://review.coreboot.… [View More]

1 0

Change in flashrom[staging]: Adapt CLI to use new libflashrom interface' print callback
by build bot (Jenkins) (Code Review) 22 Apr '17

22 Apr '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/17948 ) Change subject: Adapt CLI to use new libflashrom interface' print callback ...................................................................... Patch Set 9: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/211/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/222/ : SUCCESS -- To view, visit https://review.coreboot.org/17948 To unsubscribe, visit https://… [View More]

1 0

Change in flashrom[staging]: Add Doxyfile for libflashrom documentation
by build bot (Jenkins) (Code Review) 22 Apr '17

22 Apr '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/17947 ) Change subject: Add Doxyfile for libflashrom documentation ...................................................................... Patch Set 9: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/210/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/223/ : SUCCESS -- To view, visit https://review.coreboot.org/17947 To unsubscribe, visit https://review.coreboot.org/… [View More]

1 0

Change in flashrom[staging]: Add a convenient libflashrom interface
by build bot (Jenkins) (Code Review) 22 Apr '17

22 Apr '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/17946 ) Change subject: Add a convenient libflashrom interface ...................................................................... Patch Set 8: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/209/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/221/ : SUCCESS -- To view, visit https://review.coreboot.org/17946 To unsubscribe, visit https://review.coreboot.org/… [View More]

1 0

Change in flashrom[staging]: Add a convenient libflashrom interface
by Nico Huber (Code Review) 22 Apr '17

22 Apr '17

Hello David Hendricks, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/17946 to look at the new patch set (#8). Change subject: Add a convenient libflashrom interface ...................................................................... Add a convenient libflashrom interface This adds a minimal libflashrom interface based on the draft in the wiki. While the glue code in libflashrom.c is build on top of the existing code instead on … [View More]

1 0

Change in flashrom[staging]: Add option to read ROM layout from IFD
by Nico Huber (Code Review) 22 Apr '17

22 Apr '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/17953 ) Change subject: Add option to read ROM layout from IFD ...................................................................... Patch Set 9: (2 comments) I'm haven't tested if it builds now on non-x86. It should try at least :) https://review.coreboot.org/#/c/17953/7/cli_classic.c File cli_classic.c: PS7, Line 60: " --ifd > Since we only have a few useful single letters available for short opts, … [View More]

1 0

Change in flashrom[staging]: cli_classic: Add option (-A, --noverify-all)
by Nico Huber (Code Review) 22 Apr '17

22 Apr '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/17950 ) Change subject: cli_classic: Add option (-A, --noverify-all) ...................................................................... Patch Set 9: (1 comment) https://review.coreboot.org/#/c/17950/7/cli_classic.c File cli_classic.c: PS7, Line 58: A > I guess I'd prefer 'V' for "verify included". Might be worth asking a few o Well, 'V' is already taken, obviously. Any other suggestions? -- To view, … [View More]

1 0

Change in flashrom[staging]: Add a convenient libflashrom interface
by Nico Huber (Code Review) 22 Apr '17

22 Apr '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/17946 ) Change subject: Add a convenient libflashrom interface ...................................................................... Patch Set 7: (5 comments) https://review.coreboot.org/#/c/17946/6/flashrom.c File flashrom.c: Line 2507: return 1; > Would it make sense to add a wrapper function that calls unmap_flash() and Done It only contains unmap_flash() for now, since this was also the only cleanup … [View More]

1 0

Change in flashrom[staging]: Add functions to read/erase/write/verify by layout
by Nico Huber (Code Review) 22 Apr '17

22 Apr '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/17945 ) Change subject: Add functions to read/erase/write/verify by layout ...................................................................... Patch Set 8: -Code-Review -- To view, visit https://review.coreboot.org/17945 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic6194cea4c4c430e0cf9d586052508a865b09c86 Gerrit-PatchSet: 8 Gerrit-Project: flashrom … [View More]

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit April 2017