March 2017 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[staging]: Add iMac5, 2 to board_enable
by build bot (Jenkins) (Code Review) 22 Mar '17

22 Mar '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18943 ) Change subject: Add iMac5,2 to board_enable ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/38/ : SUCCESS -- To view, visit https://review.coreboot.org/18943 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e4daaa67f98a47e237cd73962776da369c8f0b5 Gerrit-PatchSet: 4 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Add iMac5, 2 to board_enable
by Arthur Heymans (Code Review) 22 Mar '17

22 Mar '17

Hello build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/18943 to look at the new patch set (#4). Change subject: Add iMac5,2 to board_enable ...................................................................... Add iMac5,2 to board_enable When running coreboot everything works, while on vendor bios it fails to erase anything until the 3th erase function of a SST25VF016B is tried. Change-Id: I5e4daaa67f98a47e237cd73962776da369c8f0b5 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M board_enable.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/43/18943/4 -- To view, visit https://review.coreboot.org/18943 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5e4daaa67f98a47e237cd73962776da369c8f0b5 Gerrit-PatchSet: 4 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in flashrom[staging]: Add iMAC5, 2 to board_enable
by build bot (Jenkins) (Code Review) 22 Mar '17

22 Mar '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18943 ) Change subject: Add iMAC5,2 to board_enable ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/37/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/54/ : SUCCESS -- To view, visit https://review.coreboot.org/18943 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e4daaa67f98a47e237cd73962776da369c8f0b5 Gerrit-PatchSet: 3 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Add iMAC5, 2 to board_enable
by Arthur Heymans (Code Review) 22 Mar '17

22 Mar '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/18943 ) Change subject: Add iMAC5,2 to board_enable ...................................................................... Patch Set 2: > (1 comment) > > Please send a log (taken with `-o logfile`) of a run with `-w` > where > something changes (i.e. read/erase/write) to the ML. I don't own this board but this was the output the owner gave me: https://www.flashrom.org/pipermail/flashrom/2016-September/014823.html -- To view, visit https://review.coreboot.org/18943 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e4daaa67f98a47e237cd73962776da369c8f0b5 Gerrit-PatchSet: 2 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Add iMAC5, 2 to board_enable
by Arthur Heymans (Code Review) 22 Mar '17

22 Mar '17

Hello build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/18943 to look at the new patch set (#3). Change subject: Add iMAC5,2 to board_enable ...................................................................... Add iMAC5,2 to board_enable When running coreboot everything works, while on vendor bios it fails to erase anything until the 3th erase function of a SST25VF016B is tried. Change-Id: I5e4daaa67f98a47e237cd73962776da369c8f0b5 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M board_enable.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/43/18943/3 -- To view, visit https://review.coreboot.org/18943 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5e4daaa67f98a47e237cd73962776da369c8f0b5 Gerrit-PatchSet: 3 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in flashrom[staging]: Add iMAC5, 2 to board_enable
by Nico Huber (Code Review) 22 Mar '17

22 Mar '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/18943 ) Change subject: Add iMAC5,2 to board_enable ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Please send a log (taken with `-o logfile`) of a run with `-w` where something changes (i.e. read/erase/write) to the ML. https://review.coreboot.org/#/c/18943/2/board_enable.c File board_enable.c: PS2, Line 2328: NULL, NULL, Please fix the alignment of the double `NULL`. -- To view, visit https://review.coreboot.org/18943 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e4daaa67f98a47e237cd73962776da369c8f0b5 Gerrit-PatchSet: 2 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: Yes

1 0

Change in flashrom[staging]: Add iMAC5, 2 to board_enable
by build bot (Jenkins) (Code Review) 22 Mar '17

22 Mar '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18943 ) Change subject: Add iMAC5,2 to board_enable ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/36/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/53/ : SUCCESS -- To view, visit https://review.coreboot.org/18943 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e4daaa67f98a47e237cd73962776da369c8f0b5 Gerrit-PatchSet: 2 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Add iMAC5, 2 to board_enable
by build bot (Jenkins) (Code Review) 22 Mar '17

22 Mar '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18943 ) Change subject: Add iMAC5,2 to board_enable ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/flashrom_gerrit/52/ : FAILURE https://qa.coreboot.org/job/flashrom-customrules/35/ : SUCCESS -- To view, visit https://review.coreboot.org/18943 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e4daaa67f98a47e237cd73962776da369c8f0b5 Gerrit-PatchSet: 1 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Add iMAC5, 2 to board_enable
by Arthur Heymans (Code Review) 22 Mar '17

22 Mar '17

Arthur Heymans has uploaded a new change for review. ( https://review.coreboot.org/18943 ) Change subject: Add iMAC5,2 to board_enable ...................................................................... Add iMAC5,2 to board_enable When running coreboot everything works, while on vendor bios it fails to erase anything until the 3th erase function of a SST25VF016B is tried. Change-Id: I5e4daaa67f98a47e237cd73962776da369c8f0b5 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M board_enable.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/43/18943/1 diff --git a/board_enable.c b/board_enable.c index 2f0c1c0..6d95a93 100644 --- a/board_enable.c +++ b/board_enable.c @@ -2325,6 +2325,7 @@ {0x1022, 0x2090, 0, 0, 0x1022, 0x2080, 0, 0, NULL, "artecgroup", "dbe62", P3, "Artec Group", "DBE62", 0, OK, board_artecgroup_dbe6x}, {0x8086, 0x27b9, 0xa0a0, 0x0632, 0x8086, 0x27da, 0xa0a0, 0x0632, NULL, NULL, NULL, P3, "AOpen", "i945GMx-VFX", 0, OK, intel_ich_gpio38_raise}, {0x8086, 0x277c, 0xa0a0, 0x060b, 0x8086, 0x27da, 0xa0a0, 0x060b, NULL, NULL, NULL, P3, "AOpen", "i975Xa-YDG", 0, OK, board_aopen_i975xa_ydg}, + {0x8086, 0x27A0, 0x8086, 0x7270, 0x8086, 0x27B9, 0x8086, 0x7270, "^iMac5,2$", NULL, NULL, P2, "Apple", "iMac5,2", 0, OK, p2_whitelist_laptop}, {0x8086, 0x27A0, 0x8086, 0x7270, 0x8086, 0x27B9, 0x8086, 0x7270, "^MacBook2,1$", NULL, NULL, P2, "Apple", "MacBook2,1", 0, OK, p2_whitelist_laptop}, {0x8086, 0x27b8, 0x1849, 0x27b8, 0x8086, 0x27da, 0x1849, 0x27da, "^ConRoeXFire-eSATA2", NULL, NULL, P3, "ASRock", "ConRoeXFire-eSATA2", 0, OK, intel_ich_gpio16_raise}, {0x1022, 0x1536, 0x1849, 0x1536, 0x1022, 0x780e, 0x1849, 0x780e, "^Kabini CRB$", NULL, NULL, P2, "ASRock", "IMB-A180(-H)", 0, OK, p2_not_a_laptop}, -- To view, visit https://review.coreboot.org/18943 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5e4daaa67f98a47e237cd73962776da369c8f0b5 Gerrit-PatchSet: 1 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Change in flashrom[staging]: Remove undefined behavior
by Idwer Vollering (Code Review) 22 Mar '17

22 Mar '17

Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/18792 ) Change subject: Remove undefined behavior ...................................................................... Patch Set 1: Code-Review+2 Build (and runtime) tested with clang v4.0.0+LLVM v4.0.0 on x86_64-unknown-freebsd12.0 -- To view, visit https://review.coreboot.org/18792 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82b6235e11b425fae45eebbe06b08f81c5bdbb98 Gerrit-PatchSet: 1 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit March 2017