November 2017 - flashrom-gerrit

Change in flashrom[master]: spi25: Merge remainder of spi4ba in
by build bot (Jenkins) (Code Review) 08 Nov '17

08 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22388 ) Change subject: spi25: Merge remainder of spi4ba in ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/743/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/853/ : SUCCESS -- To view, visit https://review.coreboot.org/22388 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If581e24347e45cbb27002ea99ffd70e334c110cf Gerrit-Change-Number: 22388 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 08 Nov 2017 22:35:04 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[master]: spi25: Remove now obsolete `four_bytes_addr_funcs` path
by build bot (Jenkins) (Code Review) 08 Nov '17

08 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22386 ) Change subject: spi25: Remove now obsolete `four_bytes_addr_funcs` path ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/742/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/852/ : SUCCESS -- To view, visit https://review.coreboot.org/22386 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb7c576cb159630da2268813388b497cb5f46b43 Gerrit-Change-Number: 22386 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 08 Nov 2017 22:34:58 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[master]: spi4ba: Drop now obsolete, redundant functions
by build bot (Jenkins) (Code Review) 08 Nov '17

08 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22387 ) Change subject: spi4ba: Drop now obsolete, redundant functions ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/741/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/851/ : SUCCESS -- To view, visit https://review.coreboot.org/22387 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d04448fd1acbfc37b8e17288f497a4292dfd6d6 Gerrit-Change-Number: 22387 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 08 Nov 2017 22:34:52 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[master]: spi25: Remove now obsolete `four_bytes_addr_funcs` path
by Nico Huber (Code Review) 08 Nov '17

08 Nov '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/22386 to look at the new patch set (#2). Change subject: spi25: Remove now obsolete `four_bytes_addr_funcs` path ...................................................................... spi25: Remove now obsolete `four_bytes_addr_funcs` path Change-Id: Idb7c576cb159630da2268813388b497cb5f46b43 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M flash.h M flashchips.c M flashrom.c M spi25.c 4 files changed, 22 insertions(+), 76 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/86/22386/2 -- To view, visit https://review.coreboot.org/22386 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Idb7c576cb159630da2268813388b497cb5f46b43 Gerrit-Change-Number: 22386 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[staging]: spi25: Merge remainder of spi4ba in
by Nico Huber (Code Review) 08 Nov '17

08 Nov '17

Nico Huber has abandoned this change. ( https://review.coreboot.org/22024 ) Change subject: spi25: Merge remainder of spi4ba in ...................................................................... Abandoned Update pushed for master. -- To view, visit https://review.coreboot.org/22024 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: abandon Gerrit-Change-Id: If581e24347e45cbb27002ea99ffd70e334c110cf Gerrit-Change-Number: 22024 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[staging]: spi4ba: Drop now obsolete redundant functions
by Nico Huber (Code Review) 08 Nov '17

08 Nov '17

Nico Huber has abandoned this change. ( https://review.coreboot.org/22023 ) Change subject: spi4ba: Drop now obsolete redundant functions ...................................................................... Abandoned Update pushed for master. -- To view, visit https://review.coreboot.org/22023 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: abandon Gerrit-Change-Id: I1d04448fd1acbfc37b8e17288f497a4292dfd6d6 Gerrit-Change-Number: 22023 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[staging]: spi25: Remove now obsolete `four_bytes_addr_funcs` path
by Nico Huber (Code Review) 08 Nov '17

08 Nov '17

Nico Huber has abandoned this change. ( https://review.coreboot.org/22022 ) Change subject: spi25: Remove now obsolete `four_bytes_addr_funcs` path ...................................................................... Abandoned Update pushed for master. -- To view, visit https://review.coreboot.org/22022 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: abandon Gerrit-Change-Id: Idb7c576cb159630da2268813388b497cb5f46b43 Gerrit-Change-Number: 22022 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[staging]: spi25: Remove now obsolete `four_bytes_addr_funcs` path
by Nico Huber (Code Review) 08 Nov '17

08 Nov '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/22022 ) Change subject: spi25: Remove now obsolete `four_bytes_addr_funcs` path ...................................................................... Patch Set 1: (2 comments) https://review.coreboot.org/#/c/22022/1/spi25.c File spi25.c: https://review.coreboot.org/#/c/22022/1/spi25.c@682 PS1, Line 682: while (spi_read_status_register(flash) & SPI_SR_WIP) : programmer_delay(10); > remove Done https://review.coreboot.org/#/c/22022/1/spi25.c@708 PS1, Line 708: while (spi_read_status_register(flash) & SPI_SR_WIP) : programmer_delay(10); > remove Done -- To view, visit https://review.coreboot.org/22022 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Idb7c576cb159630da2268813388b497cb5f46b43 Gerrit-Change-Number: 22022 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 08 Nov 2017 22:18:14 +0000 Gerrit-HasComments: Yes

1 0

Change in flashrom[staging]: spi25: Enable direct 4BA read and write using feature bits
by Nico Huber (Code Review) 08 Nov '17

08 Nov '17

Nico Huber has abandoned this change. ( https://review.coreboot.org/22021 ) Change subject: spi25: Enable direct 4BA read and write using feature bits ...................................................................... Abandoned Update pushed for master. -- To view, visit https://review.coreboot.org/22021 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: abandon Gerrit-Change-Id: I2f6817ca198bf923671a7aa67e956e5477d71848 Gerrit-Change-Number: 22021 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[staging]: spi25: Enable direct 4BA read and write using feature bits
by Nico Huber (Code Review) 08 Nov '17

08 Nov '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/22021 ) Change subject: spi25: Enable direct 4BA read and write using feature bits ...................................................................... Patch Set 1: (2 comments) https://review.coreboot.org/#/c/22021/1/spi25.c File spi25.c: https://review.coreboot.org/#/c/22021/1/spi25.c@582 PS1, Line 582: JEDEC_BYTE_PROGRAM_4BA > So this will use a native 4BA instruction whether or not you use the extend Done https://review.coreboot.org/#/c/22021/1/spi25.c@592 PS1, Line 592: JEDEC_READ_4BA > same comment as above Done -- To view, visit https://review.coreboot.org/22021 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I2f6817ca198bf923671a7aa67e956e5477d71848 Gerrit-Change-Number: 22021 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 08 Nov 2017 22:17:50 +0000 Gerrit-HasComments: Yes

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit November 2017