Re: [flashrom] [PATCH] Fix wrong density encoding on Intel Silvermont.

[Stefan Tauner]

On Mon, 5 Jan 2015 15:41:13 +0800
"Tai-Hong (Type) Wu"  wrote:
>   Thanks for the review and remedy.
>   Certainly, I will again verify the patch once it being committed into
>
> official svn-stream  (Looks not in r1860 yet?)
>       and/or 0.9.8-release.

OK, I normally prefer tests before committing anything, but I hope
there won't be a problem here. I have committed the change in r1861.
Thanks for your help!

[PATCH] Fix wrong density encoding on Intel Silvermont.

[Tai-Hong (Type) Wu]

Update 01/06:
=> Verified, r1861 looks OK at Rangeley dual flash platforms;
     and the regression of single flash remained OK as well.

------------------------------------------
*r1861 (Dual Flash, 2*16 MB)*
------------------------------------------
Probing for Programmer Opaque flash chip, 0 kB: Found 2 attached SPI flash
chips with a combined density of 32768 kB.
There is only one partition containing the whole address space (0x000000 -
0x1ffffff).
There are 8192 erase blocks with 4096 B each.
Found Programmer flash chip "Opaque flash chip" (32768 kB,
Programmer-specific) mapped at physical address 0x0000000000000000.
Found Programmer flash chip "Opaque flash chip" (32768 kB,
Programmer-specific).
Reading flash... Reading 33554432 bytes starting at 0x000000.

------------------------------------------
*r1860 (Dual Flash, 2*16 MB)*
------------------------------------------
Density of ICH SPI component with index 0 is invalid.Encoded density is 0xd
while maximum allowed is 0x7.
Could not determine density of flash component 0.
FAILED!
FATAL ERROR!

------------------------------------------
*r1861 (Single Flash, 1*8 MB)*
------------------------------------------
Found Programmer flash chip "Opaque flash chip" (8192 kB,
Programmer-specific).
Reading flash... Reading 8388608 bytes starting at 0x000000.

------------------------------------------
*r1860 (Single Flash, 1*8 MB)*
------------------------------------------
Found Programmer flash chip "Opaque flash chip" (8192 kB,
Programmer-specific).
Reading flash... Reading 8388608 bytes starting at 0x000000

2015-01-06 7:01 GMT+08:00 Stefan Tauner :
> On Mon, 5 Jan 2015 15:41:13 +0800
> "Tai-Hong (Type) Wu"  wrote:
> >   Thanks for the review and remedy.
> >   Certainly, I will again verify the patch once it being committed
>
> into
> > official svn-stream  (Looks not in r1860 yet?)
> >       and/or 0.9.8-release.
>
> OK, I normally prefer tests before committing anything, but I hope
> there won't be a problem here. I have committed the change in r1861.
> Thanks for your help!