[PATCH] New GigaDevice chips and tiny pastebug fix

[Роман Титов]

Few days ago stefanct, gave me a bunch of datasheets for GigaDevice 
chips, so I could get me way into flashrom.

Here is 2 pathces. One with GigaDevice chips support and one with a fix 
to *PROBABLE* pastebug in AMIC A25LQ64 chip definition, which I found 
earlier.

I never used mailing lists and not sure about mime64 attachments, so 
archive with datasheets can be found here: 
https://www.dropbox.com/s/sk5mecwj7e4z4t3/GIGADEVICE_GD25LQ.tar.bz2?dl=0

[Stefan Tauner]

On Fri, 06 Mar 2015 17:51:11 +1000
Роман Титов  wrote:
> one with a fix 
> to *PROBABLE* pastebug in AMIC A25LQ64 chip definition, which I found 
> earlier.

Hi Roman,

thanks for that! It looks indeed like this has been there since we
added "support" for the chip in 2013. I will commit this later together
with other small changes.

[PATCH] New GigaDevice chips

[Stefan Tauner]

On Fri, 06 Mar 2015 17:51:11 +1000
Роман Титов  wrote:
> One with GigaDevice chips support

Hi,

the patch looks syntactically ok but does not apply *cleanly* with
git-am. Against which revision did you create it? The git hash in the
patch suggests that it is against r1886-r1888 but I tried that...

Patching with patch instead of git-am works (thanks to some fuzzying),
but I was wondering what was causing that...?

[PATCH] New GigaDevice chips

[Roman Titov]

Well, I think this could be the result of my inexperience with svn
(and git-svn).

So, here's my steps:
1. git svn clone -rHEAD (r1887, to be exact) flashrom-trunk (I have an
error, when I'm trying to make full git svn clone, looks like git bug
:/)
2. *code*
3. make 2 local commits
4. git format-patch, and it throw me 2 patches for 2 latest commits
not over current origin (and I think thats is the reason)
5. send patches to mailing list

My suggestions would be:
1. shallow copying broke smth (idea, that git svn could bond git stuff
to full svn history stuff came to me just right now)
2. formating 2 patches broke smth
3. both?

2015-03-09 8:24 GMT+10:00 Stefan Tauner :
> On Fri, 06 Mar 2015 17:51:11 +1000
> Роман Титов  wrote:
> > One with GigaDevice chips support
>
> Hi,
>
> the patch looks syntactically ok but does not apply *cleanly* with
> git-am. Against which revision did you create it? The git hash in the
> patch suggests that it is against r1886-r1888 but I tried that...
>
> Patching with patch instead of git-am works (thanks to some fuzzying),
> but I was wondering what was causing that...?