Re: [flashrom] [PATCH] print out flash chip found after probing loop in verbose mode

[Uwe Hermann]

On Thu, Sep 08, 2011 at 11:44:23PM +0200, Stefan Tauner wrote:
> Signed-off-by: Stefan Tauner

Acked-by: Uwe Hermann

Useful IMHO, and works fine (no double-prints without -V or -VV or -VVV).

Uwe.

[PATCH] print out flash chip found after probing loop in verbose mode

[Stefan Tauner]

On Sun, 11 Sep 2011 16:23:13 +0200
Uwe Hermann  wrote:
> On Thu, Sep 08, 2011 at 11:44:23PM +0200, Stefan Tauner wrote:
> > Signed-off-by: Stefan Tauner
>
> Acked-by: Uwe Hermann
>
> Useful IMHO, and works fine (no double-prints without -V or -VV or -VVV).

thanks.
it had a major problem with -f. it would print "Assuming..." then
although nothing was assumed but a/the chip was really found. if a chip
is force we could never arrived there and the variable force does not
indicate assumption at all.

carldani does not veto this one, but is not too happy with it. while i
agree that duplicating code AND output is not a good idea in general it
is an improvement in this case. hopefully we can get rid of it again
later, when verbosely probing is less verbose.

committed in r1436.