Re: Support for GD25LR512ME flash chip.

[Anastasia Klimchuk]

Victor,

Thank you so much for the datasheets! I did a review of the pending
patch, and now it will be possible to finally finish the patch from
2021 and get the chips submitted.

Also thank you for attaching the log.

Not sure if the log is complete? It ends at the start of the reading
operation, but there is no final message of SUCCESS or FAIL.

However, importantly, I could see in the beginning of the log which
platform was detected, and it is Promontory. Which means...

Avinash,

Most likely you are hitting a known issue, you can read more details
here: https://ticket.coreboot.org/issues/370
The issue is for Promontory, and also for chips larger than 16Mbyte:
which is exactly what you have.

I was actually trying to get help from AMD with this issue, so it's
really good to have you here on the mailing list! Maybe you can help?

Someone from AMD would be in the best position to fix Promontory, you
have all the datasheets available, and all the hardware.

Thank you!

On Sat, May 11, 2024 at 9:40 PM Vlim  wrote:
> Hi, Anastasia,
>
> Please find the attached datasheet for GD25LR256E and GD25LR512ME.
>
> There are actually two issues.
>
> the released flashrom does not support GD25LR256E and GD25LR512ME.
> With my patch, the dediprog programmer works for GD25LR512ME. But the AMD internal programmer for Birman Plus Board does not work. Output file attached.
>
> This is the comment about Birman Plus Board
>
> Now, Flashrom can detect the flash chip.
> Using dediprog programmer I can read/write the flash chip successfully.
> Whereas with using the internal programmer i.e. "-p internal" the read/write is failing. I am attaching the log here.
> Please give your input on this.
>
> Regards,
>
> Victor
>
> From: Anastasia Klimchuk 
> Sent: Saturday, May 11, 2024 17:59
> To: Vlim ; Munduru, Avinash 
> Cc: [e-mail] 
> Subject: Re: [flashrom] Re: Support for GD25LR512ME flash chip.
>
> 此为外部邮件，谨防钓鱼邮件，请注意邮件是否涉及敏感信息
> This is an external email, beware of phishing emails. Please pay close attention to whether the email contains sensitive information
>
> There is another thing, in addition to my previous message.
>
> I looked into the patch which adds chip definitions (this one
> https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Freview.cor...) and the reason it is
> pending is there are no links to datasheets (old links are not working
> anymore).
> It is unfortunate that the patch is pending since 2021, but I want to
> try to fix the situation now, in the year 2024.
>
> Victor, maybe you know, is it possible to find datasheets for
> GD25LR256E and GD251R512ME? I could finish the old patch and get chips
> into the tree.
>
> This is a separate question to Avinash's issue with internal
> programmer, but for this we need the very verbose log (which is log
> with -VVV option on command line).
>
> Thank you!
>
> On Thu, May 9, 2024 at 11:03 PM Anastasia Klimchuk  wrote:
> > Avinash, I read the thread and I see you are saying "I am attaching
> > the log here" but I don't see the log? maybe you can re-send it again,
> > now with the mailing list? (perhaps you sent it to Victor only?)
> > Yes it is also important to know your board, since you are saying the
> > chip worked successfully with dediprog, but not with the internal
> > programmer.
> >
> > Victor, thank you so much for helping!
> >
> > On Mon, May 6, 2024 at 6:42 PM Vlim  wrote:
> > > Thanks, Avinash,
> > >
> > > Can you advise which board are you using?
> > > I have tested this patch with the USB programmer only since I do not have access to the motherboard.
> > >
> > > Hi, Flashrom team,
> > > Can you also help on this?
> > >
> > > Regards,
> > >
> > > Victor Lim
> > > FAE Director
> > > GigaDevice Semiconductor
> > > 4088833856
> > > [e-mail]
> > >
> > > From: Munduru, Avinash 
> > > Sent: Monday, May 6, 2024 16:24
> > > To: Vlim ; [e-mail] 
> > > Subject: Re: Support for GD25LR512ME flash chip.
> > >
> > > You don't often get email from [e-mail]. Learn why this is important
> > > 此为外部邮件，谨防钓鱼邮件，请注意邮件是否涉及敏感信息
> > > This is an external email, beware of phishing emails. Please pay close attention to whether the email contains sensitive information
> > >
> > > [AMD Official Use Only - General]
> > >
> > > Hi Victor,
> > >
> > > Thanks for sharing the patch. Here is an update after trying the shared patch.
> > >
> > > Now, Flashrom can detect the flash chip.
> > > Using dediprog programmer I can read/write the flash chip successfully.
> > > Whereas with using the internal programmer i.e. "-p internal" the read/write is failing. I am attaching the log here.
> > > Please give your input on this.
> > >
> > > Once again! Thanks for your help!
> > >
> > > From: Vlim 
> > > Sent: Sunday, May 5, 2024 1:54 PM
> > > To: [e-mail] ; Munduru, Avinash 
> > > Subject: Re: Support for GD25LR512ME flash chip.
> > >
> > > Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
> > >
> > > Hi, Avinash,
> > >
> > > Sorry that I am working on adding this part to Flashrom, but has not completed the entire process.
> > >
> > > Can you please use the attached flashchips.c and flashshchips.h and replace that in flashrom distribution?
> > >
> > > This is the process.
> > >
> > > git clone "https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Freview.cor..."
> > >
> > > meson setup builddir
> > > meson compile -C builddir
> > > meson test -C builddir
> > > meson install -C builddir
> > >
> > > Please also refer to the following link for compilation of the code.
> > > https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fflashrom.o...
> > >
> > > I have a compiled version for Ubuntu Linux, if that will help, I can share with you.
> > >
> > > Regards,
> > >
> > > Victor Lim
> > > GigaDevice Semiconductors Inc.
> > > 4088833856
> > > [e-mail]
> > >
> > > From: Munduru, Avinash via flashrom 
> > > Sent: Tuesday, April 30, 2024 16:54
> > > To: [e-mail] 
> > > Subject: [flashrom] Re: Support for GD25LR512ME flash chip.
> > >
> > > 此为外部邮件，谨防钓鱼邮件，请注意邮件是否涉及敏感信息
> > > This is an external email, beware of phishing emails. Please pay close attention to whether the email contains sensitive information
> > >
> > > [AMD Official Use Only - General]
> > > attaching the output log
> > >
> > > From: Munduru, Avinash
> > > Sent: Tuesday, April 30, 2024 2:04 PM
> > > To: [e-mail] 
> > > Subject: Support for GD25LR512ME flash chip.
> > >
> > > Hi,
> > >
> > > Currently, flash chip support for GD25LR512ME is not supported in flashrom utility.
> > > Please share a patch if it is already available. If not let me know how I can modify it.
> > >
> > > flashrom mailing list -- [e-mail]
> > > To unsubscribe send an email to [e-mail]

Support for GD25LR512ME flash chip.

[Munduru, Avinash]

[AMD Official Use Only - AMD Internal Distribution Only]

Hi,

Thanks for all your help. I have an update.

We came up with a 16MB ROM file booting with AMD-BirmanPlus board with 64MB flash chip size.
I would like to know if there is any way to flash 16MB ROM file to the GD25LR512ME flash chip using the internal programmer.

Thanks in advance!

Regards,
Avinash.

________________________________
From: Anastasia Klimchuk 
Sent: Tuesday, May 14, 2024 5:05 PM
To: Vlim ; Munduru, Avinash ; [e-mail] 
Subject: Re: [flashrom] Re: Support for GD25LR512ME flash chip.

Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.

Victor,

Thank you so much for the datasheets! I did a review of the pending
patch, and now it will be possible to finally finish the patch from
2021 and get the chips submitted.

Also thank you for attaching the log.

Not sure if the log is complete? It ends at the start of the reading
operation, but there is no final message of SUCCESS or FAIL.

However, importantly, I could see in the beginning of the log which
platform was detected, and it is Promontory. Which means...

Avinash,

Most likely you are hitting a known issue, you can read more details
here: https://ticket.coreboot.org/issues/370
The issue is for Promontory, and also for chips larger than 16Mbyte:
which is exactly what you have.

I was actually trying to get help from AMD with this issue, so it's
really good to have you here on the mailing list! Maybe you can help?

Someone from AMD would be in the best position to fix Promontory, you
have all the datasheets available, and all the hardware.

Thank you!

On Sat, May 11, 2024 at 9:40 PM Vlim  wrote:
> Hi, Anastasia,
>
> Please find the attached datasheet for GD25LR256E and GD25LR512ME.
>
> There are actually two issues.
>
> the released flashrom does not support GD25LR256E and GD25LR512ME.
> With my patch, the dediprog programmer works for GD25LR512ME. But the AMD internal programmer for Birman Plus Board does not work. Output file attached.
>
> This is the comment about Birman Plus Board
>
> Now, Flashrom can detect the flash chip.
> Using dediprog programmer I can read/write the flash chip successfully.
> Whereas with using the internal programmer i.e. "-p internal" the read/write is failing. I am attaching the log here.
> Please give your input on this.
>
> Regards,
>
> Victor
>
> From: Anastasia Klimchuk 
> Sent: Saturday, May 11, 2024 17:59
> To: Vlim ; Munduru, Avinash 
> Cc: [e-mail] 
> Subject: Re: [flashrom] Re: Support for GD25LR512ME flash chip.
>
> 此为外部邮件，谨防钓鱼邮件，请注意邮件是否涉及敏感信息
> This is an external email, beware of phishing emails. Please pay close attention to whether the email contains sensitive information
>
> There is another thing, in addition to my previous message.
>
> I looked into the patch which adds chip definitions (this one
> https://review.coreboot.org/c/flashrom/+/58025) and the reason it is
> pending is there are no links to datasheets (old links are not working
> anymore).
> It is unfortunate that the patch is pending since 2021, but I want to
> try to fix the situation now, in the year 2024.
>
> Victor, maybe you know, is it possible to find datasheets for
> GD25LR256E and GD251R512ME? I could finish the old patch and get chips
> into the tree.
>
> This is a separate question to Avinash's issue with internal
> programmer, but for this we need the very verbose log (which is log
> with -VVV option on command line).
>
> Thank you!
>
> On Thu, May 9, 2024 at 11:03 PM Anastasia Klimchuk  wrote:
> > Avinash, I read the thread and I see you are saying "I am attaching
> > the log here" but I don't see the log? maybe you can re-send it again,
> > now with the mailing list? (perhaps you sent it to Victor only?)
> > Yes it is also important to know your board, since you are saying the
> > chip worked successfully with dediprog, but not with the internal
> > programmer.
> >
> > Victor, thank you so much for helping!
> >
> > On Mon, May 6, 2024 at 6:42 PM Vlim  wrote:
> > > Thanks, Avinash,
> > >
> > > Can you advise which board are you using?
> > > I have tested this patch with the USB programmer only since I do not have access to the motherboard.
> > >
> > > Hi, Flashrom team,
> > > Can you also help on this?
> > >
> > > Regards,
> > >
> > > Victor Lim
> > > FAE Director
> > > GigaDevice Semiconductor
> > > 4088833856
> > > [e-mail]
> > >
> > > From: Munduru, Avinash 
> > > Sent: Monday, May 6, 2024 16:24
> > > To: Vlim ; [e-mail] 
> > > Subject: Re: Support for GD25LR512ME flash chip.
> > >
> > > You don't often get email from [e-mail]. Learn why this is important
> > > 此为外部邮件，谨防钓鱼邮件，请注意邮件是否涉及敏感信息
> > > This is an external email, beware of phishing emails. Please pay close attention to whether the email contains sensitive information
> > >
> > > [AMD Official Use Only - General]
> > >
> > > Hi Victor,
> > >
> > > Thanks for sharing the patch. Here is an update after trying the shared patch.
> > >
> > > Now, Flashrom can detect the flash chip.
> > > Using dediprog programmer I can read/write the flash chip successfully.
> > > Whereas with using the internal programmer i.e. "-p internal" the read/write is failing. I am attaching the log here.
> > > Please give your input on this.
> > >
> > > Once again! Thanks for your help!
> > >
> > > From: Vlim 
> > > Sent: Sunday, May 5, 2024 1:54 PM
> > > To: [e-mail] ; Munduru, Avinash 
> > > Subject: Re: Support for GD25LR512ME flash chip.
> > >
> > > Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
> > >
> > > Hi, Avinash,
> > >
> > > Sorry that I am working on adding this part to Flashrom, but has not completed the entire process.
> > >
> > > Can you please use the attached flashchips.c and flashshchips.h and replace that in flashrom distribution?
> > >
> > > This is the process.
> > >
> > > git clone "https://review.coreboot.org/flashrom"
> > >
> > > meson setup builddir
> > > meson compile -C builddir
> > > meson test -C builddir
> > > meson install -C builddir
> > >
> > > Please also refer to the following link for compilation of the code.
> > > https://flashrom.org/dev_guide/building_from_source.html
> > >
> > > I have a compiled version for Ubuntu Linux, if that will help, I can share with you.
> > >
> > > Regards,
> > >
> > > Victor Lim
> > > GigaDevice Semiconductors Inc.
> > > 4088833856
> > > [e-mail]
> > >
> > > From: Munduru, Avinash via flashrom 
> > > Sent: Tuesday, April 30, 2024 16:54
> > > To: [e-mail] 
> > > Subject: [flashrom] Re: Support for GD25LR512ME flash chip.
> > >
> > > 此为外部邮件，谨防钓鱼邮件，请注意邮件是否涉及敏感信息
> > > This is an external email, beware of phishing emails. Please pay close attention to whether the email contains sensitive information
> > >
> > > [AMD Official Use Only - General]
> > > attaching the output log
> > >
> > > From: Munduru, Avinash
> > > Sent: Tuesday, April 30, 2024 2:04 PM
> > > To: [e-mail] 
> > > Subject: Support for GD25LR512ME flash chip.
> > >
> > > Hi,
> > >
> > > Currently, flash chip support for GD25LR512ME is not supported in flashrom utility.
> > > Please share a patch if it is already available. If not let me know how I can modify it.
> > >
> > > flashrom mailing list -- [e-mail]
> > > To unsubscribe send an email to [e-mail]

Support for GD25LR512ME flash chip.

[Anastasia Klimchuk]

Hello Avinash,

Sorry for some delay in response. I was also thinking, what's useful
that I could tell you.

I understand your idea to shrink the image to 16MB, so that work
around the bug which affects images >16MB. However, flashrom checks
whether the size of the image is the same as the size of the chip
(should throw an error if not). So to write 16MB onto GD25LR512ME
which is 64MB, you would need to pad the file, with zeros usually, to
make the file 64MB.
I don't know whether it would work. Is it possible that you would try
(if you have tools to recover your device from failure of course)? Or
perhaps you have tried already?

On the other hand, some good news: support for chips GD25LR256E,
GD251R512ME has been submitted meanwhile. So no need for patching
anymore, the patch linked earlier in the thread is merged into main.

Support for GD25LR512ME flash chip.

[Anastasia Klimchuk]

As a quick addition to my previous message:

What you also can try, is to create a layout file with the region of
size 16MB, and then set the option to only write this region. The area
outside the region will not be modified.
If you decide to go this way, please read manpage, especially -l and
-i options https://flashrom.org/classic_cli_manpage.html

On Fri, Jun 14, 2024 at 12:22 PM Anastasia Klimchuk  wrote:
> Hello Avinash,
>
> Sorry for some delay in response. I was also thinking, what's useful
> that I could tell you.
>
> I understand your idea to shrink the image to 16MB, so that work
> around the bug which affects images >16MB. However, flashrom checks
> whether the size of the image is the same as the size of the chip
> (should throw an error if not). So to write 16MB onto GD25LR512ME
> which is 64MB, you would need to pad the file, with zeros usually, to
> make the file 64MB.
> I don't know whether it would work. Is it possible that you would try
> (if you have tools to recover your device from failure of course)? Or
> perhaps you have tried already?
>
> On the other hand, some good news: support for chips GD25LR256E,
> GD251R512ME has been submitted meanwhile. So no need for patching
> anymore, the patch linked earlier in the thread is merged into main.

Support for GD25LR512ME flash chip.

[Munduru, Avinash]

[AMD Official Use Only - AMD Internal Distribution Only]

Hi Anastasia,

Thanks for your input I will try looking into this possible solution.

I already tried the padding solution but it did not work.

Once again, thank you for mainlining the patch.

Regards,
Avinash.

Get Outlook for iOShttps://aka.ms/o0ukef
________________________________
From: Anastasia Klimchuk 
Sent: Friday, June 14, 2024 8:11:00 PM
To: Munduru, Avinash 
Cc: Vlim ; [e-mail] 
Subject: Re: [flashrom] Re: Support for GD25LR512ME flash chip.

Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.

As a quick addition to my previous message:

What you also can try, is to create a layout file with the region of
size 16MB, and then set the option to only write this region. The area
outside the region will not be modified.
If you decide to go this way, please read manpage, especially -l and
-i options https://flashrom.org/classic_cli_manpage.html

On Fri, Jun 14, 2024 at 12:22 PM Anastasia Klimchuk  wrote:
> Hello Avinash,
>
> Sorry for some delay in response. I was also thinking, what's useful
> that I could tell you.
>
> I understand your idea to shrink the image to 16MB, so that work
> around the bug which affects images >16MB. However, flashrom checks
> whether the size of the image is the same as the size of the chip
> (should throw an error if not). So to write 16MB onto GD25LR512ME
> which is 64MB, you would need to pad the file, with zeros usually, to
> make the file 64MB.
> I don't know whether it would work. Is it possible that you would try
> (if you have tools to recover your device from failure of course)? Or
> perhaps you have tried already?
>
> On the other hand, some good news: support for chips GD25LR256E,
> GD251R512ME has been submitted meanwhile. So no need for patching
> anymore, the patch linked earlier in the thread is merged into main.

Support for GD25LR512ME flash chip.

[Munduru, Avinash]

[AMD Official Use Only - AMD Internal Distribution Only]

+Ritul

Regards,
Avinash.
Get Outlook for iOShttps://aka.ms/o0ukef
________________________________
From: Munduru, Avinash 
Sent: Saturday, June 15, 2024 2:14 AM
To: Anastasia Klimchuk 
Cc: Vlim ; [e-mail] 
Subject: Re: [flashrom] Re: Support for GD25LR512ME flash chip.

Hi Anastasia,

Thanks for your input I will try looking into this possible solution.

I already tried the padding solution but it did not work.

Once again, thank you for mainlining the patch.

Regards,
Avinash.

Get Outlook for iOShttps://aka.ms/o0ukef
________________________________
From: Anastasia Klimchuk 
Sent: Friday, June 14, 2024 8:11:00 PM
To: Munduru, Avinash 
Cc: Vlim ; [e-mail] 
Subject: Re: [flashrom] Re: Support for GD25LR512ME flash chip.

Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.

As a quick addition to my previous message:

What you also can try, is to create a layout file with the region of
size 16MB, and then set the option to only write this region. The area
outside the region will not be modified.
If you decide to go this way, please read manpage, especially -l and
-i options https://flashrom.org/classic_cli_manpage.html

On Fri, Jun 14, 2024 at 12:22 PM Anastasia Klimchuk  wrote:
> Hello Avinash,
>
> Sorry for some delay in response. I was also thinking, what's useful
> that I could tell you.
>
> I understand your idea to shrink the image to 16MB, so that work
> around the bug which affects images >16MB. However, flashrom checks
> whether the size of the image is the same as the size of the chip
> (should throw an error if not). So to write 16MB onto GD25LR512ME
> which is 64MB, you would need to pad the file, with zeros usually, to
> make the file 64MB.
> I don't know whether it would work. Is it possible that you would try
> (if you have tools to recover your device from failure of course)? Or
> perhaps you have tried already?
>
> On the other hand, some good news: support for chips GD25LR256E,
> GD251R512ME has been submitted meanwhile. So no need for patching
> anymore, the patch linked earlier in the thread is merged into main.

Support for GD25LR512ME flash chip.

[Guru, Ritul]

[AMD Official Use Only - AMD Internal Distribution Only]

Hi Avinash,
How did you try to pad the the 16MB file?

Hi Anastasia,
Is there any plan to support 64MB flashing enabled in flashrom for this SPIROM with internal programming?

Thanks,
Ritul

From: Munduru, Avinash 
Sent: Wednesday, June 19, 2024 11:45 PM
To: Anastasia Klimchuk 
Cc: Vlim ; [e-mail]; Guru, Ritul 
Subject: Re: [flashrom] Re: Support for GD25LR512ME flash chip.

[AMD Official Use Only - AMD Internal Distribution Only]

+Ritul

Regards,
Avinash.
Get Outlook for iOShttps://aka.ms/o0ukef
________________________________
From: Munduru, Avinash <[e-mail]>
Sent: Saturday, June 15, 2024 2:14 AM
To: Anastasia Klimchuk <[e-mail]>
Cc: Vlim <[e-mail]>; [e-mail] <[e-mail]>
Subject: Re: [flashrom] Re: Support for GD25LR512ME flash chip.

Hi Anastasia,

Thanks for your input I will try looking into this possible solution.

I already tried the padding solution but it did not work.

Once again, thank you for mainlining the patch.

Regards,
Avinash.

Get Outlook for iOShttps://aka.ms/o0ukef
________________________________
From: Anastasia Klimchuk <[e-mail]>
Sent: Friday, June 14, 2024 8:11:00 PM
To: Munduru, Avinash <[e-mail]>
Cc: Vlim <[e-mail]>; [e-mail] <[e-mail]>
Subject: Re: [flashrom] Re: Support for GD25LR512ME flash chip.

Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.

As a quick addition to my previous message:

What you also can try, is to create a layout file with the region of
size 16MB, and then set the option to only write this region. The area
outside the region will not be modified.
If you decide to go this way, please read manpage, especially -l and
-i options https://flashrom.org/classic_cli_manpage.html

On Fri, Jun 14, 2024 at 12:22 PM Anastasia Klimchuk <[e-mail]> wrote:
> Hello Avinash,
>
> Sorry for some delay in response. I was also thinking, what's useful
> that I could tell you.
>
> I understand your idea to shrink the image to 16MB, so that work
> around the bug which affects images >16MB. However, flashrom checks
> whether the size of the image is the same as the size of the chip
> (should throw an error if not). So to write 16MB onto GD25LR512ME
> which is 64MB, you would need to pad the file, with zeros usually, to
> make the file 64MB.
> I don't know whether it would work. Is it possible that you would try
> (if you have tools to recover your device from failure of course)? Or
> perhaps you have tried already?
>
> On the other hand, some good news: support for chips GD25LR256E,
> GD251R512ME has been submitted meanwhile. So no need for patching
> anymore, the patch linked earlier in the thread is merged into main.

Support for GD25LR512ME flash chip.

[Anastasia Klimchuk]

Hi Ritul,

Nice to meet you! It's really good to have you on this thread.

My plan for the issue is to find someone from AMD who can fix the
issue. I mentioned this earlier in this thread :) It would be really
great if you could help?

I think someone from AMD would be in the best position to fix the
issue, you have all the datasheets available and all the hardware.
It seems from the thread you are hitting the issue during a
development process, so perhaps this can be a justification for why
this is needed for business, and why to allocate resources to fix it.

Some time ago I wrote this doc, maybe it can be useful
https://flashrom.org/how_to_support_flashrom.html#special-appeal-for-compani...
Count this as an official invitation to contribute!

Thank you for your help

About possible workarounds, I think writing only one layout region has
some chances to work.

On Thu, Jun 20, 2024 at 4:27 AM Guru, Ritul  wrote:
> [AMD Official Use Only - AMD Internal Distribution Only]
>
> Hi Avinash,
>
> How did you try to pad the the 16MB file?
>
> Hi Anastasia,
>
> Is there any plan to support 64MB flashing enabled in flashrom for this SPIROM with internal programming?
>
> Thanks,
>
> Ritul
>
> From: Munduru, Avinash 
> Sent: Wednesday, June 19, 2024 11:45 PM
> To: Anastasia Klimchuk 
> Cc: Vlim ; [e-mail]; Guru, Ritul 
> Subject: Re: [flashrom] Re: Support for GD25LR512ME flash chip.
>
> [AMD Official Use Only - AMD Internal Distribution Only]
>
> +Ritul
>
> Regards,
>
> Avinash.
>
> Get Outlook for iOS
>
> From: Munduru, Avinash 
> Sent: Saturday, June 15, 2024 2:14 AM
> To: Anastasia Klimchuk 
> Cc: Vlim ; [e-mail] 
> Subject: Re: [flashrom] Re: Support for GD25LR512ME flash chip.
>
> Hi Anastasia,
>
> Thanks for your input I will try looking into this possible solution.
>
> I already tried the padding solution but it did not work.
>
> Once again, thank you for mainlining the patch.
>
> Regards,
>
> Avinash.
>
> Get Outlook for iOS
>
> From: Anastasia Klimchuk 
> Sent: Friday, June 14, 2024 8:11:00 PM
> To: Munduru, Avinash 
> Cc: Vlim ; [e-mail] 
> Subject: Re: [flashrom] Re: Support for GD25LR512ME flash chip.
>
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>
> As a quick addition to my previous message:
>
> What you also can try, is to create a layout file with the region of
> size 16MB, and then set the option to only write this region. The area
> outside the region will not be modified.
> If you decide to go this way, please read manpage, especially -l and
> -i options https://flashrom.org/classic_cli_manpage.html
>
> On Fri, Jun 14, 2024 at 12:22 PM Anastasia Klimchuk  wrote:
> > Hello Avinash,
> >
> > Sorry for some delay in response. I was also thinking, what's useful
> > that I could tell you.
> >
> > I understand your idea to shrink the image to 16MB, so that work
> > around the bug which affects images >16MB. However, flashrom checks
> > whether the size of the image is the same as the size of the chip
> > (should throw an error if not). So to write 16MB onto GD25LR512ME
> > which is 64MB, you would need to pad the file, with zeros usually, to
> > make the file 64MB.
> > I don't know whether it would work. Is it possible that you would try
> > (if you have tools to recover your device from failure of course)? Or
> > perhaps you have tried already?
> >
> > On the other hand, some good news: support for chips GD25LR256E,
> > GD251R512ME has been submitted meanwhile. So no need for patching
> > anymore, the patch linked earlier in the thread is merged into main.

Support for GD25LR512ME flash chip.

[Guru, Ritul]

[AMD Official Use Only - AMD Internal Distribution Only]

Sure, we are looking to fix this issue, we will discuss on approach we are using and may need few inputs from you.

Thanks,
Ritul

-----Original Message-----
From: Anastasia Klimchuk 
Sent: Thursday, June 20, 2024 5:44 PM
To: Guru, Ritul 
Cc: Munduru, Avinash ; Kumar, Chaudhary amit ; Vlim ; [e-mail]
Subject: Re: [flashrom] Re: Support for GD25LR512ME flash chip.

Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.

Hi Ritul,

Nice to meet you! It's really good to have you on this thread.

My plan for the issue is to find someone from AMD who can fix the issue. I mentioned this earlier in this thread :) It would be really great if you could help?

I think someone from AMD would be in the best position to fix the issue, you have all the datasheets available and all the hardware.
It seems from the thread you are hitting the issue during a development process, so perhaps this can be a justification for why this is needed for business, and why to allocate resources to fix it.

Some time ago I wrote this doc, maybe it can be useful https://flashrom.org/how_to_support_flashrom.html#special-appeal-for-compani...
Count this as an official invitation to contribute!

Thank you for your help

About possible workarounds, I think writing only one layout region has some chances to work.

On Thu, Jun 20, 2024 at 4:27 AM Guru, Ritul  wrote:
> [AMD Official Use Only - AMD Internal Distribution Only]
>
> Hi Avinash,
>
> How did you try to pad the the 16MB file?
>
> Hi Anastasia,
>
> Is there any plan to support 64MB flashing enabled in flashrom for this SPIROM with internal programming?
>
> Thanks,
>
> Ritul
>
> From: Munduru, Avinash 
> Sent: Wednesday, June 19, 2024 11:45 PM
> To: Anastasia Klimchuk 
> Cc: Vlim ; [e-mail]; Guru, Ritul
>
> Subject: Re: [flashrom] Re: Support for GD25LR512ME flash chip.
>
> [AMD Official Use Only - AMD Internal Distribution Only]
>
> +Ritul
>
> Regards,
>
> Avinash.
>
> Get Outlook for iOS
>
> From: Munduru, Avinash 
> Sent: Saturday, June 15, 2024 2:14 AM
> To: Anastasia Klimchuk 
> Cc: Vlim ; [e-mail]
>
> Subject: Re: [flashrom] Re: Support for GD25LR512ME flash chip.
>
> Hi Anastasia,
>
> Thanks for your input I will try looking into this possible solution.
>
> I already tried the padding solution but it did not work.
>
> Once again, thank you for mainlining the patch.
>
> Regards,
>
> Avinash.
>
> Get Outlook for iOS
>
> From: Anastasia Klimchuk 
> Sent: Friday, June 14, 2024 8:11:00 PM
> To: Munduru, Avinash 
> Cc: Vlim ; [e-mail]
>
> Subject: Re: [flashrom] Re: Support for GD25LR512ME flash chip.
>
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>
> As a quick addition to my previous message:
>
> What you also can try, is to create a layout file with the region of
> size 16MB, and then set the option to only write this region. The area
> outside the region will not be modified.
> If you decide to go this way, please read manpage, especially -l and
> -i options https://flashrom.org/classic_cli_manpage.html
>
> On Fri, Jun 14, 2024 at 12:22 PM Anastasia Klimchuk  wrote:
> > Hello Avinash,
> >
> > Sorry for some delay in response. I was also thinking, what's useful
> > that I could tell you.
> >
> > I understand your idea to shrink the image to 16MB, so that work
> > around the bug which affects images >16MB. However, flashrom checks
> > whether the size of the image is the same as the size of the chip
> > (should throw an error if not). So to write 16MB onto GD25LR512ME
> > which is 64MB, you would need to pad the file, with zeros usually,
> > to make the file 64MB.
> > I don't know whether it would work. Is it possible that you would
> > try (if you have tools to recover your device from failure of
> > course)? Or perhaps you have tried already?
> >
> > On the other hand, some good news: support for chips GD25LR256E,
> > GD251R512ME has been submitted meanwhile. So no need for patching
> > anymore, the patch linked earlier in the thread is merged into main.

Support for GD25LR512ME flash chip.

[Guru, Ritul]

[AMD Official Use Only - AMD Internal Distribution Only]

Hi Anastasia,
We have enabled support for GD25LR512ME and can flash AMD BIOS.
@Munduru, Avinash will share the changes for review. Please review those - thanks

Thanks,
Ritul

-----Original Message-----
From: Guru, Ritul
Sent: Friday, June 21, 2024 5:04 PM
To: Anastasia Klimchuk 
Cc: Munduru, Avinash ; Kumar, Chaudhary amit ; Vlim ; [e-mail]
Subject: RE: [flashrom] Re: Support for GD25LR512ME flash chip.

Sure, we are looking to fix this issue, we will discuss on approach we are using and may need few inputs from you.

Thanks,
Ritul

-----Original Message-----
From: Anastasia Klimchuk 
Sent: Thursday, June 20, 2024 5:44 PM
To: Guru, Ritul 
Cc: Munduru, Avinash ; Kumar, Chaudhary amit ; Vlim ; [e-mail]
Subject: Re: [flashrom] Re: Support for GD25LR512ME flash chip.

Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.

Hi Ritul,

Nice to meet you! It's really good to have you on this thread.

My plan for the issue is to find someone from AMD who can fix the issue. I mentioned this earlier in this thread :) It would be really great if you could help?

I think someone from AMD would be in the best position to fix the issue, you have all the datasheets available and all the hardware.
It seems from the thread you are hitting the issue during a development process, so perhaps this can be a justification for why this is needed for business, and why to allocate resources to fix it.

Some time ago I wrote this doc, maybe it can be useful https://flashrom.org/how_to_support_flashrom.html#special-appeal-for-compani...
Count this as an official invitation to contribute!

Thank you for your help

About possible workarounds, I think writing only one layout region has some chances to work.

On Thu, Jun 20, 2024 at 4:27 AM Guru, Ritul  wrote:
> [AMD Official Use Only - AMD Internal Distribution Only]
>
> Hi Avinash,
>
> How did you try to pad the the 16MB file?
>
> Hi Anastasia,
>
> Is there any plan to support 64MB flashing enabled in flashrom for this SPIROM with internal programming?
>
> Thanks,
>
> Ritul
>
> From: Munduru, Avinash 
> Sent: Wednesday, June 19, 2024 11:45 PM
> To: Anastasia Klimchuk 
> Cc: Vlim ; [e-mail]; Guru, Ritul
>
> Subject: Re: [flashrom] Re: Support for GD25LR512ME flash chip.
>
> [AMD Official Use Only - AMD Internal Distribution Only]
>
> +Ritul
>
> Regards,
>
> Avinash.
>
> Get Outlook for iOS
>
> From: Munduru, Avinash 
> Sent: Saturday, June 15, 2024 2:14 AM
> To: Anastasia Klimchuk 
> Cc: Vlim ; [e-mail]
>
> Subject: Re: [flashrom] Re: Support for GD25LR512ME flash chip.
>
> Hi Anastasia,
>
> Thanks for your input I will try looking into this possible solution.
>
> I already tried the padding solution but it did not work.
>
> Once again, thank you for mainlining the patch.
>
> Regards,
>
> Avinash.
>
> Get Outlook for iOS
>
> From: Anastasia Klimchuk 
> Sent: Friday, June 14, 2024 8:11:00 PM
> To: Munduru, Avinash 
> Cc: Vlim ; [e-mail]
>
> Subject: Re: [flashrom] Re: Support for GD25LR512ME flash chip.
>
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>
> As a quick addition to my previous message:
>
> What you also can try, is to create a layout file with the region of
> size 16MB, and then set the option to only write this region. The area
> outside the region will not be modified.
> If you decide to go this way, please read manpage, especially -l and
> -i options https://flashrom.org/classic_cli_manpage.html
>
> On Fri, Jun 14, 2024 at 12:22 PM Anastasia Klimchuk  wrote:
> > Hello Avinash,
> >
> > Sorry for some delay in response. I was also thinking, what's useful
> > that I could tell you.
> >
> > I understand your idea to shrink the image to 16MB, so that work
> > around the bug which affects images >16MB. However, flashrom checks
> > whether the size of the image is the same as the size of the chip
> > (should throw an error if not). So to write 16MB onto GD25LR512ME
> > which is 64MB, you would need to pad the file, with zeros usually,
> > to make the file 64MB.
> > I don't know whether it would work. Is it possible that you would
> > try (if you have tools to recover your device from failure of
> > course)? Or perhaps you have tried already?
> >
> > On the other hand, some good news: support for chips GD25LR256E,
> > GD251R512ME has been submitted meanwhile. So no need for patching
> > anymore, the patch linked earlier in the thread is merged into main.

Support for GD25LR512ME flash chip.

[Anastasia Klimchuk]

Ritul, Avinash,

Thank you so much for your work! I am looking forward to reviewing your patches.

When you will be preparing the patch and sending for review, here are
our dev guidelines which are useful:
https://flashrom.org/dev_guide/development_guide.html

On Tue, Aug 27, 2024 at 10:47 PM Guru, Ritul  wrote:
> [AMD Official Use Only - AMD Internal Distribution Only]
>
> Hi Anastasia,
> We have enabled support for GD25LR512ME and can flash AMD BIOS.
> @Munduru, Avinash will share the changes for review. Please review those - thanks
>
> Thanks,
> Ritul
>
> -----Original Message-----
> From: Guru, Ritul
> Sent: Friday, June 21, 2024 5:04 PM
> To: Anastasia Klimchuk 
> Cc: Munduru, Avinash ; Kumar, Chaudhary amit ; Vlim ; [e-mail]
> Subject: RE: [flashrom] Re: Support for GD25LR512ME flash chip.
>
> Sure, we are looking to fix this issue, we will discuss on approach we are using and may need few inputs from you.
>
> Thanks,
> Ritul
>
> -----Original Message-----
> From: Anastasia Klimchuk 
> Sent: Thursday, June 20, 2024 5:44 PM
> To: Guru, Ritul 
> Cc: Munduru, Avinash ; Kumar, Chaudhary amit ; Vlim ; [e-mail]
> Subject: Re: [flashrom] Re: Support for GD25LR512ME flash chip.
>
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>
> Hi Ritul,
>
> Nice to meet you! It's really good to have you on this thread.
>
> My plan for the issue is to find someone from AMD who can fix the issue. I mentioned this earlier in this thread :) It would be really great if you could help?
>
> I think someone from AMD would be in the best position to fix the issue, you have all the datasheets available and all the hardware.
> It seems from the thread you are hitting the issue during a development process, so perhaps this can be a justification for why this is needed for business, and why to allocate resources to fix it.
>
> Some time ago I wrote this doc, maybe it can be useful https://flashrom.org/how_to_support_flashrom.html#special-appeal-for-compani...
> Count this as an official invitation to contribute!
>
> Thank you for your help
>
> About possible workarounds, I think writing only one layout region has some chances to work.
>
> On Thu, Jun 20, 2024 at 4:27 AM Guru, Ritul  wrote:
> > [AMD Official Use Only - AMD Internal Distribution Only]
> >
> > Hi Avinash,
> >
> > How did you try to pad the the 16MB file?
> >
> > Hi Anastasia,
> >
> > Is there any plan to support 64MB flashing enabled in flashrom for this SPIROM with internal programming?
> >
> > Thanks,
> >
> > Ritul
> >
> > From: Munduru, Avinash 
> > Sent: Wednesday, June 19, 2024 11:45 PM
> > To: Anastasia Klimchuk 
> > Cc: Vlim ; [e-mail]; Guru, Ritul
> >
> > Subject: Re: [flashrom] Re: Support for GD25LR512ME flash chip.
> >
> > [AMD Official Use Only - AMD Internal Distribution Only]
> >
> > +Ritul
> >
> > Regards,
> >
> > Avinash.
> >
> > Get Outlook for iOS
> >
> > From: Munduru, Avinash 
> > Sent: Saturday, June 15, 2024 2:14 AM
> > To: Anastasia Klimchuk 
> > Cc: Vlim ; [e-mail]
> >
> > Subject: Re: [flashrom] Re: Support for GD25LR512ME flash chip.
> >
> > Hi Anastasia,
> >
> > Thanks for your input I will try looking into this possible solution.
> >
> > I already tried the padding solution but it did not work.
> >
> > Once again, thank you for mainlining the patch.
> >
> > Regards,
> >
> > Avinash.
> >
> > Get Outlook for iOS
> >
> > From: Anastasia Klimchuk 
> > Sent: Friday, June 14, 2024 8:11:00 PM
> > To: Munduru, Avinash 
> > Cc: Vlim ; [e-mail]
> >
> > Subject: Re: [flashrom] Re: Support for GD25LR512ME flash chip.
> >
> > Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
> >
> > As a quick addition to my previous message:
> >
> > What you also can try, is to create a layout file with the region of
> > size 16MB, and then set the option to only write this region. The area
> > outside the region will not be modified.
> > If you decide to go this way, please read manpage, especially -l and
> > -i options https://flashrom.org/classic_cli_manpage.html
> >
> > On Fri, Jun 14, 2024 at 12:22 PM Anastasia Klimchuk  wrote:
> > > Hello Avinash,
> > >
> > > Sorry for some delay in response. I was also thinking, what's useful
> > > that I could tell you.
> > >
> > > I understand your idea to shrink the image to 16MB, so that work
> > > around the bug which affects images >16MB. However, flashrom checks
> > > whether the size of the image is the same as the size of the chip
> > > (should throw an error if not). So to write 16MB onto GD25LR512ME
> > > which is 64MB, you would need to pad the file, with zeros usually,
> > > to make the file 64MB.
> > > I don't know whether it would work. Is it possible that you would
> > > try (if you have tools to recover your device from failure of
> > > course)? Or perhaps you have tried already?
> > >
> > > On the other hand, some good news: support for chips GD25LR256E,
> > > GD251R512ME has been submitted meanwhile. So no need for patching
> > > anymore, the patch linked earlier in the thread is merged into main.