Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.


Victor,

Thank you so much for the datasheets! I did a review of the pending
patch, and now it will be possible to finally finish the patch from
2021 and get the chips submitted.

Also thank you for attaching the log.

Not sure if the log is complete? It ends at the start of the reading
operation, but there is no final message of SUCCESS or FAIL.

However, importantly, I could see in the beginning of the log which
platform was detected, and it is Promontory. Which means...

Avinash,

Most likely you are hitting a known issue, you can read more details
here: https://ticket.coreboot.org/issues/370
The issue is for Promontory, and also for chips larger than 16Mbyte:
which is exactly what you have.

I was actually trying to get help from AMD with this issue, so it's
really good to have you here on the mailing list! Maybe you can help?

Someone from AMD would be in the best position to fix Promontory, you
have all the datasheets available, and all the hardware.

Thank you!

On Sat, May 11, 2024 at 9:40 PM Vlim <vlim@gigadevice.com> wrote:
>
> Hi, Anastasia,
>
> Please find the attached datasheet for GD25LR256E and GD25LR512ME.
>
> There are actually two issues.
>
> the released flashrom does not support GD25LR256E and GD25LR512ME.
> With my patch, the dediprog programmer works for GD25LR512ME. But the AMD internal programmer for Birman Plus Board does not work. Output file attached.
>
>
> This is the comment about Birman Plus Board
>
> Now, Flashrom can detect the flash chip.
> Using dediprog programmer I can read/write the flash chip successfully.
> Whereas with using the internal programmer i.e. "-p internal" the read/write is failing. I am attaching the log here.
> Please give your input on this.
>
>
> Regards,
>
> Victor
>
>
> ________________________________
> From: Anastasia Klimchuk <aklm@chromium.org>
> Sent: Saturday, May 11, 2024 17:59
> To: Vlim <vlim@gigadevice.com>; Munduru, Avinash <avinash.munduru@amd.com>
> Cc: flashrom@flashrom.org <flashrom@flashrom.org>
> Subject: Re: [flashrom] Re: Support for GD25LR512ME flash chip.
>
> 此为外部邮件，谨防钓鱼邮件，请注意邮件是否涉及敏感信息
> This is an external email, beware of phishing emails. Please pay close attention to whether the email contains sensitive information
>
> There is another thing, in addition to my previous message.
>
> I looked into the patch which adds chip definitions (this one
> https://review.coreboot.org/c/flashrom/+/58025) and the reason it is
> pending is there are no links to datasheets (old links are not working
> anymore).
> It is unfortunate that the patch is pending since 2021, but I want to
> try to fix the situation now, in the year 2024.
>
> Victor, maybe you know, is it possible to find datasheets for
> GD25LR256E and GD251R512ME? I could finish the old patch and get chips
> into the tree.
>
> This is a separate question to Avinash's issue with internal
> programmer, but for this we need the very verbose log (which is log
> with -VVV option on command line).
>
> Thank you!
>
> On Thu, May 9, 2024 at 11:03 PM Anastasia Klimchuk <aklm@chromium.org> wrote:
> >
> > Avinash, I read the thread and I see you are saying "I am attaching
> > the log here" but I don't see the log? maybe you can re-send it again,
> > now with the mailing list? (perhaps you sent it to Victor only?)
> > Yes it is also important to know your board, since you are saying the
> > chip worked successfully with dediprog, but not with the internal
> > programmer.
> >
> > Victor, thank you so much for helping!
> >
> >
> > On Mon, May 6, 2024 at 6:42 PM Vlim <vlim@gigadevice.com> wrote:
> > >
> > > Thanks, Avinash,
> > >
> > > Can you advise which board are you using?
> > > I have tested this patch with the USB programmer only since I do not have access to the motherboard.
> > >
> > > Hi, Flashrom team,
> > > Can you also help on this?
> > >
> > >
> > > Regards,
> > >
> > > Victor Lim
> > > FAE Director
> > > GigaDevice Semiconductor
> > > 4088833856
> > > vlim@gigadevice.com
> > >
> > > ________________________________
> > > From: Munduru, Avinash <Avinash.Munduru@amd.com>
> > > Sent: Monday, May 6, 2024 16:24
> > > To: Vlim <vlim@gigadevice.com>; flashrom@flashrom.org <flashrom@flashrom.org>
> > > Subject: Re: Support for GD25LR512ME flash chip.
> > >
> > > You don't often get email from avinash.munduru@amd.com. Learn why this is important
> > > 此为外部邮件，谨防钓鱼邮件，请注意邮件是否涉及敏感信息
> > > This is an external email, beware of phishing emails. Please pay close attention to whether the email contains sensitive information
> > >
> > > [AMD Official Use Only - General]
> > >
> > >
> > > Hi Victor,
> > >
> > > Thanks for sharing the patch. Here is an update after trying the shared patch.
> > >
> > > Now, Flashrom can detect the flash chip.
> > > Using dediprog programmer I can read/write the flash chip successfully.
> > > Whereas with using the internal programmer i.e. "-p internal" the read/write is failing. I am attaching the log here.
> > > Please give your input on this.
> > >
> > > Once again! Thanks for your help!
> > >
> > >
> > > ________________________________
> > > From: Vlim <vlim@gigadevice.com>
> > > Sent: Sunday, May 5, 2024 1:54 PM
> > > To: flashrom@flashrom.org <flashrom@flashrom.org>; Munduru, Avinash <Avinash.Munduru@amd.com>
> > > Subject: Re: Support for GD25LR512ME flash chip.
> > >
> > > Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
> > >
> > > Hi, Avinash,
> > >
> > > Sorry that I am working on adding this part to Flashrom, but has not completed the entire process.
> > >
> > > Can you please use the attached flashchips.c and flashshchips.h and replace that in flashrom distribution?
> > >
> > > This is the process.
> > >
> > > git clone "https://review.coreboot.org/flashrom"
> > >
> > > meson setup builddir
> > > meson compile -C builddir
> > > meson test -C builddir
> > > meson install -C builddir
> > >
> > >
> > > Please also refer to the following link for compilation of the code.
> > > https://flashrom.org/dev_guide/building_from_source.html
> > >
> > > I have a compiled version for Ubuntu Linux, if that will help, I can share with you.
> > >
> > > Regards,
> > >
> > > Victor Lim
> > > GigaDevice Semiconductors Inc.
> > > 4088833856
> > > vlim@gigadevice.com
> > >
> > >
> > > ________________________________
> > > From: Munduru, Avinash via flashrom <flashrom@flashrom.org>
> > > Sent: Tuesday, April 30, 2024 16:54
> > > To: flashrom@flashrom.org <flashrom@flashrom.org>
> > > Subject: [flashrom] Re: Support for GD25LR512ME flash chip.
> > >
> > > 此为外部邮件，谨防钓鱼邮件，请注意邮件是否涉及敏感信息
> > > This is an external email, beware of phishing emails. Please pay close attention to whether the email contains sensitive information
> > >
> > > [AMD Official Use Only - General]
> > >
> > >
> > > + attaching the output log
> > >
> > > ________________________________
> > > From: Munduru, Avinash
> > > Sent: Tuesday, April 30, 2024 2:04 PM
> > > To: flashrom@flashrom.org <flashrom@flashrom.org>
> > > Subject: Support for GD25LR512ME flash chip.
> > >
> > > Hi,
> > >
> > > Currently, flash chip support for GD25LR512ME is not supported in flashrom utility.
> > > Please share a patch if it is already available. If not let me know how I can modify it.
> > >
> > > _______________________________________________
> > > flashrom mailing list -- flashrom@flashrom.org
> > > To unsubscribe send an email to flashrom-leave@flashrom.org
> >
> >
> >
> > --
> > Anastasia.
>
>
>
> --
> Anastasia.



--
Anastasia.