SFDP with Winbond chip

[ro_beri]

Hi to all team members.
 
chip: Winbond 25Q128BFVS0
programmer: ch341a
device: Intel NUC5PPYH
os: Debian Stretch
kernel: 4.9.168-1+deb9u5 (2019-08-11)
Flashrom builded with procedure:
# apt install pciutils pciutils-dev libpci-dev zlib1g-dev libpci3 libftdi-dev libusb-dev
# git clone https://github.com/flashrom/flashrom.git flashrom_git
# cd flashrom_git; make; cp flashrom ../
Some parts of build log:
# Replacing all version templates with v1.1-rc1-69-g188127e.
# Checking for a C compiler... found.
# Target arch is x86
# Target OS is Linux
# Checking for libpci headers... found.
# Checking version of pci_get_dev... new version (including PCI domain parameter).
# Checking if libpci is present and sufficient... yes.
# Checking for libusb-1.0 headers... found.
# Checking if libusb-1.0 is usable... yes.
# Checking for FTDI support... found.
# Checking for FT232H support in libftdi... found.
# Checking if Linux MTD headers are present... yes.
# Checking if Linux SPI headers are present... yes.
# Checking for utsname support... found.
# Checking for clock_gettime support... found.
 
log from "flashrom -p ch341a_spi -VV" in attachment.
 
Regards
Bercik

[Angel Pons]

Hi Bercik,

Thanks for your report.

On Thu, Aug 22, 2019 at 5:45 PM ro_beri  wrote:
> Hi to all team members.
>
> chip: Winbond 25Q128BFVS0
> programmer: ch341a
> device: Intel NUC5PPYH
> os: Debian Stretch
> kernel: 4.9.168-1+deb9u5 (2019-08-11)

That chip should be supported, but looks like SFDP probing is done first,
so you get that message about an unsupported chip. Then probing for the
"W25Q128.V" runs and finds your chip fine. In the end, you end up with two
detected chip definitions: the SFDP definition, and the W25Q128.V definition.

For now, you can tell flashrom to use the W25Q128.V definition adding the
following command-line switch:
 -c "W25Q128.V"

Nevertheless, this looks like a bug that was introduced in a recent change:
 https://review.coreboot.org/c/flashrom/+/33931
The SFDP-capable entry used to be at the end of flashchips.c, so as to be
probed last. However, the sorting done in that change moved it upwards,
before the Winbond entries. Hence the error.
> Flashrom builded with procedure:
> # apt install pciutils pciutils-dev libpci-dev zlib1g-dev libpci3 libftdi-dev libusb-dev
> # git clone https://github.com/flashrom/flashrom.git flashrom_git
> # cd flashrom_git; make; cp flashrom ../
>
> Some parts of build log:
> # Replacing all version templates with v1.1-rc1-69-g188127e.
> # Checking for a C compiler... found.
> # Target arch is x86
> # Target OS is Linux
> # Checking for libpci headers... found.
> # Checking version of pci_get_dev... new version (including PCI domain parameter).
> # Checking if libpci is present and sufficient... yes.
> # Checking for libusb-1.0 headers... found.
> # Checking if libusb-1.0 is usable... yes.
> # Checking for FTDI support... found.
> # Checking for FT232H support in libftdi... found.
> # Checking if Linux MTD headers are present... yes.
> # Checking if Linux SPI headers are present... yes.
> # Checking for utsname support... found.
> # Checking for clock_gettime support... found.
>
> log from "flashrom -p ch341a_spi -VV" in attachment.
>
> Regards
> Bercik

Best regards,

Angel Pons