A couple of bugs..

[Mike Hibbett]

I spotted these two in yesterday's code base. I'm not likely to commit code anytime soon so I will leave it to someone else to pick up if they are interested.

src/vendorcode/intel/fsp/baytrail/include/fspplatform.h:78

Duplicate declaration of  GetFspReservedMemoryFromGuid

src/northbridge/intel/fsp_sandybridge/fsp/chipset_fsp_util.c:92

GetUpdDefaultFromFsp (fsp_ptr, fsp_upd_data);/home/martin/extra/git/coreboot

Maybe martin would like to fix that one :o)

Mike

[Stefan Tauner]

On Tue, 20 May 2014 12:06:02 +0000
Mike Hibbett  wrote:
> I spotted these two in yesterday's code base. I'm not likely to commit code anytime soon so I will leave it to someone else to pick up if they are interested.
>
> src/vendorcode/intel/fsp/baytrail/include/fspplatform.h:78
>
> Duplicate declaration of  GetFspReservedMemoryFromGuid
>
> src/northbridge/intel/fsp_sandybridge/fsp/chipset_fsp_util.c:92
>
> GetUpdDefaultFromFsp (fsp_ptr, fsp_upd_data);/home/martin/extra/git/coreboot
>
> Maybe martin would like to fix that one :o)

I guess you want to send this to [e-mail] ;)

[Mike Hibbett]

Yea, there was a bug in my brain too yesterday :o)

-----Original Message-----
From: Stefan Tauner [mailto:[e-mail]] 
Sent: 21 May 2014 13:32
To: Mike Hibbett
Cc: [e-mail]
Subject: Re: [flashrom] A couple of bugs..

On Tue, 20 May 2014 12:06:02 +0000
Mike Hibbett  wrote:
> I spotted these two in yesterday's code base. I'm not likely to commit code anytime soon so I will leave it to someone else to pick up if they are interested.
>
> src/vendorcode/intel/fsp/baytrail/include/fspplatform.h:78
>
> Duplicate declaration of  GetFspReservedMemoryFromGuid
>
> src/northbridge/intel/fsp_sandybridge/fsp/chipset_fsp_util.c:92
>
> GetUpdDefaultFromFsp (fsp_ptr, fsp_upd_data);/home/martin/extra/git/coreboot
>
> Maybe martin would like to fix that one :o)

I guess you want to send this to [e-mail] ;)