flashrom

flashrom@flashrom.org

5 participants
9161 discussions

[PATCH] (now for real!) Allow DMI supported board enables with subsystem ID zero.
by Michael Karcher 04 Feb '10

04 Feb '10

This is needed for the Intel SE440BX-2 as well as the Asus P5A. Signed-off-by: Michael Karcher <flashrom(a)mkarcher.dialup.fu-berlin.de> Now *REALLY* with the right patch. I supposed I knew how to operate git :( --- board_enable.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/board_enable.c b/board_enable.c index 40db653..c73c8af 100644 --- a/board_enable.c +++ b/board_enable.c @@ -1312,7 +1312,8 @@ static struct board_pciid_enable *board_match_pci_card_ids(void) struct board_pciid_enable *board = board_pciid_enables; for (; board->vendor_name; board++) { - if (!board->first_card_vendor || !board->first_card_device) + if ((!board->first_card_vendor || !board->first_card_device) && + !board->dmi_pattern) continue; if (!pci_card_find(board->first_vendor, board->first_device, -- 1.6.5

1 0

Re: [flashrom] [PATCH] (fixed) Allow DMI supported board enables with subsystem ID zero.
by Carl-Daniel Hailfinger 04 Feb '10

04 Feb '10

On 04.02.2010 10:59, Michael Karcher wrote: > This is needed for the Intel SE440BX-2 as well as the Asus P5A. > > Thanks to Carl-Daniel Hailfinger for pointing out wrong logic in > the patch. > > Zach: please retry with this one instead of the previous version of > this patch. You can unpatch the previous version by > patch -R < oldpatch.diff > > Signed-off-by: Michael Karcher <flashrom(a)mkarcher.dialup.fu-berlin.de> > AFAICS you reposted the old patch. Regards, Carl-Daniel -- Developer quote of the year: "We are juggling too many chainsaws and flaming arrows and tigers."

1 0

[PATCH] Allow DMI supported board enables with subsystem ID zero.
by Michael Karcher 04 Feb '10

04 Feb '10

This is needed for the Intel SE440BX-2 as well as the Asus P5A. Signed-off-by: Michael Karcher <flashrom(a)mkarcher.dialup.fu-berlin.de> This time with the right patch included. --- board_enable.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/board_enable.c b/board_enable.c index 40db653..66afab4 100644 --- a/board_enable.c +++ b/board_enable.c @@ -1312,7 +1312,8 @@ static struct board_pciid_enable *board_match_pci_card_ids(void) struct board_pciid_enable *board = board_pciid_enables; for (; board->vendor_name; board++) { - if (!board->first_card_vendor || !board->first_card_device) + if (!board->first_card_vendor || + (!board->first_card_device && !board->dmi_pattern)) continue; if (!pci_card_find(board->first_vendor, board->first_device, -- 1.6.5

1 0

Re: [flashrom] [PATCH] please disregard last mail!
by Michael Karcher 04 Feb '10

04 Feb '10

Am Donnerstag, den 04.02.2010, 10:59 +0100 schrieb Michael Karcher: > Zach: please retry with this one instead of the previous version of > this patch. You can unpatch the previous version by > patch -R < oldpatch.diff That patch was identical to the first one. I mixed of things :( Regards, Michael Karcher

1 0

Re: [flashrom] [PATCH] Allow DMI supported board enables with subsystem ID zero.
by Carl-Daniel Hailfinger 04 Feb '10

04 Feb '10

On 29.01.2010 01:40, Michael Karcher wrote: > --- a/board_enable.c > +++ b/board_enable.c > @@ -1312,7 +1312,8 @@ static struct board_pciid_enable *board_match_pci_card_ids(void) > struct board_pciid_enable *board = board_pciid_enables; > > for (; board->vendor_name; board++) { > - if (!board->first_card_vendor || !board->first_card_device) > + if (!board->first_card_vendor || > + (!board->first_card_device && !board->dmi_pattern)) > continue; > > if (!pci_card_find(board->first_vendor, board->first_device, > This code still requires a nonzero subsystem vendor even if a DMI pattern is present. If that is intentional (I thought DMI would eliminate subsystem vendor+device requirement), the patch is Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Regards, Carl-Daniel -- Developer quote of the year: "We are juggling too many chainsaws and flaming arrows and tigers."

3 5

[commit] r891 - trunk
by repository service 04 Feb '10

04 Feb '10

Author: oxygene Date: Thu Feb 4 09:29:18 2010 New Revision: 891 URL: http://flashrom.org/trac/coreboot/changeset/891 Log: Properly initialize USB device in dediprog driver. That's necessary to use bulk transfers, and just the right thing in any case. Signed-off-by: Patrick Georgi <patrick.georgi(a)coresystems.de> Acked-by: Stefan Reinauer <stepan(a)coresystems.de> Modified: trunk/dediprog.c Modified: trunk/dediprog.c ============================================================================== --- trunk/dediprog.c Thu Feb 4 03:40:16 2010 (r890) +++ trunk/dediprog.c Thu Feb 4 09:29:18 2010 (r891) @@ -294,6 +294,8 @@ dev->descriptor.idVendor, dev->descriptor.idProduct); dediprog_handle = usb_open(dev); + usb_set_configuration(dediprog_handle, 1); + usb_claim_interface(dediprog_handle, 0); /* URB 6. Command A. */ if (dediprog_command_a()) return 1;

1 0

(update) Gigabyte GA-7ZXE v1.1
by Charles M 04 Feb '10

04 Feb '10

In the last message I stated the board was 1.0, but it's actually 1.1 (the board was a little dirty and I mistook the 1.1 for 1.0). Superiotool didn't find the super i/o chip. From a quick glance it appears to be a VIA VT82C686B chip. Cheers, Charles

3 3

Re: [flashrom] [commit] r885 - trunk
by Luc Verhaegen 04 Feb '10

04 Feb '10

On Thu, Jan 28, 2010 at 08:02:37PM +0100, svn(a)flashrom.org wrote: > Author: uwe > Date: 2010-01-28 20:02:36 +0100 (Thu, 28 Jan 2010) > New Revision: 885 > > Modified: > trunk/board_enable.c > Log: > The GIGABYTE GA-7ZM has a maximum decode size (parallel chips) of 512 KB. > > Add this information to the new field in the board-enable table. We match the > board via two sets of PCI IDs. However, as we don't need a board-enable > function for this board (it works out of the box; well, at least if you remove > the JP9 jumper on the board), change the code to allow NULL as value for > the board-enable function. There will likely be more boards in the future where > we want to record a maximum decode size but which don't need a board-enable. > > This is hardware-tested on the GIGABYTE GA-7ZM by successfully writing a 512KB > image of random bytes to a chip in this board. > > Signed-off-by: Uwe Hermann <uwe(a)hermann-uwe.de> > Acked-by: Sean Nelson <audiohacked(a)gmail.com> > > > > Modified: trunk/board_enable.c > =================================================================== > --- trunk/board_enable.c 2010-01-27 10:08:33 UTC (rev 884) > +++ trunk/board_enable.c 2010-01-28 19:02:36 UTC (rev 885) > @@ -1208,6 +1208,7 @@ > {0x1106, 0x3177, 0x1106, 0x3177, 0x1106, 0x3059, 0x1695, 0x3005, NULL, NULL, NULL, "EPoX", "EP-8K5A2", 0, w836xx_memw_enable_2e}, > {0x10EC, 0x8139, 0x1695, 0x9001, 0x11C1, 0x5811, 0x1695, 0x9015, NULL, NULL, NULL, "EPoX", "EP-8RDA3+", 0, nvidia_mcp_gpio31_raise}, > {0x8086, 0x7110, 0, 0, 0x8086, 0x7190, 0, 0, NULL, "epox", "ep-bx3", "EPoX", "EP-BX3", 0, board_epox_ep_bx3}, > + {0x1106, 0x0686, 0x1106, 0x0686, 0x1106, 0x3058, 0x1458, 0xa000, NULL, NULL, NULL, "GIGABYTE", "GA-7ZM", 512, NULL}, > {0x1039, 0x0761, 0, 0, 0x10EC, 0x8168, 0, 0, NULL, "gigabyte", "2761gxdk", "GIGABYTE", "GA-2761GXDK", 0, it87xx_probe_spi_flash}, > {0x1106, 0x3227, 0x1458, 0x5001, 0x10ec, 0x8139, 0x1458, 0xe000, NULL, NULL, NULL, "GIGABYTE", "GA-7VT600", 0, it8705f_write_enable_2e}, > {0x10DE, 0x0050, 0x1458, 0x0C11, 0x10DE, 0x005e, 0x1458, 0x5000, NULL, NULL, NULL, "GIGABYTE", "GA-K8N-SLI", 0, nvidia_mcp_gpio21_raise}, http://www.google.de/#q=1106%3A0686+1106%3A0686+1106%3A3058+1458%3Aa000&aq=… reveals that there are at least two different boards which matches this. You are only matching the southbridge here, and a relatively bogus (and common) subsystem id, which only tells us that it's a gigabyte board. The VT82C686 was a _hugely_ successful southbridge. I cannot even begin to count how many gigabyte boards use this chipset. So, first; swap the pairs around. Second, use 0x1106, 0x0305, 0, 0 to at least narrow the northbridge down. A further check on the gigabyte gives me 17 possible combinations of the different kt133 variations and the 686 southbridge. This makes it completely impossible to even consider the above change a sufficient match. Please provide the output of flashrom -V so we can identify a DMI match. The above logic should give you some idea of the investigation required to get a good match. It just takes a few minutes to do so too. Luc Verhaegen.

1 0

[commit] r887 - trunk
by repository service 04 Feb '10

04 Feb '10

Author: uwe Date: Sun Jan 31 21:13:06 2010 New Revision: 887 URL: http://flashrom.org/trac/coreboot/changeset/887 Log: Add the Tekram P6Pro-A5 board as supported (trivial). The board doesn't need a board-enable, writing works out of the box. Also, the board can only decode 256KB. I verified this by writing a 512KB image of random bytes (which fails), whereas 256KB of random bytes can be written correctly. Signed-off-by: Uwe Hermann <uwe(a)hermann-uwe.de> Acked-by: Uwe Hermann <uwe(a)hermann-uwe.de> Modified: trunk/board_enable.c trunk/print_wiki.c Modified: trunk/board_enable.c ============================================================================== --- trunk/board_enable.c Fri Jan 29 00:55:12 2010 (r886) +++ trunk/board_enable.c Sun Jan 31 21:13:06 2010 (r887) @@ -1235,6 +1235,7 @@ {0x10DE, 0x0050, 0x1297, 0x5036, 0x1412, 0x1724, 0x1297, 0x5036, NULL, NULL, NULL, "Shuttle", "FN25", 0, board_shuttle_fn25}, {0x1106, 0x3038, 0x0925, 0x1234, 0x1106, 0x3058, 0x15DD, 0x7609, NULL, NULL, NULL, "Soyo", "SY-7VCA", 0, board_soyo_sy_7vca}, {0x8086, 0x1076, 0x8086, 0x1176, 0x1106, 0x3059, 0x10f1, 0x2498, NULL, NULL, NULL, "Tyan", "S2498 (Tomcat K7M)", 0, w836xx_memw_enable_2e}, + {0x1106, 0x3038, 0x0925, 0x1234, 0, 0, 0, 0, NULL, NULL, NULL, "Tekram", "P6Pro-A5", 256, NULL}, {0x1106, 0x3177, 0x1106, 0xAA01, 0x1106, 0x3123, 0x1106, 0xAA01, NULL, NULL, NULL, "VIA", "EPIA M/MII/...", 0, via_vt823x_gpio15_raise}, {0x1106, 0x0259, 0x1106, 0x3227, 0x1106, 0x3065, 0x1106, 0x3149, NULL, NULL, NULL, "VIA", "EPIA-N/NL", 0, via_vt823x_gpio9_raise}, {0x1106, 0x5337, 0x1458, 0xb003, 0x1106, 0x287e, 0x1106, 0x337e, NULL, NULL, NULL, "VIA", "PC3500G", 0, it87xx_probe_spi_flash}, Modified: trunk/print_wiki.c ============================================================================== --- trunk/print_wiki.c Fri Jan 29 00:55:12 2010 (r886) +++ trunk/print_wiki.c Sun Jan 31 21:13:06 2010 (r887) @@ -167,6 +167,7 @@ { "RCA", "RM4100", "http://www.settoplinux.org/index.php?title=RCA_RM4100" }, { "Sun", "Blade x6250", "http://www.sun.com/servers/blades/x6250/" }, { "Supermicro", "H8QC8", "http://www.supermicro.com/Aplus/motherboard/Opteron/nforce/H8QC8.cfm" }, + { "Tekram", "P6Pro-A5", "http://www.motherboard.cz/mb/tekram/P6Pro-A5.htm" }, { "Thomson", "IP1000", "http://www.settoplinux.org/index.php?title=Thomson_IP1000" }, { "TriGem", "Lomita", "http://www.e4allupgraders.info/dir1/motherboards/socket370/lomita.shtml" }, { "T-Online", "S-100", "http://wiki.freifunk-hannover.de/T-Online_S_100" },

3 6

[commit] r890 - trunk
by repository service 04 Feb '10

04 Feb '10

Author: uwe Date: Thu Feb 4 03:40:16 2010 New Revision: 890 URL: http://flashrom.org/trac/coreboot/changeset/890 Log: Add a second set of PCI IDs for the Tekram P6Pro-A5 (trivial). (Re-)tested on hardware, detection works OK. Signed-off-by: Uwe Hermann <uwe(a)hermann-uwe.de> Acked-by: Uwe Hermann <uwe(a)hermann-uwe.de> Modified: trunk/board_enable.c Modified: trunk/board_enable.c ============================================================================== --- trunk/board_enable.c Tue Feb 2 12:09:03 2010 (r889) +++ trunk/board_enable.c Thu Feb 4 03:40:16 2010 (r890) @@ -1235,7 +1235,7 @@ {0x10DE, 0x0050, 0x1297, 0x5036, 0x1412, 0x1724, 0x1297, 0x5036, NULL, NULL, NULL, "Shuttle", "FN25", 0, board_shuttle_fn25}, {0x1106, 0x3038, 0x0925, 0x1234, 0x1106, 0x3058, 0x15DD, 0x7609, NULL, NULL, NULL, "Soyo", "SY-7VCA", 0, board_soyo_sy_7vca}, {0x8086, 0x1076, 0x8086, 0x1176, 0x1106, 0x3059, 0x10f1, 0x2498, NULL, NULL, NULL, "Tyan", "S2498 (Tomcat K7M)", 0, w836xx_memw_enable_2e}, - {0x1106, 0x3038, 0x0925, 0x1234, 0, 0, 0, 0, NULL, NULL, NULL, "Tekram", "P6Pro-A5", 256, NULL}, + {0x1106, 0x3038, 0x0925, 0x1234, 0x1106, 0x0596, 0x1106, 0, NULL, NULL, NULL, "Tekram", "P6Pro-A5", 256, NULL}, {0x1106, 0x3177, 0x1106, 0xAA01, 0x1106, 0x3123, 0x1106, 0xAA01, NULL, NULL, NULL, "VIA", "EPIA M/MII/...", 0, via_vt823x_gpio15_raise}, {0x1106, 0x0259, 0x1106, 0x3227, 0x1106, 0x3065, 0x1106, 0x3149, NULL, NULL, NULL, "VIA", "EPIA-N/NL", 0, via_vt823x_gpio9_raise}, {0x1106, 0x5337, 0x1458, 0xb003, 0x1106, 0x287e, 0x1106, 0x337e, NULL, NULL, NULL, "VIA", "PC3500G", 0, it87xx_probe_spi_flash},

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

flashrom