flashrom

flashrom@flashrom.org

4 participants
9098 discussions

[commit] r865 - trunk
by svn＠flashrom.org 18 Jan '10

18 Jan '10

Author: snelson Date: 2010-01-18 09:24:02 +0100 (Mon, 18 Jan 2010) New Revision: 865 Modified: trunk/flashchips.c Log: Fix A25L40PU and A2540PT due to incorrect full-chip block size is incorrect. Thanks to hailfinger's self-check-erase routine for catching this. Signed-off-by: Sean Nelson <audiohacked(a)gmail.com> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Modified: trunk/flashchips.c =================================================================== --- trunk/flashchips.c 2010-01-18 08:14:43 UTC (rev 864) +++ trunk/flashchips.c 2010-01-18 08:24:02 UTC (rev 865) @@ -1181,7 +1181,7 @@ }, .block_erase = spi_block_erase_d8, }, { - .eraseblocks = { {256 * 1024, 1} }, + .eraseblocks = { {512 * 1024, 1} }, .block_erase = spi_block_erase_c7, } }, @@ -1213,7 +1213,7 @@ }, .block_erase = spi_block_erase_d8, }, { - .eraseblocks = { {256 * 1024, 1} }, + .eraseblocks = { {512 * 1024, 1} }, .block_erase = spi_block_erase_c7, } },

1 0

[PATCH] Add eraseblock structure to self-checks
by Carl-Daniel Hailfinger 18 Jan '10

18 Jan '10

Flashrom performs a self-check on every startup before it even starts to initialize any programmer. That way, compiler errors and code errors will be caught before they can do any harm. This patch adds an eraseblock structure self-check. It also modifies the self-check code to consistently run all checks even if one check failed. I already found two errors with it: ERROR: Flash chip A25L40PT erase function 1 region walking resulted in 0x040000 bytes total, expected 0x080000 bytes. Please report a bug at flashrom(a)flashrom.org ERROR: Flash chip A25L40PU erase function 1 region walking resulted in 0x040000 bytes total, expected 0x080000 bytes. Please report a bug at flashrom(a)flashrom.org Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Index: flashrom-selfcheck_eraseblocks/flashrom.c =================================================================== --- flashrom-selfcheck_eraseblocks/flashrom.c (Revision 863) +++ flashrom-selfcheck_eraseblocks/flashrom.c (Arbeitskopie) @@ -833,6 +833,54 @@ return 0; } +/* This function shares a lot of its structure with erase_flash(). */ +int selfcheck_eraseblocks(struct flashchip *flash) +{ + int i, k; + + for (k = 0; k < NUM_ERASEFUNCTIONS; k++) { + unsigned int done = 0; + struct block_eraser eraser = flash->block_erasers[k]; + + for (i = 0; i < NUM_ERASEREGIONS; i++) { + /* Blocks with zero size are bugs in flashchips.c. */ + if (eraser.eraseblocks[i].count && + !eraser.eraseblocks[i].size) { + msg_gerr("ERROR: Flash chip %s erase function " + "%i region %i has size 0. Please report" + " a bug at flashrom(a)flashrom.org\n", + flash->name, k, i); + return 1; + break; + } + /* Blocks with zero count are bugs in flashchips.c. */ + if (!eraser.eraseblocks[i].count && + eraser.eraseblocks[i].size) { + msg_gerr("ERROR: Flash chip %s erase function " + "%i region %i has count 0. Please report" + " a bug at flashrom(a)flashrom.org\n", + flash->name, k, i); + return 1; + break; + } + done += eraser.eraseblocks[i].count * + eraser.eraseblocks[i].size; + } + /* This erase function is completely empty. */ + if (!done) + continue; + if (done != flash->total_size * 1024) { + msg_gerr("ERROR: Flash chip %s erase function %i " + "region walking resulted in 0x%06x bytes total," + " expected 0x%06x bytes. Please report a bug at" + " flashrom(a)flashrom.org\n", flash->name, k, + done, flash->total_size * 1024); + return 1; + } + } + return 0; +} + int erase_flash(struct flashchip *flash) { int i, j, k, ret = 0, found = 0; @@ -864,17 +912,6 @@ found = 1; printf_debug("trying... "); for (i = 0; i < NUM_ERASEREGIONS; i++) { - /* Blocks with zero size are bugs in flashchips.c. - * FIXME: This check should be performed on startup. - */ - if (eraser.eraseblocks[i].count && - !eraser.eraseblocks[i].size) { - fprintf(stderr, "ERROR: Erase region with size " - "0 for this chip. Please report a bug " - "at flashrom(a)flashrom.org\n"); - ret = 1; - break; - } /* count==0 for all automatically initialized array * members so the loop below won't be executed for them. */ @@ -893,10 +930,6 @@ eraser.eraseblocks[i].size; } printf_debug("\n"); - if (done != flash->total_size * 1024) - fprintf(stderr, "ERROR: Erase region walking erased " - "0x%06x bytes total, expected 0x%06x bytes.", - done, flash->total_size * 1024); /* If everything is OK, don't try another erase function. */ if (!ret) break; @@ -948,22 +981,30 @@ int selfcheck(void) { - /* Safety check. */ + int ret = 0; + struct flashchip *flash; + + /* Safety check. Instead of aborting after the first error, check + * if more errors exist. + */ if (ARRAY_SIZE(programmer_table) - 1 != PROGRAMMER_INVALID) { fprintf(stderr, "Programmer table miscompilation!\n"); - return 1; + ret = 1; } if (spi_programmer_count - 1 != SPI_CONTROLLER_INVALID) { fprintf(stderr, "SPI programmer table miscompilation!\n"); - return 1; + ret = 1; } #if BITBANG_SPI_SUPPORT == 1 if (bitbang_spi_master_count - 1 != BITBANG_SPI_INVALID) { fprintf(stderr, "Bitbanging SPI master table miscompilation!\n"); - return 1; + ret = 1; } #endif - return 0; + for (flash = flashchips; flash && flash->name; flash++) + if (selfcheck_eraseblocks(flash)) + ret = 1; + return ret; } void check_chip_supported(struct flashchip *flash) -- Developer quote of the year: "We are juggling too many chainsaws and flaming arrows and tigers."

2 2

[commit] r864 - trunk
by svn＠flashrom.org 18 Jan '10

18 Jan '10

Author: hailfinger Date: 2010-01-18 09:14:43 +0100 (Mon, 18 Jan 2010) New Revision: 864 Modified: trunk/flashrom.c Log: Flashrom performs a self-check on every startup before it even starts to initialize any programmer. That way, compiler errors and code errors will be caught before they can do any harm. This patch adds an eraseblock structure self-check. It also modifies the self-check code to consistently run all checks even if one check failed. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Acked-by: Sean Nelson <audiohacked(a)gmail.com> Modified: trunk/flashrom.c =================================================================== --- trunk/flashrom.c 2010-01-18 07:02:19 UTC (rev 863) +++ trunk/flashrom.c 2010-01-18 08:14:43 UTC (rev 864) @@ -833,6 +833,54 @@ return 0; } +/* This function shares a lot of its structure with erase_flash(). */ +int selfcheck_eraseblocks(struct flashchip *flash) +{ + int i, k; + + for (k = 0; k < NUM_ERASEFUNCTIONS; k++) { + unsigned int done = 0; + struct block_eraser eraser = flash->block_erasers[k]; + + for (i = 0; i < NUM_ERASEREGIONS; i++) { + /* Blocks with zero size are bugs in flashchips.c. */ + if (eraser.eraseblocks[i].count && + !eraser.eraseblocks[i].size) { + msg_gerr("ERROR: Flash chip %s erase function " + "%i region %i has size 0. Please report" + " a bug at flashrom(a)flashrom.org\n", + flash->name, k, i); + return 1; + break; + } + /* Blocks with zero count are bugs in flashchips.c. */ + if (!eraser.eraseblocks[i].count && + eraser.eraseblocks[i].size) { + msg_gerr("ERROR: Flash chip %s erase function " + "%i region %i has count 0. Please report" + " a bug at flashrom(a)flashrom.org\n", + flash->name, k, i); + return 1; + break; + } + done += eraser.eraseblocks[i].count * + eraser.eraseblocks[i].size; + } + /* This erase function is completely empty. */ + if (!done) + continue; + if (done != flash->total_size * 1024) { + msg_gerr("ERROR: Flash chip %s erase function %i " + "region walking resulted in 0x%06x bytes total," + " expected 0x%06x bytes. Please report a bug at" + " flashrom(a)flashrom.org\n", flash->name, k, + done, flash->total_size * 1024); + return 1; + } + } + return 0; +} + int erase_flash(struct flashchip *flash) { int i, j, k, ret = 0, found = 0; @@ -864,17 +912,6 @@ found = 1; printf_debug("trying... "); for (i = 0; i < NUM_ERASEREGIONS; i++) { - /* Blocks with zero size are bugs in flashchips.c. - * FIXME: This check should be performed on startup. - */ - if (eraser.eraseblocks[i].count && - !eraser.eraseblocks[i].size) { - fprintf(stderr, "ERROR: Erase region with size " - "0 for this chip. Please report a bug " - "at flashrom(a)flashrom.org\n"); - ret = 1; - break; - } /* count==0 for all automatically initialized array * members so the loop below won't be executed for them. */ @@ -893,10 +930,6 @@ eraser.eraseblocks[i].size; } printf_debug("\n"); - if (done != flash->total_size * 1024) - fprintf(stderr, "ERROR: Erase region walking erased " - "0x%06x bytes total, expected 0x%06x bytes.", - done, flash->total_size * 1024); /* If everything is OK, don't try another erase function. */ if (!ret) break; @@ -948,22 +981,30 @@ int selfcheck(void) { - /* Safety check. */ + int ret = 0; + struct flashchip *flash; + + /* Safety check. Instead of aborting after the first error, check + * if more errors exist. + */ if (ARRAY_SIZE(programmer_table) - 1 != PROGRAMMER_INVALID) { fprintf(stderr, "Programmer table miscompilation!\n"); - return 1; + ret = 1; } if (spi_programmer_count - 1 != SPI_CONTROLLER_INVALID) { fprintf(stderr, "SPI programmer table miscompilation!\n"); - return 1; + ret = 1; } #if BITBANG_SPI_SUPPORT == 1 if (bitbang_spi_master_count - 1 != BITBANG_SPI_INVALID) { fprintf(stderr, "Bitbanging SPI master table miscompilation!\n"); - return 1; + ret = 1; } #endif - return 0; + for (flash = flashchips; flash && flash->name; flash++) + if (selfcheck_eraseblocks(flash)) + ret = 1; + return ret; } void check_chip_supported(struct flashchip *flash)

1 0

Erase failed on different chips using v0.9.1-r790
by joe black 18 Jan '10

18 Jan '10

Hi all, don't really know if it is the right list but I'll give it a shot (sorry for your inconvenient). I am doing research on different bios chips envolving rewriting of the flash chip. As time goes by, I stumbled into the same problem over and over again (increasing rapidly). At the beginning I thought it might be a Write Protection error but it seems to me that this error is too common to be a write protection kinda crap (as far as I know most of the boards nowadays don't come with write protection enabled by default). here is a couple of flashrom trys output on different chips: After finding out the right chipset and flash chip: "Intel ICH5/ICH5R" "Winbond W49V002FA" (256 KB, FWH) at physical address 0xfffc0000. I get (about) the same error when trying to write: ERASE FAILED at 0x00000000! Expected=0xff, Read-0x25, failed byte cout from 0x00000000-0x0003ffff: 0x35e74 ERASE FAILED! ERASE FAILED! FAILED! on most of the time it fails at 0x000000000 About the same error happend on: "Intel ICH6/ICH6R" "SST SST49LF003A/B" (384 KB, FWH) at physical address 0xfffa0000 page: 0000 at address: 0x00000000>>>>>>>>>0001 at address: 0x00010000>>>>>>>>>0002 at address: 0x00020000 ERASE FAILED at 0x00020000! Expected=0xff, read=0xdb, failed byte count from 0x00020000-0x0002ffff: 0xfee5 ERASE FAILED! ERASE FAILED! FAILED! Same goes for this one: "VIA VT8237" "PMC Pm49FL004" (512 KB, LPC,FWH) at physical address 0xfff80000 ERASE FAILED at 0x00000000! Expected=0xff, Read-0x49, failed byte cout from 0x00000000-0x0000ffff: 0x463 ERASE FAILED! ERASE FAILED! FAILED! Would really like some help, Thanks ahead!

1 0

[PATCH] Fix wiki erase/write columns
by Carl-Daniel Hailfinger 18 Jan '10

18 Jan '10

The write and erase column in the --list-supported-wiki output were swapped. Thanks to Michael Karcher for noticing. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Index: flashrom-print_wiki_swap_erase_write/print_wiki.c =================================================================== --- flashrom-print_wiki_swap_erase_write/print_wiki.c (Revision 860) +++ flashrom-print_wiki_swap_erase_write/print_wiki.c (Arbeitskopie) @@ -75,7 +75,7 @@ ! align=\"left\" | Device\n! align=\"left\" | Size / KB\n\ ! align=\"left\" | Type\n! align=\"left\" colspan=\"4\" | Status\n\n\ |- bgcolor=\"#6699ff\"\n| colspan=\"4\" |  \n\ -| Probe\n| Read\n| Write\n| Erase\n\n"; +| Probe\n| Read\n| Erase\n| Write\n\n"; const char *programmer_section = "\ \n== Supported programmers ==\n\nThis is a list \ -- Developer quote of the year: "We are juggling too many chainsaws and flaming arrows and tigers."

2 2

[commit] r863 - trunk
by svn＠flashrom.org 18 Jan '10

18 Jan '10

Author: hailfinger Date: 2010-01-18 08:02:19 +0100 (Mon, 18 Jan 2010) New Revision: 863 Modified: trunk/print_wiki.c Log: The write and erase column in the --list-supported-wiki output were swapped. Thanks to Michael Karcher for noticing. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Acked-by: Uwe Hermann <uwe(a)hermann-uwe.de> Modified: trunk/print_wiki.c =================================================================== --- trunk/print_wiki.c 2010-01-12 23:29:30 UTC (rev 862) +++ trunk/print_wiki.c 2010-01-18 07:02:19 UTC (rev 863) @@ -75,7 +75,7 @@ ! align=\"left\" | Device\n! align=\"left\" | Size / KB\n\ ! align=\"left\" | Type\n! align=\"left\" colspan=\"4\" | Status\n\n\ |- bgcolor=\"#6699ff\"\n| colspan=\"4\" |  \n\ -| Probe\n| Read\n| Write\n| Erase\n\n"; +| Probe\n| Read\n| Erase\n| Write\n\n"; const char *programmer_section = "\ \n== Supported programmers ==\n\nThis is a list \

1 0

flashrom v0.9.1-r706 works with "Intel ICH10R" chipset and "Eon EN25F80" chip :)
by cam_daw＠fastmail.fm 18 Jan '10

18 Jan '10

Hello, This is to report that flashrom v0.9.1-r706 worked flawlessly for me - and as it is a system that has an unknown status in http://www.flashrom.org/Supported_hardware, could you please update flashrom to confirm that it now works. Details are as follows:- flashrom version: v0.9.1-r706 (that's in Ubuntu 9.10 x86_64 repositories) Board Manufacturer: Shuttle Board Model: SX58H7 Chipset: "Intel ICH10R" Chip: "Eon EN25F80" (1024 KB, SPI) at physical address 0xfff00000 The following flashrom commands work:- flashrom -V flashrom -rV saved.rom flashrom -EV flashrom -wV new.rom I've attached the output of these commands to this email. Note that the output from the "flashrom -wV new.rom" command generated a very large text file (1.8MB), but worked successfully as I verified my computer functioning with the new bios update past a cold boot. Also, after reading the updated bios rom to a file, and comparing the md5sums of the extracted rom and downloaded-from-the-web rom, the file's checksums match. So it wrote and read the rom files fine. Thanks for your excellent application flashrom - it's saved me a lot of time :) Regards, Cameron Dawdy -- cam_daw(a)fastmail.fm -- http://www.fastmail.fm - Does exactly what it says on the tin

1 0

Re: [flashrom] [PATCH] Support Intel 82F004BE/BV-T chip
by Sean Nelson 17 Jan '10

17 Jan '10

On 1/16/2010 4:21 PM, Michael Karcher wrote: > This chip is found in the ThinkPad T20. Implementation is from datasheet only, > test welcome. Be prepared for eventual failures, and do not reboot if > verify after write fails. > > Signed-off-by: Michael Karcher<flashrom(a)mkarcher.dialup.fu-berlin.de> > --- > Makefile | 2 +- > chipdrivers.h | 4 ++ > flashchips.c | 31 +++++++++++++++++++ > flashchips.h | 2 + > i28f00x.c | 91 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 5 files changed, 129 insertions(+), 1 deletions(-) > create mode 100644 i28f00x.c > > diff --git a/Makefile b/Makefile > index cdd45d1..2b882d4 100644 > --- a/Makefile > +++ b/Makefile > @@ -44,7 +44,7 @@ endif > CHIP_OBJS = jedec.o stm50flw0x0x.o w39v080fa.o sharplhf00l04.o w29ee011.o \ > sst28sf040.o am29f040b.o mx29f002.o m29f400bt.o pm29f002.o w39v040c.o \ > w49f002u.o 82802ab.o pm49fl00x.o sst49lf040.o en29f002a.o m29f002.o \ > - sst49lfxxxc.o sst_fwhub.o flashchips.o spi.o > + sst49lfxxxc.o sst_fwhub.o flashchips.o spi.o i28f00x.o > > LIB_OBJS = layout.o > > diff --git a/chipdrivers.h b/chipdrivers.h > index e7261e0..be1d00b 100644 > --- a/chipdrivers.h > +++ b/chipdrivers.h > @@ -52,11 +52,15 @@ int spi_nbyte_read(int addr, uint8_t *bytes, int len); > int spi_read_chunked(struct flashchip *flash, uint8_t *buf, int start, int len, int chunksize); > int spi_aai_write(struct flashchip *flash, uint8_t *buf); > > +/* i28f00x.c */ > +int write_28f00x(struct flashchip *flash, uint8_t *buf); > + > /* 82802ab.c */ > uint8_t wait_82802ab(chipaddr bios); > int probe_82802ab(struct flashchip *flash); > int erase_82802ab(struct flashchip *flash); > int erase_82802ab_block(struct flashchip *flash, unsigned int page, unsigned int pagesize); > +void write_page_82802ab(chipaddr bios, uint8_t *src, chipaddr dst, int page_size); > int write_82802ab(struct flashchip *flash, uint8_t *buf); > > /* am29f040b.c */ > diff --git a/flashchips.c b/flashchips.c > index 8e90d2a..3698c8c 100644 > --- a/flashchips.c > +++ b/flashchips.c > @@ -2385,6 +2385,37 @@ struct flashchip flashchips[] = { > > { > .vendor = "Intel", > + .name = "28F004BV/BE-T", > + .bustype = CHIP_BUSTYPE_PARALLEL, > + .manufacture_id = INTEL_ID, > + .model_id = P28F004BT, > + .total_size = 512, > + .page_size = 128 * 1024, /* for write_i28f00x: maximal block size */ > + .tested = TEST_UNTESTED, > + .probe = probe_jedec, > + .probe_timing = TIMING_ZERO, /* Datasheet has no timing info specified */ > + .erase = NULL, > + .block_erasers = > + { > + { > + /* Keep this the first block_erasers > + entry. The write functions spies here to > + get the chip layout */ > + .eraseblocks = { > + {128 * 1024, 3}, > + {96 * 1024, 1}, > + {8 * 1024, 2}, > + {16 * 1024, 1}, > + }, > + .block_erase = erase_82802ab_block, > + }, > + }, > + .write = write_28f00x, > + .read = read_memmapped, > + }, > + > + { > + .vendor = "Intel", > .name = "82802AB", > .bustype = CHIP_BUSTYPE_FWH, > .manufacture_id = INTEL_ID, > diff --git a/flashchips.h b/flashchips.h > index 2a4d93b..21d7ad5 100644 > --- a/flashchips.h > +++ b/flashchips.h > @@ -256,6 +256,8 @@ > #define I_82802AC 0xAC > #define P28F001BXT 0x94 /* 28F001BX-T */ > #define P28F001BXB 0x95 /* 28F001BX-B */ > +#define P28F004BT 0x78 /* 28F004BV/BE-T */ > +#define P28F004BB 0x79 /* 28F004BV/BE-B */ > #define SHARP_LH28F008SA 0xA2 /* Sharp chip, Intel Vendor ID */ > #define SHARP_LH28F008SC 0xA6 /* Sharp chip, Intel Vendor ID */ > > diff --git a/i28f00x.c b/i28f00x.c > new file mode 100644 > index 0000000..f312fb1 > --- /dev/null > +++ b/i28f00x.c > @@ -0,0 +1,91 @@ > +/* > + * This file is part of the flashrom project. > + * > + * Copyright (C) 2010 Michael Karcher<flashrom(a)mkarcher.dialup.fu-berlin.de> > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > + * along with this program; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA > + */ > + > +/* based on the Intel 82802A/B code which is > + * Copyright (C) 2000 Silicon Integrated System Corporation > + */ > + > +/* > + * Datasheet: > + * - Name: 4-Mbit (256K x 16, 512K x 8) SmartVoltage DataSheet > + * - URL: http://www.intel.com/design/archives/flash/docs/290530.HTM > + * - PDF: http://download.intel.com/design/archives/flash/docs/29053006.pdf > + * - Order number: 290430-006 > + */ > + > +#include<stdio.h> > +#include<stdlib.h> > +#include<string.h> > +#include "flash.h" > +#include "chipdrivers.h" > + > +int write_28f00x(struct flashchip *flash, uint8_t *buf) > +{ > + int i, j, blocknum; > + chipaddr bios = flash->virtual_memory; > + int blockoffset = 0; > + uint8_t *tmpbuf = malloc(flash->page_size); > + struct eraseblock * blocks = flash->block_erasers[0].eraseblocks; > + > + if (!tmpbuf) { > + printf("Could not allocate memory!\n"); > + exit(1); > + } > + printf("Programming block: \n"); > + blocknum = 0; > + for (i = 0; blocks[i].size != 0; i++) { > + for(j = 0; j< blocks[i].count; j++) { > + printf("\b\b\b\b\b\b\b\b\b\b\b\b\b\b" > + "\b\b\b\b\b\b\b\b\b\b\b\b\b"); > + printf("%04d at address: 0x%08x", blocknum, > + blockoffset); > + > + /* Auto Skip Blocks, which already contain the > + * desired data Faster, because we only write, what > + * has changed More secure, because blocks, which > + * are excluded (with the exclude or layout feature) > + * or not erased and rewritten; their data is > + * retained also in sudden power off situations > + */ > + chip_readn(tmpbuf, bios + blockoffset, blocks[i].size); > + if (!memcmp((void *)(buf + blockoffset), tmpbuf, > + blocks[i].size)) { > + printf("SKIPPED\n"); > + continue; > + } > + > + /* erase block by block and write block by block; > + this is the most secure way */ > + if (erase_82802ab_block(flash, blockoffset, > + blocks[i].size)) { > + fprintf(stderr, "ERASE FAILED!\n"); > + return -1; > + } > + write_page_82802ab(bios, buf + blockoffset, > + bios + blockoffset, blocks[i].size); > + blockoffset += blocks[i].size; > + blocknum++; > + } > + } > + printf("\n"); > + free(tmpbuf); > + > + return 0; > +} > It's great that you used block_erasers for the chip definition, but I don't understand the reason for write_28f00x. It looks exactly the same as write_82802 except for using erase blocks segments. i28f00x.c is completely unnecessary and extraneous in my opinion.

3 3

[PATCH] Support Intel 82F004BE/BV-T chip
by Michael Karcher 17 Jan '10

17 Jan '10

This chip is found in the ThinkPad T20. Implementation is from datasheet only, test welcome. Be prepared for eventual failures, and do not reboot if verify after write fails. Signed-off-by: Michael Karcher <flashrom(a)mkarcher.dialup.fu-berlin.de> --- Makefile | 2 +- chipdrivers.h | 4 ++ flashchips.c | 31 +++++++++++++++++++ flashchips.h | 2 + i28f00x.c | 91 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 5 files changed, 129 insertions(+), 1 deletions(-) create mode 100644 i28f00x.c diff --git a/Makefile b/Makefile index cdd45d1..2b882d4 100644 --- a/Makefile +++ b/Makefile @@ -44,7 +44,7 @@ endif CHIP_OBJS = jedec.o stm50flw0x0x.o w39v080fa.o sharplhf00l04.o w29ee011.o \ sst28sf040.o am29f040b.o mx29f002.o m29f400bt.o pm29f002.o w39v040c.o \ w49f002u.o 82802ab.o pm49fl00x.o sst49lf040.o en29f002a.o m29f002.o \ - sst49lfxxxc.o sst_fwhub.o flashchips.o spi.o + sst49lfxxxc.o sst_fwhub.o flashchips.o spi.o i28f00x.o LIB_OBJS = layout.o diff --git a/chipdrivers.h b/chipdrivers.h index e7261e0..be1d00b 100644 --- a/chipdrivers.h +++ b/chipdrivers.h @@ -52,11 +52,15 @@ int spi_nbyte_read(int addr, uint8_t *bytes, int len); int spi_read_chunked(struct flashchip *flash, uint8_t *buf, int start, int len, int chunksize); int spi_aai_write(struct flashchip *flash, uint8_t *buf); +/* i28f00x.c */ +int write_28f00x(struct flashchip *flash, uint8_t *buf); + /* 82802ab.c */ uint8_t wait_82802ab(chipaddr bios); int probe_82802ab(struct flashchip *flash); int erase_82802ab(struct flashchip *flash); int erase_82802ab_block(struct flashchip *flash, unsigned int page, unsigned int pagesize); +void write_page_82802ab(chipaddr bios, uint8_t *src, chipaddr dst, int page_size); int write_82802ab(struct flashchip *flash, uint8_t *buf); /* am29f040b.c */ diff --git a/flashchips.c b/flashchips.c index 8e90d2a..3698c8c 100644 --- a/flashchips.c +++ b/flashchips.c @@ -2385,6 +2385,37 @@ struct flashchip flashchips[] = { { .vendor = "Intel", + .name = "28F004BV/BE-T", + .bustype = CHIP_BUSTYPE_PARALLEL, + .manufacture_id = INTEL_ID, + .model_id = P28F004BT, + .total_size = 512, + .page_size = 128 * 1024, /* for write_i28f00x: maximal block size */ + .tested = TEST_UNTESTED, + .probe = probe_jedec, + .probe_timing = TIMING_ZERO, /* Datasheet has no timing info specified */ + .erase = NULL, + .block_erasers = + { + { + /* Keep this the first block_erasers + entry. The write functions spies here to + get the chip layout */ + .eraseblocks = { + {128 * 1024, 3}, + {96 * 1024, 1}, + {8 * 1024, 2}, + {16 * 1024, 1}, + }, + .block_erase = erase_82802ab_block, + }, + }, + .write = write_28f00x, + .read = read_memmapped, + }, + + { + .vendor = "Intel", .name = "82802AB", .bustype = CHIP_BUSTYPE_FWH, .manufacture_id = INTEL_ID, diff --git a/flashchips.h b/flashchips.h index 2a4d93b..21d7ad5 100644 --- a/flashchips.h +++ b/flashchips.h @@ -256,6 +256,8 @@ #define I_82802AC 0xAC #define P28F001BXT 0x94 /* 28F001BX-T */ #define P28F001BXB 0x95 /* 28F001BX-B */ +#define P28F004BT 0x78 /* 28F004BV/BE-T */ +#define P28F004BB 0x79 /* 28F004BV/BE-B */ #define SHARP_LH28F008SA 0xA2 /* Sharp chip, Intel Vendor ID */ #define SHARP_LH28F008SC 0xA6 /* Sharp chip, Intel Vendor ID */ diff --git a/i28f00x.c b/i28f00x.c new file mode 100644 index 0000000..f312fb1 --- /dev/null +++ b/i28f00x.c @@ -0,0 +1,91 @@ +/* + * This file is part of the flashrom project. + * + * Copyright (C) 2010 Michael Karcher <flashrom(a)mkarcher.dialup.fu-berlin.de> + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + */ + +/* based on the Intel 82802A/B code which is + * Copyright (C) 2000 Silicon Integrated System Corporation + */ + +/* + * Datasheet: + * - Name: 4-Mbit (256K x 16, 512K x 8) SmartVoltage DataSheet + * - URL: http://www.intel.com/design/archives/flash/docs/290530.HTM + * - PDF: http://download.intel.com/design/archives/flash/docs/29053006.pdf + * - Order number: 290430-006 + */ + +#include <stdio.h> +#include <stdlib.h> +#include <string.h> +#include "flash.h" +#include "chipdrivers.h" + +int write_28f00x(struct flashchip *flash, uint8_t *buf) +{ + int i, j, blocknum; + chipaddr bios = flash->virtual_memory; + int blockoffset = 0; + uint8_t *tmpbuf = malloc(flash->page_size); + struct eraseblock * blocks = flash->block_erasers[0].eraseblocks; + + if (!tmpbuf) { + printf("Could not allocate memory!\n"); + exit(1); + } + printf("Programming block: \n"); + blocknum = 0; + for (i = 0; blocks[i].size != 0; i++) { + for(j = 0; j < blocks[i].count; j++) { + printf("\b\b\b\b\b\b\b\b\b\b\b\b\b\b" + "\b\b\b\b\b\b\b\b\b\b\b\b\b"); + printf("%04d at address: 0x%08x", blocknum, + blockoffset); + + /* Auto Skip Blocks, which already contain the + * desired data Faster, because we only write, what + * has changed More secure, because blocks, which + * are excluded (with the exclude or layout feature) + * or not erased and rewritten; their data is + * retained also in sudden power off situations + */ + chip_readn(tmpbuf, bios + blockoffset, blocks[i].size); + if (!memcmp((void *)(buf + blockoffset), tmpbuf, + blocks[i].size)) { + printf("SKIPPED\n"); + continue; + } + + /* erase block by block and write block by block; + this is the most secure way */ + if (erase_82802ab_block(flash, blockoffset, + blocks[i].size)) { + fprintf(stderr, "ERASE FAILED!\n"); + return -1; + } + write_page_82802ab(bios, buf + blockoffset, + bios + blockoffset, blocks[i].size); + blockoffset += blocks[i].size; + blocknum++; + } + } + printf("\n"); + free(tmpbuf); + + return 0; +} -- 1.6.5

1 0

[PATCH] [rfc/demo] implementation of the Thinkpad T20/T21/T22 host
by Michael Karcher 16 Jan '10

16 Jan '10

This mainboard uses external pins for banking the ROM chip, which seems to be impossible to do with the "internal" programmer, yet I had to clone most of the init stuff from internal.c . Hints for a clean implementation will be appreciated. --- Makefile | 2 +- flash.h | 11 ++++++ flashrom.c | 19 ++++++++++ t20.c | 108 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 139 insertions(+), 1 deletions(-) create mode 100644 t20.c diff --git a/Makefile b/Makefile index 501f65a..cdd45d1 100644 --- a/Makefile +++ b/Makefile @@ -101,7 +101,7 @@ CONFIG_PRINT_WIKI ?= no ifeq ($(CONFIG_INTERNAL), yes) FEATURE_CFLAGS += -D'INTERNAL_SUPPORT=1' -PROGRAMMER_OBJS += chipset_enable.o board_enable.o cbtable.o it87spi.o ichspi.o sb600spi.o wbsio_spi.o +PROGRAMMER_OBJS += chipset_enable.o board_enable.o cbtable.o it87spi.o ichspi.o sb600spi.o t20.o wbsio_spi.o NEED_PCI := yes endif diff --git a/flash.h b/flash.h index 9a25c70..77b0d48 100644 --- a/flash.h +++ b/flash.h @@ -58,6 +58,9 @@ enum programmer { #if INTERNAL_SUPPORT == 1 PROGRAMMER_IT87SPI, #endif +#if INTERNAL_SUPPORT == 1 + PROGRAMMER_TPT20, +#endif #if FT2232_SPI_SUPPORT == 1 PROGRAMMER_FT2232SPI, #endif @@ -435,6 +438,14 @@ uint8_t drkaiser_chip_readb(const chipaddr addr); extern struct pcidev_status drkaiser_pcidev[]; #endif +/* t20.c */ +#if INTERNAL_SUPPORT == 1 +int t20_init(void); +int t20_shutdown(void); +void t20_chip_writeb(uint8_t val, chipaddr addr); +uint8_t t20_chip_readb(const chipaddr addr); +#endif + /* satasii.c */ #if SATASII_SUPPORT == 1 int satasii_init(void); diff --git a/flashrom.c b/flashrom.c index db44c2f..7f05eeb 100644 --- a/flashrom.c +++ b/flashrom.c @@ -226,6 +226,25 @@ const struct programmer_entry programmer_table[] = { }, #endif +#if INTERNAL_SUPPORT == 1 + { + .name = "t20", + .init = t20_init, + .shutdown = t20_shutdown, + .map_flash_region = fallback_map, + .unmap_flash_region = fallback_unmap, + .chip_readb = t20_chip_readb, + .chip_readw = fallback_chip_readw, + .chip_readl = fallback_chip_readl, + .chip_readn = fallback_chip_readn, + .chip_writeb = t20_chip_writeb, + .chip_writew = fallback_chip_writew, + .chip_writel = fallback_chip_writel, + .chip_writen = fallback_chip_writen, + .delay = internal_delay, + }, +#endif + #if FT2232_SPI_SUPPORT == 1 { .name = "ft2232spi", diff --git a/t20.c b/t20.c new file mode 100644 index 0000000..d6841cc --- /dev/null +++ b/t20.c @@ -0,0 +1,108 @@ +/* + * This file is part of the flashrom project. + * + * Copyright (C) 2010 Michael Karcher <flashrom(a)mkarcher.dialup.fu-berlin.de> + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + */ + +/* Base address of register IND1 in the Field IMGA in the DSDT */ +#define IMGA1_BASE 0x15EE + +#include "flash.h" + +static uint8_t *t20_base; + +#define MAX_COUNT 20 + +static void imga1_mask(uint8_t index, uint8_t mask, uint8_t value) +{ + uint16_t temp; + int count = 0; + /* Be careful, as ACPI might use these registers too, so check + that the index is still OK. */ + do { + OUTB(index, IMGA1_BASE); + temp = INW(IMGA1_BASE); + } + while ((temp & 0xff) != index && ++count < MAX_COUNT); + if(count == MAX_COUNT) + { + printf("error: IMGA1 index stuck at %02x\n", temp & 0xff); + return; + } + temp &= ~(mask << 8); + temp |= (value & mask) << 8; + OUTW(temp, IMGA1_BASE); +} + +int t20_init(void) +{ + pacc = pci_alloc(); + pci_init(pacc); + pci_scan_bus(pacc); /* We want to get the list of devices */ + get_io_perms(); + /* ID of the graphics chip in T20/T21/T22. The mainboards are + identical in these models */ + if (!pci_card_find(0x5333, 0x8c12, 0x1014, 0x017f)) + { + msg_perr("This is not a ThinkPad T20/T21/T22\n"); + return 1; + } + if (chipset_flash_enable() == -2) { + printf("WARNING: No chipset found. Flash detection " + "will most likely fail.\n"); + } + + imga1_mask(0, 4, 4); /* Enable flash writes */ + t20_base = physmap("IBM T20 mainboard flash", 0xFFFE0000, 0x20000); + buses_supported = CHIP_BUSTYPE_PARALLEL; + return 0; +} + +int t20_shutdown(void) +{ + physunmap(t20_base, 0x20000); + imga1_mask(0, 4, 4); /* Disable flash writes */ + release_io_perms(); + pci_cleanup(pacc); + return 0; +} + +static unsigned int currentbank = -1U; + +static void switchtobank(unsigned int banknum) +{ + if (banknum > 3) + { + msg_perr("Bad bank number %d\n", banknum); + return; + } + if(banknum != currentbank) + imga1_mask(0, 3, banknum); + currentbank = banknum; +} + +void t20_chip_writeb(uint8_t val, chipaddr addr) +{ + switchtobank(addr >> 17); + mmio_writeb(val, t20_base + (addr & 0x1FFFF)); +} + +uint8_t t20_chip_readb(chipaddr addr) +{ + switchtobank(addr >> 17); + return mmio_readb(t20_base + (addr & 0x1FFFF)); +} -- 1.6.5

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

flashrom