flashrom

flashrom@flashrom.org

1 participants
9187 discussions

[PATCH] Delay between probe and subsequent operations
by Carl-Daniel Hailfinger 15 Sep '10

15 Sep '10

Delay between probe and subsequent operations. Some flash chips need time to exit ID mode, and while we take care of correct timing for the matching probe, subsequent probes may have totally different timing, and that can lead to garbage responses from the flash chip during the first accesses after the probe sequence is done. Delay 100 ms between the last probe and any subsequent operation. To ensure maximum correctness, we would have to reset the chip first in case the last probe function left the chip in an undefined (non-read) state. That will be possible once struct flashchip has a .reset function. This fixes unstable erase/read/write for some flahs chips on nic3com and possible other use cases as well. Thanks to Maciej Pijanka for reporting the issue and testing patches. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Index: flashrom-delay_after_probes/cli_classic.c =================================================================== --- flashrom-delay_after_probes/cli_classic.c (Revision 1171) +++ flashrom-delay_after_probes/cli_classic.c (Arbeitskopie) @@ -456,5 +456,10 @@ if (write_it && !dont_verify_it) verify_it = 1; + /* FIXME: We should issue an unconditional chip reset here. This can be + * done once we have a .reset function in struct flashchip. + * Give the chip time to settle. + */ + programmer_delay(100000); return doit(flash, force, filename, read_it, write_it, erase_it, verify_it); } -- http://www.hailfinger.org/

2 3

[commit] r1172 - trunk
by repository service 15 Sep '10

15 Sep '10

Author: hailfinger Date: Wed Sep 15 12:20:16 2010 New Revision: 1172 URL: http://flashrom.org/trac/flashrom/changeset/1172 Log: Delay between probe and subsequent operations. Some flash chips need time to exit ID mode, and while we take care of correct timing for the matching probe, subsequent probes may have totally different timing, and that can lead to garbage responses from the flash chip during the first accesses after the probe sequence is done. Delay 100 ms between the last probe and any subsequent operation. To ensure maximum correctness, we would have to reset the chip first in case the last probe function left the chip in an undefined (non-read) state. That will be possible once struct flashchip has a .reset function. This fixes unstable erase/read/write for some flahs chips on nic3com and possible other use cases as well. Thanks to Maciej Pijanka for reporting the issue and testing patches. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Acked-by: Michael Karcher <flashrom(a)mkarcher.dialup.fu-berlin.de> Modified: trunk/cli_classic.c Modified: trunk/cli_classic.c ============================================================================== --- trunk/cli_classic.c Wed Sep 15 02:17:37 2010 (r1171) +++ trunk/cli_classic.c Wed Sep 15 12:20:16 2010 (r1172) @@ -456,5 +456,10 @@ if (write_it && !dont_verify_it) verify_it = 1; + /* FIXME: We should issue an unconditional chip reset here. This can be + * done once we have a .reset function in struct flashchip. + * Give the chip time to settle. + */ + programmer_delay(100000); return doit(flash, force, filename, read_it, write_it, erase_it, verify_it); }

1 0

Fwd: flashrom test on MSI PM8M3-V 4.1
by Shahar Or 15 Sep '10

15 Sep '10

---------- Forwarded message ---------- From: Shahar Or <mightyiampresence(a)gmail.com> Date: Wed, 15 Sep 2010 08:59:02 +0200 Subject: Re: flashrom test on MSI PM8M3-V 4.1 To: Uwe Hermann <uwe(a)hermann-uwe.de> Dear ones, It is the V H, actually. Thanks for noticing. Blessings, Shahar On 9/15/10, Uwe Hermann <uwe(a)hermann-uwe.de> wrote: > On Sat, Sep 04, 2010 at 11:39:58AM +0000, Shahar Or wrote: >> DMI string system-product-name: "MS-7211" > [...] >> SUCCESS. >> COMPLETE. >> Verifying flash... VERIFIED. > > Look good, thanks, we marked the "MSI MS-7211 (PM8M3-V)" as tested. > Just to make sure, you have the "PM8M3-V", not the "PM8M3-V H", right? > > > Thanks, Uwe. > -- > http://hermann-uwe.de | http://sigrok.org > http://randomprojects.org | http://unmaintained-free-software.org > -- Sent from my mobile device -- Sent from my mobile device

1 0

[PATCH] New chip IDs
by Carl-Daniel Hailfinger 15 Sep '10

15 Sep '10

Sorry for the totally meaningless subject. I wanted to get the current state of one of my ID-collection trees out there. Maybe someone finds it useful. The patch is WIP, but hey... if parts of it are mergeable, even better. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Index: flashrom-newchips/flashchips.c =================================================================== --- flashrom-newchips/flashchips.c (Revision 1171) +++ flashrom-newchips/flashchips.c (Arbeitskopie) @@ -1335,6 +1335,8 @@ .read = spi_chip_read, }, +/* The AT25F512, AT25F1024 and AT25F2048 apparently support a 0x62 chip erase? */ + { .vendor = "Atmel", .name = "AT25F512B", Index: flashrom-newchips/flashchips.h =================================================================== --- flashrom-newchips/flashchips.h (Revision 1171) +++ flashrom-newchips/flashchips.h (Arbeitskopie) @@ -58,12 +58,15 @@ #define AM_29F400BT 0x23 #define AM_29F800BB 0x58 #define AM_29F800BT 0xD6 +#define AMD_AM29LV001B 0x6D +#define AMD_AM29LV001T 0xED #define AM_29LV002BB 0xC2 #define AM_29LV002BT 0x40 #define AM_29LV004BB 0xB6 #define AM_29LV004BT 0xB5 #define AM_29LV008BB 0x37 #define AM_29LV008BT 0x3E +#define AMD_AM29LV010 0x6E #define AM_29LV040B 0x4F #define AM_29LV080B 0x38 /* Same as Am29LV081B */ #define AM_29LV200BB 0xBF @@ -121,14 +124,21 @@ #define AT_25DF641 0x4800 #define AT_25DQ161 0x8600 #define AT25F512 /* No device ID found in datasheet. Vendor ID - * can be read with AT25F512A_RDID */ + * can be read with AT25F512A_RDID. + * ID is 0x65??? + */ #define AT_25F512A 0x65 /* Needs AT25F512A_RDID */ #define AT_25F512B 0x6500 #define AT25F1024 /* No device ID found in datasheet. Vendor ID - * can be read with AT25F512A_RDID */ + * can be read with AT25F512A_RDID. + * ID is 0x60 or 0x40??? + */ #define AT_25F1024A 0x60 /* Needs AT25F512A_RDID */ +#define ATMEL_AT25F2048 0x63 /* Special RDID */ #define AT_25FS010 0x6601 #define AT_25FS040 0x6604 +#define ATMEL_AT25DF021 0x4300 +#define ATMEL_AT25DF041 0x4401 #define AT_26DF041 0x4400 #define AT_26DF081 0x4500 /* guessed, no datasheet available */ #define AT_26DF081A 0x4501 @@ -136,6 +146,8 @@ #define AT_26DF161A 0x4601 #define AT_26DF321 0x4700 /* Same as 25DF321 */ #define AT_26F004 0x0400 +#define ATMEL_AT29LV512 0x3D +#define ATMEL_AT29LV010A 0x35 /* Same as AT29BV010A? */ #define AT_29C040A 0xA4 #define AT_29C010A 0xD5 #define AT_29C020 0xDA @@ -166,7 +178,11 @@ #define AT_45DB321D 0x2701 /* Buggy data sheet */ #define AT_45DB642 /* No ID available */ #define AT_45DB642D 0x2800 -#define AT_49BV512 0x03 +#define AT_49BV512 0x03 /* Same as AT49F512? */ +#define ATMEL_AT49F001 0x05 +#define ATMEL_AT49F001T 0x04 +#define ATMEL_AT49F010 0x87 +#define ATMEL_AT49LV010 0x17 /* Same as AT49BV010? */ #define AT_49F020 0x0B #define AT_49F002N 0x07 /* for AT49F002(N) */ #define AT_49F002NT 0x08 /* for AT49F002(N)T */ @@ -360,6 +376,7 @@ */ #define PMC_ID 0x7F9D /* PMC */ #define PMC_ID_NOPREFIX 0x9D /* PMC, missing 0x7F prefix */ +#define PMC_PM25LD512 0x20 /* Uses PMC_ID instead of the usual PMC_ID_NOPREFIX */ #define PMC_25LV512 0x7B #define PMC_25LV010 0x7C #define PMC_25LV020 0x7D @@ -412,9 +429,9 @@ #define SST_25WF010 0x2502 #define SST_25WF020 0x2503 #define SST_25WF040 0x2504 -#define SST_25VF512A_REMS 0x48 /* REMS or RES opcode */ +#define SST_25VF512A_REMS 0x48 /* REMS or RES opcode, also SST25VF512? */ #define SST_25VF010_REMS 0x49 /* REMS or RES opcode */ -#define SST_25VF020_REMS 0x43 /* REMS or RES opcode */ +#define SST_25VF020_REMS 0x43 /* REMS or RES opcode, also SST25LF020? */ #define SST_25VF040_REMS 0x44 /* REMS or RES opcode, same as SST25LF040A */ #define SST_25VF040B 0x258D #define SST_25VF040B_REMS 0x8D /* REMS or RES opcode */ @@ -434,6 +451,7 @@ #define SST_27VF020 0xAA #define SST_28SF040 0x04 #define SST_29EE512 0x5D +#define SST_29LE512 0x3D /* Same as SST29VE512 */ #define SST_29EE010 0x07 #define SST_29LE010 0x08 /* Same as SST29VE010 */ #define SST_29EE020A 0x10 /* Same as SST29EE020 */ @@ -451,6 +469,7 @@ #define SST_39VF020 0xD6 /* Same as 39LF020 */ #define SST_39VF040 0xD7 /* Same as 39LF040 */ #define SST_39VF080 0xD8 /* Same as 39LF080/39VF080/39VF088 */ +#define SST_45VF010 0x42 /* FIXME */ #define SST_49LF040B 0x50 #define SST_49LF040 0x51 #define SST_49LF020 0x61 @@ -469,10 +488,11 @@ /* * ST25P chips are SPI, first byte of device ID is memory type, second * byte of device ID is related to log(bitsize) at least for some chips. + * ST is now called Numonyx. */ #define ST_ID 0x20 /* ST / SGS/Thomson */ #define ST_M25P05A 0x2010 -#define ST_M25P05_RES 0x10 /* Same code as M25P10. */ +#define ST_M25P05_RES 0x10 /* Same code as M25P10. Datasheet error? Should be 0x05? */ #define ST_M25P10A 0x2011 #define ST_M25P10_RES 0x10 /* Same code as M25P05. */ #define ST_M25P20 0x2012 @@ -530,6 +550,9 @@ #define SM_MVC_29C51002B 0xA2 /* Identical chips: {F,S,V}29C51002B */ #define SM_MVC_29C51004B 0xA3 /* Identical chips: {F,S,V}29C51004B */ +#define TENX_ID_NOPREFIX 0x5E /* Tenx Technologies, 0x7F7F5E */ +#define TENX_ICE25P05 0x01 /* Maybe? */ + #define TI_ID 0x97 /* Texas Instruments */ #define TI_OLD_ID 0x01 /* TI chips from last century */ #define TI_TMS29F002RT 0xB0 @@ -540,10 +563,10 @@ * byte of device ID is related to log(bitsize). */ #define WINBOND_NEX_ID 0xEF /* Winbond (ex Nexcom) serial flashes */ -#define WINBOND_NEX_W25X10 0x3011 -#define WINBOND_NEX_W25X20 0x3012 -#define WINBOND_NEX_W25X40 0x3013 -#define WINBOND_NEX_W25X80 0x3014 +#define WINBOND_NEX_W25X10 0x3011 /* W25X10A? */ +#define WINBOND_NEX_W25X20 0x3012 /* W25X20A? */ +#define WINBOND_NEX_W25X40 0x3013 /* W25X40A? */ +#define WINBOND_NEX_W25X80 0x3014 /* W25X80A? */ #define WINBOND_NEX_W25X16 0x3015 #define WINBOND_NEX_W25X32 0x3016 #define WINBOND_NEX_W25X64 0x3017 @@ -565,7 +588,7 @@ #define WINBOND_W19B323MT 0x13 #define WINBOND_W19B324MB 0x97 #define WINBOND_W19B324MT 0x16 -#define WINBOND_W29C010 0xC1 /* Same as W29C010M, W29C011A, W29EE011, W29EE012, and ASD AE29F1008 */ +#define WINBOND_W29C010 0xC1 /* Same as W29C010M, W29C011A, W29EE011, W29EE012, and ASD AE29F1008 (is there a W29C011?) */ #define WINBOND_W29C020 0x45 /* Same as W29C020C, W29C022 and ASD AE29F2008 */ #define WINBOND_W29C040 0x46 /* Same as W29C040P */ #define WINBOND_W29C512A 0xC8 /* Same as W29EE512 */ -- http://www.hailfinger.org/

1 0

[PATCH] SPI bitbanging: request/release bus
by Carl-Daniel Hailfinger 15 Sep '10

15 Sep '10

SPI bitbanging on devices which speak SPI natively has a dual-use problem: We need to shut down normal SPI operations to do the bitbanging ourselves. Once we're done, it makes a lot of sense to reenable "normal" SPI operations again. Add request_bus/release_bus functions to struct bitbang_spi_master. Add a bitbang shutdown function (not used yet). Change MCP SPI and Intel NIC SPI to use the new request/release bus infrastructure. There are multiple possible strategies for bus request/release: - Request at the start of a SPI command, release immediately afterwards. - Request at the start of a SPI multicommand, release once all commands of the multicommand are done. - Request on programmer init, release on shutdown. Each strategy has its own advantages. For now, we will stay with the first strategy which worked fine so far. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Index: flashrom-bitbang_spi_init_errorcheck_request_release_bus/bitbang_spi.c =================================================================== --- flashrom-bitbang_spi_init_errorcheck_request_release_bus/bitbang_spi.c (Revision 1164) +++ flashrom-bitbang_spi_init_errorcheck_request_release_bus/bitbang_spi.c (Arbeitskopie) @@ -53,6 +53,18 @@ return bitbang_spi_master->get_miso(); } +static void bitbang_spi_request_bus(void) +{ + if (bitbang_spi_master->request_bus) + bitbang_spi_master->request_bus(); +} + +static void bitbang_spi_release_bus(void) +{ + if (bitbang_spi_master->release_bus) + bitbang_spi_master->release_bus(); +} + int bitbang_spi_init(const struct bitbang_spi_master *master, int halfperiod) { /* BITBANG_SPI_INVALID is 0, so if someone forgot to initialize ->type, @@ -61,19 +73,44 @@ */ if (!master || master->type == BITBANG_SPI_INVALID || !master->set_cs || !master->set_sck || !master->set_mosi || !master->get_miso) { - msg_perr("Incomplete bitbanging SPI master setting! Please " - "report a bug at flashrom(a)flashrom.org\n"); + msg_perr("Incomplete SPI bitbang master setting! " + "Please report a bug at flashrom(a)flashrom.org\n"); return 1; } + if (bitbang_spi_master) { + msg_perr("SPI bitbang master already initialized! " + "Please report a bug at flashrom(a)flashrom.org\n"); + return 1; + } + bitbang_spi_master = master; bitbang_spi_half_period = halfperiod; + /* FIXME: Run bitbang_spi_request_bus here or in programmer init? */ bitbang_spi_set_cs(1); bitbang_spi_set_sck(0); bitbang_spi_set_mosi(0); return 0; } +int bitbang_spi_shutdown(const struct bitbang_spi_master *master) +{ + if (!bitbang_spi_master) { + msg_perr("Shutting down an uninitialized SPI bitbang master! " + "Please report a bug at flashrom(a)flashrom.org\n"); + return 1; + } + if (master != bitbang_spi_master) { + msg_perr("Shutting down a mismatched SPI bitbang master! " + "Please report a bug at flashrom(a)flashrom.org\n"); + return 1; + } + + /* FIXME: Run bitbang_spi_release_bus here or per command? */ + bitbang_spi_master = NULL; + return 0; +} + static uint8_t bitbang_spi_readwrite_byte(uint8_t val) { uint8_t ret = 0; @@ -96,6 +133,11 @@ { int i; + /* FIXME: Run bitbang_spi_request_bus here or in programmer init? + * Requesting and releasing the SPI bus is handled in here to allow the + * programmer to use its own SPI engine for native accesses. + */ + bitbang_spi_request_bus(); bitbang_spi_set_cs(0); for (i = 0; i < writecnt; i++) bitbang_spi_readwrite_byte(writearr[i]); @@ -105,6 +147,8 @@ programmer_delay(bitbang_spi_half_period); bitbang_spi_set_cs(1); programmer_delay(bitbang_spi_half_period); + /* FIXME: Run bitbang_spi_release_bus here or in programmer init? */ + bitbang_spi_release_bus(); return 0; } Index: flashrom-bitbang_spi_init_errorcheck_request_release_bus/nicintel_spi.c =================================================================== --- flashrom-bitbang_spi_init_errorcheck_request_release_bus/nicintel_spi.c (Revision 1164) +++ flashrom-bitbang_spi_init_errorcheck_request_release_bus/nicintel_spi.c (Arbeitskopie) @@ -91,20 +91,10 @@ { uint32_t tmp; - /* - * Requesting and releasing the SPI bus is handled in here to allow - * the chipset to use its own SPI engine for native reads. - */ - if (val == 0) - nicintel_request_spibus(); - tmp = pci_mmio_readl(nicintel_spibar + FLA); tmp &= ~(1 << FL_CS); tmp |= (val << FL_CS); pci_mmio_writel(tmp, nicintel_spibar + FLA); - - if (val == 1) - nicintel_release_spibus(); } static void nicintel_bitbang_set_sck(int val) @@ -142,6 +132,8 @@ .set_sck = nicintel_bitbang_set_sck, .set_mosi = nicintel_bitbang_set_mosi, .get_miso = nicintel_bitbang_get_miso, + .request_bus = nicintel_request_spibus, + .release_bus = nicintel_release_spibus, }; int nicintel_spi_init(void) Index: flashrom-bitbang_spi_init_errorcheck_request_release_bus/mcp6x_spi.c =================================================================== --- flashrom-bitbang_spi_init_errorcheck_request_release_bus/mcp6x_spi.c (Revision 1164) +++ flashrom-bitbang_spi_init_errorcheck_request_release_bus/mcp6x_spi.c (Arbeitskopie) @@ -66,18 +66,9 @@ static void mcp6x_bitbang_set_cs(int val) { - /* Requesting and releasing the SPI bus is handled in here to allow the - * chipset to use its own SPI engine for native reads. - */ - if (val == 0) - mcp6x_request_spibus(); - mcp_gpiostate &= ~(1 << MCP6X_SPI_CS); mcp_gpiostate |= (val << MCP6X_SPI_CS); mmio_writeb(mcp_gpiostate, mcp6x_spibar + 0x530); - - if (val == 1) - mcp6x_release_spibus(); } static void mcp6x_bitbang_set_sck(int val) @@ -106,6 +97,8 @@ .set_sck = mcp6x_bitbang_set_sck, .set_mosi = mcp6x_bitbang_set_mosi, .get_miso = mcp6x_bitbang_get_miso, + .request_bus = mcp6x_request_spibus, + .release_bus = mcp6x_release_spibus, }; int mcp6x_spi_init(int want_spi) Index: flashrom-bitbang_spi_init_errorcheck_request_release_bus/programmer.h =================================================================== --- flashrom-bitbang_spi_init_errorcheck_request_release_bus/programmer.h (Revision 1164) +++ flashrom-bitbang_spi_init_errorcheck_request_release_bus/programmer.h (Arbeitskopie) @@ -131,6 +131,8 @@ void (*set_sck) (int val); void (*set_mosi) (int val); int (*get_miso) (void); + void (*request_bus) (void); + void (*release_bus) (void); }; #if CONFIG_INTERNAL == 1 @@ -443,6 +445,7 @@ /* bitbang_spi.c */ int bitbang_spi_init(const struct bitbang_spi_master *master, int halfperiod); +int bitbang_spi_shutdown(const struct bitbang_spi_master *master); int bitbang_spi_send_command(unsigned int writecnt, unsigned int readcnt, const unsigned char *writearr, unsigned char *readarr); int bitbang_spi_read(struct flashchip *flash, uint8_t *buf, int start, int len); int bitbang_spi_write_256(struct flashchip *flash, uint8_t *buf, int start, int len); -- http://www.hailfinger.org/

2 3

[commit] r1171 - trunk
by repository service 15 Sep '10

15 Sep '10

Author: hailfinger Date: Wed Sep 15 02:17:37 2010 New Revision: 1171 URL: http://flashrom.org/trac/flashrom/changeset/1171 Log: SPI bitbanging: request/release bus. SPI bitbanging on devices which speak SPI natively has a dual-use problem: We need to shut down normal SPI operations to do the bitbanging ourselves. Once we're done, it makes a lot of sense to reenable "normal" SPI operations again. Add request_bus/release_bus functions to struct bitbang_spi_master. Add a bitbang shutdown function (not used yet). Change MCP SPI and Intel NIC SPI to use the new request/release bus infrastructure. Cosmetic changes to a few error messages (80 column limit). There are multiple possible strategies for bus request/release: - Request at the start of a SPI command, release immediately afterwards. - Request at the start of a SPI multicommand, release once all commands of the multicommand are done. - Request on programmer init, release on shutdown. Each strategy has its own advantages. For now, we will stay with the first strategy which worked fine so far. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Acked-by: Uwe Hermann <uwe(a)hermann-uwe.de> Modified: trunk/bitbang_spi.c trunk/mcp6x_spi.c trunk/nicintel_spi.c trunk/programmer.h Modified: trunk/bitbang_spi.c ============================================================================== --- trunk/bitbang_spi.c Wed Sep 15 02:13:02 2010 (r1170) +++ trunk/bitbang_spi.c Wed Sep 15 02:17:37 2010 (r1171) @@ -53,6 +53,18 @@ return bitbang_spi_master->get_miso(); } +static void bitbang_spi_request_bus(void) +{ + if (bitbang_spi_master->request_bus) + bitbang_spi_master->request_bus(); +} + +static void bitbang_spi_release_bus(void) +{ + if (bitbang_spi_master->release_bus) + bitbang_spi_master->release_bus(); +} + int bitbang_spi_init(const struct bitbang_spi_master *master, int halfperiod) { /* BITBANG_SPI_INVALID is 0, so if someone forgot to initialize ->type, @@ -61,19 +73,44 @@ */ if (!master || master->type == BITBANG_SPI_INVALID || !master->set_cs || !master->set_sck || !master->set_mosi || !master->get_miso) { - msg_perr("Incomplete bitbanging SPI master setting! Please " - "report a bug at flashrom(a)flashrom.org\n"); + msg_perr("Incomplete SPI bitbang master setting!\n" + "Please report a bug at flashrom(a)flashrom.org\n"); + return 1; + } + if (bitbang_spi_master) { + msg_perr("SPI bitbang master already initialized!\n" + "Please report a bug at flashrom(a)flashrom.org\n"); return 1; } + bitbang_spi_master = master; bitbang_spi_half_period = halfperiod; + /* FIXME: Run bitbang_spi_request_bus here or in programmer init? */ bitbang_spi_set_cs(1); bitbang_spi_set_sck(0); bitbang_spi_set_mosi(0); return 0; } +int bitbang_spi_shutdown(const struct bitbang_spi_master *master) +{ + if (!bitbang_spi_master) { + msg_perr("Shutting down an uninitialized SPI bitbang master!\n" + "Please report a bug at flashrom(a)flashrom.org\n"); + return 1; + } + if (master != bitbang_spi_master) { + msg_perr("Shutting down a mismatched SPI bitbang master!\n" + "Please report a bug at flashrom(a)flashrom.org\n"); + return 1; + } + + /* FIXME: Run bitbang_spi_release_bus here or per command? */ + bitbang_spi_master = NULL; + return 0; +} + static uint8_t bitbang_spi_readwrite_byte(uint8_t val) { uint8_t ret = 0; @@ -96,6 +133,11 @@ { int i; + /* FIXME: Run bitbang_spi_request_bus here or in programmer init? + * Requesting and releasing the SPI bus is handled in here to allow the + * programmer to use its own SPI engine for native accesses. + */ + bitbang_spi_request_bus(); bitbang_spi_set_cs(0); for (i = 0; i < writecnt; i++) bitbang_spi_readwrite_byte(writearr[i]); @@ -105,6 +147,8 @@ programmer_delay(bitbang_spi_half_period); bitbang_spi_set_cs(1); programmer_delay(bitbang_spi_half_period); + /* FIXME: Run bitbang_spi_release_bus here or in programmer init? */ + bitbang_spi_release_bus(); return 0; } Modified: trunk/mcp6x_spi.c ============================================================================== --- trunk/mcp6x_spi.c Wed Sep 15 02:13:02 2010 (r1170) +++ trunk/mcp6x_spi.c Wed Sep 15 02:17:37 2010 (r1171) @@ -66,18 +66,9 @@ static void mcp6x_bitbang_set_cs(int val) { - /* Requesting and releasing the SPI bus is handled in here to allow the - * chipset to use its own SPI engine for native reads. - */ - if (val == 0) - mcp6x_request_spibus(); - mcp_gpiostate &= ~(1 << MCP6X_SPI_CS); mcp_gpiostate |= (val << MCP6X_SPI_CS); mmio_writeb(mcp_gpiostate, mcp6x_spibar + 0x530); - - if (val == 1) - mcp6x_release_spibus(); } static void mcp6x_bitbang_set_sck(int val) @@ -106,6 +97,8 @@ .set_sck = mcp6x_bitbang_set_sck, .set_mosi = mcp6x_bitbang_set_mosi, .get_miso = mcp6x_bitbang_get_miso, + .request_bus = mcp6x_request_spibus, + .release_bus = mcp6x_release_spibus, }; int mcp6x_spi_init(int want_spi) Modified: trunk/nicintel_spi.c ============================================================================== --- trunk/nicintel_spi.c Wed Sep 15 02:13:02 2010 (r1170) +++ trunk/nicintel_spi.c Wed Sep 15 02:17:37 2010 (r1171) @@ -91,20 +91,10 @@ { uint32_t tmp; - /* - * Requesting and releasing the SPI bus is handled in here to allow - * the chipset to use its own SPI engine for native reads. - */ - if (val == 0) - nicintel_request_spibus(); - tmp = pci_mmio_readl(nicintel_spibar + FLA); tmp &= ~(1 << FL_CS); tmp |= (val << FL_CS); pci_mmio_writel(tmp, nicintel_spibar + FLA); - - if (val == 1) - nicintel_release_spibus(); } static void nicintel_bitbang_set_sck(int val) @@ -142,6 +132,8 @@ .set_sck = nicintel_bitbang_set_sck, .set_mosi = nicintel_bitbang_set_mosi, .get_miso = nicintel_bitbang_get_miso, + .request_bus = nicintel_request_spibus, + .release_bus = nicintel_release_spibus, }; int nicintel_spi_init(void) Modified: trunk/programmer.h ============================================================================== --- trunk/programmer.h Wed Sep 15 02:13:02 2010 (r1170) +++ trunk/programmer.h Wed Sep 15 02:17:37 2010 (r1171) @@ -131,6 +131,8 @@ void (*set_sck) (int val); void (*set_mosi) (int val); int (*get_miso) (void); + void (*request_bus) (void); + void (*release_bus) (void); }; #if CONFIG_INTERNAL == 1 @@ -443,6 +445,7 @@ /* bitbang_spi.c */ int bitbang_spi_init(const struct bitbang_spi_master *master, int halfperiod); +int bitbang_spi_shutdown(const struct bitbang_spi_master *master); int bitbang_spi_send_command(unsigned int writecnt, unsigned int readcnt, const unsigned char *writearr, unsigned char *readarr); int bitbang_spi_read(struct flashchip *flash, uint8_t *buf, int start, int len); int bitbang_spi_write_256(struct flashchip *flash, uint8_t *buf, int start, int len);

1 0

[PATCH] ICH SPI address window for reads
by Carl-Daniel Hailfinger 15 Sep '10

15 Sep '10

ICH SPI has the ability to restrict SPI read/write accesses to a given address range. The low end of the range is configurable by the BIOS (and by flashrom if the BIOS didn't lock down the flash interface), the high end of the range is 0xffffff (2^24-1). This patch checks for an address range restriction and uses the low end of the allowed range as base for SPI reads. A similar workaround for REMS/RES opcodes has been committed in r500. This fixes read on the Intel D945GCLF mainboard where the stock BIOS enforces a restricted address range. Please note that writes need the same fix, but for architectural reasons that fix will be merged once partial write is available. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Index: flashrom-ichspi_read_use_min_addr/spi.c =================================================================== --- flashrom-ichspi_read_use_min_addr/spi.c (Revision 1165) +++ flashrom-ichspi_read_use_min_addr/spi.c (Arbeitskopie) @@ -22,6 +22,7 @@ * Contains the generic SPI framework */ +#include <string.h> #include "flash.h" #include "flashchips.h" #include "chipdrivers.h" @@ -207,6 +208,7 @@ int spi_chip_read(struct flashchip *flash, uint8_t *buf, int start, int len) { + int addrbase = 0; if (!spi_programmer[spi_controller].read) { msg_perr("%s called, but SPI read is unsupported on this " "hardware. Please report a bug at " @@ -214,7 +216,26 @@ return 1; } - return spi_programmer[spi_controller].read(flash, buf, start, len); + /* Check if the chip fits between lowest valid and highest possible + * address. Highest possible address with the current SPI implementation + * means 0xffffff, the highest unsigned 24bit number. + */ + addrbase = spi_get_valid_read_addr(); + if (addrbase + flash->total_size * 1024 > (1 << 24)) { + msg_perr("Flash chip size exceeds the allowed access window. "); + msg_perr("Read will probably fail.\n"); + /* Try to get the best alignment subject to constraints. */ + addrbase = (1 << 24) - flash->total_size * 1024; + } + /* Check if alignment is native (at least the largest power of two which + * is a factor of the mapped size of the chip). + */ + if (ffs(flash->total_size * 1024) > (ffs(addrbase) ? : 33)) { + msg_perr("Flash chip is not aligned natively in the allowed " + "access window.\n"); + msg_perr("Read will probably return garbage.\n"); + } + return spi_programmer[spi_controller].read(flash, buf, addrbase + start, len); } /* -- http://www.hailfinger.org/

2 2

[commit] r1170 - trunk
by repository service 15 Sep '10

15 Sep '10

Author: hailfinger Date: Wed Sep 15 02:13:02 2010 New Revision: 1170 URL: http://flashrom.org/trac/flashrom/changeset/1170 Log: Honor ICH SPI address window for reads. ICH SPI has the ability to restrict SPI read/write accesses to a given address range. The low end of the range is configurable by the BIOS (and by flashrom if the BIOS didn't lock down the flash interface), the high end of the range is 0xffffff (2^24-1). This patch checks for an address range restriction and uses the low end of the allowed range as base for SPI reads. A similar workaround for REMS/RES opcodes has been committed in r500. This fixes read on the Intel D945GCLF mainboard where the stock BIOS enforces a restricted address range. Please note that writes need the same fix, but for architectural reasons that fix will be merged once partial write is available. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Tested by David Hendricks on the Intel D945GCLF mainboard, results at http://paste.flashrom.org/view.php?id=79 Acked-by: David Hendricks <dhendrix(a)google.com> Modified: trunk/spi.c Modified: trunk/spi.c ============================================================================== --- trunk/spi.c Wed Sep 15 02:03:53 2010 (r1169) +++ trunk/spi.c Wed Sep 15 02:13:02 2010 (r1170) @@ -22,6 +22,7 @@ * Contains the generic SPI framework */ +#include <string.h> #include "flash.h" #include "flashchips.h" #include "chipdrivers.h" @@ -207,6 +208,7 @@ int spi_chip_read(struct flashchip *flash, uint8_t *buf, int start, int len) { + int addrbase = 0; if (!spi_programmer[spi_controller].read) { msg_perr("%s called, but SPI read is unsupported on this " "hardware. Please report a bug at " @@ -214,7 +216,26 @@ return 1; } - return spi_programmer[spi_controller].read(flash, buf, start, len); + /* Check if the chip fits between lowest valid and highest possible + * address. Highest possible address with the current SPI implementation + * means 0xffffff, the highest unsigned 24bit number. + */ + addrbase = spi_get_valid_read_addr(); + if (addrbase + flash->total_size * 1024 > (1 << 24)) { + msg_perr("Flash chip size exceeds the allowed access window. "); + msg_perr("Read will probably fail.\n"); + /* Try to get the best alignment subject to constraints. */ + addrbase = (1 << 24) - flash->total_size * 1024; + } + /* Check if alignment is native (at least the largest power of two which + * is a factor of the mapped size of the chip). + */ + if (ffs(flash->total_size * 1024) > (ffs(addrbase) ? : 33)) { + msg_perr("Flash chip is not aligned natively in the allowed " + "access window.\n"); + msg_perr("Read will probably return garbage.\n"); + } + return spi_programmer[spi_controller].read(flash, buf, addrbase + start, len); } /*

1 0

[commit] r1169 - trunk
by repository service 15 Sep '10

15 Sep '10

Author: uwe Date: Wed Sep 15 02:03:53 2010 New Revision: 1169 URL: http://flashrom.org/trac/flashrom/changeset/1169 Log: Add missing GIGABYTE GA-7DXR entry, should have been in r1166. Signed-off-by: Uwe Hermann <uwe(a)hermann-uwe.de> Acked-by: Uwe Hermann <uwe(a)hermann-uwe.de> Modified: trunk/print.c Modified: trunk/print.c ============================================================================== --- trunk/print.c Wed Sep 15 01:56:56 2010 (r1168) +++ trunk/print.c Wed Sep 15 02:03:53 2010 (r1169) @@ -412,6 +412,7 @@ B("GIGABYTE", "GA-6ZMA", 1, "http://www.gigabyte.com/products/product-page.aspx?pid=1541", NULL), B("GIGABYTE", "GA-MA785GMT-UD2H", 1, "http://www.gigabyte.de/Products/Motherboard/Products_Overview.aspx?ProductI…", NULL), B("GIGABYTE", "GA-770TA-UD3", 1, "http://www.gigabyte.com/products/product-page.aspx?pid=3272#ov", NULL), + B("GIGABYTE", "GA-7DXR", 1, "http://www.gigabyte.de/Products/Motherboard/Products_Spec.aspx?ProductID=13…", NULL), B("GIGABYTE", "GA-7VT600", 1, "http://www.gigabyte.com/products/product-page.aspx?pid=1666", NULL), B("GIGABYTE", "GA-7ZM", 1, "http://www.gigabyte.com/products/product-page.aspx?pid=1366", "Works fine if you remove jumper JP9 on the board and disable the flash protection BIOS option."), B("GIGABYTE", "GA-8IRML", 1, "http://www.gigabyte.com/products/product-page.aspx?pid=1343", NULL),

1 0

[PATCH] Winbond chip id fix-up (ver 4)
by Mattias Mattsson 15 Sep '10

15 Sep '10

Same as version 3, but do not rearrange order of chip definitions in flashchips.c for easier review. List all chip variants in the .name strings in flashchips.c Also have two identical entries for Winbond W29C010(M)/W29C011A/W29EE011/W29EE012 with different probe functions in flashchips.c as sometimes (for newer revisions of these chips?) the standard jedec probe seems to work. Eg see test report here: http://patchwork.coreboot.org/patch/1476/ Rename constants W_nnnn -> WINBOND_Wnnnn W_25nnn -> WINBOND_NEX_W25nnn Kill incorrect ASD chip and vendor id. Group Winbond SPI and Parallell chips separately (they have different vendor ids). Change constant names to the "canonical" chip name for the following ids: W_29C020C (0x45) -> WINBOND_W29C020 (Same as W29C020C, W29C022 and ASD AE29F2008) W_29C040P (0x46) -> WINBOND_W29C040 ("P" is for package type [32-pin PLCC], irrelevant) W_29C011 + W_29EE011 (0xC1) -> WINBOND_W29C010M (Same as W29C011A, W29EE011, W29EE012, and ASD AE29F1008) Also add ids for the following Winbond chips: W25Q40 W25Q128 W19B160BB W19B160BT W19B320SB/W19L320SB W19B320ST/W19L320ST W19B322MB W19B322MT W19B323MB W19B323MT W19B324MB W19B324MT W29C512A/W29EE512 W39L010 W39L040A W39L512 W49F002/W49F002B Signed-off-by: Mattias Mattsson <vitplister(a)gmail.com>

2 3

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

flashrom