Same as version 3, but do not rearrange order of chip definitions in flashchips.c for easier review.
List all chip variants in the .name strings in flashchips.c
Also have two identical entries for Winbond W29C010(M)/W29C011A/W29EE011/W29EE012 with different probe functions in flashchips.c as sometimes (for newer revisions of these chips?) the standard jedec probe seems to work. Eg see test report here: http://patchwork.coreboot.org/patch/1476/
Rename constants W_nnnn -> WINBOND_Wnnnn W_25nnn -> WINBOND_NEX_W25nnn
Kill incorrect ASD chip and vendor id.
Group Winbond SPI and Parallell chips separately (they have different vendor ids).
Change constant names to the "canonical" chip name for the following ids:
W_29C020C (0x45) -> WINBOND_W29C020 (Same as W29C020C, W29C022 and ASD AE29F2008)
W_29C040P (0x46) -> WINBOND_W29C040 ("P" is for package type [32-pin PLCC], irrelevant)
W_29C011 + W_29EE011 (0xC1) -> WINBOND_W29C010M (Same as W29C011A, W29EE011, W29EE012, and ASD AE29F1008)
Also add ids for the following Winbond chips: W25Q40 W25Q128 W19B160BB W19B160BT W19B320SB/W19L320SB W19B320ST/W19L320ST W19B322MB W19B322MT W19B323MB W19B323MT W19B324MB W19B324MT W29C512A/W29EE512 W39L010 W39L040A W39L512 W49F002/W49F002B
Signed-off-by: Mattias Mattsson vitplister@gmail.com
Sorry forgot to attach the patch. -mattias
On Wed, Sep 15, 2010 at 01:18, Mattias Mattsson vitplister@gmail.com wrote:
Same as version 3, but do not rearrange order of chip definitions in flashchips.c for easier review.
List all chip variants in the .name strings in flashchips.c
Also have two identical entries for Winbond W29C010(M)/W29C011A/W29EE011/W29EE012 with different probe functions in flashchips.c as sometimes (for newer revisions of these chips?) the standard jedec probe seems to work. Eg see test report here: http://patchwork.coreboot.org/patch/1476/
Rename constants W_nnnn -> WINBOND_Wnnnn W_25nnn -> WINBOND_NEX_W25nnn
Kill incorrect ASD chip and vendor id.
Group Winbond SPI and Parallell chips separately (they have different vendor ids).
Change constant names to the "canonical" chip name for the following ids:
W_29C020C (0x45) -> WINBOND_W29C020 (Same as W29C020C, W29C022 and ASD AE29F2008)
W_29C040P (0x46) -> WINBOND_W29C040 ("P" is for package type [32-pin PLCC], irrelevant)
W_29C011 + W_29EE011 (0xC1) -> WINBOND_W29C010M (Same as W29C011A, W29EE011, W29EE012, and ASD AE29F1008)
Also add ids for the following Winbond chips: W25Q40 W25Q128 W19B160BB W19B160BT W19B320SB/W19L320SB W19B320ST/W19L320ST W19B322MB W19B322MT W19B323MB W19B323MT W19B324MB W19B324MT W29C512A/W29EE512 W39L010 W39L040A W39L512 W49F002/W49F002B
Signed-off-by: Mattias Mattsson vitplister@gmail.com
On Wed, Sep 15, 2010 at 01:18:50AM +0200, Mattias Mattsson wrote:
Group Winbond SPI and Parallell chips separately (they have different
Small typo, s/Parallell/Parallel/ in the commit message.
vendor ids).
IDs
Signed-off-by: Mattias Mattsson vitplister@gmail.com
Acked-by: Uwe Hermann uwe@hermann-uwe.de
Looks good and compiles. The "flashrom -L" and "flashrom -z" wiki output look a bit ugly now, but that can be fixed in another patch.
Uwe.
On Wed, Sep 15, 2010 at 01:44, Uwe Hermann uwe@hermann-uwe.de wrote:
On Wed, Sep 15, 2010 at 01:18:50AM +0200, Mattias Mattsson wrote:
Group Winbond SPI and Parallell chips separately (they have different
Small typo, s/Parallell/Parallel/ in the commit message.
vendor ids).
IDs
Fixed.
Signed-off-by: Mattias Mattsson vitplister@gmail.com
Acked-by: Uwe Hermann uwe@hermann-uwe.de
Looks good and compiles. The "flashrom -L" and "flashrom -z" wiki output look a bit ugly now, but that can be fixed in another patch.
Many thanks!
committed in r1168.
-mattias
-
Mattias Mattsson -
Uwe Hermann