flashrom

flashrom@flashrom.org

5 participants
9161 discussions

flashrom Rangeley with WINDBOND25Q64
by wenw＠adiengineering.com 12 Aug '14

12 Aug '14

Hello, I am testing flashrom on a Rangeley system using coreboot. The flash chip is W25Q64.V. I am using Stefan's refactored support for Baytrail/Rangeley: https://github.com/stefanct/flashrom/tree/intel. The read operation failed (log attached). Any suggestions to debug it would be appreciated! Thanks, Wen PS: Stefan - I finally got subscribed to the mailing list I think. My system was treating flashrom.org as spam initially. Thanks for responding my earlier email. -----Original Message----- From: "Stefan Tauner" <stefan.tauner(a)alumni.tuwien.ac.at> Sent: Monday, August 11, 2014 6:22pm To: "Wen Wang" <wen.wang(a)adiengineering.com> Subject: Re: flashrom Rangeley/Baytrail On Mon, 11 Aug 2014 12:20:15 -0400 "Wen Wang" <wen.wang(a)adiengineering.com> wrote: > Hello Stefan, > > I am trying to test the flashrom patch for Rangeley and Baytrail. I read in > your recent blog that you made some updates on top of Martin's patch. I am > very interested in trying your changes. Is it enough if I pull your branch > https://github.com/stefanct/flashrom/tree/intel? I have a Bayley Bay CRB and > a mohonpeak equivalent system to try. Hello, using that branch is fine, yes. Good luck, hopefully you won't need it :) > PS: I was trying to get onto the flashrom mailing list, but for some reason > I never got through. So I have to send an email to you directly. Maybe your server was not accepting mails from the flashrom host and you never got subscribed therefore (the flashrom.org domain had problems in the last weeks for some people which led to some servers not accepting mails from the list). Anyway, you can always send mails to the mailing list without being subscribed, we just have to moderate them manually. Please do so with any logs you create, and optionally you may wanna retry to subscribe... -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

4 3

CHIPSET: PC Engines ALIX 2c3
by venture37 12 Aug '14

12 Aug '14

http://pcengines.ch/alix2c3.htm 00:01.0 Host bridge: Advanced Micro Devices, Inc. [AMD] CS5536 [Geode companion] Host Bridge (rev 31) Subsystem: Advanced Micro Devices, Inc. [AMD] CS5536 [Geode companion] Host Bridge Control: I/O+ Mem- BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx- Status: Cap- 66MHz+ UDF- FastB2B- ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx- Latency: 64 Region 0: I/O ports at ac1c 00:01.2 Entertainment encryption device: Advanced Micro Devices, Inc. [AMD] Geode LX AES Security Block Subsystem: Advanced Micro Devices, Inc. [AMD] Geode LX AES Security Block Control: I/O- Mem+ BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx- Status: Cap- 66MHz+ UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx- Interrupt: pin A routed to IRQ 11 Region 0: Memory at fe010000 (32-bit, non-prefetchable) 00:09.0 Ethernet controller: VIA Technologies, Inc. VT6105M [Rhine-III] (rev 96) Subsystem: VIA Technologies, Inc. Device 0106 Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping+ SERR- FastB2B- DisINTx- Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx- Latency: 64 (750ns min, 2000ns max), Cache Line Size: 64 bytes Interrupt: pin A routed to IRQ 10 Region 0: I/O ports at 1000 Region 1: Memory at fe019000 (32-bit, non-prefetchable) Capabilities: [40] Power Management version 2 Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=0mA PME(D0+,D1+,D2+,D3hot+,D3cold+) Status: D0 NoSoftRst- PME-Enable+ DSel=0 DScale=0 PME- 00:0a.0 Ethernet controller: VIA Technologies, Inc. VT6105M [Rhine-III] (rev 96) Subsystem: VIA Technologies, Inc. Device 0106 Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping+ SERR- FastB2B- DisINTx- Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx- Latency: 64 (750ns min, 2000ns max), Cache Line Size: 64 bytes Interrupt: pin A routed to IRQ 11 Region 0: I/O ports at 1400 Region 1: Memory at fe019100 (32-bit, non-prefetchable) Capabilities: [40] Power Management version 2 Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=0mA PME(D0+,D1+,D2+,D3hot+,D3cold+) Status: D0 NoSoftRst- PME-Enable+ DSel=0 DScale=0 PME- 00:0b.0 Ethernet controller: VIA Technologies, Inc. VT6105M [Rhine-III] (rev 96) Subsystem: VIA Technologies, Inc. Device 0106 Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping+ SERR- FastB2B- DisINTx- Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx- Latency: 64 (750ns min, 2000ns max), Cache Line Size: 64 bytes Interrupt: pin A routed to IRQ 9 Region 0: I/O ports at 1800 Region 1: Memory at fe019200 (32-bit, non-prefetchable) Capabilities: [40] Power Management version 2 Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=0mA PME(D0+,D1+,D2+,D3hot+,D3cold+) Status: D0 NoSoftRst- PME-Enable+ DSel=0 DScale=0 PME- 00:0f.0 ISA bridge: Advanced Micro Devices, Inc. [AMD] CS5536 [Geode companion] ISA (rev 03) Subsystem: Advanced Micro Devices, Inc. [AMD] CS5536 [Geode companion] ISA Control: I/O+ Mem- BusMaster- SpecCycle+ MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx- Status: Cap- 66MHz+ UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx- Region 0: I/O ports at 24b0 Region 1: I/O ports at 1c00 Region 2: I/O ports at 2400 Region 3: I/O ports at 2480 Region 4: I/O ports at 2000 Region 5: I/O ports at 2440 00:0f.2 IDE interface: Advanced Micro Devices, Inc. [AMD] CS5536 [Geode companion] IDE (rev 01) (prog-if 80 [Master]) Subsystem: Advanced Micro Devices, Inc. [AMD] CS5536 [Geode companion] IDE Control: I/O+ Mem- BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx- Status: Cap- 66MHz+ UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx- Latency: 248 Region 4: I/O ports at 24a0 00:0f.4 USB controller: Advanced Micro Devices, Inc. [AMD] CS5536 [Geode companion] OHC (rev 02) (prog-if 10 [OHCI]) Subsystem: Advanced Micro Devices, Inc. [AMD] CS5536 [Geode companion] OHC Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx- Status: Cap+ 66MHz+ UDF- FastB2B- ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx- Latency: 0 Interrupt: pin D routed to IRQ 9 Region 0: Memory at fe016000 (32-bit, non-prefetchable) Capabilities: [40] Power Management version 2 Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA PME(D0+,D1-,D2-,D3hot+,D3cold+) Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME- 00:0f.5 USB controller: Advanced Micro Devices, Inc. [AMD] CS5536 [Geode companion] EHC (rev 02) (prog-if 20 [EHCI]) Subsystem: Advanced Micro Devices, Inc. [AMD] CS5536 [Geode companion] EHC Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx- Status: Cap+ 66MHz+ UDF- FastB2B- ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx- Latency: 0 Interrupt: pin D routed to IRQ 9 Region 0: Memory at fe017000 (32-bit, non-prefetchable) Capabilities: [40] Power Management version 2 Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA PME(D0+,D1-,D2-,D3hot+,D3cold+) Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME-

1 0

Re: [flashrom] [PATCH] Fix probe_jedec() with continuation bytes, add EN29LV640T and get rid of probe_en29lv640b().
by Stefan Tauner 11 Aug '14

11 Aug '14

On Mon, 11 Aug 2014 00:12:56 +0200 Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> wrote: > We forgot to shift the addresses for continuation bytes in r1840. > Also, probe_en29lv640b() can easily be replaced with refined probe_jedec(). > Furthermore, add EN29LV640T which is the top boot sector-variant of > EN29LV640B. > > Signed-off-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> > --- > > Rudolf, if you still have access to the bifferboard, I'd very welcome > testing this patch on it. This would verify the change we did in r1840 > (+ its fix in this patch) + the refactoring as well. > > I might look into the write function later too, but currently probing > functions are my main focus. Actually I don't see anything unusual in the datasheet regarding writing either, where does it state that the chip has to be programmed in 16b words even if BYTE# is low?. I am not 100% if jedec_probe needs a refinement for shifted access too, but we should be able to get this to work in any case without an extra function, Carl-Daniel, please advice. :) PS: I have removed probe_en29lv640b() locally which I forgot on the posted patch. -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

1 0

[PATCH] Add en29lv640b
by Rudolf Marek 11 Aug '14

11 Aug '14

Hi Following patch adds the en29lv640b which needs special command sequences in 8 bit mode. Also, 8 bit programming needs actually 16bit double byte program. The chip is found on bifferboard. Please check the patch and let me know. Signed-off-by: Rudolf Marek <r.marek(a)assembler.cz> Thanks Rudolf

4 6

Re: [flashrom] [PATCH 1/3] Refactor some CLI-relevant parts.
by Stefan Tauner 09 Aug '14

09 Aug '14

On Fri, 8 Aug 2014 16:25:07 +0200 Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> wrote: > Begin to move functions that clearly belong to the (command line) > user interface out of flashrom's core files like flashrom.c. > > - Refine messages within check_chip_supported() and move it to newly > created cli_common.c. > - Move flashbuses_to_text() to cli_common.c as well. > - Move global verbosity variables to cli_output.c. > This was Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> after renaming check_chip_supported() to print_chip_support_status() and committed in r1841. -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

1 0

[commit] r1841 - trunk
by repository service 09 Aug '14

09 Aug '14

Author: stefanct Date: Sat Aug 9 01:52:33 2014 New Revision: 1841 URL: http://flashrom.org/trac/flashrom/changeset/1841 Log: Refactor some CLI-relevant parts. Begin to move functions that clearly belong to the (command line) user interface out of flashrom's core files like flashrom.c. - Refine messages within check_chip_supported(), rename it to print_chip_support_status() and move it to newly created cli_common.c. - Move flashbuses_to_text() to cli_common.c as well. - Move global verbosity variables to cli_output.c. Signed-off-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Added: trunk/cli_common.c (contents, props changed) Modified: trunk/Makefile trunk/cli_classic.c trunk/cli_output.c trunk/flash.h trunk/flashrom.c trunk/print.c trunk/programmer.h Modified: trunk/Makefile ============================================================================== --- trunk/Makefile Fri Aug 8 10:33:01 2014 (r1840) +++ trunk/Makefile Sat Aug 9 01:52:33 2014 (r1841) @@ -363,7 +363,7 @@ ############################################################################### # Frontend related stuff. -CLI_OBJS = cli_classic.o cli_output.o print.o +CLI_OBJS = cli_classic.o cli_output.o cli_common.o print.o # Set the flashrom version string from the highest revision number of the checked out flashrom files. # Note to packagers: Any tree exported with "make export" or "make tarball" Modified: trunk/cli_classic.c ============================================================================== --- trunk/cli_classic.c Fri Aug 8 10:33:01 2014 (r1840) +++ trunk/cli_classic.c Sat Aug 9 01:52:33 2014 (r1841) @@ -499,7 +499,7 @@ fill_flash = &flashes[0]; - check_chip_supported(fill_flash->chip); + print_chip_support_status(fill_flash->chip); size = fill_flash->chip->total_size * 1024; if (check_max_decode(fill_flash->mst->buses_supported & fill_flash->chip->bustype, size) && (!force)) { Added: trunk/cli_common.c ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ trunk/cli_common.c Sat Aug 9 01:52:33 2014 (r1841) @@ -0,0 +1,117 @@ +/* + * This file is part of the flashrom project. + * + * Copyright (C) 2009 Uwe Hermann <uwe(a)hermann-uwe.de> + * Copyright (C) 2009 Carl-Daniel Hailfinger + * Copyright (C) 2011-2014 Stefan Tauner + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + */ + +#include <stdlib.h> +#include <string.h> +#include "flash.h" + +/* + * Return a string corresponding to the bustype parameter. + * Memory is obtained with malloc() and must be freed with free() by the caller. + */ +char *flashbuses_to_text(enum chipbustype bustype) +{ + char *ret = calloc(1, 1); + /* + * FIXME: Once all chipsets and flash chips have been updated, NONSPI + * will cease to exist and should be eliminated here as well. + */ + if (bustype == BUS_NONSPI) { + ret = strcat_realloc(ret, "Non-SPI, "); + } else { + if (bustype & BUS_PARALLEL) + ret = strcat_realloc(ret, "Parallel, "); + if (bustype & BUS_LPC) + ret = strcat_realloc(ret, "LPC, "); + if (bustype & BUS_FWH) + ret = strcat_realloc(ret, "FWH, "); + if (bustype & BUS_SPI) + ret = strcat_realloc(ret, "SPI, "); + if (bustype & BUS_PROG) + ret = strcat_realloc(ret, "Programmer-specific, "); + if (bustype == BUS_NONE) + ret = strcat_realloc(ret, "None, "); + } + /* Kill last comma. */ + ret[strlen(ret) - 2] = '\0'; + ret = realloc(ret, strlen(ret) + 1); + return ret; +} + + +void print_chip_support_status(const struct flashchip *chip) +{ + if (chip->feature_bits & FEATURE_OTP) { + msg_cdbg("This chip may contain one-time programmable memory. flashrom cannot read\n" + "and may never be able to write it, hence it may not be able to completely\n" + "clone the contents of this chip (see man page for details).\n"); + } + + if ((chip->tested.erase == NA) && (chip->tested.write == NA)) { + msg_cdbg("This chip's main memory can not be erased/written by design.\n"); + } + + if ((chip->tested.probe == BAD) || (chip->tested.probe == NT) || + (chip->tested.read == BAD) || (chip->tested.read == NT) || + (chip->tested.erase == BAD) || (chip->tested.erase == NT) || + (chip->tested.write == BAD) || (chip->tested.write == NT)){ + msg_cinfo("===\n"); + if ((chip->tested.probe == BAD) || + (chip->tested.read == BAD) || + (chip->tested.erase == BAD) || + (chip->tested.write == BAD)) { + msg_cinfo("This flash part has status NOT WORKING for operations:"); + if (chip->tested.probe == BAD) + msg_cinfo(" PROBE"); + if (chip->tested.read == BAD) + msg_cinfo(" READ"); + if (chip->tested.erase == BAD) + msg_cinfo(" ERASE"); + if (chip->tested.write == BAD) + msg_cinfo(" WRITE"); + msg_cinfo("\n"); + } + if ((chip->tested.probe == NT) || + (chip->tested.read == NT) || + (chip->tested.erase == NT) || + (chip->tested.write == NT)) { + msg_cinfo("This flash part has status UNTESTED for operations:"); + if (chip->tested.probe == NT) + msg_cinfo(" PROBE"); + if (chip->tested.read == NT) + msg_cinfo(" READ"); + if (chip->tested.erase == NT) + msg_cinfo(" ERASE"); + if (chip->tested.write == NT) + msg_cinfo(" WRITE"); + msg_cinfo("\n"); + } + msg_cinfo("The test status of this chip may have been updated in the latest development\n" + "version of flashrom. If you are running the latest development version,\n" + "please email a report to flashrom(a)flashrom.org if any of the above operations\n" + "work correctly for you with this flash chip. Please include the flashrom log\n" + "file for all operations you tested (see the man page for details), and mention\n" + "which mainboard or programmer you tested in the subject line.\n" + "Thanks for your help!\n"); + } +} + Modified: trunk/cli_output.c ============================================================================== --- trunk/cli_output.c Fri Aug 8 10:33:01 2014 (r1840) +++ trunk/cli_output.c Sat Aug 9 01:52:33 2014 (r1841) @@ -25,6 +25,9 @@ #include <errno.h> #include "flash.h" +int verbose_screen = MSG_INFO; +int verbose_logfile = MSG_DEBUG2; + #ifndef STANDALONE static FILE *logfile = NULL; Modified: trunk/flash.h ============================================================================== --- trunk/flash.h Fri Aug 8 10:33:01 2014 (r1840) +++ trunk/flash.h Sat Aug 9 01:52:33 2014 (r1841) @@ -238,7 +238,6 @@ void chip_readn(const struct flashctx *flash, uint8_t *buf, const chipaddr addr, size_t len); /* print.c */ -char *flashbuses_to_text(enum chipbustype bustype); int print_supported(void); void print_supported_wiki(void); @@ -251,8 +250,6 @@ void tolower_string(char *str); /* flashrom.c */ -extern int verbose_screen; -extern int verbose_logfile; extern const char flashrom_version[]; extern const char *chip_to_probe; void map_flash_registers(struct flashctx *flash); @@ -285,7 +282,13 @@ */ #define ERROR_FLASHROM_LIMIT -201 +/* cli_common.c */ +char *flashbuses_to_text(enum chipbustype bustype); +void print_chip_support_status(const struct flashchip *chip); + /* cli_output.c */ +extern int verbose_screen; +extern int verbose_logfile; #ifndef STANDALONE int open_logfile(const char * const filename); int close_logfile(void); Modified: trunk/flashrom.c ============================================================================== --- trunk/flashrom.c Fri Aug 8 10:33:01 2014 (r1840) +++ trunk/flashrom.c Sat Aug 9 01:52:33 2014 (r1841) @@ -42,11 +42,8 @@ const char flashrom_version[] = FLASHROM_VERSION; const char *chip_to_probe = NULL; -int verbose_screen = MSG_INFO; -int verbose_logfile = MSG_DEBUG2; static enum programmer programmer = PROGRAMMER_INVALID; - static const char *programmer_param = NULL; /* @@ -1783,73 +1780,6 @@ return ret; } -void check_chip_supported(const struct flashchip *chip) -{ - if (chip->feature_bits & FEATURE_OTP) { - msg_cdbg("This chip may contain one-time programmable memory. " - "flashrom cannot read\nand may never be able to write " - "it, hence it may not be able to completely\n" - "clone the contents of this chip (see man page for " - "details).\n"); - } - - if ((chip->tested.erase == NA) && (chip->tested.write == NA)) { - msg_cdbg("This chip's main memory can not be erased/written by design.\n"); - } - - if ((chip->tested.probe == BAD) || (chip->tested.probe == NT) || - (chip->tested.read == BAD) || (chip->tested.read == NT) || - (chip->tested.erase == BAD) || (chip->tested.erase == NT) || - (chip->tested.write == BAD) || (chip->tested.write == NT)){ - msg_cinfo("===\n"); - if ((chip->tested.probe == BAD) || - (chip->tested.read == BAD) || - (chip->tested.erase == BAD) || - (chip->tested.write == BAD)) { - msg_cinfo("This flash part has status NOT WORKING for operations:"); - if (chip->tested.probe == BAD) - msg_cinfo(" PROBE"); - if (chip->tested.read == BAD) - msg_cinfo(" READ"); - if (chip->tested.erase == BAD) - msg_cinfo(" ERASE"); - if (chip->tested.write == BAD) - msg_cinfo(" WRITE"); - msg_cinfo("\n"); - } - if ((chip->tested.probe == NT) || - (chip->tested.read == NT) || - (chip->tested.erase == NT) || - (chip->tested.write == NT)) { - msg_cinfo("This flash part has status UNTESTED for operations:"); - if (chip->tested.probe == NT) - msg_cinfo(" PROBE"); - if (chip->tested.read == NT) - msg_cinfo(" READ"); - if (chip->tested.erase == NT) - msg_cinfo(" ERASE"); - if (chip->tested.write == NT) - msg_cinfo(" WRITE"); - msg_cinfo("\n"); - } - /* FIXME: This message is designed towards CLI users. */ - msg_cinfo("The test status of this chip may have been updated " - "in the latest development\n" - "version of flashrom. If you are running the latest " - "development version,\n" - "please email a report to flashrom(a)flashrom.org if " - "any of the above operations\n" - "work correctly for you with this flash part. Please " - "include the flashrom\n" - "output with the additional -V option for all " - "operations you tested (-V, -Vr,\n" - "-VE, -Vw), and mention which mainboard or " - "programmer you tested.\n" - "Please mention your board in the subject line. " - "Thanks for your help!\n"); - } -} - /* FIXME: This function signature needs to be improved once doit() has a better * function signature. */ Modified: trunk/print.c ============================================================================== --- trunk/print.c Fri Aug 8 10:33:01 2014 (r1840) +++ trunk/print.c Sat Aug 9 01:52:33 2014 (r1841) @@ -59,39 +59,6 @@ } } -/* - * Return a string corresponding to the bustype parameter. - * Memory is obtained with malloc() and must be freed with free() by the caller. - */ -char *flashbuses_to_text(enum chipbustype bustype) -{ - char *ret = calloc(1, 1); - /* - * FIXME: Once all chipsets and flash chips have been updated, NONSPI - * will cease to exist and should be eliminated here as well. - */ - if (bustype == BUS_NONSPI) { - ret = strcat_realloc(ret, "Non-SPI, "); - } else { - if (bustype & BUS_PARALLEL) - ret = strcat_realloc(ret, "Parallel, "); - if (bustype & BUS_LPC) - ret = strcat_realloc(ret, "LPC, "); - if (bustype & BUS_FWH) - ret = strcat_realloc(ret, "FWH, "); - if (bustype & BUS_SPI) - ret = strcat_realloc(ret, "SPI, "); - if (bustype & BUS_PROG) - ret = strcat_realloc(ret, "Programmer-specific, "); - if (bustype == BUS_NONE) - ret = strcat_realloc(ret, "None, "); - } - /* Kill last comma. */ - ret[strlen(ret) - 2] = '\0'; - ret = realloc(ret, strlen(ret) + 1); - return ret; -} - static int print_supported_chips(void) { const char *delim = "/"; Modified: trunk/programmer.h ============================================================================== --- trunk/programmer.h Fri Aug 8 10:33:01 2014 (r1840) +++ trunk/programmer.h Sat Aug 9 01:52:33 2014 (r1841) @@ -513,7 +513,6 @@ extern struct decode_sizes max_rom_decode; extern int programmer_may_write; extern unsigned long flashbase; -void check_chip_supported(const struct flashchip *chip); int check_max_decode(enum chipbustype buses, uint32_t size); char *extract_programmer_param(const char *param_name);

1 0

Efi password lost iMac27
by mustapha.rafik 09 Aug '14

09 Aug '14

Hello, I have lost the password of my imac27 looking a way to reset it. I found a link to a tutorial using a bus pirate and a flashrom. I am not sure I can do it by myself. I am far from being a specialist of computing and electronics. Do you have explanations on how to do it? Is it simple for a beginner? Thank you in advance, Regards Envoyé depuis un mobile Samsung

1 0

Re: [flashrom] [PATCH 2/3] Refine handling chips that exceed maximum programmer sizes.
by Stefan Tauner 08 Aug '14

08 Aug '14

On Fri, 8 Aug 2014 16:57:23 +0200 Daniele Forsi <dforsi(a)gmail.com> wrote: > 2014-08-08 16:25 GMT+02:00 Stefan Tauner: > > > --- a/cli_classic.c > > +++ b/cli_classic.c > > @@ -91,7 +91,6 @@ static int check_filename(char *filename, char *type) > > > > int main(int argc, char *argv[]) > > { > > - unsigned long size; > > /* Probe for up to three flash chips. */ > > const struct flashchip *chip = NULL; > > struct flashctx flashes[6] = {{0}}; > > unrelated to this changeset, but the comment above should read "six > flash chips" now > Yes, I am aware of that but thanks for reporting! Let's hope the whole array is gone soon ;) I have added the comment change to my tested_stuff branch #22 already just in case... -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

1 0

Re: [flashrom] [PATCH 2/3] Refine handling chips that exceed maximum programmer sizes.
by Daniele Forsi 08 Aug '14

08 Aug '14

2014-08-08 16:25 GMT+02:00 Stefan Tauner: > --- a/cli_classic.c > +++ b/cli_classic.c > @@ -91,7 +91,6 @@ static int check_filename(char *filename, char *type) > > int main(int argc, char *argv[]) > { > - unsigned long size; > /* Probe for up to three flash chips. */ > const struct flashchip *chip = NULL; > struct flashctx flashes[6] = {{0}}; unrelated to this changeset, but the comment above should read "six flash chips" now -- Daniele Forsi

1 0

[PATCH 3/3] Refine physical address mapping of flash chips.
by Stefan Tauner 08 Aug '14

08 Aug '14

Previously we did map the physical memory corresponding to all chips, even for SPI chips where it is completely unnecessary because we do not use it in any SPI-capable programmer. Also, the mapping was never undone before the program exited. Mapping of additional flash registers was done within probing methods instead of centrally. Besides all of that, this patch also adds proper error handling for mapping-related operations. Signed-off-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> --- 82802ab.c | 2 -- flash.h | 1 - flashrom.c | 84 ++++++++++++++++++++++++++++++++++++++++++++++---------------- jedec.c | 6 ----- 4 files changed, 63 insertions(+), 30 deletions(-) diff --git a/82802ab.c b/82802ab.c index 70c6af0..5d015ba 100644 --- a/82802ab.c +++ b/82802ab.c @@ -83,8 +83,6 @@ int probe_82802ab(struct flashctx *flash) if (id1 != flash->chip->manufacture_id || id2 != flash->chip->model_id) return 0; - if (flash->chip->feature_bits & FEATURE_REGISTERMAP) - map_flash_registers(flash); return 1; } diff --git a/flash.h b/flash.h index 82a8b74..998696c 100644 --- a/flash.h +++ b/flash.h @@ -252,7 +252,6 @@ void tolower_string(char *str); /* flashrom.c */ extern const char flashrom_version[]; extern const char *chip_to_probe; -void map_flash_registers(struct flashctx *flash); int read_memmapped(struct flashctx *flash, uint8_t *buf, unsigned int start, unsigned int len); int erase_flash(struct flashctx *flash); int probe_flash(struct registered_master *mst, int startchip, struct flashctx *fill_flash, int force); diff --git a/flashrom.c b/flashrom.c index 0ff6b63..72bf157 100644 --- a/flashrom.c +++ b/flashrom.c @@ -528,12 +528,23 @@ void programmer_delay(unsigned int usecs) programmer_table[programmer].delay(usecs); } -void map_flash_registers(struct flashctx *flash) +static int map_flash_registers(struct flashctx *flash) { size_t size = flash->chip->total_size * 1024; /* Flash registers live 4 MByte below the flash. */ - /* FIXME: This is incorrect for nonstandard flashbase. */ - flash->virtual_registers = (chipaddr)programmer_map_flash_region("flash chip registers", (0xFFFFFFFF - 0x400000 - size + 1), size); + uintptr_t base = (flashbase != 0) ? flashbase : (0xffffffff - size + 1); + if (base < 0x400000) { + msg_perr("Base address is too low to map flash registers."); + return 1; + } + base -= 0x400000; + void *addr = programmer_map_flash_region("flash chip registers", base, size); + if (addr == ERROR_PTR) { + msg_perr("Could not map flash chip registers.\n"); + return 1; + } + flash->virtual_registers = (chipaddr)addr; + return 0; } int read_memmapped(struct flashctx *flash, uint8_t *buf, unsigned int start, @@ -1052,12 +1063,49 @@ unsigned int count_max_decode_exceedings(struct flashctx *flash) return limitexceeded; } +void unmap_flash(struct flashctx *flash) +{ + if (flash->chip->bustype & (BUS_PARALLEL | BUS_LPC | BUS_FWH)) { + if (flash->virtual_memory != 0) { + programmer_unmap_flash_region((void *)flash->virtual_memory, + flash->chip->total_size * 1024); + flash->virtual_memory = 0; + } + + if (flash->chip->feature_bits & FEATURE_REGISTERMAP && flash->virtual_registers != 0) { + programmer_unmap_flash_region((void *)flash->virtual_registers, + flash->chip->total_size * 1024); + flash->virtual_registers = 0; + } + } +} + +int map_flash(struct flashctx *flash) +{ + const unsigned long size = flash->chip->total_size; + if (flash->chip->bustype & (BUS_PARALLEL | BUS_LPC | BUS_FWH)) { + uintptr_t base = flashbase ? flashbase : (0xffffffff - size + 1); + void *addr = programmer_map_flash_region("flash chip", base, size); + if (addr == ERROR_PTR) { + msg_perr("Could not map flash chip registers.\n"); + return 1; + } + flash->virtual_memory = (chipaddr)addr; + + if (flash->chip->feature_bits & FEATURE_REGISTERMAP) { + if (map_flash_registers(flash) != 0) { + unmap_flash(flash); + return 1; + } + } + } + + return 0; +} + int probe_flash(struct registered_master *mst, int startchip, struct flashctx *flash, int force) { const struct flashchip *chip; - unsigned long base = 0; - char location[64]; - uint32_t size; enum chipbustype buses_common; char *tmp; @@ -1082,9 +1130,8 @@ int probe_flash(struct registered_master *mst, int startchip, struct flashctx *f memcpy(flash->chip, chip, sizeof(struct flashchip)); flash->mst = mst; - size = chip->total_size * 1024; - base = flashbase ? flashbase : (0xffffffff - size + 1); - flash->virtual_memory = (chipaddr)programmer_map_flash_region("flash chip", base, size); + if (map_flash(flash) != 0) + return -1; /* We handle a forced match like a real match, we just avoid probing. Note that probe_flash() * is only called with force=1 after normal probing failed. @@ -1133,8 +1180,7 @@ int probe_flash(struct registered_master *mst, int startchip, struct flashctx *f break; /* Not the first flash chip detected on this bus, and it's just a generic match. Ignore it. */ notfound: - programmer_unmap_flash_region((void *)flash->virtual_memory, size); - flash->virtual_memory = (chipaddr)NULL; + unmap_flash(flash); free(flash->chip); flash->chip = NULL; } @@ -1142,16 +1188,9 @@ notfound: if (!flash->chip) return -1; -#if CONFIG_INTERNAL == 1 - if (programmer_table[programmer].map_flash_region == physmap) - snprintf(location, sizeof(location), "at physical address 0x%lx", base); - else -#endif - snprintf(location, sizeof(location), "on %s", programmer_table[programmer].name); - tmp = flashbuses_to_text(flash->chip->bustype); - msg_cinfo("%s %s flash chip \"%s\" (%d kB, %s) %s.\n", force ? "Assuming" : "Found", - flash->chip->vendor, flash->chip->name, flash->chip->total_size, tmp, location); + msg_cinfo("%s %s flash chip \"%s\" (%d kB, %s).\n", force ? "Assuming" : "Found", + flash->chip->vendor, flash->chip->name, flash->chip->total_size, tmp); free(tmp); /* Flash registers will not be mapped if the chip was forced. Lock info @@ -1872,7 +1911,8 @@ int doit(struct flashctx *flash, int force, const char *filename, int read_it, flash->chip->unlock(flash); if (read_it) { - return read_flash_to_file(flash, filename); + ret = read_flash_to_file(flash, filename); + goto unmap; } oldcontents = malloc(size); @@ -1991,5 +2031,7 @@ int doit(struct flashctx *flash, int force, const char *filename, int read_it, out: free(oldcontents); free(newcontents); +unmap: + unmap_flash(flash); return ret; } diff --git a/jedec.c b/jedec.c index 358b850..1345b89 100644 --- a/jedec.c +++ b/jedec.c @@ -166,9 +166,6 @@ int probe_jedec_29gl(struct flashctx *flash) if (man_id != chip->manufacture_id || dev_id != chip->model_id) return 0; - if (chip->feature_bits & FEATURE_REGISTERMAP) - map_flash_registers(flash); - return 1; } @@ -287,9 +284,6 @@ static int probe_jedec_common(struct flashctx *flash, unsigned int mask) if (largeid1 != chip->manufacture_id || largeid2 != chip->model_id) return 0; - if (chip->feature_bits & FEATURE_REGISTERMAP) - map_flash_registers(flash); - return 1; } -- Kind regards, Stefan Tauner

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

flashrom