flashrom February 2015

flashrom@flashrom.org

30 participants
77 discussions

Unknown SPI chip on Google Falco with linux_spi

by Remigijus Jarmalavičius

Hi, I am trying to unbrick latest Acer C720 with flashrom. What I have already done: - Created ROM image successfully for writing with flashrom; - Connected wires from Raspberry Pi to EEPROM chip on C720. - Enabled kernel modules and tested with spidev_test (it returns data, looks normal - not all 00's or FF's) - Download latest flashrom from svn and compiled. - Then executed: ./flashrom -VVV -p linux_spi:dev=/dev/spidev0.0 After a lot output it said to me: Found Generic flash chip "unknown SPI chip (RDID)" (0 kB, SPI) on linux_spi. Probing for Generic unknown SPI chip (REMS), 0 kB: REMS returned 0xff 0xff. probe_spi_rems: id1 0xff, id2 0xff Found Generic flash chip "unknown SPI chip (RDID)" (0 kB, SPI). === This flash part has status NOT WORKING for operations: PROBE READ ERASE WRITE The test status of this chip may have been updated in the latest development version of flashrom. If you are running the latest development version, please email a report to flashrom(a)flashrom.org if any of the above operations work correctly for you with this flash chip. Please include the flashrom log file for all operations you tested (see the man page for details), and mention which mainboard or programmer you tested in the subject line. Thanks for your help! No operations were specified. I saw that sometimes chip numbers are not entered to the flashrom source, maybe it's the same case? I think I have read all sites I found on Google about unbricking acer c720. What I should try next? Some details: - Ubuntu 14 OS on Raspberry Pi B version. - Acer chromebook c720 (model no: zhn) Please help me solve the issue. I am attaching complete log command: ./flashrom -VVV -p linux_spi:dev=/dev/spidev0.0 > log -- *Remigijus Jarmalavičius*

6 years, 7 months

Re: [flashrom] [PATCH] Fix a number of problems in mstarddc_spi.c.

by Alexandre Boeglin

Hello, Le mercredi 18 février 2015 à 01:31, Stefan Tauner a écrit: > Coverity has brought up the following problems: Sorry, I wasn't aware that there were coverity reports for the project. > This patch revamps the function in various ways to fix these issues and some > other irritating bits. > It reduces scopes of variables where possible, pushes the code towards our > coding standards and introduces a label-based resource cleanup at the end. I agree, this patch does make the code easier to read, in addition to fixing my mistakes :) Best regards, Alex -- Alexandre Boeglin email: alex (at) boeglin (dot) org jabber: alex (at) im (dot) boeglin (dot) org website: http://boeglin.org/

6 years, 7 months

[commit] r1885 - trunk

by repository service

Author: stefanct Date: Thu Feb 19 00:28:30 2015 New Revision: 1885 URL: http://flashrom.org/trac/flashrom/changeset/1885 Log: Fix a number of problems in mstarddc_spi.c. Coverity has brought up the following problems: mstarddc_spi_send_command(): - CID 1270702: bad comparison of malloced pointer 'cmd'. - CID 1270701: a NULL pointer dereference possible because of above. Simply checking the return value of malloc in a valid way fixes both problems. mstarddc_spi_init(): - CID 1270699 and 1270700: Memory leak of i2c_device. This patch revamps the function in various ways to fix these issues and some other irritating bits. It reduces scopes of variables where possible, pushes the code towards our coding standards and introduces a label-based resource cleanup at the end. Signed-off-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> Acked-by: Alexandre Boeglin <alex(a)boeglin.org> Modified: trunk/mstarddc_spi.c Modified: trunk/mstarddc_spi.c ============================================================================== --- trunk/mstarddc_spi.c Wed Feb 11 23:30:30 2015 (r1884) +++ trunk/mstarddc_spi.c Thu Feb 19 00:28:30 2015 (r1885) @@ -74,37 +74,37 @@ /* Returns 0 upon success, a negative number upon errors. */ int mstarddc_spi_init(void) { - char *i2c_device; - char *i2c_address; - char *noreset; + int ret = 0; // Get device, address from command-line - i2c_device = extract_programmer_param("dev"); - if (i2c_device && strlen(i2c_device)) { - if ((i2c_address = strchr(i2c_device, ':'))) { + char *i2c_device = extract_programmer_param("dev"); + if (i2c_device != NULL && strlen(i2c_device) > 0) { + char *i2c_address = strchr(i2c_device, ':'); + if (i2c_address != NULL) { *i2c_address = '\0'; i2c_address++; } - if (!i2c_address || !strlen(i2c_address)) { + if (i2c_address == NULL || strlen(i2c_address) == 0) { msg_perr("Error: no address specified.\n" "Use flashrom -p mstarddc_spi:dev=/dev/device:address.\n"); - return -1; + ret = -1; + goto out; } - mstarddc_addr = strtol(i2c_address, NULL, 16); + mstarddc_addr = strtol(i2c_address, NULL, 16); // FIXME: error handling } else { msg_perr("Error: no device specified.\n" "Use flashrom -p mstarddc_spi:dev=/dev/device:address.\n"); - return -1; + ret = -1; + goto out; } - msg_pinfo("Info: Will try to use device %s and address 0x%02x.\n", - i2c_device, mstarddc_addr); + msg_pinfo("Info: Will try to use device %s and address 0x%02x.\n", i2c_device, mstarddc_addr); // Get noreset=1 option from command-line - if ((noreset = extract_programmer_param("noreset")) - && noreset[0] == '1') + char *noreset = extract_programmer_param("noreset"); + if (noreset != NULL && noreset[0] == '1') mstarddc_doreset = 0; - msg_pinfo("Info: WILL %sreset the device at the end.\n", - mstarddc_doreset ? "" : "NOT "); + free(noreset); + msg_pinfo("Info: Will %sreset the device at the end.\n", mstarddc_doreset ? "" : "NOT "); // Open device if ((mstarddc_fd = open(i2c_device, O_RDWR)) < 0) { switch (errno) { @@ -119,16 +119,17 @@ i2c_device); break; default: - msg_perr("Error opening %s: errno %d.\n", - i2c_device, errno); + msg_perr("Error opening %s: %s.\n", i2c_device, strerror(errno)); } - return -1; + ret = -1; + goto out; } // Set slave address if (ioctl(mstarddc_fd, I2C_SLAVE, mstarddc_addr) < 0) { msg_perr("Error setting slave address 0x%02x: errno %d.\n", mstarddc_addr, errno); - return -1; + ret = -1; + goto out; } // Enable ISP mode uint8_t cmd[5] = { 'M', 'S', 'T', 'A', 'R' }; @@ -141,7 +142,8 @@ msg_perr("Error enabling ISP mode: errno %d & %d.\n" "Please check that device (%s) and address (0x%02x) are correct.\n", enable_err, errno, i2c_device, mstarddc_addr); - return -1; + ret = -1; + goto out; } } // Register shutdown function @@ -149,7 +151,9 @@ // Register programmer register_spi_master(&spi_master_mstarddc); - return 0; +out: + free(i2c_device); + return ret; } /* Returns 0 upon success, a negative number upon errors. */ @@ -160,9 +164,8 @@ unsigned char *readarr) { int ret = 0; - uint8_t *cmd; - - if ((cmd = malloc((writecnt + 1) * sizeof(uint8_t))) < 0) { + uint8_t *cmd = malloc((writecnt + 1) * sizeof(uint8_t)); + if (cmd == NULL) { msg_perr("Error allocating memory: errno %d.\n", errno); ret = -1; }

6 years, 7 months

Re: [flashrom] Asus P5W-DH board enable problem

by Stefan Tauner

On Thu, 19 Feb 2015 01:04:34 +0300 "nicolae788 ." <nicolae788(a)gmail.com> wrote: > Thank you very much for your response. I will check the link and hope to > manage and enable it. One last question: if a board recognizes a 512kb chip > is it normal to not recognize the above described ( SST 49LF008A ) 1Mb chip > ??? I have a board with which i could do the flash procedure, it is > fully supported by flashrom, flash chip, chipset, board, but it doesn;t > seem to find the chip i want to flash. The original 512 Kb chip it's listed > when i run flashrom, but when i change chips with the 1Mb one and run again > flashrom the new chip it's not recognized... There are different kinds of protocols involved and it is possible that chips with the same form factor/package are not compatible. http://flashrom.org/Technology#Communication_bus_protocol You should state more facts and/or post logs if you need more help. -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

6 years, 7 months

Re: [flashrom] Asus P5W-DH board enable problem

by Stefan Tauner

On Wed, 18 Feb 2015 16:26:35 +0300 "nicolae788 ." <nicolae788(a)gmail.com> wrote: > Hello, > > I am trying to write a chip SST 49LF008A in a P5W-DH board. This is not the > original chip of the board, it's a hot flash. The flashrom properly detects > the ICH7R chipset and the chip described above, but can only read from it > no erase or write. The problem is that it does not enable the TBL pin on > the chip, it stays low. I checked if the pin can be enabled by using the > onboard flash utility from whitin the original BIOS of this board an i get > a high on that pin ( +3.3V ) so it means that the chipset it's doing the > work if properly enabled. > […] > Can someone please instruct me on how to proceed further? Thank you very > much for your kindness. > Hi, as the name suggests a board enable is rather board-specific. It is usually required to toggle a GPIO pin of the southbridge that is connected to the TBL or #WP pin of the flash chip. What needs to be done is actually encoded in the BIOS image (not the flash tool) so it can be recovered by reverse engineering. See http://flashrom.org/Board_Enable for more details. -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

6 years, 7 months

Asus P5W-DH board enable problem

by nicolae788 .

Hello, I am trying to write a chip SST 49LF008A in a P5W-DH board. This is not the original chip of the board, it's a hot flash. The flashrom properly detects the ICH7R chipset and the chip described above, but can only read from it no erase or write. The problem is that it does not enable the TBL pin on the chip, it stays low. I checked if the pin can be enabled by using the onboard flash utility from whitin the original BIOS of this board an i get a high on that pin ( +3.3V ) so it means that the chipset it's doing the work if properly enabled. I tryied specifying another board model that has the same chipset, but it exists with a message that " no suitable boar enable found for the board name and manufacturer...". I tried with version 0.9.7-r1711 and 0.9.5.2-r1546 under linux. Both gave the same results. When it tries to erase/write to the chip i get "erase failed at 0x00000000! expected=0xff read=0x6d, failed byte count from 0x00000000 - 0x0000ffff: 0x837 erase failed ! Reading current flash chip contents...done. erase failed at 0x00000000! Expected 0x0xff, Read=0x6d, failed byte count from 0x00000000 - 0x0000ffff: 0x66dc Erase failed ! Failed ! Can someone please instruct me on how to proceed further? Thank you very much for your kindness. Alex.

6 years, 7 months

[PATCH] Fix a number of problems in mstarddc_spi.c.

by Stefan Tauner

Coverity has brought up the following problems: mstarddc_spi_send_command(): - CID 1270702: bad comparison of malloced pointer 'cmd'. - CID 1270701: a NULL pointer dereference possible because of above. Simply checking the return value of malloc in a valid way fixes both problems. mstarddc_spi_init(): - CID 1270699 and 1270700: Memory leak of i2c_device. This patch revamps the function in various ways to fix these issues and some other irritating bits. It reduces scopes of variables where possible, pushes the code towards our coding standards and introduces a label-based resource cleanup at the end. Signed-off-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at> --- mstarddc_spi.c | 53 ++++++++++++++++++++++++++++------------------------- 1 file changed, 28 insertions(+), 25 deletions(-) diff --git a/mstarddc_spi.c b/mstarddc_spi.c index 0b41a1b..809d690 100644 --- a/mstarddc_spi.c +++ b/mstarddc_spi.c @@ -74,37 +74,37 @@ static int mstarddc_spi_shutdown(void *data) /* Returns 0 upon success, a negative number upon errors. */ int mstarddc_spi_init(void) { - char *i2c_device; - char *i2c_address; - char *noreset; + int ret = 0; // Get device, address from command-line - i2c_device = extract_programmer_param("dev"); - if (i2c_device && strlen(i2c_device)) { - if ((i2c_address = strchr(i2c_device, ':'))) { + char *i2c_device = extract_programmer_param("dev"); + if (i2c_device != NULL && strlen(i2c_device) > 0) { + char *i2c_address = strchr(i2c_device, ':'); + if (i2c_address != NULL) { *i2c_address = '\0'; i2c_address++; } - if (!i2c_address || !strlen(i2c_address)) { + if (i2c_address == NULL || strlen(i2c_address) == 0) { msg_perr("Error: no address specified.\n" "Use flashrom -p mstarddc_spi:dev=/dev/device:address.\n"); - return -1; + ret = -1; + goto out; } - mstarddc_addr = strtol(i2c_address, NULL, 16); + mstarddc_addr = strtol(i2c_address, NULL, 16); // FIXME: error handling } else { msg_perr("Error: no device specified.\n" "Use flashrom -p mstarddc_spi:dev=/dev/device:address.\n"); - return -1; + ret = -1; + goto out; } - msg_pinfo("Info: Will try to use device %s and address 0x%02x.\n", - i2c_device, mstarddc_addr); + msg_pinfo("Info: Will try to use device %s and address 0x%02x.\n", i2c_device, mstarddc_addr); // Get noreset=1 option from command-line - if ((noreset = extract_programmer_param("noreset")) - && noreset[0] == '1') + char *noreset = extract_programmer_param("noreset"); + if (noreset != NULL && noreset[0] == '1') mstarddc_doreset = 0; - msg_pinfo("Info: WILL %sreset the device at the end.\n", - mstarddc_doreset ? "" : "NOT "); + free(noreset); + msg_pinfo("Info: Will %sreset the device at the end.\n", mstarddc_doreset ? "" : "NOT "); // Open device if ((mstarddc_fd = open(i2c_device, O_RDWR)) < 0) { switch (errno) { @@ -119,16 +119,17 @@ int mstarddc_spi_init(void) i2c_device); break; default: - msg_perr("Error opening %s: errno %d.\n", - i2c_device, errno); + msg_perr("Error opening %s: %s.\n", i2c_device, strerror(errno)); } - return -1; + ret = -1; + goto out; } // Set slave address if (ioctl(mstarddc_fd, I2C_SLAVE, mstarddc_addr) < 0) { msg_perr("Error setting slave address 0x%02x: errno %d.\n", mstarddc_addr, errno); - return -1; + ret = -1; + goto out; } // Enable ISP mode uint8_t cmd[5] = { 'M', 'S', 'T', 'A', 'R' }; @@ -141,7 +142,8 @@ int mstarddc_spi_init(void) msg_perr("Error enabling ISP mode: errno %d & %d.\n" "Please check that device (%s) and address (0x%02x) are correct.\n", enable_err, errno, i2c_device, mstarddc_addr); - return -1; + ret = -1; + goto out; } } // Register shutdown function @@ -149,7 +151,9 @@ int mstarddc_spi_init(void) // Register programmer register_spi_master(&spi_master_mstarddc); - return 0; +out: + free(i2c_device); + return ret; } /* Returns 0 upon success, a negative number upon errors. */ @@ -160,9 +164,8 @@ static int mstarddc_spi_send_command(struct flashctx *flash, unsigned char *readarr) { int ret = 0; - uint8_t *cmd; - - if ((cmd = malloc((writecnt + 1) * sizeof(uint8_t))) < 0) { + uint8_t *cmd = malloc((writecnt + 1) * sizeof(uint8_t)); + if (cmd == NULL) { msg_perr("Error allocating memory: errno %d.\n", errno); ret = -1; } -- Kind regards, Stefan Tauner

6 years, 7 months

Re: [flashrom] flashrom support for Spansion S25FL128S

by Stefan Tauner

On Tue, 17 Feb 2015 04:46:16 -0600 <Ron_Taylor(a)DELL.com> wrote: > 0x54: 0x000f0000 FREG0: Warning: Flash Descriptor region (0x00000000-0x0000ffff) is read-only. > 0x58: 0x07ff0200 FREG1: BIOS region (0x00200000-0x007fffff) is read-write. The problem is that the flash descriptor regions do not cover the whole flash chip. There is a hole between 0x10000 and 0x1fffff (and the second half of the chip is not mapped either). The chipset does not allow accessing these holes but flashrom does try it by default anyway because it reads the complete chip. With some patching of flashrom this can be avoided but there is no ready solution as far as I know. There are some patches regarding layout handling that might be part of a possible solution, cf. http://patchwork.coreboot.org/project/flashrom/list/ -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

6 years, 7 months

Re: [flashrom] ARM-USB-OCD works!

by Stefan Tauner

On Tue, 17 Feb 2015 19:04:24 +0100 skrizi(a)web.de wrote: > Hi, > i just want to confirm that the ARM-USB-OCD (without H suffix) works too so you can check this in the supported devices. > […] Hello skrizi, thanks for your report! I have marked the ARM-USB-OCD as working OK and will commit that later together with other small changes. -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

6 years, 7 months

SPI flash, correction

by skrizi＠web.de

6 years, 7 months

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

flashrom February 2015