flashrom August 2012

flashrom@flashrom.org

31 participants
160 discussions

[PATCH] Allow specifying CPPFLAGS
by Carl-Daniel Hailfinger 16 Aug '12

16 Aug '12

The user may know better which CFLAGS/CPPFLAGS are appropriate. Use FLASHROM_CFLAGS for flags which flashrom definitely needs to build. Note: With this patch, automatic Ubuntu Launchpad builds should work again. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Index: flashrom-makefile_allow_cppflags/Makefile =================================================================== --- flashrom-makefile_allow_cppflags/Makefile (Revision 1574) +++ flashrom-makefile_allow_cppflags/Makefile (Arbeitskopie) @@ -122,7 +122,7 @@ ifeq ($(TARGET_OS), MinGW) EXEC_SUFFIX := .exe # MinGW doesn't have the ffs() function, but we can use gcc's __builtin_ffs(). -CPPFLAGS += -Dffs=__builtin_ffs +FLASHROM_CFLAGS += -Dffs=__builtin_ffs # libusb-win32/libftdi stuff is usually installed in /usr/local. CPPFLAGS += -I/usr/local/include LDFLAGS += -L/usr/local/lib @@ -201,7 +201,7 @@ endif ifeq ($(TARGET_OS), libpayload) -CPPFLAGS += -DSTANDALONE +FLASHROM_CFLAGS += -DSTANDALONE ifeq ($(CONFIG_DUMMY), yes) UNSUPPORTED_FEATURES += CONFIG_DUMMY=yes else @@ -603,7 +603,7 @@ TAROPTIONS = $(shell LC_ALL=C tar --version|grep -q GNU && echo "--owner=root --group=root") %.o: %.c .features - $(CC) -MMD $(CFLAGS) $(CPPFLAGS) $(FEATURE_CFLAGS) $(SVNDEF) -o $@ -c $< + $(CC) -MMD $(CFLAGS) $(CPPFLAGS) $(FLASHROM_CFLAGS) $(FEATURE_CFLAGS) $(SVNDEF) -o $@ -c $< # Make sure to add all names of generated binaries here. # This includes all frontends and libflashrom. Index: flashrom-makefile_allow_cppflags/util/ich_descriptors_tool/Makefile =================================================================== --- flashrom-makefile_allow_cppflags/util/ich_descriptors_tool/Makefile (Revision 1574) +++ flashrom-makefile_allow_cppflags/util/ich_descriptors_tool/Makefile (Arbeitskopie) @@ -30,10 +30,10 @@ endif -CPPFLAGS += -MMD -MP -MF $(DEPPATH)/$((a)F).d +FLASHROM_CFLAGS += -MMD -MP -MF $(DEPPATH)/$((a)F).d # enables functions that populate the descriptor structs from plain binary dumps -CPPFLAGS += -D ICH_DESCRIPTORS_FROM_DUMP -CPPFLAGS += $(patsubst %,-I%,$(EXTRAINCDIRS)) +FLASHROM_CFLAGS += -D ICH_DESCRIPTORS_FROM_DUMP +FLASHROM_CFLAGS += $(patsubst %,-I%,$(EXTRAINCDIRS)) OBJ = $(OBJATH)/$(SRC:%.c=%.o) @@ -42,15 +42,15 @@ all:$(PROGRAM)$(EXEC_SUFFIX) $(OBJ): $(OBJATH)/%.o : %.c - $(CC) $(CFLAGS) $(CPPFLAGS) -o $@ -c $< + $(CC) $(CFLAGS) $(CPPFLAGS) $(FLASHROM_CFLAGS) -o $@ -c $< # this enables us to share source files without simultaneously sharing .o files # with flashrom, which would lead to unexpected results (w/o running make clean) $(SHAREDOBJ): $(OBJATH)/%.o : $(SHAREDSRCDIR)/%.c - $(CC) $(CFLAGS) $(CPPFLAGS) -o $@ -c $< + $(CC) $(CFLAGS) $(CPPFLAGS) $(FLASHROM_CFLAGS) -o $@ -c $< $(PROGRAM)$(EXEC_SUFFIX): $(OBJ) $(SHAREDOBJ) - $(CC) -o $(PROGRAM)$(EXEC_SUFFIX) $(OBJ) $(SHAREDOBJ) + $(CC) $(LDFLAGS) -o $(PROGRAM)$(EXEC_SUFFIX) $(OBJ) $(SHAREDOBJ) clean: rm -f $(PROGRAM) $(PROGRAM).exe -- http://www.hailfinger.org/

1 1

[commit] r1575 - in trunk: . util/ich_descriptors_tool
by repository service 16 Aug '12

16 Aug '12

Author: hailfinger Date: Thu Aug 16 01:06:32 2012 New Revision: 1575 URL: http://flashrom.org/trac/flashrom/changeset/1575 Log: Allow specifying CPPFLAGS The user may know better which CFLAGS/CPPFLAGS are appropriate. Use FLASHROM_CFLAGS for flags which flashrom definitely needs to build. Thanks to Stefan Tauner for pointing out the flaw in r1574. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Modified: trunk/Makefile trunk/util/ich_descriptors_tool/Makefile Modified: trunk/Makefile ============================================================================== --- trunk/Makefile Tue Aug 14 23:36:11 2012 (r1574) +++ trunk/Makefile Thu Aug 16 01:06:32 2012 (r1575) @@ -122,7 +122,7 @@ ifeq ($(TARGET_OS), MinGW) EXEC_SUFFIX := .exe # MinGW doesn't have the ffs() function, but we can use gcc's __builtin_ffs(). -CPPFLAGS += -Dffs=__builtin_ffs +FLASHROM_CFLAGS += -Dffs=__builtin_ffs # libusb-win32/libftdi stuff is usually installed in /usr/local. CPPFLAGS += -I/usr/local/include LDFLAGS += -L/usr/local/lib @@ -201,7 +201,7 @@ endif ifeq ($(TARGET_OS), libpayload) -CPPFLAGS += -DSTANDALONE +FLASHROM_CFLAGS += -DSTANDALONE ifeq ($(CONFIG_DUMMY), yes) UNSUPPORTED_FEATURES += CONFIG_DUMMY=yes else @@ -603,7 +603,7 @@ TAROPTIONS = $(shell LC_ALL=C tar --version|grep -q GNU && echo "--owner=root --group=root") %.o: %.c .features - $(CC) -MMD $(CFLAGS) $(CPPFLAGS) $(FEATURE_CFLAGS) $(SVNDEF) -o $@ -c $< + $(CC) -MMD $(CFLAGS) $(CPPFLAGS) $(FLASHROM_CFLAGS) $(FEATURE_CFLAGS) $(SVNDEF) -o $@ -c $< # Make sure to add all names of generated binaries here. # This includes all frontends and libflashrom. Modified: trunk/util/ich_descriptors_tool/Makefile ============================================================================== --- trunk/util/ich_descriptors_tool/Makefile Tue Aug 14 23:36:11 2012 (r1574) +++ trunk/util/ich_descriptors_tool/Makefile Thu Aug 16 01:06:32 2012 (r1575) @@ -30,10 +30,10 @@ endif -CPPFLAGS += -MMD -MP -MF $(DEPPATH)/$((a)F).d +FLASHROM_CFLAGS += -MMD -MP -MF $(DEPPATH)/$((a)F).d # enables functions that populate the descriptor structs from plain binary dumps -CPPFLAGS += -D ICH_DESCRIPTORS_FROM_DUMP -CPPFLAGS += $(patsubst %,-I%,$(EXTRAINCDIRS)) +FLASHROM_CFLAGS += -D ICH_DESCRIPTORS_FROM_DUMP +FLASHROM_CFLAGS += $(patsubst %,-I%,$(EXTRAINCDIRS)) OBJ = $(OBJATH)/$(SRC:%.c=%.o) @@ -42,15 +42,15 @@ all:$(PROGRAM)$(EXEC_SUFFIX) $(OBJ): $(OBJATH)/%.o : %.c - $(CC) $(CFLAGS) $(CPPFLAGS) -o $@ -c $< + $(CC) $(CFLAGS) $(CPPFLAGS) $(FLASHROM_CFLAGS) -o $@ -c $< # this enables us to share source files without simultaneously sharing .o files # with flashrom, which would lead to unexpected results (w/o running make clean) $(SHAREDOBJ): $(OBJATH)/%.o : $(SHAREDSRCDIR)/%.c - $(CC) $(CFLAGS) $(CPPFLAGS) -o $@ -c $< + $(CC) $(CFLAGS) $(CPPFLAGS) $(FLASHROM_CFLAGS) -o $@ -c $< $(PROGRAM)$(EXEC_SUFFIX): $(OBJ) $(SHAREDOBJ) - $(CC) -o $(PROGRAM)$(EXEC_SUFFIX) $(OBJ) $(SHAREDOBJ) + $(CC) $(LDFLAGS) -o $(PROGRAM)$(EXEC_SUFFIX) $(OBJ) $(SHAREDOBJ) clean: rm -f $(PROGRAM) $(PROGRAM).exe

1 0

Re: [flashrom] IBM SurePOS 700 4800-783 support
by Stefan Tauner 15 Aug '12

15 Aug '12

On Wed, 15 Aug 2012 08:56:34 -0400 Jason_Vannest(a)abercrombie.com wrote: Hi Jason! > Sorry Stefan, > > I've been busy and our test lab is being used to do a regression right now > so I've not had time to try and compile and test the patch you provided. NP, i just wanted to get sure you have received my last mail and nothing momentous happened, because your replies were within days or even hours before. > I do intend to do so, give me a little more time and I'll see what I can > do. We have received your other message containing the read out bios image. It sits in the moderation queue at the moment, because we can't publish it (it is copyrighted). Thanks for taking the time to test! What we actually wanted to see is the output that flashrom prints to screen (or saves to a file when one specifies the log file option -o "logfilename"). But since you were able to read the BIOS file correctly the patch seems to have worked at least to some extend. This is great news! Nevertheless please send the verbose output of flashrom too. > On the topic of IBM and help, I have been in discussion with IBM about the > firmware updates and they have been very adamant that we need to insure > that we update all the devices not just the BIOS itself. From looking at > a handful of their update packages, I can see that they frequently include > updates for riser cards, service processors and possibly other devices > with the BIOS updates. So before we implement something with flashrom we > would want to make sure we're not missing something that could later cause > us issues even if the issues are only that IBM is unhappy because we > didn't follow their update procedures. The latter would be the last thing i would worry about, but especially the service processors might interact with the BIOS and if an update changes the protocol that they talk with each other, then this may lead to unbootable machines... It is probably possible to add support for the other device to flashrom as well, but that would certainly not be a single line change and take way more time to implement, even if IBM provides some documentation. Without documentation it would probably be pretty much infeasible. -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

1 0

Re: [flashrom] IBM SurePOS 700 4800-783 support
by Stefan Tauner 15 Aug '12

15 Aug '12

On Wed, 11 Jul 2012 18:17:19 -0400 Jason_Vannest(a)abercrombie.com wrote: > If I'm reading the flashrom site correctly this is one of the flash chips > that flashrom has support for already. So that might be a plus. Yes, the flash chip itself wont be a problem. There is a service manual for the POS located at ftp://ftp.software.ibm.com/software/retail/pubs/hw/4800_surepos700/btd5_480… and it mentions a "backup bios" in the service processor section. That could complicate things further (or help you out if something fails if you are very lucky, but usually it make things worse for us). The remainder of the document is not very helpful (targeted at users not developers). > > I'd venture a guess that we can do this before IBM can > > even give you a quote. > > What kind of information would you want? I have pretty solid connections > with IBM I may be able to get questions answered about this. A schematic that contains the data path between the southbridge and the flash chip as well as its relation to the Renesas IC would indicate if we have to take care about the Renesas at all. Any additional information regarding the BIOS upgrade process (e.g. if the version of the Renesas' firmware has to be kept in sync with the BIOS) or the service processor's interaction with the flash chip would be very welcome too. Above all we need to work on the support for the VIA chipset (VT8251), but IBM won't be able to help us with that. I have no news regarding that. -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

3 6

Re: [flashrom] Issue with flashrom tool
by Carl-Daniel Hailfinger 15 Aug '12

15 Aug '12

Hi Lap Ngo Doan, your flashrom version is very old. Please get a newer flashrom version from https://launchpad.net/~flashrom-developers/+archive/flashrom-daily or compile latest flashrom from source: http://flashrom.org/Downloads Am 15.08.2012 05:14 schrieb Lap Ngo Doan: > We are preparing flash new rom (coreboot.rom) to Persimmon board using > flashrom tool > http://www.coreboot.org/AMD_DB-FT1_PERSIMMON > http://www.amd.com/us/Documents/49286_Embedded_Solutions_Brief_FT1_web.pdf > Before do that, We'd like to make a test of using flashroom tool. > [Envrionment] > Hardware: Persimmon board > OS: Ubuntu 10.10 32bits > Flash rom tool: flashrom > [Testing steps] > 1. Use flashrom tool to capture/read current ROM > file (to make a backup) : ROM_BOARD2.rom > $flashrom -r ROM_BOARD2.rom > 2. Verify captured data (ROM_BOARD2.rom) with > current ROM > $flashrom -v ROM_BOARD2.rom > Unfortunately, the verifiy status is FALIED ==> We are not confident to use > flashrom tool to update new rom file Please retry the test with flashrom 0.9.5 or 0.9.6 or newer in verbose mode: flashrom -p internal -VV -r ROM_BOARD2.rom flashrom -p internal -VV -v ROM_BOARD2.rom Then post the new verbose logs to this mailing list. Regards, Carl-Daniel -- http://www.hailfinger.org/

1 0

Issue with flashrom tool
by Lap Ngo Doan 15 Aug '12

15 Aug '12

Hi all, We are preparing flash new rom (coreboot.rom) to Persimmon board using flashrom tool http://www.coreboot.org/AMD_DB-FT1_PERSIMMON http://www.amd.com/us/Documents/49286_Embedded_Solutions_Brief_FT1_web.pdf Before do that, We'd like to make a test of using flashroom tool. [Envrionment] Hardware: Persimmon board OS: Ubuntu 10.10 32bits Flash rom tool: flashrom [Testing steps] 1. Use flashrom tool to capture/read current ROM file (to make a backup) : ROM_BOARD2.rom $flashrom -r ROM_BOARD2.rom 2. Verify captured data (ROM_BOARD2.rom) with current ROM $flashrom -v ROM_BOARD2.rom Unfortunately, the verifiy status is FALIED ==> We are not confident to use flashrom tool to update new rom file Could you please refer to log file to see the details and give us some advises? Thank you very much!

1 0

Fix for serprog-ardu initialization failure due to unimplemented S_CMD_S_BUSTYPE (0x12)
by Alexander Meyer 15 Aug '12

15 Aug '12

Hi, I had problems making flashrom talk to an Arduino as described in http://www.flashrom.org/index.php?title=Serprog&redirect=no It always failed right after this: Warning: Automatic command availability check failed for cmd 0x12 - won't execute cmd With help from stefanct on the IRC I was able to fix it and successfully write and verify a W25X80 bios chip. The problem was, stefanct implemented a mandatory check for S_CMD_S_BUSTYPE (0x12) in flashrom which isn't yet implemented in the Arduino code. To work around it you can downgrade flashrom to before r1557 or you can make the Arduino code give a satisfactory answer to the check. To do that, you must append "| (1 << (S_CMD_S_BUSTYPE - 16))" to the SUPPORTED_COMMANDS_HIGH define, and send an ACK when asked for S_CMD_S_BUSTYPE (0x12) in the Arduino code. Actually, "<stefanct> the right way would be to test if flashrom tries to set SPI and ack in that case and nak in all other cases". I also had problems with the high baudrate. Setting it to 1000000 instead of 2000000 seems to work reliably and is still fast enough for me. YMMV. Note that the value must be changed in the arguments for flashrom as well as the Arduino code. Thank you guys for your great work and thank you stefanct for helping me out! Cheers, Alexander

1 0

Shuttle Inc FN78S: flashrom -V
by dvrhax 15 Aug '12

15 Aug '12

3 4

Gigabyte GA-H77-D3H test
by Alexander Gordeev 14 Aug '12

14 Aug '12

Hi! I've got the attached output after running flashrom -V. Is it ok to try to write to flash? Particularly this line concerns me: enable_flash_ich_dc_spi: unknown ICH generation. Please report! Anyway, Gigabyte DualBIOS should save it if write corrupts BIOS... Right? :) -- Alexander

2 1

[PATCH] Allow the user to specify CFLAGS without breaking the build
by Carl-Daniel Hailfinger 14 Aug '12

14 Aug '12

GNU make has a very interesting quirk: If you set a variable on the command line, any changes to that variable in the Makefile are ignored unless marked with the "override" keyword. Use CFLAGS only for optimization and warning options, and use CPPFLAGS for the dependency and other preprocessor related options. That way packagers can specify their own CFLAGS without breaking the build. As a side benefit, the ich_descriptors_tool Makefile now behaves exactly the same whether called standalone or as part of the main Makefile. Note: THIS WILL BREAK THE BUILD due to problems in the ich_descriptors_tool code. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Index: flashrom-gnumake_workaround_cflags_ich_descriptors_tool/Makefile =================================================================== --- flashrom-gnumake_workaround_cflags_ich_descriptors_tool/Makefile (Revision 1569) +++ flashrom-gnumake_workaround_cflags_ich_descriptors_tool/Makefile (Arbeitskopie) @@ -26,6 +26,9 @@ # If you want to cross-compile, just run e.g. # make CC=i586-pc-msdosdjgpp-gcc # You may have to specify STRIP/AR/RANLIB as well. +# +# Note for anyone editing this Makefile: gnumake will happily ignore any +# changes in this Makefile to variables set on the command line. CC ?= gcc STRIP ?= strip INSTALL = install @@ -83,7 +86,7 @@ EXEC_SUFFIX := .exe CPPFLAGS += -I../libgetopt # DJGPP has odd uint*_t definitions which cause lots of format string warnings. -CPPFLAGS += -Wno-format +CFLAGS += -Wno-format # FIXME Check if we can achieve the same effect with -L../libgetopt -lgetopt LIBS += ../libgetopt/libgetopt.a # Bus Pirate, Serprog and PonyProg are not supported under DOS (missing serial support). @@ -119,7 +122,7 @@ ifeq ($(TARGET_OS), MinGW) EXEC_SUFFIX := .exe # MinGW doesn't have the ffs() function, but we can use gcc's __builtin_ffs(). -CFLAGS += -Dffs=__builtin_ffs +CPPFLAGS += -Dffs=__builtin_ffs # libusb-win32/libftdi stuff is usually installed in /usr/local. CPPFLAGS += -I/usr/local/include LDFLAGS += -L/usr/local/lib Index: flashrom-gnumake_workaround_cflags_ich_descriptors_tool/util/ich_descriptors_tool/Makefile =================================================================== --- flashrom-gnumake_workaround_cflags_ich_descriptors_tool/util/ich_descriptors_tool/Makefile (Revision 1569) +++ flashrom-gnumake_workaround_cflags_ich_descriptors_tool/util/ich_descriptors_tool/Makefile (Arbeitskopie) @@ -1,4 +1,8 @@ -CC ?= gcc +# +# This file is part of the flashrom project. +# +# This Makefile works standalone, but it is usually called from the main +# Makefile in the flashrom directory. PROGRAM=ich_descriptors_tool EXTRAINCDIRS = ../../ . @@ -6,20 +10,31 @@ OBJATH = .obj SHAREDSRC = ich_descriptors.c SHAREDSRCDIR = ../.. +# If your compiler spits out excessive warnings, run make WARNERROR=no +# You shouldn't have to change this flag. +WARNERROR ?= yes SRC = $(wildcard *.c) -CFLAGS += -Wall -CFLAGS += -MMD -MP -MF $(DEPPATH)/$((a)F).d -# enables functions that populate the descriptor structs from plain binary dumps -CFLAGS += -D ICH_DESCRIPTORS_FROM_DUMP -CFLAGS += $(patsubst %,-I%,$(EXTRAINCDIRS)) +CC ?= gcc +# If the user has specified custom CFLAGS, all CFLAGS settings below will be +# completely ignored by gnumake. +CFLAGS ?= -Os -Wall -Wshadow ifeq ($(TARGET_OS), DOS) # DJGPP has odd uint*_t definitions which cause lots of format string warnings. CFLAGS += -Wno-format endif +ifeq ($(WARNERROR), yes) +CFLAGS += -Werror +endif + +CPPFLAGS += -MMD -MP -MF $(DEPPATH)/$((a)F).d +# enables functions that populate the descriptor structs from plain binary dumps +CPPFLAGS += -D ICH_DESCRIPTORS_FROM_DUMP +CPPFLAGS += $(patsubst %,-I%,$(EXTRAINCDIRS)) + OBJ = $(OBJATH)/$(SRC:%.c=%.o) SHAREDOBJ = $(OBJATH)/$(notdir $(SHAREDSRC:%.c=%.o)) @@ -27,12 +42,12 @@ all:$(PROGRAM)$(EXEC_SUFFIX) $(OBJ): $(OBJATH)/%.o : %.c - $(CC) $(CFLAGS) -o $@ -c $< + $(CC) $(CFLAGS) $(CPPFLAGS) -o $@ -c $< # this enables us to share source files without simultaneously sharing .o files # with flashrom, which would lead to unexpected results (w/o running make clean) $(SHAREDOBJ): $(OBJATH)/%.o : $(SHAREDSRCDIR)/%.c - $(CC) $(CFLAGS) -o $@ -c $< + $(CC) $(CFLAGS) $(CPPFLAGS) -o $@ -c $< $(PROGRAM)$(EXEC_SUFFIX): $(OBJ) $(SHAREDOBJ) $(CC) -o $(PROGRAM)$(EXEC_SUFFIX) $(OBJ) $(SHAREDOBJ) -- http://www.hailfinger.org/

2 2

← Newer
1
...
8
9
10
11
12
13
14
15
16
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

flashrom August 2012