flashrom March 2011

flashrom@flashrom.org

37 participants
170 discussions

Start a nNew thread

flashrom -E
by Eric Konesky 08 Mar '11

08 Mar '11

I accidently erased my bios does this erase the boot block?

2 1

[PATCH] Initial ITE IT8500 EC support (second try)
by David Hendricks 08 Mar '11

08 Mar '11

A few months ago, ITE open sourced the initial IT8500 EC patch on this mailing list ( http://www.flashrom.org/pipermail/flashrom/2010-August/004382.html) so that we could check it in to the Chromium OS branch. It didn't quite make it upstream, and has been updated since then. The attached patch basically does the same thing and has been deployed and tested to work on the Cr-48. There are a few caveats, though: - The boot BIOS straps register must be modified to select LPC. This can be done with the attached "select_bbs.sh" script (Install iotools ( http://code.google.com/p/iotools/) before using select_bbs). We worked around this in the Chromium OS branch by adding a bus argument to the programmer option, ie "flashrom -p internal:bus=lpc". - It is very important to disable power management daemons before running Flashrom on this EC. I commented out the brute force method we use in the Chromium OS branch that disables powerd, since IIRC Carl-Daniel has a better approach in the works. - Due to dependencies which may be introduced by the OEM/ODM EC firmware, the code is not guaranteed to work for anything other than the Cr-48. - Carl-Daniel pointed out that the code might ignore the result of it87 init code. I've attempted to mitigate this in the patch (see internal.c), but I think it's just the symptom of a larger problem with how we detect and initialize IO bridges, and should probably be dealt with in a separate patch. *Here is the text from the original patch submission: The attached patch adds generalized support for IT8500/IT8502 embedded controllers. The patch was developed by Google for Flashrom r1082, but applies cleanly against r1130. It was tested for IT8500E on a Chrome OS platform and may require modification depending on ODM/OEM customization and EC firmware version. This patch is not officially supported by ITE Tech Inc.* Signed-off-by: David Hendricks <dhendrix(a)google.com> (The original patch also included a sign-off from Yung-chieh Lo @ Google and Donald Huang @ ITE). -- David Hendricks (dhendrix) Systems Software Engineer, Google Inc.

2 5

[commit] r1279 - trunk
by repository service 08 Mar '11

08 Mar '11

Author: hailfinger Date: Tue Mar 8 01:23:49 2011 New Revision: 1279 URL: http://flashrom.org/trac/flashrom/changeset/1279 Log: Various IT85* cleanups and fixes. Fix a few typos. Change the EC memory region mapping name. Drop unused function parameter. Use mmio_writeb()/mmio_readb() to get reliable access to volatile memory locations instead of plain pointer access which is optimized away by gcc. Use own it85_* SPI high-level chip read/write functions instead of relying on unrelated ICH functions. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> David writes: I applied the patch against the Chromium OS branch and successfully tested read and write operations on a Cr48. Acked-by: David Hendricks <dhendrix(a)google.com> Modified: trunk/it85spi.c trunk/programmer.h trunk/spi.c Modified: trunk/it85spi.c ============================================================================== --- trunk/it85spi.c Tue Mar 8 01:09:11 2011 (r1278) +++ trunk/it85spi.c Tue Mar 8 01:23:49 2011 (r1279) @@ -37,7 +37,7 @@ #define MAX_TIMEOUT 100000 #define MAX_TRY 5 -/* Constans for I/O ports */ +/* Constants for I/O ports */ #define ITE_SUPERIO_PORT1 0x2e #define ITE_SUPERIO_PORT2 0x4e @@ -52,13 +52,14 @@ #define CHIP_CHIP_VER_REG 0x22 /* These are standard Super I/O 16-bit base address registers */ -#define SHM_IO_BAD0 0x60 /* big-endian, this is high bits */ -#define SHM_IO_BAD1 0x61 +#define SHM_IO_BAR0 0x60 /* big-endian, this is high bits */ +#define SHM_IO_BAR1 0x61 -/* 8042 keyboard controller uses an input buffer and an output buffer to - * communicate with host CPU. Both buffers are 1-byte depth. That means the - * IBF is set to 1 when host CPU sends a command to input buffer (standing on - * the EC side). IBF is cleared to 0 once the command is read by EC. */ +/* The 8042 keyboard controller uses an input buffer and an output buffer to + * communicate with the host CPU. Both buffers are 1-byte depth. That means + * IBF is set to 1 when the host CPU sends a command to the input buffer + * of the EC. IBF is cleared to 0 once the command is read by the EC. + */ #define KB_IBF (1 << 1) /* Input Buffer Full */ #define KB_OBF (1 << 0) /* Output Buffer Full */ @@ -278,8 +279,8 @@ #ifdef LPC_IO /* Get LPCPNP of SHM. That's big-endian */ sio_write(superio.port, LDNSEL, 0x0F); /* Set LDN to SHM (0x0F) */ - shm_io_base = (sio_read(superio.port, SHM_IO_BAD0) << 8) + - sio_read(superio.port, SHM_IO_BAD1); + shm_io_base = (sio_read(superio.port, SHM_IO_BAR0) << 8) + + sio_read(superio.port, SHM_IO_BAR1); msg_pdbg("%s():%d shm_io_base=0x%04x\n", __func__, __LINE__, shm_io_base); @@ -296,8 +297,8 @@ INDIRECT_A3(shm_io_base, (base >> 24)); #endif #ifdef LPC_MEMORY - base = (chipaddr)programmer_map_flash_region("flash base", 0xFFFFF000, - 0x1000); + base = (chipaddr)programmer_map_flash_region("it85 communication", + 0xFFFFF000, 0x1000); msg_pdbg("%s():%d base=0x%08x\n", __func__, __LINE__, (unsigned int)base); ce_high = (unsigned char*)(base + 0xE00); /* 0xFFFFFE00 */ @@ -328,7 +329,7 @@ } /* Called by internal_init() */ -int it85xx_probe_spi_flash(const char *name) +int it85xx_probe_spi_flash(void) { int ret; @@ -377,14 +378,14 @@ INDIRECT_A1(shm_io_base, (((unsigned long int)ce_low) >> 8) & 0xff); #endif #ifdef LPC_MEMORY - *ce_high = 0; + mmio_writeb(0, ce_high); #endif for (i = 0; i < writecnt; ++i) { #ifdef LPC_IO INDIRECT_WRITE(shm_io_base, writearr[i]); #endif #ifdef LPC_MEMORY - *ce_low = writearr[i]; + mmio_writeb(writearr[i], ce_low); #endif } for (i = 0; i < readcnt; ++i) { @@ -392,7 +393,7 @@ readarr[i] = INDIRECT_READ(shm_io_base); #endif #ifdef LPC_MEMORY - readarr[i] = *ce_low; + readarr[i] = mmio_readb(ce_low); #endif } #ifdef LPC_IO @@ -400,10 +401,20 @@ INDIRECT_WRITE(shm_io_base, 0xFF); /* Write anything to this address.*/ #endif #ifdef LPC_MEMORY - *ce_high = 0; + mmio_writeb(0, ce_high); #endif return 0; } +int it85_spi_read(struct flashchip *flash, uint8_t * buf, int start, int len) +{ + return spi_read_chunked(flash, buf, start, len, 64); +} + +int it85_spi_write_256(struct flashchip *flash, uint8_t * buf, int start, int len) +{ + return spi_write_chunked(flash, buf, start, len, 64); +} + #endif Modified: trunk/programmer.h ============================================================================== --- trunk/programmer.h Tue Mar 8 01:09:11 2011 (r1278) +++ trunk/programmer.h Tue Mar 8 01:23:49 2011 (r1279) @@ -585,9 +585,11 @@ struct superio probe_superio_ite85xx(void); int it85xx_spi_init(void); int it85xx_shutdown(void); -int it85xx_probe_spi_flash(const char *name); +int it85xx_probe_spi_flash(void); int it85xx_spi_send_command(unsigned int writecnt, unsigned int readcnt, const unsigned char *writearr, unsigned char *readarr); +int it85_spi_read(struct flashchip *flash, uint8_t * buf, int start, int len); +int it85_spi_write_256(struct flashchip *flash, uint8_t * buf, int start, int len); /* it87spi.c */ void enter_conf_mode_ite(uint16_t port); Modified: trunk/spi.c ============================================================================== --- trunk/spi.c Tue Mar 8 01:09:11 2011 (r1278) +++ trunk/spi.c Tue Mar 8 01:23:49 2011 (r1279) @@ -58,8 +58,8 @@ { /* SPI_CONTROLLER_IT85XX */ .command = it85xx_spi_send_command, .multicommand = default_spi_send_multicommand, - .read = ich_spi_read, - .write_256 = ich_spi_write_256, + .read = it85_spi_read, + .write_256 = it85_spi_write_256, }, { /* SPI_CONTROLLER_IT87XX */

1 0

[PATCH] Compile fixes
by Carl-Daniel Hailfinger 08 Mar '11

08 Mar '11

Fix compilation if CONFIG_INTERNAL=no. Fix compilation if everything except CONFIG_SATAMV is no. Do not compile in PCI support for wiki printing if no PCI devices are supported. Note: The flashrom.c hunk is ugly. Suggestions how to solve the ugliness are appreciated. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Index: flashrom-compilefixes/print_wiki.c =================================================================== --- flashrom-compilefixes/print_wiki.c (Revision 1275) +++ flashrom-compilefixes/print_wiki.c (Arbeitskopie) @@ -246,6 +246,8 @@ printf("\n|}\n\n|}\n"); } +/* Not needed for CONFIG_INTERNAL, but for all other PCI-based programmers. */ +#if CONFIG_NIC3COM+CONFIG_NICREALTEK+CONFIG_NICNATSEMI+CONFIG_GFXNVIDIA+CONFIG_DRKAISER+CONFIG_SATASII+CONFIG_ATAHPT+CONFIG_NICINTEL_SPI+CONFIG_OGP_SPI+CONFIG_SATAMV >= 1 static void print_supported_pcidevs_wiki(const struct pcidev_status *devs) { int i = 0; @@ -262,6 +264,7 @@ (devs[i].status == NT) ? "?3" : "OK"); } } +#endif void print_supported_wiki(void) { Index: flashrom-compilefixes/flashrom.c =================================================================== --- flashrom-compilefixes/flashrom.c (Revision 1275) +++ flashrom-compilefixes/flashrom.c (Arbeitskopie) @@ -1186,9 +1186,12 @@ if (!flash || !flash->name) return NULL; +#if CONFIG_INTERNAL == 1 if (programmer_table[programmer].map_flash_region == physmap) { snprintf(location, sizeof(location), "at physical address 0x%lx", base); - } else { + } else +#endif + { snprintf(location, sizeof(location), "on %s", programmer_table[programmer].name); } Index: flashrom-compilefixes/programmer.h =================================================================== --- flashrom-compilefixes/programmer.h (Revision 1275) +++ flashrom-compilefixes/programmer.h (Arbeitskopie) @@ -229,7 +229,7 @@ #endif /* print.c */ -#if CONFIG_NIC3COM+CONFIG_NICREALTEK+CONFIG_NICNATSEMI+CONFIG_GFXNVIDIA+CONFIG_DRKAISER+CONFIG_SATASII+CONFIG_ATAHPT+CONFIG_NICINTEL_SPI+CONFIG_OGP_SPI >= 1 +#if CONFIG_NIC3COM+CONFIG_NICREALTEK+CONFIG_NICNATSEMI+CONFIG_GFXNVIDIA+CONFIG_DRKAISER+CONFIG_SATASII+CONFIG_ATAHPT+CONFIG_NICINTEL_SPI+CONFIG_OGP_SPI+CONFIG_SATAMV >= 1 void print_supported_pcidevs(const struct pcidev_status *devs); #endif -- http://www.hailfinger.org/

2 2

[commit] r1278 - trunk
by repository service 08 Mar '11

08 Mar '11

Author: hailfinger Date: Tue Mar 8 01:09:11 2011 New Revision: 1278 URL: http://flashrom.org/trac/flashrom/changeset/1278 Log: Fix compilation if CONFIG_INTERNAL=no. Fix compilation if everything except CONFIG_SATAMV is no. Do not compile in PCI support for wiki printing if no PCI devices are supported. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Acked-by: Michael Karcher <flashrom(a)mkarcher.dialup.fu-berlin.de> Modified: trunk/flashrom.c trunk/print_wiki.c trunk/programmer.h Modified: trunk/flashrom.c ============================================================================== --- trunk/flashrom.c Mon Mar 7 16:32:58 2011 (r1277) +++ trunk/flashrom.c Tue Mar 8 01:09:11 2011 (r1278) @@ -1186,11 +1186,12 @@ if (!flash || !flash->name) return NULL; - if (programmer_table[programmer].map_flash_region == physmap) { +#if CONFIG_INTERNAL == 1 + if (programmer_table[programmer].map_flash_region == physmap) snprintf(location, sizeof(location), "at physical address 0x%lx", base); - } else { + else +#endif snprintf(location, sizeof(location), "on %s", programmer_table[programmer].name); - } msg_cinfo("%s chip \"%s %s\" (%d KB, %s) %s.\n", force ? "Assuming" : "Found", Modified: trunk/print_wiki.c ============================================================================== --- trunk/print_wiki.c Mon Mar 7 16:32:58 2011 (r1277) +++ trunk/print_wiki.c Tue Mar 8 01:09:11 2011 (r1278) @@ -246,6 +246,8 @@ printf("\n|}\n\n|}\n"); } +/* Not needed for CONFIG_INTERNAL, but for all other PCI-based programmers. */ +#if CONFIG_NIC3COM+CONFIG_NICREALTEK+CONFIG_NICNATSEMI+CONFIG_GFXNVIDIA+CONFIG_DRKAISER+CONFIG_SATASII+CONFIG_ATAHPT+CONFIG_NICINTEL_SPI+CONFIG_OGP_SPI+CONFIG_SATAMV >= 1 static void print_supported_pcidevs_wiki(const struct pcidev_status *devs) { int i = 0; @@ -262,6 +264,7 @@ (devs[i].status == NT) ? "?3" : "OK"); } } +#endif void print_supported_wiki(void) { Modified: trunk/programmer.h ============================================================================== --- trunk/programmer.h Mon Mar 7 16:32:58 2011 (r1277) +++ trunk/programmer.h Tue Mar 8 01:09:11 2011 (r1278) @@ -229,7 +229,7 @@ #endif /* print.c */ -#if CONFIG_NIC3COM+CONFIG_NICREALTEK+CONFIG_NICNATSEMI+CONFIG_GFXNVIDIA+CONFIG_DRKAISER+CONFIG_SATASII+CONFIG_ATAHPT+CONFIG_NICINTEL_SPI+CONFIG_OGP_SPI >= 1 +#if CONFIG_NIC3COM+CONFIG_NICREALTEK+CONFIG_NICNATSEMI+CONFIG_GFXNVIDIA+CONFIG_DRKAISER+CONFIG_SATASII+CONFIG_ATAHPT+CONFIG_NICINTEL_SPI+CONFIG_OGP_SPI+CONFIG_SATAMV >= 1 void print_supported_pcidevs(const struct pcidev_status *devs); #endif

1 0

[patch] Fix compiling r1275 and higher
by Idwer Vollering 07 Mar '11

07 Mar '11

Signed-off-by: Idwer Vollering <vidwer(a)gmail.com> Acked-by: Idwer Vollering <vidwer(a)gmail.com> Index: flashchips.c =================================================================== --- flashchips.c (revision 1275) +++ flashchips.c (working copy) @@ -5567,7 +5567,7 @@ .total_size = 64, .page_size = 4096, .feature_bits = FEATURE_EITHER_RESET, - .tested = TEST_PREW, + .tested = TEST_OK_PREW, .probe = probe_jedec, .probe_timing = 1, /* 150 ns */ .block_erasers =

2 1

[commit] r1277 - trunk
by repository service 07 Mar '11

07 Mar '11

Author: hailfinger Date: Mon Mar 7 16:32:58 2011 New Revision: 1277 URL: http://flashrom.org/trac/flashrom/changeset/1277 Log: Fix broken compilation caused by a typo in r1275. Signed-off-by: Idwer Vollering <vidwer(a)gmail.com> Acked-by: Idwer Vollering <vidwer(a)gmail.com> Modified: trunk/flashchips.c Modified: trunk/flashchips.c ============================================================================== --- trunk/flashchips.c Mon Mar 7 11:59:06 2011 (r1276) +++ trunk/flashchips.c Mon Mar 7 16:32:58 2011 (r1277) @@ -5567,7 +5567,7 @@ .total_size = 64, .page_size = 4096, .feature_bits = FEATURE_EITHER_RESET, - .tested = TEST_PREW, + .tested = TEST_OK_PREW, .probe = probe_jedec, .probe_timing = 1, /* 150 ns */ .block_erasers =

1 0

Re: [flashrom] [PATCH] Remove delays in JEDEC erase sequence
by Carl-Daniel Hailfinger 07 Mar '11

07 Mar '11

Auf 06.03.2011 20:11, Michael Karcher schrieb: > t is extremely unlikely that a chip not requiring delays in probe does > require them in erase. We observed unreliable erasing with a SST49LF004A > with these delays, so remove them if the are not required. > > Signed-off-by: Michael Karcher <flashrom(a)mkarcher.dialup.fu-berlin.de> > --- > jedec.c | 33 +++++++++++++++++++++------------ > 1 files changed, 21 insertions(+), 12 deletions(-) > > diff --git a/jedec.c b/jedec.c > index 199c64d..822de88 100644 > --- a/jedec.c > +++ b/jedec.c > @@ -242,21 +242,24 @@ static int erase_sector_jedec_common(struct flashchip *flash, unsigned int page, > unsigned int pagesize, unsigned int mask) > { > chipaddr bios = flash->virtual_memory; > + int delay_us = 10; > + if(flash->probe_timing != TIMING_ZERO) > + delay_us = 0; > Inverted logic. Could you fix the logic like this: + int delay_us = 0; + if(flash->probe_timing != TIMING_ZERO) + delay_us = 10; Default to 0 delay, and only change it if the chip is slow. > > /* Issue the Sector Erase command */ > chip_writeb(0xAA, bios + (0x5555 & mask)); > - programmer_delay(10); > + programmer_delay(delay_us); > probe_jedec goes further by making that call conditional on nonzero delay. I don't have a strong preference, but wanted to mention it. Anyway, with the logic fix this is Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Regards, Carl-Daniel -- http://www.hailfinger.org/

1 0

[PATCH] mark Erase/Write on MX25L1605 as tested
by Sven Schnelle 07 Mar '11

07 Mar '11

Hi List, i flashed my ThinkPad X60s which contains a Macronix MX25L1605D yesterday with flashrom. Erase and Write worked without problems several times, so i think it is safe to mark that Part as completely tested. Signed-off-by: Sven Schnelle <svens(a)stackframe.org>

2 2

[commit] r1276 - trunk
by repository service 07 Mar '11

07 Mar '11

Author: hailfinger Date: Mon Mar 7 11:59:06 2011 New Revision: 1276 URL: http://flashrom.org/trac/flashrom/changeset/1276 Log: Mark Macronix MX25L1605D as fully tested. Signed-off-by: Sven Schnelle <svens(a)stackframe.org> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Modified: trunk/flashchips.c Modified: trunk/flashchips.c ============================================================================== --- trunk/flashchips.c Mon Mar 7 02:09:55 2011 (r1275) +++ trunk/flashchips.c Mon Mar 7 11:59:06 2011 (r1276) @@ -3829,7 +3829,7 @@ .total_size = 2048, .page_size = 256, .feature_bits = FEATURE_WRSR_WREN, - .tested = TEST_OK_PR, + .tested = TEST_OK_PREW, .probe = probe_spi_rdid, .probe_timing = TIMING_ZERO, .block_erasers =

1 0

← Newer
1
...
10
11
12
13
14
15
16
17
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

flashrom March 2011