flashrom February 2010

flashrom@flashrom.org

55 participants
173 discussions

[commit] r893 - trunk
by repository service 04 Feb '10

04 Feb '10

Author: hailfinger Date: Thu Feb 4 12:12:04 2010 New Revision: 893 URL: http://flashrom.org/trac/coreboot/changeset/893 Log: Document the rules for DMI matching with PCI subsystem IDs. The rules may change in the future, but right now it is important that the comments match the code. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Modified: trunk/board_enable.c Modified: trunk/board_enable.c ============================================================================== --- trunk/board_enable.c Thu Feb 4 11:58:50 2010 (r892) +++ trunk/board_enable.c Thu Feb 4 12:12:04 2010 (r893) @@ -1160,9 +1160,10 @@ * subsystem/card IDs in a sane manner. * * Keep the second set NULLed if it should be ignored. Keep the subsystem IDs - * NULLed if they don't identify the board fully. But please take care to - * provide an as complete set of pci ids as possible; autodetection is the - * preferred behaviour and we would like to make sure that matches are unique. + * NULLed if they don't identify the board fully and if you can't use DMI. + * But please take care to provide an as complete set of pci ids as possible; + * autodetection is the preferred behaviour and we would like to make sure that + * matches are unique. * * If PCI IDs are not sufficient for board matching, the match can be further * constrained by a string that has to be present in the DMI database for @@ -1171,6 +1172,11 @@ * or the end (with a $ at the end). Both anchors may be specified at the * same time to match the full field. * + * When a board is matched through DMI, the first and second main PCI IDs + * and the first subsystem PCI ID have to match as well. If you specify the + * first subsystem ID as 0x0:0x0, the DMI matching code expects that the + * subsystem ID of that device is indeed zero. + * * The coreboot ids are used two fold. When running with a coreboot firmware, * the ids uniquely matches the coreboot board identification string. When a * legacy bios is installed and when autodetection is not possible, these ids

1 0

Re: [flashrom] [PATCH] (now for real!) Allow DMI supported board enables with subsystem ID zero.
by Carl-Daniel Hailfinger 04 Feb '10

04 Feb '10

On 04.02.2010 11:19, Michael Karcher wrote: > This is needed for the Intel SE440BX-2 as well as the Asus P5A. > > Signed-off-by: Michael Karcher <flashrom(a)mkarcher.dialup.fu-berlin.de> > Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Regards, Carl-Daniel -- Developer quote of the year: "We are juggling too many chainsaws and flaming arrows and tigers."

2 1

[commit] r892 - trunk
by repository service 04 Feb '10

04 Feb '10

Author: mkarcher Date: Thu Feb 4 11:58:50 2010 New Revision: 892 URL: http://flashrom.org/trac/coreboot/changeset/892 Log: Allow DMI supported board enables with subsystem ID zero. This is needed for the Intel SE440BX-2 as well as the Asus P5A. Signed-off-by: Michael Karcher <flashrom(a)mkarcher.dialup.fu-berlin.de> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Modified: trunk/board_enable.c Modified: trunk/board_enable.c ============================================================================== --- trunk/board_enable.c Thu Feb 4 09:29:18 2010 (r891) +++ trunk/board_enable.c Thu Feb 4 11:58:50 2010 (r892) @@ -1305,7 +1305,8 @@ struct board_pciid_enable *board = board_pciid_enables; for (; board->vendor_name; board++) { - if (!board->first_card_vendor || !board->first_card_device) + if ((!board->first_card_vendor || !board->first_card_device) && + !board->dmi_pattern) continue; if (!pci_card_find(board->first_vendor, board->first_device,

1 0

[PATCH] (now for real!) Allow DMI supported board enables with subsystem ID zero.
by Michael Karcher 04 Feb '10

04 Feb '10

This is needed for the Intel SE440BX-2 as well as the Asus P5A. Signed-off-by: Michael Karcher <flashrom(a)mkarcher.dialup.fu-berlin.de> Now *REALLY* with the right patch. I supposed I knew how to operate git :( --- board_enable.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/board_enable.c b/board_enable.c index 40db653..c73c8af 100644 --- a/board_enable.c +++ b/board_enable.c @@ -1312,7 +1312,8 @@ static struct board_pciid_enable *board_match_pci_card_ids(void) struct board_pciid_enable *board = board_pciid_enables; for (; board->vendor_name; board++) { - if (!board->first_card_vendor || !board->first_card_device) + if ((!board->first_card_vendor || !board->first_card_device) && + !board->dmi_pattern) continue; if (!pci_card_find(board->first_vendor, board->first_device, -- 1.6.5

1 0

Re: [flashrom] [PATCH] (fixed) Allow DMI supported board enables with subsystem ID zero.
by Carl-Daniel Hailfinger 04 Feb '10

04 Feb '10

On 04.02.2010 10:59, Michael Karcher wrote: > This is needed for the Intel SE440BX-2 as well as the Asus P5A. > > Thanks to Carl-Daniel Hailfinger for pointing out wrong logic in > the patch. > > Zach: please retry with this one instead of the previous version of > this patch. You can unpatch the previous version by > patch -R < oldpatch.diff > > Signed-off-by: Michael Karcher <flashrom(a)mkarcher.dialup.fu-berlin.de> > AFAICS you reposted the old patch. Regards, Carl-Daniel -- Developer quote of the year: "We are juggling too many chainsaws and flaming arrows and tigers."

1 0

[PATCH] Allow DMI supported board enables with subsystem ID zero.
by Michael Karcher 04 Feb '10

04 Feb '10

This is needed for the Intel SE440BX-2 as well as the Asus P5A. Signed-off-by: Michael Karcher <flashrom(a)mkarcher.dialup.fu-berlin.de> This time with the right patch included. --- board_enable.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/board_enable.c b/board_enable.c index 40db653..66afab4 100644 --- a/board_enable.c +++ b/board_enable.c @@ -1312,7 +1312,8 @@ static struct board_pciid_enable *board_match_pci_card_ids(void) struct board_pciid_enable *board = board_pciid_enables; for (; board->vendor_name; board++) { - if (!board->first_card_vendor || !board->first_card_device) + if (!board->first_card_vendor || + (!board->first_card_device && !board->dmi_pattern)) continue; if (!pci_card_find(board->first_vendor, board->first_device, -- 1.6.5

1 0

Re: [flashrom] [PATCH] please disregard last mail!
by Michael Karcher 04 Feb '10

04 Feb '10

Am Donnerstag, den 04.02.2010, 10:59 +0100 schrieb Michael Karcher: > Zach: please retry with this one instead of the previous version of > this patch. You can unpatch the previous version by > patch -R < oldpatch.diff That patch was identical to the first one. I mixed of things :( Regards, Michael Karcher

1 0

Re: [flashrom] [PATCH] Allow DMI supported board enables with subsystem ID zero.
by Carl-Daniel Hailfinger 04 Feb '10

04 Feb '10

On 29.01.2010 01:40, Michael Karcher wrote: > --- a/board_enable.c > +++ b/board_enable.c > @@ -1312,7 +1312,8 @@ static struct board_pciid_enable *board_match_pci_card_ids(void) > struct board_pciid_enable *board = board_pciid_enables; > > for (; board->vendor_name; board++) { > - if (!board->first_card_vendor || !board->first_card_device) > + if (!board->first_card_vendor || > + (!board->first_card_device && !board->dmi_pattern)) > continue; > > if (!pci_card_find(board->first_vendor, board->first_device, > This code still requires a nonzero subsystem vendor even if a DMI pattern is present. If that is intentional (I thought DMI would eliminate subsystem vendor+device requirement), the patch is Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Regards, Carl-Daniel -- Developer quote of the year: "We are juggling too many chainsaws and flaming arrows and tigers."

3 5

[commit] r891 - trunk
by repository service 04 Feb '10

04 Feb '10

Author: oxygene Date: Thu Feb 4 09:29:18 2010 New Revision: 891 URL: http://flashrom.org/trac/coreboot/changeset/891 Log: Properly initialize USB device in dediprog driver. That's necessary to use bulk transfers, and just the right thing in any case. Signed-off-by: Patrick Georgi <patrick.georgi(a)coresystems.de> Acked-by: Stefan Reinauer <stepan(a)coresystems.de> Modified: trunk/dediprog.c Modified: trunk/dediprog.c ============================================================================== --- trunk/dediprog.c Thu Feb 4 03:40:16 2010 (r890) +++ trunk/dediprog.c Thu Feb 4 09:29:18 2010 (r891) @@ -294,6 +294,8 @@ dev->descriptor.idVendor, dev->descriptor.idProduct); dediprog_handle = usb_open(dev); + usb_set_configuration(dediprog_handle, 1); + usb_claim_interface(dediprog_handle, 0); /* URB 6. Command A. */ if (dediprog_command_a()) return 1;

1 0

(update) Gigabyte GA-7ZXE v1.1
by Charles M 04 Feb '10

04 Feb '10

In the last message I stated the board was 1.0, but it's actually 1.1 (the board was a little dirty and I mistook the 1.1 for 1.0). Superiotool didn't find the super i/o chip. From a quick glance it appears to be a VIA VT82C686B chip. Cheers, Charles

3 3

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

flashrom February 2010