Board: Acorp 6A815EPD autodetectable.

[Carl-Daniel Hailfinger]

On 21.10.2009 23:33, Luc Verhaegen wrote:
> Board: Make Acorp 6A815EPD autodetectable.
>
> Add subsystem id for hostbridge match for Acorp 6A815EPD; even though
> it reads "intel", NULL, this, together with the promise ultra100 chip
> and subsystem ids, should form a unique enough match for us to depend
> upon.
>
> Signed-off-by: Luc Verhaegen

Patch available for download at http://patchwork.coreboot.org/patch/457/raw/

Regards,
Carl-Daniel

[Jonathan A. Kollasch]

On Wed, Oct 28, 2009 at 12:43:13AM +0100, Carl-Daniel Hailfinger wrote:
> On 21.10.2009 23:33, Luc Verhaegen wrote:
> > Board: Make Acorp 6A815EPD autodetectable.
> >
> > Add subsystem id for hostbridge match for Acorp 6A815EPD; even though
> > it reads "intel", NULL, this, together with the promise ultra100 chip
> > and subsystem ids, should form a unique enough match for us to depend
> > upon.
> >
> > Signed-off-by: Luc Verhaegen

This may work, but board_match_card_ids() doesn't work in the case
where first_card_device is 0x0000.

Jonathan Kollasch

[Carl-Daniel Hailfinger]

On 28.10.2009 02:35, Jonathan A. Kollasch wrote:
> On Wed, Oct 28, 2009 at 12:43:13AM +0100, Carl-Daniel Hailfinger wrote:
> > On 21.10.2009 23:33, Luc Verhaegen wrote:
> > > Board: Make Acorp 6A815EPD autodetectable.
> > >
> > > Add subsystem id for hostbridge match for Acorp 6A815EPD; even though
> > > it reads "intel", NULL, this, together with the promise ultra100 chip
> > > and subsystem ids, should form a unique enough match for us to depend
> > > upon.
> > >
> > > Signed-off-by: Luc Verhaegen
>
> This may work, but board_match_card_ids() doesn't work in the case
> where first_card_device is 0x0000.

Good point. I'll fix up the patch and resend. Thanks for checking.

Regards,
Carl-Daniel

[Luc Verhaegen]

On Wed, Oct 28, 2009 at 01:35:20AM +0000, Jonathan A. Kollasch wrote:
> On Wed, Oct 28, 2009 at 12:43:13AM +0100, Carl-Daniel Hailfinger wrote:
> > On 21.10.2009 23:33, Luc Verhaegen wrote:
> > > Board: Make Acorp 6A815EPD autodetectable.
> > >
> > > Add subsystem id for hostbridge match for Acorp 6A815EPD; even though
> > > it reads "intel", NULL, this, together with the promise ultra100 chip
> > > and subsystem ids, should form a unique enough match for us to depend
> > > upon.
> > >
> > > Signed-off-by: Luc Verhaegen
>
> This may work, but board_match_card_ids() doesn't work in the case
> where first_card_device is 0x0000.
>
> Jonathan Kollasch

You are right. In the current code, we should swap the id sets around.

Luc Verhaegen.