Re: [flashrom] [PATCH 1/3] fix probe_flash to report new values set by probing functions

[Carl-Daniel Hailfinger]

Am 24.06.2011 16:53 schrieb Stefan Tauner:
> This is needed if the probing function changes its fill_flash parameter like in the pattern
> used to support Intel Hardware Sequencing and SFDP.
>
> Signed-off-by: Stefan Tauner

Back when I converted that code to the const flashchip array, I assumed
flash chip sizes would be immutable and other programmer types wouldn't
be supported anyway. With your ICH hardware sequencing patches, that
assumption is no longer valid.

Acked-by: Carl-Daniel Hailfinger

Regards,
Carl-Daniel

[PATCH 1/3] fix probe_flash to report new values set by probing functions

[Stefan Tauner]

On Sat, 25 Jun 2011 18:28:38 +0200
Carl-Daniel Hailfinger  wrote:
> Am 24.06.2011 16:53 schrieb Stefan Tauner:
> > This is needed if the probing function changes its fill_flash parameter like in the pattern
> > used to support Intel Hardware Sequencing and SFDP.
> >
> > Signed-off-by: Stefan Tauner
>
> Back when I converted that code to the const flashchip array, I assumed
> flash chip sizes would be immutable and other programmer types wouldn't
> be supported anyway. With your ICH hardware sequencing patches, that
> assumption is no longer valid.
>
> Acked-by: Carl-Daniel Hailfinger

i was not complaining :)
although revamping the whole probing is a big point rather high on my
todo list, but we need to talk about that later...

thanks, r1350