Re: [flashrom] [PATCH 2/6] some additional comments for ichspi.c

[Michael Karcher]

Am Freitag, den 01.04.2011, 14:33 +0200 schrieb Stefan Tauner:
> uint8_t atomic;		//Use preop: (0: none, 1: preop0, 2: preop1
> uint8_t atomic;		//Use preop: (0: none, 1: preop0 only, 2: both)

Nack.

The ICH10 data sheet is explicit on SPOP selecting "one of the two
programmed prefix opcodes". So 2 does not mean both, but preop1.

Regards,
  Michael Karcher

[PATCH 2/6] some additional comments for ichspi.c

[Stefan Tauner]

On Sat, 23 Apr 2011 19:42:50 +0200
Michael Karcher  wrote:
> Am Freitag, den 01.04.2011, 14:33 +0200 schrieb Stefan Tauner:
> > uint8_t atomic;		//Use preop: (0: none, 1:
> >
> > preop0, 2: preop1
> > uint8_t atomic;		//Use preop: (0: none, 1:
> >
> > preop0 only, 2: both)
>
> Nack.
>
> The ICH10 data sheet is explicit on SPOP selecting "one of the two
> programmed prefix opcodes". So 2 does not mean both, but preop1.

correct. i misread the switch statement that actually uses the struct.