On 25.03.2010 10:54, Michael Karcher wrote:
This finishes the it87spi autodetection stuff of r983. Also fixes sorting of Gigabyte boards.
Signed-off-by: Michael Karcher flashrom@mkarcher.dialup.fu-berlin.de
Hm. IMHO we have too much cosmetic changes in that table. The only thing that happens is reordering, but AFAICS this won't affect output in any way. Does ordering into different (OK/boardenable/bad) groups even make sense? That stuff is bound to change anyway we fix/modify some boards, and the group info is stored in other arrays anyway. A similar question applies to the laptop/non-laptop distinction in that table.
Your patch changes the code to match the comments again, so I don't have a valid code-based reason to reject your patch. Still, I think we should discuss the general ordering of that table before that file will get a hotbed of reodering moves. Acked-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net
Regards, Carl-Daniel
Am Donnerstag, den 25.03.2010, 15:16 +0100 schrieb Carl-Daniel Hailfinger:
Hm. IMHO we have too much cosmetic changes in that table. The only thing that happens is reordering, but AFAICS this won't affect output in any way. Does ordering into different (OK/boardenable/bad) groups even make sense?
It seems to be supposed to help managing that table. The output is unchanged be reordering this table. It happens that the grouping in this table is the grouping used in the Wiki, so it helps finding the URL when you see the entry on the Wiki page.
Your patch changes the code to match the comments again, so I don't have a valid code-based reason to reject your patch. Still, I think we should discuss the general ordering of that table before that file will get a hotbed of reodering moves.
We should discuss http://patchwork.coreboot.org/patch/1044/ which does away with this table completely.
Acked-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net
I will wait with that patch, thanks for the Ack.
Regards, Michael Karcher
-
Carl-Daniel Hailfinger -
Michael Karcher