[PATCH] Kill fake SPI D8 chip erase

[Carl-Daniel Hailfinger]

The SPI opcode 0xd8 is not a chip erase opcode on any chip out there.
Besides that, the function as implemented just walks the chip and
ignores sector sizes.
Sector erase with SPI opcode 0xd8 is of course still supported.
Kill a declaration for a nonexisting function while we're at it.

Signed-off-by: Carl-Daniel Hailfinger

Index: flashrom-kill_fake_spi_chip_erase_d8/spi25.c
===================================================================
--- flashrom-kill_fake_spi_chip_erase_d8/spi25.c	(Revision 1028)
+++ flashrom-kill_fake_spi_chip_erase_d8/spi25.c	(Arbeitskopie)
@@ -652,29 +652,6 @@
    return 0;
 }

-int spi_chip_erase_d8(struct flashchip *flash)
-{
-	int i, rc = 0;
-	int total_size = flash->total_size * 1024;
-	int erase_size = 64 * 1024;
-
-	spi_disable_blockprotect();
-
-	msg_cinfo("Erasing chip: \n");
-
-	for (i = 0; i < total_size / erase_size; i++) {
-		rc = spi_block_erase_d8(flash, i * erase_size, erase_size);
-		if (rc) {
-			msg_cerr("Error erasing block at 0x%x\n", i);
-			break;
-		}
-	}
-
-	msg_cinfo("\n");
-
-	return rc;
-}
-
 /* Sector size is usually 4k, though Macronix eliteflash has 64k */
 int spi_block_erase_20(struct flashchip *flash, unsigned int addr, unsigned int blocklen)
 {
Index: flashrom-kill_fake_spi_chip_erase_d8/chipdrivers.h
===================================================================
--- flashrom-kill_fake_spi_chip_erase_d8/chipdrivers.h	(Revision 1028)
+++ flashrom-kill_fake_spi_chip_erase_d8/chipdrivers.h	(Arbeitskopie)
@@ -35,8 +35,6 @@
 int spi_write_disable(void);
 int spi_chip_erase_60(struct flashchip *flash);
 int spi_chip_erase_c7(struct flashchip *flash);
-int spi_chip_erase_60_c7(struct flashchip *flash);
-int spi_chip_erase_d8(struct flashchip *flash);
 int spi_block_erase_20(struct flashchip *flash, unsigned int addr, unsigned int blocklen);
 int spi_block_erase_52(struct flashchip *flash, unsigned int addr, unsigned int blocklen);
 int spi_block_erase_d7(struct flashchip *flash, unsigned int addr, unsigned int blocklen);

[Sean Nelson]

On 6/3/10 6:56 PM, Carl-Daniel Hailfinger wrote:
> The SPI opcode 0xd8 is not a chip erase opcode on any chip out there.
> Besides that, the function as implemented just walks the chip and
> ignores sector sizes.
> Sector erase with SPI opcode 0xd8 is of course still supported.
> Kill a declaration for a nonexisting function while we're at it.
>
> Signed-off-by: Carl-Daniel Hailfinger

Acked-by: Sean Nelson

[Carl-Daniel Hailfinger]

On 19.06.2010 23:15, Sean Nelson wrote:
> On 6/3/10 6:56 PM, Carl-Daniel Hailfinger wrote:
> > The SPI opcode 0xd8 is not a chip erase opcode on any chip out there.
> > Besides that, the function as implemented just walks the chip and
> > ignores sector sizes.
> > Sector erase with SPI opcode 0xd8 is of course still supported.
> > Kill a declaration for a nonexisting function while we're at it.
> >
> > Signed-off-by: Carl-Daniel Hailfinger
>
> Acked-by: Sean Nelson

Thanks, committed in r1054.

Regards,
Carl-Daniel