Submitting patches for flashrom?

[Feldschmid, Ingo]

Hi there,

How do I submit patches if I have changed code for the flashrom utility?
Do I just post them here, or do I have to do something else? (I have
mailed changes to support the Intel Tunnel Creek SPI chipset, but didn't
get any response so far, so I assume I have to do something else?)

Best regards,
Ingo

Es gelten unsere Allgemeinen Leistungsbedingungen die 
unter http://www.msc-ge.com/alb abrufbar sind.

Our standard terms and conditions apply which are 
available under http://www.msc-ge.com/alb .

MSC Vertriebs GmbH

Sitz der Gesellschaft:	Industriestrasse 16, 76297 Stutensee 
Handelsregister: 	Mannheim, HRB Nr. 10 3631
Geschaftsfuhrung: 	Manfred Schwarztrauber, Lothar Kummerlin, Rudiger Kuhn, Silvano Geissler
Umsatzsteuer ID Nr.: 	DE 143 585 507
WEEE Reg. Nr. :		DE 31011852

Gleichmann & Co. Electronics GmbH

Sitz der Gesellschaft:	Schraderstrasse 44, 67227 Frankenthal 
Handelsregister:	Ludwigshafen, HRB Nr. 21305
Geschaftsfuhrung:	Manfred Schwarztrauber, Thomas Klein
Umsatzsteuer ID Nr. :	DE 148 421 329            
WEEE Reg. Nr.:		DE 72277043

Diese E-Mail enthalt vertrauliche und/ oder rechtlich geschutzte Informationen. 
Wenn Sie nicht der beabsichtigte Empfanger sind, informieren Sie bitte sofort den
Absender und loschen Sie diese E-Mail.

The information contained in this message is confidential and/ or protected by law. 
If you are not the intended recipient, please contact the sender and delete this message.

[Idwer Vollering]

2011/9/7 Feldschmid, Ingo :
> Hi there,
>
> How do I submit patches if I have changed code for the flashrom utility?

Run "svn diff > description_of_the_patch.diff" (after you ran svn add,
when you are introducing new files) and submit that patch.
> Do I just post them here, or do I have to do something else?

We follow the same instructions as the linux kernel does:
http://www.coreboot.org/Development_Guidelines#Sign-off_Procedure
> (I have mailed changes to support the Intel Tunnel Creek SPI chipset, but didn't
> get any response so far, so I assume I have to do something else?)
>
> Best regards,
> Ingo

[Stefan Tauner]

On Wed, 7 Sep 2011 11:07:01 +0200
"Feldschmid, Ingo"  wrote:
> Hi there,
>
> How do I submit patches if I have changed code for the flashrom utility?
> Do I just post them here, or do I have to do something else? (I have
> mailed changes to support the Intel Tunnel Creek SPI chipset, but didn't
> get any response so far, so I assume I have to do something else?)

hello ingo!

thanks for your patch(es)! there is no need to do more. we have seen
the patch (and the follow-up one too), but if you look at
http://patchwork.coreboot.org/project/flashrom/list/ there are very,
very many not yet reviewed patches. i have your patch on my todo list,
but please be more patient :)

[Uwe Hermann]

On Wed, Sep 07, 2011 at 08:57:31PM +0200, Stefan Tauner wrote:
> "Feldschmid, Ingo"  wrote:
> > How do I submit patches if I have changed code for the flashrom utility?
> > Do I just post them here, or do I have to do something else? (I have
> > mailed changes to support the Intel Tunnel Creek SPI chipset, but didn't
> > get any response so far, so I assume I have to do something else?)

Nope, you did everything right (posted the patch, didn't forget the
Signed-off-by), it just takes a little while to review patches
sometimes.
> thanks for your patch(es)! there is no need to do more. we have seen
> the patch (and the follow-up one too), but if you look at
> http://patchwork.coreboot.org/project/flashrom/list/ there are very,
> very many not yet reviewed patches. i have your patch on my todo list,
> but please be more patient :)

Oops, sorry, I just committed the patch with small changes, didn't see
your mail. Please do review though, there might be some refactoring
possible in those code areas.

Uwe.