See patch... With this flashrom won't try to open /dev/cpu/x/msr on non-linux OSes...
Stefan
On 11.08.2009 15:00, Stefan Reinauer wrote:
I'm not totally happy with the abstraction and think getting MSR access should be part of getting IO permissions, but this is a good step forward.
Acked-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net
It would be nice if you could address the one comment below, either with an updated patch or a second fixup patch.
Regards, Carl-Daniel
Missing error handling for the setup case. rdmsr and wrmsr don't have to be checked after setup was successful.
On 8/11/09 3:43 PM, Carl-Daniel Hailfinger wrote:
I considered that. BUT: Why make code run every time, if it's only needed on 1% or less of the machines.
Stefan
On 11.08.2009 15:59, Stefan Reinauer wrote:
True. Go ahead.
Regards, Carl-Daniel
On 11.08.2009 15:43, Carl-Daniel Hailfinger wrote:
Committed by Stefan with changes in r677.
Regards, Carl-Daniel