Re: [flashrom] report for Intel QM67 | Winbond W25Q64 - layout patches

[Stefan Tauner]

On Fri, 26 Aug 2011 11:25:27 +0200
"Frei, Thomas (GE Germany)"  wrote:
> Hi,
>
> Now I loaded the Revision 1421 from SVN repository, patched it and tried to compile - nope :-(
>
> Output of GCC:
> ---snip---
> Checking for a C compiler... found.
> ARCH is "x86"
> Checking for libpci headers... found.
> Checking if libpci is present and sufficient... yes.
> Checking for FTDI support... not found.
> Checking for utsname support... found.
> cc -MMD -Os -Wall -Wshadow -Werror  -D'CONFIG_INTERNAL=1' -D'CONFIG_SERPROG=1' -D'CONFIG_RAYER_SPI=1' -D'CONFIG_BITBANG_SPI=1' -D'CONFIG_NIC3COM=1' -D'CONFIG_GFXNVIDIA=1' -D'CONFIG_SATASII=1'  -D'CONFIG_DUMMY=1' -D'CONFIG_DRKAISER=1' -D'CONFIG_NICREALTEK=1' -D'CONFIG_NICINTEL=1' -D'CONFIG_NICINTEL_SPI=1' -D'CONFIG_OGP_SPI=1' -D'CONFIG_BUSPIRATE_SPI=1' -D'CONFIG_SATAMV=1' -D'NEED_PCI=1' -D'HAVE_UTSNAME=1' -D'FLASHROM_VERSION="0.9.4-r1421"' -o layout.o -c layout.c
> layout.c:43:20: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘rom_entries’
> layout.c: In function ‘read_romlayout’:
> layout.c:161:50: error: ‘rom_entries’ undeclared (first use in this function)
> layout.c:161:50: note: each undeclared identifier is reported only once for each function it appears in
> layout.c: At top level:
> layout.c:214:12: error: static declaration of ‘find_romentry’ follows non-static declaration
> flash.h:256:5: note: previous declaration of ‘find_romentry’ was here
> layout.c: In function ‘find_romentry’:
> layout.c:230:15: error: ‘rom_entries’ undeclared (first use in this function)
> layout.c: At top level:
> layout.c:279:13: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘*’ token
> layout.c:309:47: error: expected ‘)’ before ‘*’ token
> layout.c: In function ‘build_new_image’:
> layout.c:355:2: error: ‘romlayout_t’ undeclared (first use in this function)
> layout.c:355:15: error: ‘entry’ undeclared (first use in this function)
> cc1: warnings being treated as errors
> layout.c:368:3: error: implicit declaration of function ‘get_next_included_romentry’
> layout.c:381:3: error: implicit declaration of function ‘read_content_from_file’
> make: *** [layout.o] Error 1
> ---snip---
> ???
>
> Please help.

hello

the output was probably mangled in the mail transfer, but besides that
it certainly does not look as it should either. i have tried to
reproduce the behavior by checking out r1421 and applying the patches i
have sent you. after each application of a patch i have run make clean;
make and got no errors whatsoever. please assure that you have a clean
checkout of r1421 without any remains of previous trials etc. and that
the patches apply cleanly. if they dont, you have either started with
the wrong sources or something is broken. in that case please tell us
the exact command sequence (and the outputs respectively) that leads to
the error.