[PATCH] Reduce message severity level for skipped chips

[Carl-Daniel Hailfinger]

Old verbose log excerpt:
Probing for Atmel AT25DF021, 256 KB: skipped. Host bus type Parallel and chip bus type SPI are incompatible.

New verbose log excerpt:
Probing for Atmel AT25DF021, 256 KB: skipped.

This makes logs more readable and manageable. If someone really
desperately wants all the bus debugging stuff, he/she can switch to SPEW
mode instead of VERBOSE mode.

Signed-off-by: Carl-Daniel Hailfinger

Index: flashrom-skip_bus_nonverbose/flashrom.c
===================================================================
--- flashrom-skip_bus_nonverbose/flashrom.c	(Revision 969)
+++ flashrom-skip_bus_nonverbose/flashrom.c	(Arbeitskopie)
@@ -877,20 +877,24 @@
    for (flash = first_flash; flash && flash->name; flash++) {
    	if (chip_to_probe && strcmp(flash->name, chip_to_probe) != 0)
    		continue;
-		printf_debug("Probing for %s %s, %d KB: ",
+		msg_gdbg("Probing for %s %s, %d KB: ",
    		     flash->vendor, flash->name, flash->total_size);
    	if (!flash->probe && !force) {
-			printf_debug("failed! flashrom has no probe function for this flash chip.\n");
+			msg_gdbg("failed! flashrom has no probe function for "
+				 "this flash chip.\n");
    		continue;
    	}
    	buses_common = buses_supported & flash->bustype;
    	if (!buses_common) {
    		tmp = flashbuses_to_text(buses_supported);
-			printf_debug("skipped. Host bus type %s ", tmp);
+			msg_gdbg("skipped.");
+			msg_gspew(" Host bus type %s ", tmp);
    		free(tmp);
    		tmp = flashbuses_to_text(flash->bustype);
-			printf_debug("and chip bus type %s are incompatible.\n", tmp);
+			msg_gspew("and chip bus type %s are incompatible.",
+				  tmp);
    		free(tmp);
+			msg_gdbg("\n");
    		continue;
    	}

[Michael Karcher]

Am Montag, den 22.03.2010, 23:30 +0100 schrieb Carl-Daniel Hailfinger:
> Old verbose log excerpt:
> Probing for Atmel AT25DF021, 256 KB: skipped. Host bus type Parallel and chip bus type SPI are incompatible.
>
> New verbose log excerpt:
> Probing for Atmel AT25DF021, 256 KB: skipped.

You might want to leave in the chip bus type, as in:
Probing for Atmel AT25DF021, 256 KB: chip is SPI, skipped.

Either way is
Acked-By: Michael Karcher

Regards,
  Michael Karcher

[Carl-Daniel Hailfinger]

On 23.03.2010 00:19, Michael Karcher wrote:
> Am Montag, den 22.03.2010, 23:30 +0100 schrieb Carl-Daniel Hailfinger:
> > Old verbose log excerpt:
> > Probing for Atmel AT25DF021, 256 KB: skipped. Host bus type Parallel and chip bus type SPI are incompatible.
> >
> > New verbose log excerpt:
> > Probing for Atmel AT25DF021, 256 KB: skipped.
>
> You might want to leave in the chip bus type, as in:
> Probing for Atmel AT25DF021, 256 KB: chip is SPI, skipped.

I thought about that, but given the sometimes pretty short wraparounds
in some mails coming to our list, I went with the shorter variant.
> Either way is
> Acked-By: Michael Karcher

Thank you for the review, committed in r970.

Regards,
Carl-Daniel